Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1342#discussion_r44764893
  
    --- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
    @@ -249,7 +249,15 @@ if [ -n "$HADOOP_HOME" ]; then
         fi
     fi
     
    
-INTERNAL_HADOOP_CLASSPATHS="$HADOOP_CLASSPATH:$HADOOP_CONF_DIR:$YARN_CONF_DIR"
    
+INTERNAL_HADOOP_CLASSPATHS="${HADOOP_CLASSPATH}:${HADOOP_CONF_DIR}:${YARN_CONF_DIR}"
    +
    +if [ -n "${HBASE_CONF_DIR}" ]; then
    +    # Setup the HBase classpath.
    +    INTERNAL_HADOOP_CLASSPATHS="${INTERNAL_HADOOP_CLASSPATHS}:`hbase 
classpath`"
    --- End diff --
    
    what happens if the call to `hbase` fails, for example because its not in 
the `$PATH` ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to