Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-160988124
Thank for your contribution @HilmiYildirim. I've merged your commit and put
some changes on top of it in 9215b72422d3e638fe950b61fa01f2e4e04981a0.
---
If your project is se
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1243
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-160650903
Ok great
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r46054711
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.jav
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-160146335
I'm creating a unit test for the source which mocks the RabbitMQ classes. I
would like to merge your pull request with a few changes for both the
fault-tolerant and the non-
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r46048074
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.jav
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-160141917
This currently only works when checkpointing is turned on. If checkpointing
is turned off, not only the number of queued messages will grow unbounded, but
also the messages
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r46046784
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.jav
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r46040790
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSource.jav
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-157720650
Okay. I'll try to review this and get it merged in the next days. Maybe I
can even use Mockito for a minimal test...
---
If your project is set up for it, you can r
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-157522385
I think RabbitMQ is written in Erlang and does not run in the JVM. We could
provide a test that expects a running RabbitMQ server somewhere (locally).
---
If your proj
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-155820098
Unfortunately, I do not know a simple way to run an embedded RabbitMQ broker
---
If your project is set up for it, you can reply to this email and have your
reply
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-155783584
I would like to look over this in the next days and merge it if it looks
good.
@HilmiYildirim Do you know of any simple way to run an embedded RabbitMQ
brok
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-149248114
Somehow there was an error in the push. I fixed it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-149195168
I adapted the code and pushed it to my repo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user HilmiYildirim commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42360149
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQ
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-148737070
I disagree with the locking in the base class. If you look at the
documenation for sources, it states how to make sure you hold the checkpoint
lock when emitting the
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42250317
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledingSourceBase.java
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42249355
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSo
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42250017
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledingSourceBase.java
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42249791
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledingSourceBase.java
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42249695
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledingSourceBase.java
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42249568
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledingSourceBase.java
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42248976
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSo
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42247633
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledingSourceBase.java
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-148726397
Done. I hope this is ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not h
Github user mbalassi commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-148675785
I would like to shepherd this PR.
@HilmiYildirim, I do agree with your suggestion regarding the checkpoint
log. Could you change that in the PR, please?
Cou
Github user HilmiYildirim commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-147963553
There are test failures. But it seems this is not my fault.
Furthermore, I have not synchronized by the checkpointingLock when calling
addId. I think it is bett
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1243#issuecomment-147625208
Hi Hilmi,
thank you for your PR. We'll review it soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
GitHub user HilmiYildirim opened a pull request:
https://github.com/apache/flink/pull/1243
[FLINK-2624]: RabbitMQSource now extends MessageAcknowledgingSourceBase.
It now participates in checkpointing.
You can merge this pull request into a Git repository by running:
$ git pull
30 matches
Mail list logo
