Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1243#discussion_r42247633
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/MessageAcknowledingSourceBase.java
---
@@ -144,6 +152,20 @@ protected void addId(Id id) {
@Override
public SerializedCheckpointData[] snapshotState(long checkpointId, long
checkpointTimestamp) throws Exception {
+ if (idsForCurrentCheckpoint == null) {
--- End diff --
I think these checks are pretty redundant. The tasks should guarantee that
no calls happen on non-open functions, or closed functions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
