Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1153
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1153#issuecomment-146948889
I made some more fixes for the shading of the curator dependency. Once
Travis gives green light, I'll merge it.
---
If your project is set up for it, you can reply
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1153#issuecomment-146810519
Rebased on the current master and incorporated the job manager state
modification fix. Thanks for that!
Can we merge this after Travis gives the green light?
---
I
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1153#issuecomment-146639217
Till found another issue in one of is Travis runs, which has been addressed
in e54a86c.
This is now rebased on the current master.
---
If your project is set up fo
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41536137
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphStore.java
---
@@ -0,0 +1,380 @@
+/*
+ * Licensed to
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1153#issuecomment-146610846
I've addressed your points. Thanks for taking the time to review again. I
had to revert the check point ID counter removal. Sorry for the confusion. If
we don't find anythin
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41536249
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphStore.java
---
@@ -0,0 +1,380 @@
+/*
+ * Licensed to
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41536142
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphStore.java
---
@@ -0,0 +1,380 @@
+/*
+ * Licensed to
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41535719
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StandaloneCompletedCheckpointStore.java
---
@@ -0,0 +1,105 @@
+/*
+ * Licensed
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41535724
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointStore.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apac
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41535673
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * Licensed t
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41535485
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed to the Apa
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41532972
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41532867
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41531514
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * L
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41531592
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * L
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41531181
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphStore.java
---
@@ -0,0 +1,380 @@
+/*
+ * Lic
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41531112
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphStore.java
---
@@ -0,0 +1,380 @@
+/*
+ * Lic
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41528652
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41528000
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * L
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41527930
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41527783
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * L
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41527578
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41527148
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointStore.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed to
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41526930
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StandaloneCompletedCheckpointStore.java
---
@@ -0,0 +1,105 @@
+/*
+ *
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41526810
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * L
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41526594
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed to the Apa
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41526551
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * L
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41526411
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * L
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41526216
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStore.java
---
@@ -0,0 +1,310 @@
+/*
+ * L
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41523825
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41523760
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,423 @@
+/*
+ * Licensed t
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1153#issuecomment-146297139
I've addressed your inline comments (see commits). Not rebased yet. I think
it's easier to review this way.
The major points:
- Followed all renaming suggestions
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41428998
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41428891
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41428924
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41428959
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41428971
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41428739
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphs.java
---
@@ -0,0 +1,356 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41428442
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphs.java
---
@@ -0,0 +1,356 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41424050
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41422825
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCheckpointIDCounter.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41414813
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandle.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache So
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41414820
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandle.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache So
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41414806
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41413616
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoints.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache S
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41413324
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/SubmittedJobGraphs.java
---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Sof
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41411532
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SuccessfulCheckpoint.java
---
@@ -19,29 +19,28 @@
package org.apache.flink.runtime
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41411405
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41410527
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41409570
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41409329
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41409302
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41409272
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41408822
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java
---
@@ -153,6 +176,143 @@ public static ZooKeeperLeaderElectionService
c
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41408810
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java
---
@@ -153,6 +176,143 @@ public static ZooKeeperLeaderElectionService
c
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41408785
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/util/ZooKeeperUtils.java
---
@@ -153,6 +176,143 @@ public static ZooKeeperLeaderElectionService
c
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41402553
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/LeaderElectionService.java
---
@@ -67,4 +67,20 @@
* @return true if the as
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41402299
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphs.java
---
@@ -0,0 +1,356 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41401940
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphs.java
---
@@ -0,0 +1,356 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41399491
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/StandaloneSubmittedJobGraphs.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41397436
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCheckpointIDCounter.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41397266
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateForTask.java
---
@@ -48,9 +55,9 @@
private final int subtask;
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41397182
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -178,9 +195,9 @@ public void run() {
* After
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41397076
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -110,61 +120,68 @@
public CheckpointCoo
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1153#issuecomment-145798045
What happens if the last JM dies and with it the currently executed job
fails permanently. The in ZooKeeper stored `JobGraph` will then be recovered
when a new Flin
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41158214
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCheckpointIDCounter.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licens
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1153#issuecomment-145557954
Thanks for taking the time to review. Thanks for the great renaming
suggestions and all the other more subtle remarks. I agree with virtually all
comments.
The only
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152047
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed t
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152813
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152515
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SuccessfulCheckpoint.java
---
@@ -19,29 +19,28 @@
package org.apache.flink.runtime
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152586
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphs.java
---
@@ -0,0 +1,356 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152418
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1153#issuecomment-145554976
Great piece of work @uce :-) I've gone through the code and added some
comments. The main points are
* the exception handling in `ZooKeeperSubmittedJobGra
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152294
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152368
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed t
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152286
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/LeaderElectionService.java
---
@@ -67,4 +67,20 @@
* @return true if the as
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152317
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152243
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed t
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152128
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphs.java
---
@@ -0,0 +1,356 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152087
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed t
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152116
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateForTask.java
---
@@ -48,9 +55,9 @@
private final int subtask;
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152148
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphs.java
---
@@ -0,0 +1,356 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152092
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/StandaloneSubmittedJobGraphs.java
---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152041
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -110,61 +120,68 @@
public CheckpointCoo
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41152054
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -178,9 +195,9 @@ public void run() {
* After
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41151947
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed to the Apa
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41151770
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/SubmittedJobGraphs.java
---
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Sof
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41151872
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandle.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache So
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41151337
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41150514
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/LeaderElectionService.java
---
@@ -67,4 +67,20 @@
* @return true
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41149990
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCheckpointIDCounter.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41149926
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java
---
@@ -0,0 +1,422 @@
+/*
+ * Licensed t
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41149494
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphs.java
---
@@ -0,0 +1,356 @@
+/*
+ * License
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41149560
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/ZooKeeperSubmittedJobGraphs.java
---
@@ -0,0 +1,356 @@
+/*
+ * License
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41147873
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/ZooKeeperCheckpointIDCounter.java
---
@@ -0,0 +1,130 @@
+/*
+ * Licens
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41146895
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandle.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41145818
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CompletedCheckpoints.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41146553
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandle.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1153#discussion_r41146216
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandle.java
---
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the
1 - 100 of 139 matches
Mail list logo