Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1153#discussion_r41152515
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/SuccessfulCheckpoint.java
 ---
    @@ -19,29 +19,28 @@
     package org.apache.flink.runtime.checkpoint;
     
     import org.apache.flink.api.common.JobID;
    -import org.slf4j.Logger;
    -import org.slf4j.LoggerFactory;
     
    +import java.io.Serializable;
    +import java.util.ArrayList;
     import java.util.List;
     
     /**
      * A successful checkpoint describes a checkpoint after all required tasks 
acknowledged it (with their state)
      * and that is considered completed.
      */
    -public class SuccessfulCheckpoint {
    -   
    -   private static final Logger LOG = 
LoggerFactory.getLogger(SuccessfulCheckpoint.class);
    -   
    +public class SuccessfulCheckpoint implements Serializable {
    --- End diff --
    
    OK. I thought about this as well, but kept it to refrain from unnecessary 
changes. But if you feel the same way, there is probably a good reason to 
change it. ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to