Github user twalthr closed the pull request at:
https://github.com/apache/flink/pull/1127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1127#issuecomment-145001030
Again, thanks for the feedback.
I will close this PR and open 2 separate PRs for TableSources and
HCatInputFormat.
---
If your project is set up for it, you can rep
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40674516
--- Diff: flink-staging/flink-table/pom.xml ---
@@ -37,7 +37,7 @@ under the License.
com.google.guava
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40674158
--- Diff: flink-staging/flink-table/pom.xml ---
@@ -37,7 +37,7 @@ under the License.
com.google.guava
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1127#issuecomment-143728302
Don't worry, everyone was once a starter in Scala. :smiley:
You can also leave the `supports*` methods in if you think that they might
be necessary in the fut
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40545392
--- Diff: flink-staging/flink-table/pom.xml ---
@@ -37,7 +37,7 @@ under the License.
com.google.guava
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40545360
--- Diff: flink-staging/flink-table/pom.xml ---
@@ -59,6 +59,12 @@ under the License.
+ org.apac
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1127#issuecomment-143718074
Thanks @aljoscha for reviewing my code! Sorry for the bad Scala style. This
was my first really large Scala code project I wrote (not just small scripts),
I'm still lear
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40540522
--- Diff: flink-staging/flink-table/pom.xml ---
@@ -59,6 +59,12 @@ under the License.
+ org.apach
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40540138
--- Diff: flink-staging/flink-table/pom.xml ---
@@ -37,7 +37,7 @@ under the License.
com.google.guava
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1127#issuecomment-143703367
Hi,
I like the work. :smile:
Some remarks about Scala style. We are trying to make our Scala code more
consistent. Mostly, I didn't comment everything, jus
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40536932
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/PredicateFilter.scala
---
@@ -0,0 +1,88 @@
+/*
+
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40536239
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/PredicatePushdown.scala
---
@@ -0,0 +1,124 @@
+/*
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40535960
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/expressions/analysis/ResolveFieldReferences.scala
---
@@ -30,21 +33,43 @@ impo
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40534836
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaBatchTranslator.scala
---
@@ -118,6 +140,12 @@ class JavaBatchTransla
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40534596
--- Diff:
flink-staging/flink-table/src/main/scala/org/apache/flink/api/java/table/JavaBatchTranslator.scala
---
@@ -54,6 +56,26 @@ class JavaBatchTranslato
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40534229
--- Diff: flink-staging/flink-table/pom.xml ---
@@ -59,6 +59,12 @@ under the License.
+ org.apac
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/1127#discussion_r40534193
--- Diff: flink-staging/flink-table/pom.xml ---
@@ -37,7 +37,7 @@ under the License.
com.google.guava
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1127#issuecomment-140355813
Hi @chiwanpark, yes I think splitting it up makes sense. I just opened this
PR to get some feedback and to show why my changes are necessary to integrate
new input forma
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1127#issuecomment-140327645
Hi @twalthr, thanks for your contribution. But this PR contains many
changes unrelated to HCatalog format. Maybe we should split this PR into
HCatalog and other chang
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/1127
[FLINK-2167] [table] Add fromHCat() to TableEnvironment
This PR introduces input format interfaces (so-called `TableSource`s) for
the Table API. There are two types of TableSources:
- `Adap
21 matches
Mail list logo
