Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1127#issuecomment-143718074
Thanks @aljoscha for reviewing my code! Sorry for the bad Scala style. This
was my first really large Scala code project I wrote (not just small scripts),
I'm still learning by doing ;) I will correct the issues you mentioned.
For the technical part: Yes, I don't modify the expression tree, I'm just
giving the sources the possibility to adapt to the need of the program.
Regarding the `supports*` methods, yes you are right, actually they are not
necessary, but I thought it makes sense for possible future table sources to
check that in advance. In some cases it also reduces the amout of some method
calls, but I can also remove the `supports*` methods for reason of simplicity,
no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
