Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/678
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-105641949
will merge!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabl
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-105429495
Great!
+1 for opening a separate issue for `difference` and big +1 for remembering
to use @ForwardedFields :))
---
If your project is set up for it, you can reply to t
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-105311774
Yes, I got the idea of difference, we agree on the functionality. What I
was trying to say is that it cannot be used in the remove* methods as it needs
to create a gra
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-105287317
Hey @andralungu,
first of all, you can always discuss implementation details by starting a
thread in the mailing list. This is usually done for bigger changes, so t
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-105277029
Hi @vasia,
I updated the addition methods to fit your suggestion. Feedback, for both
of us in the future: discuss implementation details like just add vertice
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-105014574
Hi @andralungu,
I think that mixing DataSet with List is not the way to go. When would one
end up with a DataSet of vertices, but just a list of Edges (given that e
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-103862850
Hi @vasia ,
I will address your comments one by one :)
- the addVertices method receives a List of Edges instead of a DataSet of
Edges because you need to
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-103574952
Thanks for this PR @andralungu!
There are a few things we need to consider here I think:
- when to have a `DataSet` argument and when to have a `List`. For examp
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-102301712
Well that was embarrassing ^^. Excellent catch @rmetzger! The code was
written yesterday evening during a plane ride; My tests found a bug and I
basically put that the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-102299465
Looks good (+1 for updating the docs and having tests ;) )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/678#discussion_r30390037
--- Diff:
flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/operations/GraphMutationsITCase.java
---
@@ -271,4 +605,31 @@ public void testR
GitHub user andralungu opened a pull request:
https://github.com/apache/flink/pull/678
[FLINK-2012][gelly] Added methods to remove/add multiple edges/vertices
This pull request provides methods for adding/deleting more than one
vertex/edge at a time.
The addEdges method is over
13 matches
Mail list logo
