[GitHub] flink issue #4127: [FLINK-6892][table]Add L/RPAD supported in SQL

2018-01-24 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/4127 Thank you @sunjincheng121. I will expose this to the Table API as well and merge this. ---

[GitHub] flink issue #4127: [FLINK-6892][table]Add L/RPAD supported in SQL

2018-01-11 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4127 @twalthr Thanks for the review! I have update the PR. I will be very grateful if you can review again. Thanks, Jincheng ---

[GitHub] flink issue #4127: [FLINK-6892][table]Add L/RPAD supported in SQL

2017-07-19 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4127 Hi, @twalthr Thanks for your reviewing. For performance reasons I have not using `String.format()`. I have a simple test using `String.format()` and PR approach. run `10` times. The re

[GitHub] flink issue #4127: [FLINK-6892][table]Add L/RPAD supported in SQL

2017-07-06 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4127 I had rebase the code and update the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] flink issue #4127: [FLINK-6892][table]Add L/RPAD supported in SQL

2017-06-23 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/4127 I'll Rebase code and add doc after FLINK-6960 & FLINK-6925. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe