Github user sunjincheng121 commented on the issue:

    https://github.com/apache/flink/pull/4127
  
    Hi, @twalthr Thanks for your reviewing. 
    For performance reasons I have not using `String.format()`. I have a simple 
test using `String.format()` and PR approach. run `100000` times. The result as 
follows:
    `str.concat(String.format("%" + (length - str.length()) + "s", 
"").replace(" ", car));` : 1345ms
    `The PR lpad` : 145ms. So I think we should not using `String.format()`. 
Please tell me if there are any mistake.
    
    Thanks, Jincheng



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to