Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3721
Merging this.
I filed a follow-up JIRA to address the "configuration with units" to make
sure all memory-related parameters behave the same way, without loss of byte
precision where needed: h
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3721
Okay, taking a step back. Looking through the code some more, the internal
arithmetric should certainly stay in bytes. However, bytes are tedious to
configure.
I suggest to add support t
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3721
Code is good in general and well tested (including the shell scripts, which
is great!)
I would do some on-the fly polishing while merging. Main thing I want to
adjust if having the confi
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3721
I am checking this PR out now...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/3721
For the two tests that failed on Travis CI: they were simply killed and a
"`Killed`" appeared in their logs which is usually an indicator that memory ran
out and the kernel killed a process
---
If yo
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3721
I've merged the 2 PR's that this one build upon; could you rebase this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
