Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3721
  
    Code is good in general and well tested (including the shell scripts, which 
is great!)
    
    I would do some on-the fly polishing while merging. Main thing I want to 
adjust if having the configuration parameters specified in Megabytes, not 
Bytes. All other memory related parameters are in Megabytes, so that one should 
be as well, for consistency. Also, I think we don't need a finer granularity 
these days.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to