Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
The Bahir PR was merged in closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
The Bahir PR is open now: https://github.com/apache/bahir-flink/issues/3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
Great, I'll take your changes to open a PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger Thank you for your help. I'll try to make the change today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
Okay, can do.
It would be good if you could address the comment first.
Sent from my iPhone
> On 22.08.2016, at 16:53, Ivan Mushketyk wrote:
>
> @rmetzger Please op
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger Please open a PR yourself.
Sorry for confusing you.
Would it make sense to address your comment first though?
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
Do you want to open the PR at Bahir or should I do it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have t
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
> One more thing: Let me know if you don't like to do the migration to
Bahir. I understand that this is a bit annoying and our fault. I can also do
the migration if you want.
@rmetzger I d
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
One more thing: Let me know if you don't like to do the migration to Bahir.
I understand that this is a bit annoying and our fault. I can also do the
migration if you want.
---
If your project is
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
Hi Ivan,
thank you for addressing all my comments. I've filed a JIRA in Bahir for
adding the ActiveMQ connector: https://issues.apache.org/jira/browse/BAHIR-56
I'll do a final check of t
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger I performed the check as you described and everything seems to be
fine.
I also updated the PR according to your suggestions.
Is this commit in a good shape to merge it?
---
If yo
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger Thank you for detailed instructions. I'll check this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
Lets wait for the Bahir GitHub repo being opened and then open a PR there.
I can't merge it there myself, because I'm not a committer, but I'm sure
they'll merge it once I've done a final review.
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger About moving to bahir. Would you (or someone else) merge this
into Apache Flink and them move this code with other connectors, or should I
create another PR with the AMQ connector for Bah
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger About the "job jar". Could you suggest how to check this? Is
there anything I should do except performing "mvn clean install"?
---
If your project is set up for it, you can reply to this
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
@mushketyk: The bahir community is currently setting up a repository for
Flink.
I think it'll be available in the next days.
The connector is almost ready to be merged to bahir.
---
If your
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
>>Were there any any dependency issues / conflicts with the user job jar?
>
>Sorry, what do you mean by the "job jar"?
When adding the flink-connector-activemq as a dependency to a ma
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger I've updated the PR according to your review. Could you please
take another look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
>> Did you test the code on a cluster?
I tested it using the test ActiveMQ server (via an integration test), but I
can also test it using an ActiveMQ cluster.
>> Were there any any depe
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger Thank you for your detailed review. I'll update the PR today or
tomorrow.
Despite of the fact that this connector will probably moved to Bahir it
would make sense to make sure that it
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
Thank you for this contribution. I did an initial check of the code.
Once all my comments are addressed, I'll do another check.
Did you test the code on a cluster? Were there any any depe
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/2314
Thanks a lot for the contribution @mushketyk.
It seems like the Flink community prefers to have put the majority of
connector modules to Apache Bahir. We are currently in the process of figuring
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2314
Hi @mushketyk
Thanks for opening this big contribution.
I would like to take a short step back, though. For new modules and new
integrations, we need to have consensus first whet
23 matches
Mail list logo
