Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5241
Thanks @fhueske, I had rebase the code. I appreciate if you can review the
changes.
Best, Jincheng
---
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/5320
[FLINK-8355][table] remove DataSetAggregateWithNullValuesRule.
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5295
It's `NoResourceAvailableException` error, not sure, but we can try to
rebuild it.
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r161798960
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicEventTimeSessionWindows.java
---
@@ -0,0
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r161800866
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SessionWindowTimeGapExtractor.java
---
@@ -0,0 +1,30
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r161799107
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicEventTimeSessionWindows.java
---
@@ -0,0
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r161799438
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicProcessingTimeSessionWindows.java
---
@@ -0,0
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5295#discussion_r161799387
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/DynamicProcessingTimeSessionWindows.java
---
@@ -0,0
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5292
Looks good to me. +1
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4117#discussion_r161504809
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
---
@@ -702,12 +703,15 @@ object
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5210
@xccui sorry for the late reply. Sometimes we add new feature when we have
the requirement. :) Can you give me a example about add the trailing delimiter
as a new feature?
Thanks
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5241
@fhueske Thanks for your review and suggestion about FLINK-8355, I have
fixed the FLINK-8355 issue in this PR. I appreciate if you can review the
change again.
Best, Jincheng
---
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4127
@twalthr Thanks for the review! I have update the PR. I will be very
grateful if you can review again.
Thanks, Jincheng
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160730995
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala
---
@@ -414,6 +414,34 @@ object
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4128
@thedrow Thanks a lot ...
Best, Jincheng
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160454995
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
---
@@ -278,7 +278,14
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5202
Thanks @dubin555, The PR looks pretty good.
+1 to merged.
Thanks, Jincheng
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160442170
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala
---
@@ -254,7 +254,7 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160439631
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
---
@@ -278,7 +278,14
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5210
Hi, @xccui thanks for tell me more about the background of this issue.
But if we improved the `CsvInputFormat` to support that case. Just like
FLINK-8331 did. I think we do not need this
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160430205
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
---
@@ -278,7 +278,14
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160428673
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -1130,259 +1134,263
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160426130
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala
---
@@ -254,7 +254,7 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160419117
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
---
@@ -278,7 +278,14
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160416641
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
---
@@ -278,7 +278,14
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160414914
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/JoinITCase.scala
---
@@ -254,7 +254,7 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160413930
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
---
@@ -145,6
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5241#discussion_r160413762
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
@@ -359,12 +359,17 @@ class
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5210
Thanks for the PR @xccui. The PR looks good for me. But I am not sure, do
we need this change if all CSV parser supported the format of without trailing
delimiter. What do you think?
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046851
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046954
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046904
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046913
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160047907
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -1216,6 +1216,64 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046875
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046817
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046872
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046823
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046929
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160047969
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala
---
@@ -58,4 +58,22 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046944
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160046879
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160047972
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala
---
@@ -58,4 +58,22 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160047888
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -1216,6 +1216,64 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r160047012
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,45 @@ object
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5218
Thanks @fhueske, I'll fix it then merging.
Thanks, Jincheng
---
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5218
@fhueske Thanks a lot for your review. I had updated the PR. :)
Thanks, Jincheng
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159683964
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/LongParser.java ---
@@ -86,6 +92,11 @@ public int parseField(byte[] bytes, int
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159682488
--- Diff:
flink-core/src/main/java/org/apache/flink/types/parser/StringParser.java ---
@@ -42,6 +42,12 @@ public void enableQuotedStringParsing(byte
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/5241
[FLINK-8325][table] Add COUNT(*),COUNT(1) supported
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5212
Thanks @twalthr
---
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5212
@twalthr Thanks for your comments. I am grateful if you can take a look at
this PR again. :)
Thanks, Jincheng
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5212#discussion_r159413615
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
---
@@ -47,9 +47,22 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5212#discussion_r159411155
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -356,8 +356,117 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5205#discussion_r159222950
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/TaskCancelThread.java
---
@@ -49,7 +49,7 @@ public
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5212
Will merged...
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159148351
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,75 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159148499
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala
---
@@ -58,4 +58,22 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159148345
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,75 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159148353
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,75 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159148352
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,75 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159148053
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
---
@@ -1216,6 +1216,69 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159148349
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,75 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159148500
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala
---
@@ -58,4 +58,22 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159148346
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,75 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5202#discussion_r159148340
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/functions/ScalarFunctions.scala
---
@@ -109,4 +110,75 @@ object
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5218
@fhueske thanks for your explanation, make sense to me. I updated the PR.
The changes as follows:
- Revert the change of `RowCsvInputFormatTest.testTailingEmptyFields`.
- Unity
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159139198
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java ---
@@ -407,26 +407,47 @@ public void
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159139167
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -362,61 +365,95 @@ public void
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159136839
--- Diff:
flink-core/src/test/java/org/apache/flink/types/parser/ParserTestBase.java ---
@@ -407,26 +407,47 @@ public void
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5218
@fhueske Thanks for the review.
I have updated the PR according your comments. And I have extended the
`RowCsvInputFormatTest.testTailingEmptyFields` method for
DOUBLE/FLOAT/BIGINT/BIGDEC
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159134590
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -61,6 +62,84 @@
private static final
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5218#discussion_r159132545
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
---
@@ -61,6 +62,84 @@
private static final
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/5218
[FLINK-8331][core] FieldParser do not correctly set EMPT_COLUMN error state.
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/5212
[FLINK-8323][table] fix MOD scalar function bug.
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5206
@Xpray Thanks for the update.
+1 to merged.
Best, Jincheng
---
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/5203
merging...
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5206#discussion_r158604394
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala
---
@@ -153,15 +154,19 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5206#discussion_r158603997
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/ScalarSqlFunction.scala
---
@@ -153,15 +154,19 @@ object
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5206#discussion_r158603987
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
---
@@ -481,4 +484,34 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5203#discussion_r158598552
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
---
@@ -481,4 +484,84 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5203#discussion_r158598528
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/table/CalcITCase.scala
---
@@ -541,6 +541,48 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5203#discussion_r158598561
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CalcITCase.scala
---
@@ -352,4 +354,64 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5203#discussion_r158598514
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/CalcITCase.scala
---
@@ -352,6 +353,72 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5203#discussion_r158582395
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
---
@@ -481,4 +484,48 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5203#discussion_r158582801
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CalcITCase.scala
---
@@ -352,4 +354,38 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5203#discussion_r158582778
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
---
@@ -481,4 +484,48 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5203#discussion_r158582780
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/table/CalcITCase.scala
---
@@ -352,4 +354,38 @@ class
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/5203#discussion_r158582750
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
---
@@ -481,4 +484,48 @@ class
Github user sunjincheng121 closed the pull request at:
https://github.com/apache/flink/pull/4652
---
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4210
Hi @wuchong I had rebase the PR. Please look at the PR. :-)
Thanks, jincheng
---
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4652
@fhueske @Jacob Park I am appreciated if you can review the PR.
Thanks, jincheng
---
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4556
I have update the PP. Please look at the PR. :) @fhueske @twalthr @wuchong
@shaoxuan-wang
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4128#discussion_r140644236
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/sql/ScalarSqlFunctions.scala
---
@@ -33,6 +33,14 @@ object
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4534
@fhueske Because the 11.11, I have not update this PR in time. sorry about
that. Now, I have updated the PR. and PR description. Please look at the PR. :)
Thanks, jincheng
---
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4669
[FLINK-7618][table] Add BINARY supported in FlinkTypeFactory
## What is the purpose of the change
*Add BINARY supported in FlinkTypeFactory*
## Brief change log
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4652
[FLINK-7465][table]Add cardinality count for tableAPI and SQL.
## What is the purpose of the change
*In this PR. we want add add CARDINALITY_COUNT for tableAPI and SQL.(Using
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4536
Thanks for the updating, looks good to me.
+1 to merged.
---
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4556#discussion_r137142537
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/FirstValueAggFunctionWithRetract.scala
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4640
[FLINK-7572][table]Improve TableSchema and FlinkTable validation exceâ¦
## What is the purpose of the change
Currently, the exception message of `TableScheam` and `FlinkTable` a little
1 - 100 of 664 matches
Mail list logo
