Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5218#discussion_r159134590
  
    --- Diff: 
flink-java/src/test/java/org/apache/flink/api/java/io/RowCsvInputFormatTest.java
 ---
    @@ -61,6 +62,84 @@
        private static final String FIRST_PART = "That is the first part";
        private static final String SECOND_PART = "That is the second part";
     
    +   @Test
    +   public void testNullValueWithoutTrailingDelimiter() throws Exception {
    --- End diff --
    
    About `RowCsvInputFormatTest.testEmptyFields()`do not check the tailing 
empty field, And in  `RowCsvInputFormatTest.testTailingEmptyFields`, test 
tailing empty field for STRING type. I think we shoud add 
    DOUBLE/FLOAT/BIGINT/BIGDEC/SQL_DATE/SQL_TIME/SQL_TIMESTAMP test case as 
well.
    What do you think?


---

Reply via email to