[jira] [Closed] (FLINK-12744) ML common parameters

2019-07-05 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-12744. - Resolution: Fixed Fix Version/s: 1.9.0 > ML common paramet

[jira] [Commented] (FLINK-12744) ML common parameters

2019-07-05 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879343#comment-16879343 ] Shaoxuan Wang commented on FLINK-12744: --- Fixed in ma

[jira] [Closed] (FLINK-12758) Add flink-ml-lib module

2019-07-05 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-12758. - Resolution: Fixed > Add flink-ml-lib module > --- > >

[jira] [Commented] (FLINK-12758) Add flink-ml-lib module

2019-07-05 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879055#comment-16879055 ] Shaoxuan Wang commented on FLINK-12758: --- Fixed in ma

[jira] [Closed] (FLINK-12597) Remove the legacy flink-libraries/flink-ml

2019-07-05 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-12597. - Resolution: Fixed Fix Version/s: 1.9.0 > Remove the legacy flink-libraries/flink

[jira] [Commented] (FLINK-12597) Remove the legacy flink-libraries/flink-ml

2019-07-05 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879052#comment-16879052 ] Shaoxuan Wang commented on FLINK-12597: --- Fixed in ma

[jira] [Closed] (FLINK-12881) Add more functionalities for ML Params and ParamInfo class

2019-06-30 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-12881. - Resolution: Fixed Fix Version/s: 1.9.0 > Add more functionalities for ML Params

[jira] [Commented] (FLINK-12881) Add more functionalities for ML Params and ParamInfo class

2019-06-30 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875719#comment-16875719 ] Shaoxuan Wang commented on FLINK-12881: --- Fixed in ma

[jira] [Issue Comment Deleted] (FLINK-12470) FLIP39: Flink ML pipeline and ML libs

2019-06-30 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang updated FLINK-12470: -- Comment: was deleted (was: Fixed in master:1660c6b47af789fa5c9bf6a3ff77e868ca90

[jira] [Commented] (FLINK-12470) FLIP39: Flink ML pipeline and ML libs

2019-06-30 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875717#comment-16875717 ] Shaoxuan Wang commented on FLINK-12470: --- Fixed in ma

[jira] [Closed] (FLINK-12473) Add the interface of ML pipeline and ML lib

2019-05-24 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-12473. - Resolution: Fixed Fix Version/s: 1.9.0 Fixed in master

[jira] [Created] (FLINK-12597) Remove the legacy flink-libraries/flink-ml

2019-05-23 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-12597: - Summary: Remove the legacy flink-libraries/flink-ml Key: FLINK-12597 URL: https://issues.apache.org/jira/browse/FLINK-12597 Project: Flink Issue Type: Sub

[jira] [Assigned] (FLINK-12473) Add the interface of ML pipeline and ML lib

2019-05-10 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang reassigned FLINK-12473: - Assignee: Luo Gen > Add the interface of ML pipeline and ML

[jira] [Updated] (FLINK-12473) Add the interface of ML pipeline and ML lib

2019-05-10 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang updated FLINK-12473: -- Summary: Add the interface of ML pipeline and ML lib (was: Add ML pipeline and ML lib Core

[jira] [Created] (FLINK-12473) Add ML pipeline and ML lib Core API

2019-05-09 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-12473: - Summary: Add ML pipeline and ML lib Core API Key: FLINK-12473 URL: https://issues.apache.org/jira/browse/FLINK-12473 Project: Flink Issue Type: Sub-task

[jira] [Closed] (FLINK-11115) Port some flink.ml algorithms to table based

2019-05-09 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-5. - Resolution: Duplicate We decided to move the entire ml pipeline and ml lib development under

[jira] [Closed] (FLINK-11114) Support wrapping inference pipeline as a UDF function in SQL

2019-05-09 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-4. - Resolution: Duplicate We decided to move the entire ml pipeline and ml lib development under

[jira] [Closed] (FLINK-11113) Support periodically update models when inferencing

2019-05-09 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-3. - Resolution: Duplicate We decided to move the entire ml pipeline and ml lib development under

[jira] [Closed] (FLINK-11111) Create a new set of parameters

2019-05-09 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-1. - Resolution: Duplicate We decided to move the entire ml pipeline and ml lib development under

[jira] [Closed] (FLINK-11112) Support pipeline import/export

2019-05-09 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-2. - Resolution: Duplicate We decided to move the entire ml pipeline and ml lib development under

[jira] [Closed] (FLINK-11109) Create Table based optimizers

2019-05-09 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-11109. - Resolution: Duplicate We decided to move the entire ml pipeline and ml lib development under

[jira] [Closed] (FLINK-11108) Create a new set of table based ML Pipeline classes

2019-05-09 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-11108. - Resolution: Duplicate We decided to move the entire ml pipeline and ml lib development under

[jira] [Closed] (FLINK-11096) Create a new table based flink ML package

2019-05-09 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-11096. - Resolution: Duplicate We decided to move the entire ml pipeline and ml lib development under

[jira] [Comment Edited] (FLINK-11095) Table based ML Pipeline

2019-05-09 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836837#comment-16836837 ] Shaoxuan Wang edited comment on FLINK-11095 at 5/10/19 2:4

[jira] [Closed] (FLINK-11095) Table based ML Pipeline

2019-05-09 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-11095. - Resolution: Fixed We decided to move the entire ml pipeline and ml lib development under FLIP39

[jira] [Created] (FLINK-12470) FLIP39: Flink ML pipeline and ML libs

2019-05-09 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-12470: - Summary: FLIP39: Flink ML pipeline and ML libs Key: FLINK-12470 URL: https://issues.apache.org/jira/browse/FLINK-12470 Project: Flink Issue Type: New

[jira] [Closed] (FLINK-11004) Wrong ProcessWindowFunction.process argument in example of Incremental Window Aggregation with ReduceFunction

2018-11-28 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-11004. - Resolution: Fixed Fixed and merged into master > Wrong ProcessWindowFunction.process argum

[GitHub] flink pull request #4471: [FLINK-6094] [table] Implement stream-stream proct...

2017-09-25 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/4471#discussion_r140951770 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/datastream/DataStreamJoinRule.scala --- @@ -0,0 +1,93

[jira] [Commented] (FLINK-5905) Add user-defined aggregation functions to documentation.

2017-08-15 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16127439#comment-16127439 ] Shaoxuan Wang commented on FLINK-5905: -- This issue will be solved once FLINK-675

[GitHub] flink pull request #4546: [FLINK-6751] [docs] Add missing documentation for ...

2017-08-15 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/4546 [FLINK-6751] [docs] Add missing documentation for User-Defined Functions Page *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink

[jira] [Comment Edited] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-19 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092983#comment-16092983 ] Shaoxuan Wang edited comment on FLINK-7194 at 7/19/17 12:1

[jira] [Commented] (FLINK-7194) Add getResultType and getAccumulatorType to AggregateFunction

2017-07-19 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092983#comment-16092983 ] Shaoxuan Wang commented on FLINK-7194: -- [~fhueske], I am ok with your proposal

[jira] [Commented] (FLINK-6751) Table API / SQL Docs: UDFs Page

2017-07-19 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092970#comment-16092970 ] Shaoxuan Wang commented on FLINK-6751: -- Sorry for being no update. I will wor

[jira] [Closed] (FLINK-6725) make requiresOver as a contracted method in udagg

2017-07-17 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-6725. Resolution: Won't Fix > make requiresOver as a contracted method

[GitHub] flink issue #3993: [FLINK-6725][table] make requiresOver as a contracted met...

2017-07-17 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3993 @fhueske @sunjincheng121 @wuchong, thanks for the valuable inputs. We talked offline and get an agreement that we'd better to put `getAccumulatorType()`, `getResultType()` et

[GitHub] flink pull request #3993: [FLINK-6725][table] make requiresOver as a contrac...

2017-07-17 Thread shaoxuan-wang
Github user shaoxuan-wang closed the pull request at: https://github.com/apache/flink/pull/3993 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Updated] (FLINK-5878) Add stream-stream inner/left-out join

2017-07-16 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang updated FLINK-5878: - Summary: Add stream-stream inner/left-out join (was: Add stream-stream inner join on TableAPI

[jira] [Assigned] (FLINK-5878) Add stream-stream inner/left-out join

2017-07-16 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang reassigned FLINK-5878: Assignee: Hequn Cheng (was: Shaoxuan Wang) > Add stream-stream inner/left-out j

[jira] [Commented] (FLINK-7146) FLINK SQLs support DDL

2017-07-12 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083614#comment-16083614 ] Shaoxuan Wang commented on FLINK-7146: -- [~yuemeng], DDL is an important inter

[jira] [Created] (FLINK-6962) SQL DDL for input and output tables

2017-06-21 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-6962: Summary: SQL DDL for input and output tables Key: FLINK-6962 URL: https://issues.apache.org/jira/browse/FLINK-6962 Project: Flink Issue Type: New Feature

[jira] [Created] (FLINK-6963) User Defined Operator

2017-06-21 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-6963: Summary: User Defined Operator Key: FLINK-6963 URL: https://issues.apache.org/jira/browse/FLINK-6963 Project: Flink Issue Type: New Feature

[jira] [Created] (FLINK-6961) Enable configurable early-firing rate

2017-06-21 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-6961: Summary: Enable configurable early-firing rate Key: FLINK-6961 URL: https://issues.apache.org/jira/browse/FLINK-6961 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-5354) Split up Table API documentation into multiple pages

2017-05-28 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16027842#comment-16027842 ] Shaoxuan Wang commented on FLINK-5354: -- [~fhueske], thanks for kicking off thi

[jira] [Assigned] (FLINK-6751) Table API / SQL Docs: UDFs Page

2017-05-28 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang reassigned FLINK-6751: Assignee: Shaoxuan Wang > Table API / SQL Docs: UDFs P

[GitHub] flink issue #3993: [FLINK-6725][table] make requiresOver as a contracted met...

2017-05-26 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3993 Thanks for the review @fhueske @sunjincheng121 . Fabian, yes, I do not think this will be a blocker for release. In fact, this is a similar interface clean-up issue as FLINK-6457 that we

[GitHub] flink pull request #3993: [FLINK-6725][table] make requiresOver as a contrac...

2017-05-25 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3993 [FLINK-6725][table] make requiresOver as a contracted method in udagg Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Created] (FLINK-6725) make requiresOver as a contracted method in udagg

2017-05-25 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-6725: Summary: make requiresOver as a contracted method in udagg Key: FLINK-6725 URL: https://issues.apache.org/jira/browse/FLINK-6725 Project: Flink Issue Type

[jira] [Updated] (FLINK-6637) Move registerFunction to TableEnvironment

2017-05-23 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang updated FLINK-6637: - Component/s: Table API & SQL > Move registerFunction to TableEnvi

[jira] [Created] (FLINK-6637) Move registerFunction to TableEnvironment

2017-05-19 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-6637: Summary: Move registerFunction to TableEnvironment Key: FLINK-6637 URL: https://issues.apache.org/jira/browse/FLINK-6637 Project: Flink Issue Type

[GitHub] flink issue #3923: [FLINK-6587] [table] Simplification and bug fixing of the...

2017-05-16 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3923 @twalthr, it seems we have reserved the keyword with the case insensitive. For instance, we cannot use "Sum" and "SUM", as "sum" is reserved. Did we intent t

[jira] [Updated] (FLINK-6544) Expose State Backend Interface for UDAGG

2017-05-12 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang updated FLINK-6544: - Summary: Expose State Backend Interface for UDAGG (was: Expose Backend State Interface for UDAGG

[jira] [Assigned] (FLINK-6544) Expose Backend State Interface for UDAGG

2017-05-12 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang reassigned FLINK-6544: Assignee: Kaibo Zhou > Expose Backend State Interface for UD

[jira] [Closed] (FLINK-5433) initiate function of Aggregate does not take effect for DataStream aggregation

2017-05-04 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang closed FLINK-5433. Resolution: Fixed Fixed by UDAGG subtasks FLINK-5564 > initiate function of Aggregate does

[jira] [Resolved] (FLINK-5915) Add support for the aggregate on multi fields

2017-05-04 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang resolved FLINK-5915. -- Resolution: Fixed This is completely resolved with FLINK-5906. > Add support for the aggreg

[GitHub] flink pull request #3809: [FLINK-5906] [table] Add support to register UDAGG...

2017-05-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3809#discussion_r114692346 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/AggSqlFunction.scala --- @@ -0,0 +1,177

[GitHub] flink pull request #3809: [FLINK-5906] [table] Add support to register UDAGG...

2017-05-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3809#discussion_r114692276 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/utils/AggSqlFunction.scala --- @@ -0,0 +1,177

[GitHub] flink pull request #3809: [FLINK-5906] [table] Add support to register UDAGG...

2017-05-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3809#discussion_r114690845 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/aggregations.scala --- @@ -130,3 +142,63 @@ case class Avg

[GitHub] flink pull request #3809: [FLINK-5906] [table] Add support to register UDAGG...

2017-05-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3809#discussion_r114579772 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/batch/table/DSetUDAGGITCase.scala --- @@ -0,0 +1,192

[GitHub] flink pull request #3809: [FLINK-5906] [table] Add support to register UDAGG...

2017-05-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3809#discussion_r114576600 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala --- @@ -178,4 +178,24 @@ class

[GitHub] flink pull request #3809: [FLINK-5906] [table] Add support to register UDAGG...

2017-05-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3809#discussion_r114571910 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/ProjectionTranslator.scala --- @@ -327,4 +332,56 @@ object

[GitHub] flink pull request #3809: [FLINK-5906] [table] Add support to register UDAGG...

2017-05-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3809#discussion_r114498337 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/DStreamUDAGGITCase.scala --- @@ -0,0 +1,309

[GitHub] flink issue #3809: [FLINK-5906] [table] Add support to register UDAGG in Tab...

2017-05-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3809 Thanks for the review, @fhueske , and very good point regarding to the approach to "replace UDAGGFunctionCall". I have addressed your comments. Please take a look. --- If your proj

[GitHub] flink pull request #3809: [FLINK-5906] [table] Add support to register UDAGG...

2017-05-02 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3809 [FLINK-5906] [table] Add support to register UDAGG in Table and SQL API Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Assigned] (FLINK-5905) Add user-defined aggregation functions to documentation.

2017-05-02 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang reassigned FLINK-5905: Assignee: Shaoxuan Wang > Add user-defined aggregation functions to documentat

[jira] [Updated] (FLINK-5906) Add support to register UDAGG in Table and SQL API

2017-05-02 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang updated FLINK-5906: - Summary: Add support to register UDAGG in Table and SQL API (was: Add support to register UDAGGs

[GitHub] flink issue #3768: [FLINK-6368][table] Grouping keys in stream aggregations ...

2017-04-25 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3768 I ran into the same problem today when adding the new test cases for UDAGG. Thanks for the fix, @xccui --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] flink issue #3762: [FLINK-6361] [table] Refactoring the AggregateFunction in...

2017-04-25 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3762 Hi @fhueske , it is good to have a dedicated Iterable for pair-merge. Please go ahead. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #3762: [FLINK-6361] [table] Refactoring the AggregateFunc...

2017-04-24 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3762 [FLINK-6361] [table] Refactoring the AggregateFunction interface and built-in aggregates This PR includes the following changes: 1) remove Accumulator trait; 2) move accumulate

[jira] [Created] (FLINK-6361) Finalize the AggregateFunction interface and refactoring built-in aggregates

2017-04-22 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-6361: Summary: Finalize the AggregateFunction interface and refactoring built-in aggregates Key: FLINK-6361 URL: https://issues.apache.org/jira/browse/FLINK-6361 Project

[jira] [Resolved] (FLINK-5813) code generation for user-defined aggregate functions

2017-04-22 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang resolved FLINK-5813. -- Resolution: Fixed All required issues are solved. > code generation for user-defined aggreg

[GitHub] flink issue #3735: [FLINK-6242] [table] Add code generation for DataSet Aggr...

2017-04-21 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3735 @fhueske , your changes look good to me, I left a few comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Updated] (FLINK-6334) Refactoring UDTF interface

2017-04-19 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang updated FLINK-6334: - Description: The current UDTF leverages the table.join(expression) interface, which is not a

[GitHub] flink issue #3735: [FLINK-6242] [table] Add code generation for DataSet Aggr...

2017-04-18 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3735 @fhueske thanks for your feedback. Yes, we could keep GeneratedAggregations interface very clean as ``` abstract class GeneratedAggregations extends Function { def

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3735#discussion_r111986331 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GeneratedAggregations.scala --- @@ -36,6 +36,15

[GitHub] flink pull request #3735: [FLINK-6242] [table] Add code generation for DataS...

2017-04-18 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3735 [FLINK-6242] [table] Add code generation for DataSet Aggregates Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[GitHub] flink issue #3694: [FLINK-6240] [table] codeGen dataStream aggregates that u...

2017-04-17 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3694 Thanks @fhueske , I have addressed your comments, please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] flink pull request #3694: [FLINK-6240] [table] codeGen dataStream aggregates...

2017-04-17 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3694#discussion_r111813245 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala --- @@ -792,6 +792,20 @@ object

[GitHub] flink issue #3696: [FLINK-6090] [table] Add RetractionRule at the stage of d...

2017-04-13 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3696 @fhueske, thanks for the review and valuable comments. Yes, we'd better add the attributes (which provide information for deriving ACCMode) inside the DataStreamRel interface, such

[GitHub] flink pull request #3694: [FLINK-6240] [table] codeGen dataStream aggregates...

2017-04-07 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3694#discussion_r110345902 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateAggFunction.scala --- @@ -18,69 +18,51

[GitHub] flink pull request #3694: [FLINK-6240] [table] codeGen dataStream aggregates...

2017-04-07 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3694#discussion_r110344806 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala --- @@ -403,6 +403,41 @@ class CodeGenerator

[GitHub] flink pull request #3694: [FLINK-6240] [table] codeGen dataStream aggregates...

2017-04-07 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3694 [FLINK-6240] [table] codeGen dataStream aggregates that use AggregateAggFunction Thanks for contributing to Apache Flink. Before you open your pull request, please take the following

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-04-06 Thread shaoxuan-wang
Github user shaoxuan-wang closed the pull request at: https://github.com/apache/flink/pull/3646 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-04-05 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3646#discussion_r110073336 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -299,27 +299,6

[GitHub] flink issue #3676: [FLINK-6241] [table] codeGen dataStream aggregates that u...

2017-04-05 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3676 Thanks @fhueske, these changes look good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] flink issue #3646: [FLINK-6216] [table] DataStream unbounded groupby aggrega...

2017-04-05 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3646 @fhueske, thanks for your review. I have addressed all your comments, and rebased the code to the master. Please take a look. --- If your project is set up for it, you can reply to this

[GitHub] flink pull request #3676: [FLINK-6241] [table] codeGen dataStream aggregates...

2017-04-05 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3676 [FLINK-6241] [table] codeGen dataStream aggregates that use ProcessFunction Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check

[GitHub] flink issue #3665: [FLINK-6011] Support TUMBLE, HOP, SESSION window in strea...

2017-04-04 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3665 So we finally got those supported by Calcite 1.12?Really excited to see those features supported in flinkSQL. Thanks @haohui. --- If your project is set up for it, you can reply to this

[jira] [Commented] (FLINK-5564) User Defined Aggregates

2017-04-01 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952127#comment-15952127 ] Shaoxuan Wang commented on FLINK-5564: -- [~fhueske], implementing the entire cod

[jira] [Created] (FLINK-6242) codeGen DataSet Goupingwindow Aggregates

2017-04-01 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-6242: Summary: codeGen DataSet Goupingwindow Aggregates Key: FLINK-6242 URL: https://issues.apache.org/jira/browse/FLINK-6242 Project: Flink Issue Type: Sub-task

[jira] [Created] (FLINK-6241) codeGen dataStream aggregates that use ProcessFunction

2017-04-01 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-6241: Summary: codeGen dataStream aggregates that use ProcessFunction Key: FLINK-6241 URL: https://issues.apache.org/jira/browse/FLINK-6241 Project: Flink Issue

[jira] [Created] (FLINK-6240) codeGen dataStream aggregates that use AggregateAggFunction

2017-04-01 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-6240: Summary: codeGen dataStream aggregates that use AggregateAggFunction Key: FLINK-6240 URL: https://issues.apache.org/jira/browse/FLINK-6240 Project: Flink

[GitHub] flink issue #3647: [FLINK-5915] [table] forward the entire aggregate ArgList...

2017-03-31 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3647 Thanks @fhueske, I overlooked a list is not always an arraylist. I change it to scala array, but keep the type as integer, as this is type returned (and not easy to be casted to Int) from

[GitHub] flink pull request #3647: [FLINK-5915] [table] forward the entire aggregate ...

2017-03-29 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3647 [FLINK-5915] [table] forward the entire aggregate ArgList to aggregate runtime functions This PR partially solved "FLINK-5915 Add support for the aggregate on multi fields". T

[GitHub] flink pull request #3646: [FLINK-6216] [table] DataStream unbounded groupby ...

2017-03-29 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3646 [FLINK-6216] [table] DataStream unbounded groupby aggregate with early firing 1. Implemented an unbounded groupby aggregate with early firing (period is 1, emit per every record) 2

[jira] [Created] (FLINK-6216) DataStream unbounded groupby aggregate with early firing

2017-03-29 Thread Shaoxuan Wang (JIRA)
Shaoxuan Wang created FLINK-6216: Summary: DataStream unbounded groupby aggregate with early firing Key: FLINK-6216 URL: https://issues.apache.org/jira/browse/FLINK-6216 Project: Flink Issue

[jira] [Assigned] (FLINK-6091) Implement and turn on the retraction for grouping window aggregate

2017-03-24 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang reassigned FLINK-6091: Assignee: Hequn Cheng (was: Shaoxuan Wang) > Implement and turn on the retraction

[jira] [Assigned] (FLINK-6090) Implement optimizer for retraction and turn on retraction for over window aggregate

2017-03-24 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang reassigned FLINK-6090: Assignee: Hequn Cheng (was: Shaoxuan Wang) > Implement optimizer for retraction and t

[GitHub] flink pull request #3585: [FLINK-5990][table]Add event time OVER ROWS BETWEE...

2017-03-23 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3585#discussion_r107649062 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -317,4 +397,24 @@ class

[GitHub] flink pull request #3564: [FLINK-6089] [table] Implement decoration phase fo...

2017-03-22 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3564#discussion_r107594707 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala --- @@ -162,6 +162,27 @@ abstract class

[GitHub] flink issue #3579: [FLINK-6124] [Table API & SQL] support max/min aggregatio...

2017-03-22 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3579 @twalthr thanks for the reply and explanation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

  1   2   3   >