Github user s1ck commented on the issue:
https://github.com/apache/flink/pull/2527
@greghogan since I addressed all your comments, is there anything left to
do that prevents this from merging?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user s1ck commented on the issue:
https://github.com/apache/flink/pull/2527
> I'd also like to add a ToNullValue translator that would accept any type
and convert to NullValue.
I don't know if I get this right. Do you mean an additional test case with
`
Github user s1ck commented on the issue:
https://github.com/apache/flink/pull/2527
> Would a graph translator simplify the conversion from Long to String? You
can do graph.run(new TranslateEdgeValues<...>(new StringToLong()) and write a
simple public class StringToLong i
Github user s1ck commented on the issue:
https://github.com/apache/flink/pull/2527
> I'm not following why specifying the TypeInformation is now required with
the change to using Either. Is the type system failing to handle this properly?
You are right, I was experiment
Github user s1ck commented on a diff in the pull request:
https://github.com/apache/flink/pull/2527#discussion_r80186110
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/Summarization.java
---
@@ -226,11 +247,15 @@ public void
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/2527
[FLINK-4624] Allow for null values in Graph Summarization
* Bug was caused by serializers that cannot handle null values (e.g. Long)
* VertexGroupItem now uses Either instead of VV
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1786#issuecomment-196175512
Sounds good, but then I would change the text to:
`A detailed explanation can be found in our [Contribute Code
Guide](http://flink.apache.org/contribute-code.html
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1786
[FLINK-3611] [docs] corrected link in CONTRIBUTING.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/s1ck/flink FLINK-3611
Alternatively you can
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1785
[FLINK-3272] [Gelly] Generic value in Connected Components
* Updated scatter-gather and GSA implementation + tests
* updated documentation
You can merge this pull request into a Git repository by
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1575#issuecomment-194251517
Ok, I will keep that in mind. Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1575#issuecomment-193968765
Hi @vasia this is a nice PR, I commented some minor documentation / naming
issues
+1 for merging
---
If your project is set up for it, you can reply to this email and
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1521
[FLINK-3122] [Gelly] Generic vertex value in label propagation
* updated algorithm and tests
* updated / corrected algorithm documentation
You can merge this pull request into a Git repository by
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1471#issuecomment-169421134
Hi, sorry for the delay. I'll add the test asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1471#issuecomment-166341381
Sorry for missing javadoc, I was inspired by the other methods in
`TypeExtractor` ;) The test will be a generic version of `LabelPropagation`,
described in https
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1471
[FLINK-3118] [Gelly] Consider ResultTypeQueryable in Message and
GatherFunction
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/s1ck/flink FLINK
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1396
[FLINK-3064] [core] Add size check in GroupReduceOperatorBase
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/s1ck/flink FLINK-3064
Alternatively
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1335
[FLINK-2981] [docs] update requirements in docs/README.md
* added libraries and versions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/s1ck/flink
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1329#issuecomment-154061114
yeah, that's fine with me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1329#issuecomment-154057136
Hey!
you're welcome :) I will fix the comments later today. There is no
difference, `graph1.intersect(graph2)` is just a convenience method if the user
want
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1329
[FLINK-2905] [gelly] Add Graph Intersection method
* added two strategies for edge intersection
* added Scala methods
* added tests
* updated docs
You can merge this pull request into a
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1269#issuecomment-150207311
Thx, currently thinking about making the aggregation more flexible (SUM,
COUNT and AVG). But this will be another issue :)
---
If your project is set up for it, you can
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1269
[FLINK-2411] [gelly] Add Summarization Algorithm
* implemented algorithm
* implemented integration tests
* updated gelly guide
You can merge this pull request into a Git repository by running
Github user s1ck closed the pull request at:
https://github.com/apache/flink/pull/1264
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1264#issuecomment-149149391
Hi @vasia,
I will update the docs asap and append it to the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1264
[FLINK-2411] Add graph summarization algorithm
* added algorithm
* added integration tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/s1ck
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136658385
Ok, thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136654131
Sorry, I did not see that there are also identical test cases in Scala
which now fail due to the `-1` change. As those scala methods wrap the Java
methods, is it necessary
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136633442
@tillrohrmann of course you are right, I thought wrong about it. it's
committed
---
If your project is set up for it, you can reply to this email and have your
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136445029
@tillrohrmann I did not include the `shifter =
getBitSize(getRuntimeContext().getNumberOfParallelSubtasks() - 1)` as your hint
only applies for power of 2 values. E.g
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136431165
@StephanEwen thx for the hint. works fine! Will cleanup and commit now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136426216
@tillrohrmann While writing the new tests for both methods, I encountered
that `zipWithIndex` is broken, too. It sometimes throws
`ConcurrentModificationException`. This
Github user s1ck commented on the pull request:
https://github.com/apache/flink/pull/1075#issuecomment-136380943
There is already a test case for zipWithUniqueId() in
https://github.com/apache/flink/blob/master/flink-tests/src/test/java/org/apache/flink/test/util
GitHub user s1ck opened a pull request:
https://github.com/apache/flink/pull/1075
[FLINK-2590] fixing DataSetUtils.zipWithUniqueId()
* modified algorithm as explained in the issue
* updated method documentation
You can merge this pull request into a Git repository by running
33 matches
Mail list logo
