Github user mcfongtw commented on the issue:
https://github.com/apache/flink/pull/5183
+1 for this change, @NicoK . I did not see this error as I was working on
FLINK-6805 - my bad :(. Also, you might want to remove those comment to avoid
future confusion.
---
GitHub user mcfongtw opened a pull request:
https://github.com/apache/flink/pull/5002
[hotfix][docs] Remove the caveat about Cassandra connector.
## What is the purpose of the change
Remove a caveat in Cassandra connector docs.
## Brief change log
As FLINK
Github user mcfongtw commented on the issue:
https://github.com/apache/flink/pull/4605
Hi, @zentol , thanks for reviewing this PR. I recalled that I put a [caveat
](https://ci.apache.org/projects/flink/flink-docs-release-1.4/dev/connectors/cassandra.html#checkpointing-and-fault
Github user mcfongtw commented on the issue:
https://github.com/apache/flink/pull/4605
@zentol , cool! Thanks for reviewing it!
---
Github user mcfongtw commented on the issue:
https://github.com/apache/flink/pull/4605
Hi, @zentol, since there are some conflicts in this branch and a bit out of
date from current master, I will rebase on this branch. However, I need to know
if you are planning to review and merge
Github user mcfongtw commented on the issue:
https://github.com/apache/flink/pull/4848
Thanks!
---
Github user mcfongtw closed the pull request at:
https://github.com/apache/flink/pull/4848
---
Github user mcfongtw commented on the issue:
https://github.com/apache/flink/pull/4848
@aljoscha, do you think adding these note would suffice?
---
GitHub user mcfongtw opened a pull request:
https://github.com/apache/flink/pull/4848
[FLINK-7839] [doc] Add a note on possible maven failure for creating
quickstart project
## What is the purpose of the change
This only applies before project release
Github user mcfongtw commented on the issue:
https://github.com/apache/flink/pull/4696
Hi, @zentol , could you take another look? Thank you.
---
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4696#discussion_r141785837
--- Diff: docs/dev/connectors/cassandra.md ---
@@ -35,37 +43,47 @@ To use this connector, add the following dependency to
your project
Github user mcfongtw commented on the issue:
https://github.com/apache/flink/pull/4605
@zentol, could you also take another look if the revision has addressed the
concerns? Thank you.
---
Github user mcfongtw commented on the issue:
https://github.com/apache/flink/pull/4696
@zentol, Could you take another look? Thank you.
---
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4696#discussion_r140620313
--- Diff: docs/dev/connectors/cassandra.md ---
@@ -78,76 +96,195 @@ Note that that enabling this feature will have an
adverse impact on latency
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4696#discussion_r140620261
--- Diff: docs/dev/connectors/cassandra.md ---
@@ -78,76 +96,195 @@ Note that that enabling this feature will have an
adverse impact on latency
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4696#discussion_r140620296
--- Diff: docs/dev/connectors/cassandra.md ---
@@ -78,76 +96,195 @@ Note that that enabling this feature will have an
adverse impact on latency
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4696#discussion_r140620211
--- Diff: docs/dev/connectors/cassandra.md ---
@@ -78,76 +96,195 @@ Note that that enabling this feature will have an
adverse impact on latency
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4696#discussion_r140620229
--- Diff: docs/dev/connectors/cassandra.md ---
@@ -78,76 +96,195 @@ Note that that enabling this feature will have an
adverse impact on latency
GitHub user mcfongtw opened a pull request:
https://github.com/apache/flink/pull/4696
[FLINK-7632] [document] Overhaul on Cassandra connector doc
## What is the purpose of the change
Refactor Cassandra connector documentation by providing
- in-depth information about
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4605#discussion_r139950435
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java
---
@@ -0,0
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4605#discussion_r139685528
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java
---
@@ -0,0
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4605#discussion_r139685362
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java
---
@@ -0,0
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4605#discussion_r139658146
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
---
@@ -37,29
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4605#discussion_r139630504
--- Diff:
flink-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBase.java
---
@@ -37,29
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4605#discussion_r139615174
--- Diff:
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraSinkBaseTest.java
---
@@ -0,0
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4641#discussion_r137220153
--- Diff: docs/quickstart/setup_quickstart.md ---
@@ -284,7 +284,7 @@ window of processing time, as long as words are
floating in.
as words are
GitHub user mcfongtw opened a pull request:
https://github.com/apache/flink/pull/4641
[hotfix][docs] Fix a typo on log name for quick start guide.
## Brief change log
The console output of examples should appear in \*-taskmanager-\*.log
instead of \*-jobmanager-\*.log
GitHub user mcfongtw opened a pull request:
https://github.com/apache/flink/pull/4605
[FLINK-4500] [C* Connector] CassandraSinkBase implements
CheckpointedFunction
## What is the purpose of the change
Have CassandraSinkBase to implement CheckpointedFunction so that all
in
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4545#discussion_r133404126
--- Diff: flink-connectors/flink-connector-cassandra/pom.xml ---
@@ -83,6 +85,10 @@ under the License
Github user mcfongtw commented on a diff in the pull request:
https://github.com/apache/flink/pull/4545#discussion_r13339
--- Diff: flink-connectors/flink-connector-cassandra/pom.xml ---
@@ -39,6 +39,7 @@ under the License.
2.2.5
3.0.0
GitHub user mcfongtw opened a pull request:
https://github.com/apache/flink/pull/4545
[FLINK-6805] [Cassandra-Connector] Shade indirect netty4 dep in pom.xml
## Brief change log
- To relocate various *indirect* netty4 dep of ver 4.0.33.Final to
classpath of Flink's flavor
31 matches
Mail list logo
