Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/4681
@fhueske Thanks for your advice. I already update the pr based on your
suggestion.
---
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4681#discussion_r140462913
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkRelOptTable.scala
---
@@ -0,0 +1,265
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4681#discussion_r140462814
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkRelOptTable.scala
---
@@ -0,0 +1,265
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4681#discussion_r140462752
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/schema/FlinkRelOptTable.scala
---
@@ -0,0 +1,265
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/4681
[FLINK-7636][Table API & SQL]Introduce Flink RelOptTable, and remove
tableSource from all TableSourceScan node constructor
## What is the purpose of the change
There are two way
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3409
@fhueske @twalthr , thanks for the reviews. I've updated the pr based on
your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107636567
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107636115
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,32 @@ class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107061507
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
---
@@ -511,15 +511,15 @@ case class Join
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107060990
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/exceptions.scala
---
@@ -165,3 +165,31 @@ case class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r107059962
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/java/BatchTableEnvironment.scala
---
@@ -178,4 +178,32 @@ class
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3569
[flink-6036]Let catalog support partition
This pr aims to let catalog support partition.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3559
@KurtYoung , thanks for the review. I've updated the pr based on your
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3559#discussion_r106797445
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/FlinkPlannerImpl.scala
---
@@ -100,6 +101,7 @@ class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106648264
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,76
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3559
[flink-6037] [Table API & SQL]hotfix: metadata provider didn't work in SQL
This pr aims to fix a bug referenced by
https://issues.apache.org/jira/browse/FLINK-6037.
After using
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3406
@twalthr , thanks for the review. I have updated the pr based on your
suggestion. I would add documents later in the pr #3409. About the name of
ExternalCatalog, I notice that there are three
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106404460
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/sources/CsvTableSourceConverter.scala
---
@@ -0,0 +1,73
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106403723
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalTableSourceUtil.scala
---
@@ -0,0 +1,153
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106395036
--- Diff:
flink-libraries/flink-table/src/main/resources/tableSourceConverter.properties
---
@@ -0,0 +1,19
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106395005
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala
---
@@ -0,0 +1,76
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r106394128
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CrudExternalCatalog.scala
---
@@ -0,0 +1,110
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3409
@fhueske , thanks for the review. I have updated the pr based on your
suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r10636
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -353,19 +388,48 @@ abstract class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106368629
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -246,6 +251,36 @@ abstract class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106368614
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -246,6 +251,36 @@ abstract class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3409#discussion_r106368344
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/TableEnvironment.scala
---
@@ -99,6 +101,9 @@ abstract class
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3406
@fhueske , thanks for your review. I already updated the pr based on your
comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3406
@fhueske , thanks for your review. I updated the pr based on your comments.
Your suggestion about moving the annotation from TableSource to
TableSourceConverter is good, I changed the pr in
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105384191
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,138
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105363822
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105363598
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105362031
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala
---
@@ -0,0 +1,138
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105362292
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala
---
@@ -0,0 +1,114 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r105316858
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java
---
@@ -0,0 +1,63
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3406
@fhueske, thanks for your review. I changed the pr based on your
suggestions, except for one point.
About adding the version field to ExternalCatalogCompatible, could we
define tableType is
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104401203
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,7 +92,12 @@ under the License
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104401325
--- Diff:
flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java
---
@@ -0,0 +1,63
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104394065
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
---
@@ -0,0 +1,166
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104371759
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,7 +92,12 @@ under the License
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104343965
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala
---
@@ -68,6 +62,90 @@ object CommonTestData
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104343679
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala
---
@@ -68,6 +62,90 @@ object CommonTestData
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104340593
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala
---
@@ -0,0 +1,166
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3406#discussion_r104333889
--- Diff: flink-libraries/flink-table/pom.xml ---
@@ -92,7 +92,12 @@ under the License
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3409
[flink-5570] [Table API & SQL]Support register external catalog to table
environment
This pr aims to support register external catalog to TableEnvironment.
The pr contains two commits,
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3406
[flink-5568] [Table API & SQL]Introduce interface for catalog, and provide
an in-memory implementation. Integrate external catalog with calcite catalog
This pr aims to introduce interface
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3197
@fhueske , thanks for your review. I already modify code based on your
advice and rebase the pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/3196
@fhueske , thanks for your review. I modify code based on your advice,
including compatibility with Java and column stats field type.
---
If your project is set up for it, you can reply to this
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3196#discussion_r100958745
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3196#discussion_r100951579
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3196#discussion_r100950729
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2791
@tillrohrmann , thanks your reply. However my partner @wangzhijiang999 had
a different implementation on this jira before, he will open a new pr soon. So
I would close this pr. Sorry for wasting
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2791
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3197
[FLINK-5567] [Table API & SQL]Introduce and migrate current table
statistics to FlinkStatistics
This pr includes two commits, the first commit is Related to
[https://github.com/apache/f
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3196
[FLINK-5566] [Table API & SQL]Introduce structure to hold table and column
level statistics
This pr aims to introduce structure to hold table and column level
statistics.
TableSt
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3058#discussion_r96112195
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSort.scala
---
@@ -71,6 +72,21 @@ class DataSetSort
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3058#discussion_r95967156
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetSort.scala
---
@@ -71,6 +72,21 @@ class DataSetSort
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/3058
[FLINK-5394] [Table API & SQL]the estimateRowCount method of DataSetCalc
didn't work
This pr aims to fix a bug which is referenced by
https://issues.apache.org/jira/browse/FLINK-5394
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2923
@fhueske , thanks for your review, I already modify code based on your
advices.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2923#discussion_r91847990
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/batch/ProjectableTableSourceITCase.scala
---
@@ -0,0 +1,154
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2923#discussion_r91847985
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/table/plan/rules/util/RexProgramProjectExtractorTest.scala
---
@@ -0,0 +1,121
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2926#discussion_r91455098
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/DataSetCalc.scala
---
@@ -73,7 +75,11 @@ class
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2923#discussion_r91429660
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchScan.scala
---
@@ -45,7 +45,8 @@ abstract class
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2923
@fhueske , thanks for your review. I have already modified the pr based on
your advice, including following main changes:
1. Adapt the cost model for the BatchTableSourceScan
2. Modify
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2923
[FLINK-5220] [Table API & SQL] Flink SQL projection pushdown
This pr aims to do projection pushdown optimization.
There are two commits here, first one is linked to
[h
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2921#discussion_r90577312
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/dataset/BatchTableSourceScan.scala
---
@@ -32,18 +31,20
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2921
[FLINK-5185] [Table API & SQL] Decouple BatchTableSourceScan with
TableSourceTable
The pr aims to decouple BatchTableSourceScan with TableSourceTable for
further optimization, e.g, projec
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2791
[FLINK-4449] [cluster management] add Heartbeat manager in ResourceManager
with TaskExecutor
This pr aims to add Heartbeat manager in ResourceManager with TaskExecutor.
This pr focused on
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2571
@mxm, What would happen under following cases: taskExecutor releases a
registered slot, then taskExecutor reports its latest slotReport to
ResourceManager, ResourceManager should remove the old
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2540
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2543
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2540#discussion_r80836325
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -324,6 +337,158 @@ public void handleError
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2540
@mxm , thanks for your review, I modified the pr based on your advices:
1. fIx checkstyle error, `AkkaRpcActorTest` testcase and
`RpcCompletenessTest` testcase. Sorry for those mistakes, I
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2540#discussion_r80612002
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -66,15 +67,16 @@
* {@link
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2524
@mxm , thanks for your review. I modified the content based on your advice:
1. The changes could compile successfully now, sorry for the level mistake.
2. AwaitJobResult method in
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2543
Hi, till. Thanks for your review.
First sorry to bind to the wrong jira link, already correct it.
About heartbeatManager, i thought we could separate HeartbeatManager into
two part, each
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2543
[FLINK-4606] [cluster management] Add watch mechanism on current RPC
framework
This pr aims at adding watch mechanism on current RPC framework, so RPC
gateway could be watched to make sure the
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2540
[FLINK-4606] [Client] Integrate the new ResourceManager with the existed
FlinkResourceManager
This pr aims to integrate the new ResourceManager with the existed
FlinkResourceManager, the main
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2455
@tillrohrmann , I rebase the PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2451
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2479
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2524
@mxm , I rebase the PR already. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2524
[FLINK-4653] [Client] Refactor JobClientActor to adapt to new Rpc framework
and new cluster managerment
There are following main changes:
1. Create a RpcEndpoint(temporary named
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77943543
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
---
@@ -52,15 +58,28 @@
*
*/
public
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2479
[FLINK-4537] [cluster management] ResourceManager registration with
JobManager
This pull request is to implement ResourceManager registration with
JobManager, which including:
1. Check
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2455
@tillrohrmann @StephanEwen , thanks for your review. I changed the code
based on your comment, including two points:
1. Change the JIRA and the PR subject line to better reflect the actual
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77769044
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -89,32 +93,37 @@ public SlotManager
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2463#discussion_r77768256
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManager.java
---
@@ -89,32 +93,37 @@ public SlotManager
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2451
@tillrohrmann , thanks for your review. I changed the pr based on your
advice, including ï¼
1. Modify UnmatchedLeaderSessionIDException to LeaderSessionIDException,
format code style and
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2451#discussion_r77757943
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/resourcemanager/ResourceManager.java
---
@@ -138,22 +150,46 @@ public SlotAssignment
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2455#discussion_r77754084
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
---
@@ -189,7 +191,49 @@ public void stop
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2455#discussion_r77753174
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java
---
@@ -189,7 +191,49 @@ public void stop
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2455
[FLINK-4547] [cluster management] Return same object when call connect
method in AkkaRpcService using same address and same rpc gateway class
The pull request is to add equals and hashCode
GitHub user beyond1920 opened a pull request:
https://github.com/apache/flink/pull/2451
[FLINK-4535] [cluster management] resourceManager process the registration
from TaskExecutor
This pull request is to implement ResourceManager registration with
TaskExecutor, which including
Github user beyond1920 closed the pull request at:
https://github.com/apache/flink/pull/2427
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2427
Hi @mxm , thanks so much. I already close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user beyond1920 commented on the issue:
https://github.com/apache/flink/pull/2427
@mxm , Thanks for your review. And I change the ResourceManagerHATest to
use a mocked RpcService instead of TestingSerialRpcService.
---
If your project is set up for it, you can reply to this
Github user beyond1920 commented on a diff in the pull request:
https://github.com/apache/flink/pull/2435#discussion_r76938462
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatListener.java
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the
1 - 100 of 136 matches
Mail list logo
