Re: [PR] [FLINK-37120][minor] Rename ending chunk to unbounded chunk [flink-cdc]

2025-03-05 Thread via GitHub
leonardBang merged PR #3938: URL: https://github.com/apache/flink-cdc/pull/3938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-37120][minor] Rename ending chunk to unbounded chunk [flink-cdc]

2025-03-05 Thread via GitHub
beryllw commented on PR #3938: URL: https://github.com/apache/flink-cdc/pull/3938#issuecomment-2703016890 Thanks for the naming correction. LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [BP-2.0][FLINK-37367][state/forst] Make ForSt inherit uploaded SST files after restorations. [flink]

2025-03-05 Thread via GitHub
flinkbot commented on PR #26259: URL: https://github.com/apache/flink/pull/26259#issuecomment-2702951750 ## CI report: * 8c14ab729c846a53f28972d6e295ba401b22e586 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-2.0][FLINK-37367][state/forst] Make ForSt inherit uploaded SST files after restorations. [flink]

2025-03-05 Thread via GitHub
AlexYinHan opened a new pull request, #26259: URL: https://github.com/apache/flink/pull/26259 ## What is the purpose of the change To fix the bug that ForSt does not inherit uploaded SST files from restored checkpoints. ## Brief change log - Register mate

Re: [PR] [FLINK-33525] Move ImpulseSource to new Source API [flink-kubernetes-operator]

2025-03-05 Thread via GitHub
Poorvankbhatia commented on code in PR #950: URL: https://github.com/apache/flink-kubernetes-operator/pull/950#discussion_r1982742633 ## examples/autoscaling/src/main/java/autoscaling/LoadSimulationPipeline.java: ## @@ -74,8 +78,38 @@ public static void main(String[] args) thro

Re: [PR] [FLINK-37408] Update all docker-compose references to docker compose [flink]

2025-03-05 Thread via GitHub
nilmadhab commented on code in PR #26239: URL: https://github.com/apache/flink/pull/26239#discussion_r1982215113 ## .github/workflows/template.flink-ci.yml: ## @@ -316,7 +316,7 @@ jobs: maven_repo_folder: ${{ env.MAVEN_REPO_FOLDER }} - name: "Install missing

Re: [PR] [FLINK-37383][flink-examples]Correct throttling logic on ThrottledIterator [flink]

2025-03-05 Thread via GitHub
rafaelzimmermann commented on PR #26203: URL: https://github.com/apache/flink/pull/26203#issuecomment-2702847195 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [FLINK-37120][minor] Rename ending chunk to bounded chunk [flink-cdc]

2025-03-05 Thread via GitHub
leonardBang commented on PR #3938: URL: https://github.com/apache/flink-cdc/pull/3938#issuecomment-2702760761 @beryllw Would you like to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [FLINK-37367][state/forst] Make ForSt inherit uploaded SST files after restorations. [flink]

2025-03-05 Thread via GitHub
Zakelly commented on PR #26202: URL: https://github.com/apache/flink/pull/26202#issuecomment-2702768008 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [FLINK-37120][minor] Rename ending chunk to bounded chunk [flink-cdc]

2025-03-05 Thread via GitHub
leonardBang opened a new pull request, #3938: URL: https://github.com/apache/flink-cdc/pull/3938 Minor improvements for FLINK-37120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Resolved] (FLINK-37424) Using JDK11 for the binary convenience release

2025-03-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-37424. Resolution: Fixed master(2.1) via 0a30a65c1a0e4c5da5acfe9bca57922a1597d84c. release-2.0 via 7da4a

Re: [PR] Bump io.netty:netty-common from 4.1.46.Final to 4.1.118.Final in /flink-end-to-end-tests/flink-end-to-end-tests-hive [flink]

2025-03-05 Thread via GitHub
dependabot[bot] commented on PR #26158: URL: https://github.com/apache/flink/pull/26158#issuecomment-2702737038 Dependabot couldn't find a pom.xml. Because of this, Dependabot cannot update this pull request. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [FLINK-37424][release] Using JDK11 for the binary convenience release [flink]

2025-03-05 Thread via GitHub
reswqa merged PR #26251: URL: https://github.com/apache/flink/pull/26251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

Re: [PR] [FLINK-37424][release] Using JDK11 for the binary convenience release [flink]

2025-03-05 Thread via GitHub
reswqa commented on PR #26251: URL: https://github.com/apache/flink/pull/26251#issuecomment-2702723094 Update: I personally confirmed with Xintong(one of the 2.0 RMs) that this PR can be merged now. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] [FLINK-37427] Fix incorrect NPE message in StandaloneHaServices constructor [flink]

2025-03-05 Thread via GitHub
flinkbot commented on PR #26258: URL: https://github.com/apache/flink/pull/26258#issuecomment-2702648761 ## CI report: * 99d4355af7e0b8fd48247d0206c86e04fc150965 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
Zakelly commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1982638373 ## docs/layouts/shortcodes/generated/forst_configuration.html: ## @@ -30,7 +30,7 @@ state.backend.forst.cache.reserve-size 256 mb

[jira] [Commented] (FLINK-37312) Missing closing tab in state_v2.md

2025-03-05 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932813#comment-17932813 ] Zakelly Lan commented on FLINK-37312: - 7722f00 on 2.0 > Missing closing tab in stat

[jira] [Updated] (FLINK-37312) Missing closing tab in state_v2.md

2025-03-05 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-37312: Fix Version/s: 2.0.0 (was: 2.1.0) > Missing closing tab in state_v2.md > --

Re: [PR] [BP-2.0][docs] backports two fixes about documentation [flink]

2025-03-05 Thread via GitHub
Zakelly merged PR #26256: URL: https://github.com/apache/flink/pull/26256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [hotfix][docs] Fix label format in docs for state v2 [flink]

2025-03-05 Thread via GitHub
Zakelly merged PR #26255: URL: https://github.com/apache/flink/pull/26255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
Zakelly commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1982613914 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -126,22 +126,35 @@ public static FileBas

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
Zakelly commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1982610524 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStOptions.java: ## @@ -102,6 +102,9 @@ public class ForStOptions {

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
Zakelly commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1982603327 ## docs/layouts/shortcodes/generated/forst_configuration.html: ## @@ -30,7 +30,7 @@ state.backend.forst.cache.reserve-size 256 mb

[jira] [Updated] (FLINK-37427) incorrect NPE message in StandaloneHaServices constructor

2025-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37427: --- Labels: easyfix pull-request-available (was: easyfix) > incorrect NPE message in Standalone

[PR] [FLINK-37427] Fix incorrect NPE message in StandaloneHaServices constructor [flink]

2025-03-05 Thread via GitHub
lurongjiang opened a new pull request, #26258: URL: https://github.com/apache/flink/pull/26258 ## What is the purpose of the change developers receive unhelpful error messages when parameters are null. ## Brief change log Replace checkNotNull(clusterRe

Re: [PR] [hotfix][docs] URL for test-filesystem is wrong in materialized table… [flink]

2025-03-05 Thread via GitHub
libenchao merged PR #26252: URL: https://github.com/apache/flink/pull/26252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Updated] (FLINK-37427) incorrect NPE message in StandaloneHaServices constructor

2025-03-05 Thread LuJiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LuJiang updated FLINK-37427: Description: The constructor of org.apache.flink.runtime.highavailability.nonha.standalone.StandaloneHaSe

[jira] [Updated] (FLINK-37427) incorrect NPE message in StandaloneHaServices constructor

2025-03-05 Thread LuJiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] LuJiang updated FLINK-37427: Description: The constructor of org.apache.flink.runtime.highavailability.nonha.standalone.StandaloneHaSe

[jira] [Created] (FLINK-37427) incorrect NPE message in StandaloneHaServices constructor

2025-03-05 Thread LuJiang (Jira)
LuJiang created FLINK-37427: --- Summary: incorrect NPE message in StandaloneHaServices constructor Key: FLINK-37427 URL: https://issues.apache.org/jira/browse/FLINK-37427 Project: Flink Issue Type: I

[jira] [Updated] (FLINK-37243) Ensure that async callback processing happen on known thread

2025-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37243: --- Labels: pull-request-available (was: ) > Ensure that async callback processing happen on kn

Re: [PR] [FLINK-37243] Adds main thread callback to AsyncWaitOperator [flink]

2025-03-05 Thread via GitHub
bideyio commented on code in PR #26122: URL: https://github.com/apache/flink/pull/26122#discussion_r1982429509 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncWaitOperatorTest.java: ## @@ -1321,6 +1327,123 @@ private void testProcessing

Re: [PR] [FLINK-37120][cdc-connector] Add ending split chunk first to avoid TaskManager oom [flink-cdc]

2025-03-05 Thread via GitHub
beryllw commented on PR #3856: URL: https://github.com/apache/flink-cdc/pull/3856#issuecomment-2702484596 > Rebase this PR to master to obtain fixed patches, let's see what happens next @beryllw Sorry, I've been too busy to check earlier. Thanks for your help. -- This is an automat

Re: [PR] [FLINK-37244] mention scylladb in docs [flink-connector-cassandra]

2025-03-05 Thread via GitHub
mkorolyov commented on PR #32: URL: https://github.com/apache/flink-connector-cassandra/pull/32#issuecomment-2702308947 @dannycranmer Hey, could you pls take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [hotfix] make previousCpuTicks and previousProcCpuTicks volatile to increase visibility for all threads [flink]

2025-03-05 Thread via GitHub
flinkbot commented on PR #26257: URL: https://github.com/apache/flink/pull/26257#issuecomment-2702193762 ## CI report: * 529badb7740a3165f7e1648df67e97d292f9ea91 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix] make previousCpuTicks and previousProcCpuTicks volatile to increase visibility for all threads [flink]

2025-03-05 Thread via GitHub
bjornarjatten opened a new pull request, #26257: URL: https://github.com/apache/flink/pull/26257 ## What is the purpose of the change This pull request fixes a visibility issue in the `SystemResourcesCounter `class by marking `previousCpuTicks `and `previousProcCpuTicks `as volatile.

Re: [PR] [FLINK-37408] Update all docker-compose references to docker compose [flink]

2025-03-05 Thread via GitHub
nilmadhab commented on code in PR #26239: URL: https://github.com/apache/flink/pull/26239#discussion_r1982215113 ## .github/workflows/template.flink-ci.yml: ## @@ -316,7 +316,7 @@ jobs: maven_repo_folder: ${{ env.MAVEN_REPO_FOLDER }} - name: "Install missing

Re: [PR] [FLINK-37408] Update all docker-compose references to docker compose [flink]

2025-03-05 Thread via GitHub
nilmadhab commented on code in PR #26239: URL: https://github.com/apache/flink/pull/26239#discussion_r1982215113 ## .github/workflows/template.flink-ci.yml: ## @@ -316,7 +316,7 @@ jobs: maven_repo_folder: ${{ env.MAVEN_REPO_FOLDER }} - name: "Install missing

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-03-05 Thread via GitHub
lihaosky commented on code in PR #25834: URL: https://github.com/apache/flink/pull/25834#discussion_r1981920664 ## tools/maven/suppressions.xml: ## @@ -40,6 +40,7 @@ under the License. + Review Comment: Added

Re: [PR] [FLINK-37408] Update all docker-compose references to docker compose [flink]

2025-03-05 Thread via GitHub
davidradl commented on code in PR #26239: URL: https://github.com/apache/flink/pull/26239#discussion_r1981880531 ## .github/workflows/template.flink-ci.yml: ## @@ -316,7 +316,7 @@ jobs: maven_repo_folder: ${{ env.MAVEN_REPO_FOLDER }} - name: "Install missing

Re: [PR] [FLINK-37408] Update all docker-compose references to docker compose [flink]

2025-03-05 Thread via GitHub
davidradl commented on code in PR #26239: URL: https://github.com/apache/flink/pull/26239#discussion_r1981875197 ## docs/content/docs/try-flink/flink-operations-playground.md: ## @@ -89,7 +89,7 @@ output of the Flink job should show 1000 views per page and window. The playgrou

Re: [PR] [FLINK-37408] Update all docker-compose references to docker compose [flink]

2025-03-05 Thread via GitHub
davidradl commented on code in PR #26239: URL: https://github.com/apache/flink/pull/26239#discussion_r1981872179 ## docs/content.zh/docs/try-flink/flink-operations-playground.md: ## @@ -83,7 +83,7 @@ Job 监控以及资源管理。Flink TaskManager 运行 worker 进程, 环境搭建只需要几步就可以完成,我们将会带你过一遍必要的操作命令,

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
davidradl commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1981863315 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -126,22 +126,35 @@ public static FileB

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-03-05 Thread via GitHub
lihaosky commented on code in PR #25834: URL: https://github.com/apache/flink/pull/25834#discussion_r1981858877 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlAlterModelResetConverter.java: ## @@ -0,0 +1,82 @@ +/* + * Lic

[PR] [BP-2.0][docs] backports two fixes about documentation [flink]

2025-03-05 Thread via GitHub
Zakelly opened a new pull request, #26256: URL: https://github.com/apache/flink/pull/26256 Backporting #20195 and #26255 to 2.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
davidradl commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1981848270 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStOptions.java: ## @@ -102,6 +102,9 @@ public class ForStOptions {

Re: [PR] [FLINK-37367][state/forst] Make ForSt inherit uploaded SST files after restorations. [flink]

2025-03-05 Thread via GitHub
AlexYinHan commented on code in PR #26202: URL: https://github.com/apache/flink/pull/26202#discussion_r1981370846 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStKeyedStateBackendBuilder.java: ## @@ -259,10 +259,14 @@ public ForSt

Re: [PR] [FLINK-36630][Connectors/Kafka] Wrap consumer.position in retryOnWakeup [flink-connector-kafka]

2025-03-05 Thread via GitHub
trompa commented on PR #133: URL: https://github.com/apache/flink-connector-kafka/pull/133#issuecomment-2701583837 done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
davidradl commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1981844268 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStOptions.java: ## @@ -102,6 +102,9 @@ public class ForStOptions {

Re: [PR] [FLINK-36630][Connectors/Kafka] Wrap consumer.position in retryOnWakeup [flink-connector-kafka]

2025-03-05 Thread via GitHub
trompa commented on code in PR #133: URL: https://github.com/apache/flink-connector-kafka/pull/133#discussion_r1981846925 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java: ## @@ -279,6 +279,10 @@ void setConsum

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
davidradl commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1981839842 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -126,22 +126,35 @@ public static FileB

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
davidradl commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1981836587 ## docs/layouts/shortcodes/generated/forst_configuration.html: ## @@ -30,7 +30,7 @@ state.backend.forst.cache.reserve-size 256 mb

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
davidradl commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1981836587 ## docs/layouts/shortcodes/generated/forst_configuration.html: ## @@ -30,7 +30,7 @@ state.backend.forst.cache.reserve-size 256 mb

Re: [PR] [FLINK-36630][Connectors/Kafka] Wrap consumer.position in retryOnWakeup [flink-connector-kafka]

2025-03-05 Thread via GitHub
trompa commented on PR #133: URL: https://github.com/apache/flink-connector-kafka/pull/133#issuecomment-2701569509 fine for me -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [BP-2.0][docs] backports two fixes about documentation [flink]

2025-03-05 Thread via GitHub
flinkbot commented on PR #26256: URL: https://github.com/apache/flink/pull/26256#issuecomment-2701526823 ## CI report: * ea4c59f257d0f73fbf362840c4d45c75913e8c33 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][docs] Fix label format in docs for state v2 [flink]

2025-03-05 Thread via GitHub
flinkbot commented on PR #26255: URL: https://github.com/apache/flink/pull/26255#issuecomment-2701526462 ## CI report: * 86987774dc00a6c1fc6ed8d7add53c0a93c6cf0f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][docs] Fix label format in docs for state v2 [flink]

2025-03-05 Thread via GitHub
Zakelly opened a new pull request, #26255: URL: https://github.com/apache/flink/pull/26255 ## What is the purpose of the change Some of the labels in docs are broken, this PR fixes that. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] FLINK-37179 - remove priority: 0 from CRDs [flink-kubernetes-operator]

2025-03-05 Thread via GitHub
luismacosta commented on PR #940: URL: https://github.com/apache/flink-kubernetes-operator/pull/940#issuecomment-2701436908 There is an issue raised with argo-cd https://github.com/argoproj/argo-cd/issues/3889 I will close this PR Thanks -- This is an automated message from the Apa

Re: [PR] FLINK-37179 - remove priority: 0 from CRDs [flink-kubernetes-operator]

2025-03-05 Thread via GitHub
luismacosta closed pull request #940: FLINK-37179 - remove priority: 0 from CRDs URL: https://github.com/apache/flink-kubernetes-operator/pull/940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
Zakelly commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1981704626 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -126,22 +126,35 @@ public static FileBas

Re: [PR] [FLINK-37424][release] Using JDK11 for the binary convenience release [flink]

2025-03-05 Thread via GitHub
reswqa commented on PR #26251: URL: https://github.com/apache/flink/pull/26251#issuecomment-2700323625 cc @snuyanzin, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[jira] [Created] (FLINK-37426) FLIP-481: Introduce Event Reporting

2025-03-05 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-37426: -- Summary: FLIP-481: Introduce Event Reporting Key: FLINK-37426 URL: https://issues.apache.org/jira/browse/FLINK-37426 Project: Flink Issue Type: Improveme

Re: [PR] [FLINK-30371] Fix the problem of JdbcOutputFormat database connection leak [flink-connector-jdbc]

2025-03-05 Thread via GitHub
fapaul commented on PR #75: URL: https://github.com/apache/flink-connector-jdbc/pull/75#issuecomment-2701194740 Sorry my previous message wasn't well-formatted (fixed now). The try-catch block around the `closeStatement` is ok, but I'd not touch the flush method. -- This is an automated

Re: [PR] [FLINK-36630][Connectors/Kafka] Wrap consumer.position in retryOnWakeup [flink-connector-kafka]

2025-03-05 Thread via GitHub
fapaul commented on PR #133: URL: https://github.com/apache/flink-connector-kafka/pull/133#issuecomment-2701264799 Good catch. This also shows that the existing test with the retry loop is more or less flaky due to your discovered issue. With all that in mind, I am tending to remove all th

Re: [PR] [FLINK-16080][docs-zh] Translate new DISTRIBUTED BY documentation into Chinese [flink]

2025-03-05 Thread via GitHub
jnh5y commented on code in PR #26196: URL: https://github.com/apache/flink/pull/26196#discussion_r1981625211 ## docs/content/docs/dev/table/sql/create.md: ## @@ -502,7 +502,7 @@ You can control the merging behavior of: * GENERATED - computed columns * METADATA - metadata colum

[jira] [Resolved] (FLINK-37364) Bump Flink 1.19, 1.20 patch versions in Flink CDC

2025-03-05 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-37364. Resolution: Fixed Resolved via master: 617955d269567075aff9174e7029356ea3dc7088 > Bump Flink 1.19

Re: [PR] [FLINK-33525] Move ImpulseSource to new Source API [flink-kubernetes-operator]

2025-03-05 Thread via GitHub
afedulov commented on code in PR #950: URL: https://github.com/apache/flink-kubernetes-operator/pull/950#discussion_r1981589005 ## examples/autoscaling/src/main/java/autoscaling/LoadSimulationPipeline.java: ## @@ -74,8 +78,38 @@ public static void main(String[] args) throws Exc

Re: [PR] [FLINK-37364][build] Bump Flink 1.19 and 1.20 patch versions [flink-cdc]

2025-03-05 Thread via GitHub
leonardBang merged PR #3927: URL: https://github.com/apache/flink-cdc/pull/3927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-33525] Move ImpulseSource to new Source API [flink-kubernetes-operator]

2025-03-05 Thread via GitHub
afedulov commented on code in PR #950: URL: https://github.com/apache/flink-kubernetes-operator/pull/950#discussion_r1981589005 ## examples/autoscaling/src/main/java/autoscaling/LoadSimulationPipeline.java: ## @@ -74,8 +78,38 @@ public static void main(String[] args) throws Exc

Re: [PR] [FLINK-37364][build] Bump Flink 1.19 and 1.20 patch versions [flink-cdc]

2025-03-05 Thread via GitHub
leonardBang commented on PR #3927: URL: https://github.com/apache/flink-cdc/pull/3927#issuecomment-2701212576 All CI green, nice, merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Resolved] (FLINK-37120) MySqlSnapshotSplitAssigner assign the ending chunk early to avoid TaskManager OOM

2025-03-05 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-37120. Resolution: Fixed Fixed via master: 2c699860aa88c33a971b8c855904bfbe679f3a69 > MySqlSnapshotSplit

[jira] [Updated] (FLINK-37120) MySqlSnapshotSplitAssigner assign the ending chunk early to avoid TaskManager OOM

2025-03-05 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-37120: --- Fix Version/s: cdc-3.4.0 > MySqlSnapshotSplitAssigner assign the ending chunk early to avoid TaskMan

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
fredia commented on code in PR #26253: URL: https://github.com/apache/flink/pull/26253#discussion_r1981501160 ## flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java: ## @@ -126,22 +126,35 @@ public static FileBase

Re: [PR] [FLINK-37120][cdc-connector] Add ending split chunk first to avoid TaskManager oom [flink-cdc]

2025-03-05 Thread via GitHub
leonardBang merged PR #3856: URL: https://github.com/apache/flink-cdc/pull/3856 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

Re: [PR] [FLINK-37120][cdc-connector] Add ending split chunk first to avoid TaskManager oom [flink-cdc]

2025-03-05 Thread via GitHub
leonardBang commented on PR #3856: URL: https://github.com/apache/flink-cdc/pull/3856#issuecomment-2701108728 CI passed, merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Updated] (FLINK-37365) Add API stability annotations (@Experimental, @PublicEvolving) to PyFlink APIs

2025-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37365: --- Labels: pull-request-available (was: ) > Add API stability annotations (@Experimental, @Pub

Re: [PR] [FLINK-37424][release] Using JDK11 for the binary convenience release [flink]

2025-03-05 Thread via GitHub
snuyanzin commented on PR #26251: URL: https://github.com/apache/flink/pull/26251#issuecomment-2700333542 I'm ok with the changes however I guess the final decision about this should be taken by current release managers -- This is an automated message from the Apache Git Service. To re

Re: [PR] [FLINK-16080][docs-zh] Translate new DISTRIBUTED BY documentation into Chinese [flink]

2025-03-05 Thread via GitHub
JinkunLiu commented on code in PR #26196: URL: https://github.com/apache/flink/pull/26196#discussion_r1981466318 ## docs/content/docs/dev/table/sql/create.md: ## @@ -502,7 +502,7 @@ You can control the merging behavior of: * GENERATED - computed columns * METADATA - metadata c

[jira] [Created] (FLINK-37425) Sanity check before ForSt cache created

2025-03-05 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-37425: --- Summary: Sanity check before ForSt cache created Key: FLINK-37425 URL: https://issues.apache.org/jira/browse/FLINK-37425 Project: Flink Issue Type: Bug Aff

Re: [PR] [BP-2.0][FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
flinkbot commented on PR #26254: URL: https://github.com/apache/flink/pull/26254#issuecomment-2701010351 ## CI report: * 0e7202a2e01c7262d42d29e2d5e92fc52e915b1e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter … [flink]

2025-03-05 Thread via GitHub
gyfora commented on PR #25896: URL: https://github.com/apache/flink/pull/25896#issuecomment-2701004982 > Wow, I'm excited this actually got merged! Thanks for pushing this over the finish line @gyfora ! Thanks for all the work @kurtostfeld :) -- This is an automated message from t

Re: [PR] [FLINK-36630][Connectors/Kafka] Wrap consumer.position in retryOnWakeup [flink-connector-kafka]

2025-03-05 Thread via GitHub
trompa commented on PR #133: URL: https://github.com/apache/flink-connector-kafka/pull/133#issuecomment-2701005587 Added the wakeUp loop on my tests: ``` while (t.isAlive() && System.currentTimeMillis() < deadline) { reader.wakeUp(); Thread.sleep(10);

[jira] [Commented] (FLINK-37420) AbstractAggregatingState add may return wrong result

2025-03-05 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932609#comment-17932609 ] Zakelly Lan commented on FLINK-37420: - Master: 141363f0 2.0: in progress > Abstrac

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-05 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1981408324 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumeratorStateSerializerTest.java: ## @@ -0,0 +1,101 @@

Re: [PR] [FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter … [flink]

2025-03-05 Thread via GitHub
kurtostfeld commented on PR #25896: URL: https://github.com/apache/flink/pull/25896#issuecomment-2700975594 Wow, I'm excited this actually got merged! Thanks for pushing this over the finish line @gyfora ! -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
flinkbot commented on PR #26253: URL: https://github.com/apache/flink/pull/26253#issuecomment-2700959923 ## CI report: * cd8680dce4b29115d5cecd0984e4d41868fc02c3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-05 Thread via GitHub
ferenc-csaky commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1980100133 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumeratorStateSerializerTest.java: ## @@ -0,0 +1,101 @@

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-05 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1981409990 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumeratorStateSerializerTest.java: ## @@ -0,0 +1,101 @@

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-05 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1981405621 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/enumerator/KuduSourceEnumeratorStateSerializerTest.java: ## @@ -0,0 +1,101 @@

[PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
Zakelly opened a new pull request, #26254: URL: https://github.com/apache/flink/pull/26254 ## What is the purpose of the change There is a chance that the space based cache limit policy in ForStStateBackend could not work on the specified cache path, resulting in the whole cache fail

Re: [PR] [FLINK-36855] Source API implementation [flink-connector-kudu]

2025-03-05 Thread via GitHub
martongreber commented on code in PR #8: URL: https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1981397597 ## flink-connector-kudu/src/test/java/org/apache/flink/connector/kudu/source/KuduSourceITCase.java: ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Sof

[jira] [Updated] (FLINK-37425) Sanity check before ForSt cache created

2025-03-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37425: --- Labels: pull-request-available (was: ) > Sanity check before ForSt cache created >

[PR] [FLINK-37425] Sanity check before ForSt cache created [flink]

2025-03-05 Thread via GitHub
Zakelly opened a new pull request, #26253: URL: https://github.com/apache/flink/pull/26253 ## What is the purpose of the change There is a chance that the space based cache limit policy in ForStStateBackend could not work on the specified cache path, resulting in the whole cache fail

Re: [PR] [hotfix][tests] Fix MySQL test case failure in exact UTC timezone [flink-cdc]

2025-03-05 Thread via GitHub
leonardBang commented on PR #3936: URL: https://github.com/apache/flink-cdc/pull/3936#issuecomment-2700672796 CI passed finally, merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] [hotfix][docs] URL for test-filesystem is wrong in materialized table… [flink]

2025-03-05 Thread via GitHub
flinkbot commented on PR #26252: URL: https://github.com/apache/flink/pull/26252#issuecomment-2700848143 ## CI report: * d2a210ca35d14afc0bcd04b6cd11f6acdbad084f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37420] fix AbstractAggregatingState add may return wrong result [flink]

2025-03-05 Thread via GitHub
Zakelly merged PR #26246: URL: https://github.com/apache/flink/pull/26246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-37364][build] Bump Flink 1.19 and 1.20 patch versions [flink-cdc]

2025-03-05 Thread via GitHub
leonardBang commented on PR #3927: URL: https://github.com/apache/flink-cdc/pull/3927#issuecomment-2700804177 Try to fix failed issue via rebasing this PR to latest master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] [hotfix][docs] URL for test-filesystem is wrong in materialized table… [flink]

2025-03-05 Thread via GitHub
libenchao opened a new pull request, #26252: URL: https://github.com/apache/flink/pull/26252 … quickstart ## What is the purpose of the change Fix wrong link in materialized table quickstart document. ## Brief change log ## Verifying this change

Re: [PR] [FLINK-37120][cdc-connector] Add ending split chunk first to avoid TaskManager oom [flink-cdc]

2025-03-05 Thread via GitHub
leonardBang commented on PR #3856: URL: https://github.com/apache/flink-cdc/pull/3856#issuecomment-2700772302 Rebase this PR to master to obtain fixed patches, let's see what happens next @beryllw -- This is an automated message from the Apache Git Service. To respond to the message, ple

[jira] [Updated] (FLINK-36960) FLIP-467 Introduce Generalized Watermarks for DataStream V2

2025-03-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-36960: --- Parent: FLINK-34547 Issue Type: Sub-task (was: New Feature) > FLIP-467 Introduce Generalize

[jira] [Updated] (FLINK-37112) FLIP-499: Support Event Time by Generalized Watermark in DataStream V2

2025-03-05 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-37112: --- Parent: FLINK-34547 Issue Type: Sub-task (was: New Feature) > FLIP-499: Support Event Time

  1   2   >