Zakelly commented on code in PR #26253:
URL: https://github.com/apache/flink/pull/26253#discussion_r1982610524


##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/ForStOptions.java:
##########
@@ -102,6 +102,9 @@ public class ForStOptions {
                                                     + "the cache will reserve 
the specified size of disk space. "
                                                     + "This option and the 
'%s' option can be set simultaneously, the "
                                                     + "smaller cache limit 
will be used as the upper limit. "
+                                                    + "If the specified file 
system of cache directory does not support "
+                                                    + "reading the remaining 
space, the cache will not be able to reserve "
+                                                    + "the specified space. 
Thus this option will be ignored. "

Review Comment:
   We have provided a default value for this options (meaning we enable the 
cache but do not overuse the disk) for out-of-the-box experience.  An thrown 
exception will affect the user experience.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to