[jira] [Created] (FLINK-37332) Support any columns as chunk key column (postgres, orcale, db2, sqlserver)

2025-02-15 Thread Lee SeungMin (Jira)
Lee SeungMin created FLINK-37332: Summary: Support any columns as chunk key column (postgres, orcale, db2, sqlserver) Key: FLINK-37332 URL: https://issues.apache.org/jira/browse/FLINK-37332 Project: F

Re: [PR] [FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter … [flink]

2025-02-15 Thread via GitHub
kurtostfeld commented on PR #25896: URL: https://github.com/apache/flink/pull/25896#issuecomment-2661248821 @nicknezis The project organizers are choosing not to respond to this. I believe their strategy is to phase Kryo out and use their own serialization code instead of upgrading Kryo.

Re: [PR] [FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter … [flink]

2025-02-15 Thread via GitHub
nicknezis commented on PR #25896: URL: https://github.com/apache/flink/pull/25896#issuecomment-2661216618 > @kurtostfeld I see your motivation for doing this, but you mention that there will not be binary compatibility with v1 state. Do you have an idea on how v1 Kyro state would migrate to

Re: [PR] [FLINK-37328][FileSystems] Upgrade GCS connector to 2.2.26. [flink]

2025-02-15 Thread via GitHub
cnauroth commented on PR #26160: URL: https://github.com/apache/flink/pull/26160#issuecomment-2661055672 It looks like the CI failure is an unrelated test failure in `TableSinkITCase#testSinkDisorderChangeLogWithRank`. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] [FLINK-36086] [Sqlserver] Fix Sqlserver restart during one transaction [flink-cdc]

2025-02-15 Thread via GitHub
morozov commented on code in PR #3873: URL: https://github.com/apache/flink-cdc/pull/3873#discussion_r1957042775 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-sqlserver-cdc/src/test/java/org/apache/flink/cdc/connectors/sqlserver/source/reader/SqlserverSourceReaderTest

[PR] [FLINK-36429] [runtime-web] Enhancing Flink History Server File Storage and Retrieval with RocksDB [flink]

2025-02-15 Thread via GitHub
Shawnsuun opened a new pull request, #25838: URL: https://github.com/apache/flink/pull/25838 ## What is the purpose of the change Currently, when a Flink job finishes, it writes an archive as a single file that maps paths to JSON files. Flink History Server (FHS) job archives

Re: [PR] [FLINK-36429] [runtime-web] Enhancing Flink History Server File Storage and Retrieval with RocksDB [flink]

2025-02-15 Thread via GitHub
Shawnsuun closed pull request #25838: [FLINK-36429] [runtime-web] Enhancing Flink History Server File Storage and Retrieval with RocksDB URL: https://github.com/apache/flink/pull/25838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on PR #26113: URL: https://github.com/apache/flink/pull/26113#issuecomment-2660949807 Hey @twalthr, thanks for the review! I've addressed all the points. An important shout is that I'll definitely be looking into using semantic tests for future changes. Curr

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957126571 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/UnnestITCase.scala: ## @@ -379,4 +380,486 @@ class UnnestITC

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957126499 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/UnnestRowsFunctionBase.java: ## @@ -0,0 +1,211 @@ +/* + * Licens

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957126373 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/UnnestITCase.scala: ## @@ -315,4 +315,279 @@ class UnnestITCa

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957125379 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/UnnestITCase.scala: ## @@ -379,4 +380,486 @@ class UnnestITC

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957097592 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/UnnestRowsFunctionBase.java: ## @@ -0,0 +1,211 @@ +/* + * Licens

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957125408 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/UnnestITCase.scala: ## @@ -379,4 +380,486 @@ class UnnestITC

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957125379 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/UnnestITCase.scala: ## @@ -379,4 +380,486 @@ class UnnestITC

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957124916 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/UnnestITCase.scala: ## @@ -315,4 +315,279 @@ class UnnestITCa

[jira] [Updated] (FLINK-37331) Add comprehensive data type coverage tests for new MysqlSource implementation

2025-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37331: --- Labels: pull-request-available (was: ) > Add comprehensive data type coverage tests for new

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957099781 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/UnnestRowsFunctionBase.java: ## @@ -0,0 +1,198 @@ +/* + * Licens

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957099724 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/UnnestRowsFunctionBase.java: ## @@ -0,0 +1,198 @@ +/* + * Licens

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957099724 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/UnnestRowsFunctionBase.java: ## @@ -0,0 +1,198 @@ +/* + * Licens

[jira] [Commented] (FLINK-37331) Add comprehensive data type coverage tests for new MysqlSource implementation

2025-02-15 Thread ronghangye (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927390#comment-17927390 ] ronghangye commented on FLINK-37331: I will go ahead and finish it. > Add comprehen

[jira] [Created] (FLINK-37331) Add comprehensive data type coverage tests for new MysqlSource implementation

2025-02-15 Thread ronghangye (Jira)
ronghangye created FLINK-37331: -- Summary: Add comprehensive data type coverage tests for new MysqlSource implementation Key: FLINK-37331 URL: https://issues.apache.org/jira/browse/FLINK-37331 Project: Fl

Re: [PR] [FLINK-37267][table] Add support for UNNEST WITH ORDINALITY [flink]

2025-02-15 Thread via GitHub
gustavodemorais commented on code in PR #26113: URL: https://github.com/apache/flink/pull/26113#discussion_r1957097592 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/UnnestRowsFunctionBase.java: ## @@ -0,0 +1,211 @@ +/* + * Licens

[jira] [Commented] (FLINK-23886) An exception is thrown out when recover job timers from checkpoint file

2025-02-15 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927381#comment-17927381 ] Gabor Somogyi commented on FLINK-23886: --- Thanks for giving some more insights! Hmm

Re: [PR] [FLINK-37282] Add Backchannel and ProducerPool [flink-connector-kafka]

2025-02-15 Thread via GitHub
AHeise commented on code in PR #152: URL: https://github.com/apache/flink-connector-kafka/pull/152#discussion_r1957074058 ## flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/internal/BackchannelImplTest.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the

Re: [PR] [FLINK-37282] Add Backchannel and ProducerPool [flink-connector-kafka]

2025-02-15 Thread via GitHub
AHeise commented on code in PR #152: URL: https://github.com/apache/flink-connector-kafka/pull/152#discussion_r1957073671 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/internal/BackchannelFactory.java: ## @@ -0,0 +1,123 @@ +/* + * Licensed to the

[jira] [Updated] (FLINK-37330) Add state migration test for Flink 2.0

2025-02-15 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise updated FLINK-37330: Description: Let's cover the common scenario that users want to upgrade their sources/sinks from

[jira] [Updated] (FLINK-37330) Add state migration test for Flink 2.0

2025-02-15 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arvid Heise updated FLINK-37330: Priority: Blocker (was: Major) > Add state migration test for Flink 2.0 > ---

[jira] [Created] (FLINK-37330) Add state migration test for Flink 2.0

2025-02-15 Thread Arvid Heise (Jira)
Arvid Heise created FLINK-37330: --- Summary: Add state migration test for Flink 2.0 Key: FLINK-37330 URL: https://issues.apache.org/jira/browse/FLINK-37330 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-36832] Remove Deprecated classes and relevant tests. [flink-connector-kafka]

2025-02-15 Thread via GitHub
AHeise commented on PR #139: URL: https://github.com/apache/flink-connector-kafka/pull/139#issuecomment-2660827638 I added https://issues.apache.org/jira/browse/FLINK-37330 as a follow-up task and marked it a blocker. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] [FLINK-36832] Remove Deprecated classes and relevant tests. [flink-connector-kafka]

2025-02-15 Thread via GitHub
AHeise commented on code in PR #139: URL: https://github.com/apache/flink-connector-kafka/pull/139#discussion_r1957071526 ## flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicPartitionTest.java: ## @@ -26,14 +27,14 @@ import st

Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]

2025-02-15 Thread via GitHub
flinkbot commented on PR #26162: URL: https://github.com/apache/flink/pull/26162#issuecomment-2660821630 ## CI report: * 3b79dd61d83e7894d806901120a66067486db35b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]

2025-02-15 Thread via GitHub
shameersss1 commented on PR #26162: URL: https://github.com/apache/flink/pull/26162#issuecomment-2660820214 @JunRuiLee Could you please review the changes ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (FLINK-37329) Skip Source Stats Collection When "table.optimizer.source.report-statistics-enabled" is false

2025-02-15 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Syed Shameerur Rahman updated FLINK-37329: -- Summary: Skip Source Stats Collection When "table.optimizer.source.report-stat

[jira] [Updated] (FLINK-37329) Skip Source Stats Collection When "table.optimizer.source.report-statistics-enabled" is False

2025-02-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37329: --- Labels: pull-request-available (was: ) > Skip Source Stats Collection When > "table.optimi

[PR] [FLINK-37329][table-planner] Skip Source Stats Collection When table.optimizer.source.report-statistics-enabled is False [flink]

2025-02-15 Thread via GitHub
shameersss1 opened a new pull request, #26162: URL: https://github.com/apache/flink/pull/26162 ## What is the purpose of the change Currently when "table.optimizer.source.report-statistics-enabled" is set to false, The statistics collection is not disabled for all the

Re: [PR] [FLINK-28047][docs] Remove deprecated StreamExecutionEnvironment#readTextFile method in documentation [flink]

2025-02-15 Thread via GitHub
flinkbot commented on PR #26161: URL: https://github.com/apache/flink/pull/26161#issuecomment-2660815689 ## CI report: * 8a46ab1489e55f4bdc8f976c7c155218414e975d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-37329) Skip Source Stats Collection When "table.optimizer.source.report-statistics-enabled" is False

2025-02-15 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Syed Shameerur Rahman updated FLINK-37329: -- Description: Currently when "table.optimizer.source.report-statistics-enabled"

[jira] [Updated] (FLINK-37329) Skip Source Stats Collection When "table.optimizer.source.report-statistics-enabled" is False

2025-02-15 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Syed Shameerur Rahman updated FLINK-37329: -- Description: Currently when "table.optimizer.source.report-statistics-enabled"

[jira] [Updated] (FLINK-37329) Skip Source Stats Collection When "table.optimizer.source.report-statistics-enabled" is False

2025-02-15 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Syed Shameerur Rahman updated FLINK-37329: -- Component/s: Table SQL / Planner > Skip Source Stats Collection When > "table

[jira] [Updated] (FLINK-37329) Skip Source Stats Collection When "table.optimizer.source.report-statistics-enabled" is False

2025-02-15 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Syed Shameerur Rahman updated FLINK-37329: -- Summary: Skip Source Stats Collection When "table.optimizer.source.report-stat

[jira] [Updated] (FLINK-37329) Skip Source Stats Collection When "table.optimizer.source.report-statistics-enabled" is False

2025-02-15 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Syed Shameerur Rahman updated FLINK-37329: -- Description: Currently when "table.optimizer.source.report-statistics-enabled"

[jira] [Created] (FLINK-37329) Skip Source Stats Collection When "table.optimizer.source.report-statistics-enabled

2025-02-15 Thread Syed Shameerur Rahman (Jira)
Syed Shameerur Rahman created FLINK-37329: - Summary: Skip Source Stats Collection When "table.optimizer.source.report-statistics-enabled Key: FLINK-37329 URL: https://issues.apache.org/jira/browse/FLINK-37

[jira] [Updated] (FLINK-37329) Skip Source Stats Collection When "table.optimizer.source.report-statistics-enabled" is False

2025-02-15 Thread Syed Shameerur Rahman (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Syed Shameerur Rahman updated FLINK-37329: -- Description: Currently when > Skip Source Stats Collection When > "table.opti