Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]

2025-01-10 Thread via GitHub
beliefer commented on code in PR #25835: URL: https://github.com/apache/flink/pull/25835#discussion_r1911925092 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamSink.java: ## @@ -25,6 +25,7 @@ import org.apache.flink.streaming.runtime.tasks.Processi

Re: [PR] [FLINK-36160] Support hive advanced configuration [flink]

2025-01-10 Thread via GitHub
luoyuxia commented on PR #25258: URL: https://github.com/apache/flink/pull/25258#issuecomment-2585115946 FYI, let's wait the response for the question I asked in [FLINK-37097](https://issues.apache.org/jira/browse/FLINK-37097?focusedCommentId=17912172&page=com.atlassian.jira.plugin.system.is

[jira] [Commented] (FLINK-37097) Remove Hive connector from core Flink

2025-01-10 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912172#comment-17912172 ] luoyuxia commented on FLINK-37097: -- So the currently pending pr for hive connector shou

[jira] [Commented] (FLINK-34932) Translate concepts of Flink-Kubernetes-Operator documentation

2025-01-10 Thread yinrhh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912164#comment-17912164 ] yinrhh commented on FLINK-34932: Hi. can anybody assign this problem to me,i truly want

[jira] [Commented] (FLINK-34932) Translate concepts of Flink-Kubernetes-Operator documentation

2025-01-10 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912165#comment-17912165 ] Rui Fan commented on FLINK-34932: - [~fernandoha] , assigned it to you.  Hi [~caicancai]

[jira] [Assigned] (FLINK-34932) Translate concepts of Flink-Kubernetes-Operator documentation

2025-01-10 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-34932: --- Assignee: yinrhh (was: Caican Cai) > Translate concepts of Flink-Kubernetes-Operator documentation

Re: [PR] [FLINK-28897] [TABLE-SQL] Fail to use udf in added jar when enabling checkpoint [flink]

2025-01-10 Thread via GitHub
ammu20-dev commented on PR #25656: URL: https://github.com/apache/flink/pull/25656#issuecomment-2585004128 > In that case the primary question should be - why does the `userClassLoader` class field not contain the actual user class loader in the first place. Should not that be the focus of

Re: [PR] [FLINK-35600] Add timestamp for low and high watermark [flink-cdc]

2025-01-10 Thread via GitHub
github-actions[bot] commented on PR #3415: URL: https://github.com/apache/flink-cdc/pull/3415#issuecomment-2584936582 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [FLINK-36696] [flink-autoscaler-plugin-jdbc] Switch sql connection usages to datasource [flink-kubernetes-operator]

2025-01-10 Thread via GitHub
sharath1709 commented on PR #929: URL: https://github.com/apache/flink-kubernetes-operator/pull/929#issuecomment-2584888730 Thanks a lot @1996fanrui for the quick review. Please find my replies below 1. Typically, DataSource connections will be relinquished automatically after a time

Re: [PR] [FLINK-36645] [flink-autoscaler] Gracefully handle null execution pla… [flink-kubernetes-operator]

2025-01-10 Thread via GitHub
sharath1709 commented on code in PR #930: URL: https://github.com/apache/flink-kubernetes-operator/pull/930#discussion_r1911479006 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/topology/JobTopology.java: ## @@ -150,6 +151,11 @@ public static JobTopology fromJson

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2025-01-10 Thread via GitHub
dadoonet commented on code in PR #136: URL: https://github.com/apache/flink-connector-jdbc/pull/136#discussion_r1911366874 ## flink-connector-jdbc-elasticsearch/pom.xml: ## @@ -0,0 +1,122 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLS

Re: [PR] [FLINK-36910][table] Add function call syntax support to time-related dynamic functions [flink]

2025-01-10 Thread via GitHub
gustavodemorais commented on PR #25951: URL: https://github.com/apache/flink/pull/25951#issuecomment-2584156849 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [1.19][FLINK-36740] [WebFrontend] Update frontend dependencies to address vulnerabilities [flink]

2025-01-10 Thread via GitHub
flinkbot commented on PR #25959: URL: https://github.com/apache/flink/pull/25959#issuecomment-2584134036 ## CI report: * 869ff30fc0ca6d6bc1fa4ab01201fe6588281d16 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-36716) Address vulnerabilities in Flink UI

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912115#comment-17912115 ] Alexander Fedulov commented on FLINK-36716: --- Backports to 1.19 (also need to b

Re: [PR] [FLINK-35721][docs] Fix CAST compatibility table [flink]

2025-01-10 Thread via GitHub
afedulov commented on PR #25938: URL: https://github.com/apache/flink/pull/25938#issuecomment-2583819948 Test failures are unrelated to the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [FLINK-36910][table] Add function call syntax support to time-related dynamic functions [flink]

2025-01-10 Thread via GitHub
gustavodemorais commented on PR #25951: URL: https://github.com/apache/flink/pull/25951#issuecomment-2583625250 > @flinkbot run azure I see the CI error is coming up in some PRs `Jan 10 10:32:46 10:32:46.859 [ERROR] SqlYARNApplicationITCase.testDeployScriptViaSqlClient:85->YarnTe

Re: [PR] [FLINK-36910][table] Add function call syntax support to time-related dynamic functions [flink]

2025-01-10 Thread via GitHub
gustavodemorais commented on PR #25951: URL: https://github.com/apache/flink/pull/25951#issuecomment-2583621913 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (FLINK-36227) NullPointerException when starting flink with logback logger

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912086#comment-17912086 ] Alexander Fedulov commented on FLINK-36227: --- Merged: * master (2.0): [https:

[jira] [Resolved] (FLINK-36227) NullPointerException when starting flink with logback logger

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov resolved FLINK-36227. --- Resolution: Fixed > NullPointerException when starting flink with logback logger > -

Re: [PR] [FLINK-36227] Restore compatibility with Logback 1.2 - Flink 2.0 [flink]

2025-01-10 Thread via GitHub
afedulov merged PR #25942: URL: https://github.com/apache/flink/pull/25942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-36227] Restore compatibility with Logback 1.2 - Flink 2.0 [flink]

2025-01-10 Thread via GitHub
afedulov commented on PR #25942: URL: https://github.com/apache/flink/pull/25942#issuecomment-2583595797 Test failures are unreleated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Comment Edited] (FLINK-36689) [UI] Upgrade runtime web Angular framework and associated deps to latest version

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911248#comment-17911248 ] Alexander Fedulov edited comment on FLINK-36689 at 1/10/25 6:28 PM: --

Re: [PR] [1.19][FLINK-36689][Runtime/Web Frontend] Update ng-zorro-antd to v18 [flink]

2025-01-10 Thread via GitHub
flinkbot commented on PR #25958: URL: https://github.com/apache/flink/pull/25958#issuecomment-2583329176 ## CI report: * b20a34e9ce0b70550831c909e358d92a665ab379 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-36689][Runtime/Web Frontend] Update ng-zorro-antd to v18 [flink]

2025-01-10 Thread via GitHub
afedulov opened a new pull request, #25958: URL: https://github.com/apache/flink/pull/25958 Unmodified backport of https://github.com/apache/flink/pull/25829 to 1.19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-10 Thread via GitHub
flinkbot commented on PR #25957: URL: https://github.com/apache/flink/pull/25957#issuecomment-2583284812 ## CI report: * 3240a67474eff4d9790b671a7d5eb925767cd31b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [1.20][FLINK-36739] Update the NodeJS to v22.11.0 (LTS) [flink]

2025-01-10 Thread via GitHub
afedulov opened a new pull request, #25957: URL: https://github.com/apache/flink/pull/25957 Unmodified backport of https://github.com/apache/flink/pull/25794 to 1.19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-37098] Fix selecting time attribute from a view [flink]

2025-01-10 Thread via GitHub
davidradl commented on code in PR #25952: URL: https://github.com/apache/flink/pull/25952#discussion_r1910652096 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/catalog/JavaCatalogTableTest.java: ## @@ -177,6 +177,31 @@ void testTimeAttributeOfVie

Re: [PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2025-01-10 Thread via GitHub
davidradl commented on PR #749: URL: https://github.com/apache/flink-kubernetes-operator/pull/749#issuecomment-2583197136 @lajith2006 please update the Jira to remove the link to this PR and add in the link to the new PR, thanks. -- This is an automated message from the Apache Git Servic

Re: [PR] [FLINK-xx][table] Add Join remove rules. [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25932: URL: https://github.com/apache/flink/pull/25932#issuecomment-2583188348 Reviewed by Chi on 09/01/2025 Need a committer to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-34417) Add JobID to logging MDC

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-34417: -- Fix Version/s: 1.20.0 (was: 1.19.0) > Add JobID to logging MDC

[jira] [Commented] (FLINK-34417) Add JobID to logging MDC

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912032#comment-17912032 ] Alexander Fedulov commented on FLINK-34417: --- MdcUtils does not exist in 1.19,

Re: [PR] [FLINK-36549]Fix using the ignore-parse-errors parameter in Debezium/Canal/Maxwell/Ogg JSON results in unexpected data loss [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25919: URL: https://github.com/apache/flink/pull/25919#issuecomment-2583177431 Reviewed by Chi on 09/01/2025 Need a committer to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [hotfix] Update copyright NOTICE year to 2025 [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25916: URL: https://github.com/apache/flink/pull/25916#issuecomment-2583175619 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [hotfix] Update copyright NOTICE year to 2025 [flink]

2025-01-10 Thread via GitHub
davidradl commented on code in PR #25916: URL: https://github.com/apache/flink/pull/25916#discussion_r1910623612 ## flink-runtime-web/src/main/resources/META-INF/NOTICE: ## @@ -1053,13 +1053,10 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. --- color-name@

[jira] [Closed] (FLINK-35453) StreamReader Charset fix with UTF8 in core files

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov closed FLINK-35453. - Resolution: Won't Fix > StreamReader Charset fix with UTF8 in core files > -

Re: [PR] [BP-1.19][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25911: URL: https://github.com/apache/flink/pull/25911#issuecomment-2583164726 Reviewed by Chi on 09/01/2025 Approve - looking for committer to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (FLINK-36740) Update frontend dependencies to address vulnerabilities

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912030#comment-17912030 ] Alexander Fedulov commented on FLINK-36740: --- Merged in release-1.20: https://

Re: [PR] [FLINK-37019][tests] Bump junit5 to 5.11.4 [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25906: URL: https://github.com/apache/flink/pull/25906#issuecomment-2583161983 Reviewed by Chi on 09/01/2025 Approve - looking for committer to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [FLINK-37009][table] Migrate PruneAggregateCallRule to java [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25900: URL: https://github.com/apache/flink/pull/25900#issuecomment-2583159607 Reviewed by Chi on 09/01/2025 Need a committer to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-36898][Table] Support SQL FLOOR and CEIL functions with NanoSecond and MicroSecond for TIMESTAMP_TLZ [flink]

2025-01-10 Thread via GitHub
davidradl commented on code in PR #25897: URL: https://github.com/apache/flink/pull/25897#discussion_r1910615148 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/FloorCeilCallGen.scala: ## @@ -65,15 +65,17 @@ class FloorCeilCallGen(

[jira] [Updated] (FLINK-36227) NullPointerException when starting flink with logback logger

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-36227: -- Fix Version/s: 2.0-preview > NullPointerException when starting flink with logback log

[jira] [Updated] (FLINK-36227) NullPointerException when starting flink with logback logger

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-36227: -- Fix Version/s: (was: 1.19.2) > NullPointerException when starting flink with logba

Re: [PR] [FLINK-36227] Restore compatibility with Logback 1.2 - Flink 2.0 [flink]

2025-01-10 Thread via GitHub
afedulov commented on PR #25942: URL: https://github.com/apache/flink/pull/25942#issuecomment-2583135341 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter … [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25896: URL: https://github.com/apache/flink/pull/25896#issuecomment-2583133692 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-36992][table] Migrate DecomposeGroupingSetsRule to java [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25893: URL: https://github.com/apache/flink/pull/25893#issuecomment-2583129973 Reviewed by Chi on 09/01/2025 Need a committer to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-36997] Add Log4j JSONTemplateLayout to flink-dist [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25888: URL: https://github.com/apache/flink/pull/25888#issuecomment-2583123978 Reviewed by Chi on 09/01/2025 Approve - looking for committer to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [FLINK-36899][state/forst] Introduce metrics for forst cache [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25884: URL: https://github.com/apache/flink/pull/25884#issuecomment-2583120995 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-36899][state/forst] Introduce metrics for forst cache [flink]

2025-01-10 Thread via GitHub
davidradl commented on code in PR #25884: URL: https://github.com/apache/flink/pull/25884#discussion_r1910600361 ## docs/content/docs/ops/metrics.md: ## @@ -1526,6 +1526,41 @@ Note that for failed checkpoints, metrics are updated on a best efforts basis an ### RocksDB Certain

Re: [PR] [FLINK-36979][rpc] Reverting pekko version bump in Flink 1.20 [flink]

2025-01-10 Thread via GitHub
ferenc-csaky commented on PR #25866: URL: https://github.com/apache/flink/pull/25866#issuecomment-2583112184 IMO yes, I will close both this one and the [1.19 equivalent](https://github.com/apache/flink/pull/25867) on Monday if no objections until then. -- This is an automated message fr

Re: [PR] [FLINK-36992][table] Migrate SplitAggregateRule to java [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25883: URL: https://github.com/apache/flink/pull/25883#issuecomment-2583108943 Reviewed by Chi on 09/01/2025 Need a committer to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-36988][table] Migrate LogicalCorrelateToJoinFromTemporalTableF… [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25882: URL: https://github.com/apache/flink/pull/25882#issuecomment-2583108276 Reviewed by Chi on 09/01/2025 Need a committer to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-36746] Fix the deadlock bug when initializing SerializedThrowable object. [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25870: URL: https://github.com/apache/flink/pull/25870#issuecomment-2583098445 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-36979][rpc] Reverting pekko version bump in Flink 1.19 [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25867: URL: https://github.com/apache/flink/pull/25867#issuecomment-2583096443 @ferenc-csaky can we close this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [FLINK-36979][rpc] Reverting pekko version bump in Flink 1.20 [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25866: URL: https://github.com/apache/flink/pull/25866#issuecomment-2583092943 @ferenc-csaky sounds good - can we close this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] [FLINK-36629][table-planner] Introducing the AdaptiveSkewedJoinOptimizationStrategy [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25859: URL: https://github.com/apache/flink/pull/25859#issuecomment-2583084833 Reviewed by Chi on 09/01/2025 Need a committer to review after the conflicts have been resolved -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [hotfix][docs] Fix Apache Avro Specification Link [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25850: URL: https://github.com/apache/flink/pull/25850#issuecomment-2583080401 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-36957][Datastream] Implement asyc state version of stream flatmap [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25848: URL: https://github.com/apache/flink/pull/25848#issuecomment-2583064222 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-36429] [runtime-web] Enhancing Flink History Server File Storage and Retrieval with RocksDB [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25838: URL: https://github.com/apache/flink/pull/25838#issuecomment-2583060608 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [MINOR] Rename PunctuatedWatermarkStrategyWrapper with PunctuatedWatermarkAssignerWrapper [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25836: URL: https://github.com/apache/flink/pull/25836#issuecomment-2583054345 Reviewed by Chi on 09/01/2025 Approve - looking for committer to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]

2025-01-10 Thread via GitHub
davidradl commented on code in PR #25835: URL: https://github.com/apache/flink/pull/25835#discussion_r1910577181 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/StreamSink.java: ## @@ -25,6 +25,7 @@ import org.apache.flink.streaming.runtime.tasks.Process

Re: [PR] [MINOR] Deprecated StreamSink and SinkOperator [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25835: URL: https://github.com/apache/flink/pull/25835#issuecomment-2583051317 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Comment Edited] (FLINK-36739) Update NodeJS to v22 (LTS)

2025-01-10 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910799#comment-17910799 ] Alexander Fedulov edited comment on FLINK-36739 at 1/10/25 3:57 PM: --

Re: [PR] [FLINK-35014] SqlNode to operation conversion for models [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25834: URL: https://github.com/apache/flink/pull/25834#issuecomment-2583032679 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-xx][table] Add more Calcite PruneEmptyRules [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25826: URL: https://github.com/apache/flink/pull/25826#issuecomment-2583030238 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-36911][table] Add more Calcite Reduce Expression Rules [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25825: URL: https://github.com/apache/flink/pull/25825#issuecomment-2583029140 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-xx][table] Remove RelBuilder [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25823: URL: https://github.com/apache/flink/pull/25823#issuecomment-2583028136 Reviewed by Chi on 09/01/2025 Go back to the submitter with review comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] [FLINK-37026] Add Stale PR GitHub Action workflow [flink]

2025-01-10 Thread via GitHub
tomncooper commented on code in PR #25953: URL: https://github.com/apache/flink/pull/25953#discussion_r1910541006 ## .github/workflows/stale.yml: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [PR] [FLINK-35721][docs] Fix CAST compatibility table [flink]

2025-01-10 Thread via GitHub
afedulov commented on PR #25938: URL: https://github.com/apache/flink/pull/25938#issuecomment-2582971634 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [FLINK-37086] Clean up should remove all autoscaler state [flink-kubernetes-operator]

2025-01-10 Thread via GitHub
gyfora opened a new pull request, #932: URL: https://github.com/apache/flink-kubernetes-operator/pull/932 ## What is the purpose of the change The autoscaler cleanup logic currently does not actually delete the state of the job from the state store only the cache. This can cause leaks

Re: [PR] [FLINK-37026] Add Stale PR GitHub Action workflow [flink]

2025-01-10 Thread via GitHub
gyfora commented on code in PR #25953: URL: https://github.com/apache/flink/pull/25953#discussion_r1910533490 ## .github/workflows/stale.yml: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOT

Re: [PR] Add hostNetwork for operator pod, default false [flink-kubernetes-operator]

2025-01-10 Thread via GitHub
gyfora commented on PR #925: URL: https://github.com/apache/flink-kubernetes-operator/pull/925#issuecomment-2582959086 Could you please open a JIRA ticket for this change so we can track it in the project? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] [FLINK-37026] Add Stale PR GitHub Action workflow [flink]

2025-01-10 Thread via GitHub
davidradl commented on code in PR #25953: URL: https://github.com/apache/flink/pull/25953#discussion_r1910525460 ## .github/workflows/stale.yml: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [PR] [FLINK-37026] Add Stale PR GitHub Action workflow [flink]

2025-01-10 Thread via GitHub
tomncooper commented on code in PR #25953: URL: https://github.com/apache/flink/pull/25953#discussion_r1910530571 ## .github/workflows/stale.yml: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [PR] [FLINK-37026] Add Stale PR GitHub Action workflow [flink]

2025-01-10 Thread via GitHub
davidradl commented on code in PR #25953: URL: https://github.com/apache/flink/pull/25953#discussion_r1910527537 ## .github/workflows/stale.yml: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [PR] [FLINK-37026] Add Stale PR GitHub Action workflow [flink]

2025-01-10 Thread via GitHub
tomncooper commented on code in PR #25953: URL: https://github.com/apache/flink/pull/25953#discussion_r1910529186 ## .github/workflows/stale.yml: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [PR] [FLINK-36645] [flink-autoscaler] Gracefully handle null execution pla… [flink-kubernetes-operator]

2025-01-10 Thread via GitHub
gyfora commented on code in PR #930: URL: https://github.com/apache/flink-kubernetes-operator/pull/930#discussion_r1910525502 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/topology/JobTopology.java: ## @@ -150,6 +151,11 @@ public static JobTopology fromJsonPlan(

Re: [PR] [FLINK-37026] Add Stale PR GitHub Action workflow [flink]

2025-01-10 Thread via GitHub
davidradl commented on code in PR #25953: URL: https://github.com/apache/flink/pull/25953#discussion_r1910525460 ## .github/workflows/stale.yml: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [PR] [hotfix][docs] Add 2025 on NOTICE [flink-kubernetes-operator]

2025-01-10 Thread via GitHub
gyfora merged PR #927: URL: https://github.com/apache/flink-kubernetes-operator/pull/927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Updated] (FLINK-37086) State leaks for JDBC state store after job is stopped

2025-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37086: --- Labels: pull-request-available (was: ) > State leaks for JDBC state store after job is stop

Re: [PR] [FLINK-37091][table-common] Remove deprecated interface CatalogLock [flink]

2025-01-10 Thread via GitHub
davidradl commented on PR #25947: URL: https://github.com/apache/flink/pull/25947#issuecomment-2582943114 @snuyanzin fyi This PR is removing a class that the Hive connector depends on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [1.19][FLINK-37100][tests] Fix `test_netty_shuffle_memory_control.sh` in CI for JDK11+ [flink]

2025-01-10 Thread via GitHub
flinkbot commented on PR #25956: URL: https://github.com/apache/flink/pull/25956#issuecomment-2582926450 ## CI report: * 91c0b55755cf7df79b56e32566eba087b895184e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [1.20][FLINK-37100][tests] Fix `test_netty_shuffle_memory_control.sh` in CI for JDK11+ [flink]

2025-01-10 Thread via GitHub
He-Pin commented on code in PR #25955: URL: https://github.com/apache/flink/pull/25955#discussion_r1910506639 ## flink-end-to-end-tests/test-scripts/test_netty_shuffle_memory_control.sh: ## @@ -36,6 +36,10 @@ set_config_key "taskmanager.network.netty.num-arenas" "1" # Limits th

Re: [PR] [FLINK-36979][rpc] Reverting pekko version bump in Flink 1.19 [flink]

2025-01-10 Thread via GitHub
ferenc-csaky commented on PR #25867: URL: https://github.com/apache/flink/pull/25867#issuecomment-2582918047 Opened https://github.com/apache/flink/pull/25956 which I believe should supersede this current PR. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] [1.20][FLINK-37100][tests] Fix `test_netty_shuffle_memory_control.sh` in CI for JDK11+ [flink]

2025-01-10 Thread via GitHub
flinkbot commented on PR #25955: URL: https://github.com/apache/flink/pull/25955#issuecomment-2582913733 ## CI report: * b2a98e60ad0ecb695a6178d6130cda84553b8ff2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [1.19][FLINK-37100][tests] Fix `test_netty_shuffle_memory_control.sh` in CI for JDK11+ [flink]

2025-01-10 Thread via GitHub
ferenc-csaky opened a new pull request, #25956: URL: https://github.com/apache/flink/pull/25956 ## What is the purpose of the change Fixes the test executed by `test_netty_shuffle_memory_control.sh` that can possibly fail the CI in case Netty4 cannot reserve enough memory, hence Pekko

Re: [PR] [FLINK-36979][rpc] Reverting pekko version bump in Flink 1.20 [flink]

2025-01-10 Thread via GitHub
ferenc-csaky commented on PR #25866: URL: https://github.com/apache/flink/pull/25866#issuecomment-2582907004 Opened https://github.com/apache/flink/pull/25955 which I believe should supersede this current PR. -- This is an automated message from the Apache Git Service. To respond to the m

[jira] [Updated] (FLINK-37100) Fix test_netty_shuffle_memory_control.sh in CI for JDK11+

2025-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37100: --- Labels: pull-request-available (was: ) > Fix test_netty_shuffle_memory_control.sh in CI for

[PR] [FLINK-37100][tests] Fix `test_netty_shuffle_memory_control.sh` in CI for JDK11+ [flink]

2025-01-10 Thread via GitHub
ferenc-csaky opened a new pull request, #25955: URL: https://github.com/apache/flink/pull/25955 ## What is the purpose of the change Fixes the test executed by `test_netty_shuffle_memory_control.sh` that can possibly fail the CI in case Netty4 cannot reserve enough memory, hence Pekko

Re: [PR] [FLINK-37090][e2e] Add adaptive broadcast join to e2e tpc-ds tests. [flink]

2025-01-10 Thread via GitHub
flinkbot commented on PR #25954: URL: https://github.com/apache/flink/pull/25954#issuecomment-2582853466 ## CI report: * 27e503efb6c2fc7742a513cd166399a51312af67 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37026] Add Stale PR GitHub Action workflow [flink]

2025-01-10 Thread via GitHub
flinkbot commented on PR #25953: URL: https://github.com/apache/flink/pull/25953#issuecomment-2582853276 ## CI report: * 03ee68c53e6523046cbb64f9a2b6d15823edb659 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-37098] Fix selecting time attribute from a view [flink]

2025-01-10 Thread via GitHub
flinkbot commented on PR #25952: URL: https://github.com/apache/flink/pull/25952#issuecomment-2582853024 ## CI report: * fdf0105d32c8a346d9a890411098715bd297ddee UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-37090) Introduce a TPC-DS E2E case for adaptive broadcast join

2025-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37090: --- Labels: pull-request-available (was: ) > Introduce a TPC-DS E2E case for adaptive broadcast

[PR] [FLINK-37090][e2e] Add adaptive broadcast join to e2e tpc-ds tests. [flink]

2025-01-10 Thread via GitHub
SinBex opened a new pull request, #25954: URL: https://github.com/apache/flink/pull/25954 ## What is the purpose of the change Add adaptive broadcast join to e2e tpc-ds tests. In this case, we will set the AdaptiveBroadcastJoinStrategy to RUNTIME_ONLY, significantly increasing

Re: [PR] [FLINK-37026] Add Stale PR GitHub Action workflow [flink]

2025-01-10 Thread via GitHub
tomncooper commented on PR #25953: URL: https://github.com/apache/flink/pull/25953#issuecomment-2582840912 cc @gyfora @1996fanrui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Updated] (FLINK-37026) Enable Stale PR Github Action

2025-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37026: --- Labels: pull-request-available (was: ) > Enable Stale PR Github Action > --

[PR] [FLINK-37026] Add Stale PR GitHub Action workflow [flink]

2025-01-10 Thread via GitHub
tomncooper opened a new pull request, #25953: URL: https://github.com/apache/flink/pull/25953 ## What is the purpose of the change This is the implementation of the [Stale PR GitHub Action Proposal](https://cwiki.apache.org/confluence/display/FLINK/Stale+PR+Cleanup). This was [voted

[jira] [Updated] (FLINK-37098) Can not select time attribute from a view

2025-01-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37098: --- Labels: pull-request-available (was: ) > Can not select time attribute from a view > --

[PR] [FLINK-37098] Fix selecting time attribute from a view [flink]

2025-01-10 Thread via GitHub
dawidwys opened a new pull request, #25952: URL: https://github.com/apache/flink/pull/25952 ## What is the purpose of the change It makes it possible to query views which have time attributes added while converting from SqlNode to RelNode ## Verifying this change Added a

Re: [PR] [FLINK-30702] Add Elasticsearch dialect [flink-connector-jdbc]

2025-01-10 Thread via GitHub
linghengqian commented on code in PR #136: URL: https://github.com/apache/flink-connector-jdbc/pull/136#discussion_r1910444296 ## flink-connector-jdbc-elasticsearch/pom.xml: ## @@ -0,0 +1,122 @@ + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi="http://www.w3.org/2001/

[jira] [Created] (FLINK-37100) Fix test_netty_shuffle_memory_control.sh in CI for JDK11+

2025-01-10 Thread Ferenc Csaky (Jira)
Ferenc Csaky created FLINK-37100: Summary: Fix test_netty_shuffle_memory_control.sh in CI for JDK11+ Key: FLINK-37100 URL: https://issues.apache.org/jira/browse/FLINK-37100 Project: Flink Iss

  1   2   3   >