sharath1709 commented on PR #929: URL: https://github.com/apache/flink-kubernetes-operator/pull/929#issuecomment-2584888730
Thanks a lot @1996fanrui for the quick review. Please find my replies below 1. Typically, DataSource connections will be relinquished automatically after a time out and DataSource isn't Closeable. However, some DataSource implementations like HikariDataSource implement the Closeable interface to close the ConnectionPool. We can add a check to see if the DataSource is Closeable and then close it. Additionally, I've attempted to make the classes that hold the datasource objects Autocloseable as well so that they could be created in a try-with-resources block 2. Thanks, I've tried to fix most of the issues but might need a couple more iterations. 3. Great point, I will try to add a test case for this scenario soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
