Re: [PR] [FLINK-3154][API] Upgrade from Kryo 2.x to Kryo 5.x. Removed twitter … [flink]

2025-01-05 Thread via GitHub
kurtostfeld commented on PR #25896: URL: https://github.com/apache/flink/pull/25896#issuecomment-2572500238 The following test failure is caused by a test file, external to the main git repo, that I don't have access to change. It simply needs Class changed to Class. ``` /tmp/juni

Re: [PR] [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-05 Thread via GitHub
XComp commented on PR #25827: URL: https://github.com/apache/flink/pull/25827#issuecomment-2572493197 > Do you have an idea what could be wrong? The [CI build](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=64350&view=logs&j=d3c25614-fe65-5341-2db6-c20b16adba8d

Re: [PR] [FLINK-37009][table] Migrate PruneAggregateCallRule to java [flink]

2025-01-05 Thread via GitHub
liuyongvs commented on code in PR #25900: URL: https://github.com/apache/flink/pull/25900#discussion_r1903784779 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/PruneAggregateCallRule.java: ## @@ -0,0 +1,238 @@ +/* + * Licensed

[jira] [Updated] (FLINK-37009) Migrate PruneAggregateCallRule

2025-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37009: --- Labels: pull-request-available (was: ) > Migrate PruneAggregateCallRule > -

[PR] [FLINK-37009][table] Migrate PruneAggregateCallRule to java [flink]

2025-01-05 Thread via GitHub
liuyongvs opened a new pull request, #25900: URL: https://github.com/apache/flink/pull/25900 ## What is the purpose of the change The PR migrates PruneAggregateCallRule to java ## Verifying this change This change is already covered by existing tests ## Does this p

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-05 Thread via GitHub
yiyutian1 commented on code in PR #25763: URL: https://github.com/apache/flink/pull/25763#discussion_r1903771370 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/TimeFunctionsITCase.java: ## @@ -853,18 +848,13 @@ private Stream toTimestam

[jira] [Created] (FLINK-37010) Unify KeyedProcessFunction and the async one

2025-01-05 Thread Zakelly Lan (Jira)
Zakelly Lan created FLINK-37010: --- Summary: Unify KeyedProcessFunction and the async one Key: FLINK-37010 URL: https://issues.apache.org/jira/browse/FLINK-37010 Project: Flink Issue Type: Sub-ta

Re: [PR] [FLINK-36862][table] Implement additional TO_TIMESTAMP_LTZ() functions [flink]

2025-01-05 Thread via GitHub
yiyutian1 commented on PR #25763: URL: https://github.com/apache/flink/pull/25763#issuecomment-2572428331 > Thanks for addressing feedback it looks we are approaching > > There is at least one case found showing regression > > ```sql > SELECT to_timestamp_ltz(123, CAST(NULL A

[jira] [Updated] (FLINK-36974) support overwrite flink config by command line

2025-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36974: --- Labels: pull-request-available (was: ) > support overwrite flink config by command line >

Re: [PR] [FLINK-36974]support overwrite flink config by command line [flink-cdc]

2025-01-05 Thread via GitHub
yuxiqian commented on code in PR #3823: URL: https://github.com/apache/flink-cdc/pull/3823#discussion_r1903736412 ## flink-cdc-cli/src/test/java/org/apache/flink/cdc/cli/CliFrontendTest.java: ## @@ -145,6 +146,31 @@ void testPipelineExecuting() throws Exception { asser

[jira] [Created] (FLINK-37009) Migrate PruneAggregateCallRule

2025-01-05 Thread Jacky Lau (Jira)
Jacky Lau created FLINK-37009: - Summary: Migrate PruneAggregateCallRule Key: FLINK-37009 URL: https://issues.apache.org/jira/browse/FLINK-37009 Project: Flink Issue Type: Sub-task Compo

[jira] [Commented] (FLINK-33265) Support source parallelism setting for Kafka connector

2025-01-05 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910011#comment-17910011 ] Zhanghao Chen commented on FLINK-33265: --- [~yunta] [~lincoln.86xy] RocMarshal has a

Re: [PR] [FLINK-36825][table] Introduce FastTop1Function in Rank with Async State API [flink]

2025-01-05 Thread via GitHub
Zakelly commented on code in PR #25717: URL: https://github.com/apache/flink/pull/25717#discussion_r1903721138 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/asyncprocessing/AsyncStateKeyedProcessOperator.java: ## @@ -0,0 +1,196 @@ +/* + * Licensed to th

Re: [PR] [FLINK-22091][yarn] Make Flink on YARN honor env.java.home [flink]

2025-01-05 Thread via GitHub
X-czh commented on PR #25877: URL: https://github.com/apache/flink/pull/25877#issuecomment-2572349685 Squashed both commits into one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [FLINK-36979][rpc] Reverting pekko version bump in Flink 1.20 [flink]

2025-01-05 Thread via GitHub
He-Pin commented on PR #25866: URL: https://github.com/apache/flink/pull/25866#issuecomment-2572345937 @XComp Is there any update can share, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [FLINK-22091][yarn] Make Flink on YARN honor env.java.home [flink]

2025-01-05 Thread via GitHub
Samrat002 commented on PR #25877: URL: https://github.com/apache/flink/pull/25877#issuecomment-2572300758 NIT : Squash both the commits into one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [FLINK-36576][runtime] Improving amount-based data balancing distribution algorithm for DefaultVertexParallelismAndInputInfosDecider [flink]

2025-01-05 Thread via GitHub
JunRuiLee commented on code in PR #25552: URL: https://github.com/apache/flink/pull/25552#discussion_r1903628396 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/BlockingInputInfo.java: ## @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software F

Re: [PR] [FLINK-37008] [runtime-web] Flink UI should show the type of checkpoint (full vs incremental) [flink]

2025-01-05 Thread via GitHub
flinkbot commented on PR #25899: URL: https://github.com/apache/flink/pull/25899#issuecomment-2572234932 ## CI report: * 1494ec245bca1ca1f43d7153421033bfa7cbc602 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-36576][runtime] Improving amount-based data balancing distribution algorithm for DefaultVertexParallelismAndInputInfosDecider [flink]

2025-01-05 Thread via GitHub
JunRuiLee commented on code in PR #25552: URL: https://github.com/apache/flink/pull/25552#discussion_r1903626133 ## flink-runtime/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java: ## @@ -77,6 +77,10 @@ public class StreamEdge implements Serializable { pr

[jira] [Updated] (FLINK-37008) Flink UI should show the type of checkpoint (full vs incremental)

2025-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-37008: --- Labels: pull-request-available (was: ) > Flink UI should show the type of checkpoint (full

[PR] [FLINK-37008] [runtime-web] Flink UI should show the type of checkpoint (full vs incremental) [flink]

2025-01-05 Thread via GitHub
ryanvanhuuksloot opened a new pull request, #25899: URL: https://github.com/apache/flink/pull/25899 ## What is the purpose of the change It would be useful for the UI to show if a checkpoint is full or incremental. I'm curious how others would like to expose this in the UI / A

Re: [PR] [FLINK-36999][cdc-source-connectors] When the source field type is de… [flink-cdc]

2025-01-05 Thread via GitHub
linjianchang commented on PR #3833: URL: https://github.com/apache/flink-cdc/pull/3833#issuecomment-2572228210 **source oracle table structure:** create table PORTAL.SYSTEM_USER ( sys_user_id NUMBER not null, staff_idNUMBER not null, sys_user_code VARCHAR2(2

[jira] [Created] (FLINK-37008) Flink UI should show the type of checkpoint (full vs incremental)

2025-01-05 Thread Ryan van Huuksloot (Jira)
Ryan van Huuksloot created FLINK-37008: -- Summary: Flink UI should show the type of checkpoint (full vs incremental) Key: FLINK-37008 URL: https://issues.apache.org/jira/browse/FLINK-37008 Project

Re: [PR] [FLINK-36576][runtime] Improving amount-based data balancing distribution algorithm for DefaultVertexParallelismAndInputInfosDecider [flink]

2025-01-05 Thread via GitHub
zhuzhurk commented on code in PR #25552: URL: https://github.com/apache/flink/pull/25552#discussion_r1903612414 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptivebatch/DefaultVertexParallelismAndInputInfosDecider.java: ## @@ -128,12 +128,8 @@ public Paral

Re: [PR] [FLINK-36993][table] Support ALTER MATERIALIZED TABLE As statement [flink]

2025-01-05 Thread via GitHub
hackergin commented on code in PR #25880: URL: https://github.com/apache/flink/pull/25880#discussion_r1903612300 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/materializedtable/AlterMaterializedTableAsQueryOperation.java: ## @@ -0,0 +1,142 @

Re: [PR] [FLINK-36993][table] Support ALTER MATERIALIZED TABLE As statement [flink]

2025-01-05 Thread via GitHub
hackergin commented on code in PR #25880: URL: https://github.com/apache/flink/pull/25880#discussion_r1903611482 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlMaterializedTableNodeToOperationConverterTest.java: ## @@ -391,6 +392,17

[jira] [Updated] (FLINK-36993) FLIP-492: Support Query Modifications for Materialized Tables

2025-01-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36993: --- Labels: pull-request-available (was: ) > FLIP-492: Support Query Modifications for Material

Re: [PR] [FLINK-36993][table] Support ALTER MATERIALIZED TABLE As statement [flink]

2025-01-05 Thread via GitHub
hackergin commented on code in PR #25880: URL: https://github.com/apache/flink/pull/25880#discussion_r1903610990 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -804,6 +808,78 @@ protect

[jira] [Closed] (FLINK-36989) Scheduler benchmark regression since Dec.25th

2025-01-05 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-36989. --- Fix Version/s: 2.0.0 Resolution: Fixed 81f882bcf79770072f3cee9a026c658ed9b04219 > Scheduler benchmar

Re: [PR] [FLINK-36989][runtime] Fix scheduler benchmark regression caused by ConsumedSubpartitionContext [flink]

2025-01-05 Thread via GitHub
zhuzhurk merged PR #25887: URL: https://github.com/apache/flink/pull/25887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-36989][runtime] Fix scheduler benchmark regression caused by ConsumedSubpartitionContext [flink]

2025-01-05 Thread via GitHub
noorall commented on PR #25887: URL: https://github.com/apache/flink/pull/25887#issuecomment-2572182080 > Thanks @noorall for fixing. LGTM. Could you post the results of the three regressed benchmark cases after the fix? I tested it on my own computer, and here are the test results:

Re: [PR] [FLINK-36989][runtime] Fix scheduler benchmark regression caused by ConsumedSubpartitionContext [flink]

2025-01-05 Thread via GitHub
zhuzhurk commented on PR #25887: URL: https://github.com/apache/flink/pull/25887#issuecomment-2572026995 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34123][FLINK-35068][FLINK-36903] Introduce built-in serialization support for common collection types [flink]

2025-01-05 Thread via GitHub
X-czh commented on code in PR #25797: URL: https://github.com/apache/flink/pull/25797#discussion_r1903397742 ## docs/layouts/shortcodes/generated/pipeline_configuration.html: ## @@ -20,6 +20,12 @@ Duration The interval of the automatic watermark emissio

Re: [PR] [FLINK-34825][pipeline-connector][mongodb] Add Implementation of DataSource in MongoDB [flink-cdc]

2025-01-05 Thread via GitHub
github-actions[bot] commented on PR #3679: URL: https://github.com/apache/flink-cdc/pull/3679#issuecomment-2571801368 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [FLINK-30782][build] Use https for schemaLocations [flink]

2025-01-05 Thread via GitHub
snuyanzin closed pull request #21753: [FLINK-30782][build] Use https for schemaLocations URL: https://github.com/apache/flink/pull/21753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-33817][flink-protobuf] Set ReadDefaultValues=False by default in proto3 for performance improvement [flink]

2025-01-05 Thread via GitHub
ikstewa commented on PR #24035: URL: https://github.com/apache/flink/pull/24035#issuecomment-2571733258 @sharath1709 I'm trying to follow up on this change to understand why we do not support optional primitive types. I believe proto3 has support for field presence on primitives when they h

[jira] [Created] (FLINK-37007) FLIP-494: Add missing createTable/createView methods to TableEnvironment

2025-01-05 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-37007: --- Summary: FLIP-494: Add missing createTable/createView methods to TableEnvironment Key: FLINK-37007 URL: https://issues.apache.org/jira/browse/FLINK-37007 Projec

Re: [PR] [FLINK-36976] Upgrade jackson from 2.15.3 to 2.18.2 [flink]

2025-01-05 Thread via GitHub
snuyanzin commented on code in PR #25865: URL: https://github.com/apache/flink/pull/25865#discussion_r1903311567 ## pom.xml: ## @@ -1857,7 +1857,7 @@ under the License.

Re: [PR] [FLINK-36976] Upgrade jackson from 2.15.3 to 2.18.2 [flink]

2025-01-05 Thread via GitHub
snuyanzin commented on code in PR #25865: URL: https://github.com/apache/flink/pull/25865#discussion_r1903312062 ## flink-kubernetes/pom.xml: ## @@ -31,7 +31,7 @@ under the License. jar - 6.9.2 + 6.13.4 Review Comment: since it

Re: [PR] [BP-1.20][FLINK-34194] Update CI to Ubuntu 22.04 (Jammy) [flink]

2025-01-05 Thread via GitHub
afedulov commented on PR #25827: URL: https://github.com/apache/flink/pull/25827#issuecomment-2571694701 @XComp I retriggered a [follow-up PR](https://github.com/apache/flink/pull/25794) after this one has been merged: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildI

[jira] [Updated] (FLINK-33571) Bump json-path from 2.7.0 to 2.9.0

2025-01-05 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-33571: -- Fix Version/s: 1.19.2 > Bump json-path from 2.7.0 to 2.9.0 > -

[jira] [Commented] (FLINK-33571) Bump json-path from 2.7.0 to 2.9.0

2025-01-05 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909920#comment-17909920 ] Alexander Fedulov commented on FLINK-33571: --- *Merged to 1.19:* 3b334bd1b0d0162

Re: [PR] [FLINK-33571][table] Upgrade json-path from 2.7.0 to 2.9.0 [flink]

2025-01-05 Thread via GitHub
afedulov merged PR #25885: URL: https://github.com/apache/flink/pull/25885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Commented] (FLINK-36593) Upgrade io.airlift:aircompressor to mitigate CVE

2025-01-05 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909918#comment-17909918 ] Alexander Fedulov commented on FLINK-36593: --- Merged to 1.19: ff4243a7b4c25dd87

[jira] [Updated] (FLINK-36593) Upgrade io.airlift:aircompressor to mitigate CVE

2025-01-05 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov updated FLINK-36593: -- Fix Version/s: 1.19.2 > Upgrade io.airlift:aircompressor to mitigate CVE > ---

[jira] [Comment Edited] (FLINK-36593) Upgrade io.airlift:aircompressor to mitigate CVE

2025-01-05 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909918#comment-17909918 ] Alexander Fedulov edited comment on FLINK-36593 at 1/5/25 3:59 PM: ---

Re: [PR] [FLINK-36593][runtime] Backport io.airlift:aircompressor upgrade to 0.27 [flink]

2025-01-05 Thread via GitHub
afedulov merged PR #25886: URL: https://github.com/apache/flink/pull/25886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-34123][FLINK-35068][FLINK-36903] Introduce built-in serialization support for common collection types [flink]

2025-01-05 Thread via GitHub
X-czh commented on code in PR #25797: URL: https://github.com/apache/flink/pull/25797#discussion_r1903292910 ## flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfigImpl.java: ## @@ -356,6 +356,9 @@ public void configure(ReadableConfig configuration

[jira] [Commented] (FLINK-33117) a wrong scala example in udfs page

2025-01-05 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909877#comment-17909877 ] Alexander Fedulov commented on FLINK-33117: --- *Merged:* * master (2.0): fbf532

[jira] [Resolved] (FLINK-33117) a wrong scala example in udfs page

2025-01-05 Thread Alexander Fedulov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedulov resolved FLINK-33117. --- Resolution: Fixed > a wrong scala example in udfs page > ---

[jira] [Resolved] (FLINK-37006) Apply changes from FLINK-36277 to AdaptiveJoin

2025-01-05 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-37006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-37006. - Fix Version/s: 2.0.0 Resolution: Fixed > Apply changes from FLINK-36277 to Adapti

Re: [PR] [WIP][FLINK-36181] Use Java 17 by default [flink]

2025-01-05 Thread via GitHub
snuyanzin commented on PR #25898: URL: https://github.com/apache/flink/pull/25898#issuecomment-2571616830 @MartijnVisser I think you need to rebase to the latest master the failure seems to be related to the bug in master fixed within https://github.com/apache/flink/pull/25895 -- This

Re: [PR] [WIP][FLINK-36181] Use Java 17 by default [flink]

2025-01-05 Thread via GitHub
flinkbot commented on PR #25898: URL: https://github.com/apache/flink/pull/25898#issuecomment-2571590347 ## CI report: * a0684fd6aa67d81c3e117622b82495fe6c08fe41 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [WIP][FLINK-36181] Use Java 17 by default [flink]

2025-01-05 Thread via GitHub
MartijnVisser opened a new pull request, #25898: URL: https://github.com/apache/flink/pull/25898 ## What is the purpose of the change This PR is a Work In Progress, and will change Flink to use Java 17 by default. ## Brief change log ## Verifying this change