kurtostfeld commented on PR #25896:
URL: https://github.com/apache/flink/pull/25896#issuecomment-2572500238
The following test failure is caused by a test file, external to the main
git repo, that I don't have access to change. It simply needs Class<Byte>
changed to Class<? extends Byte>.
```
/tmp/junit13815350649750541837/CustomKryo.java:6: error: CustomKryo is not
abstract and does not override abstract method read(Kryo,Input,Class<? extends
Byte>) in Serializer
public class CustomKryo extends Serializer<Byte> implements Serializable {
```
This error with table seems like a flaky test that is unrelated to the
changes in this PR:
```
Jan 05 06:56:38 06:56:38.023 [ERROR]
AdaptiveJoinTest.testWithShuffleHashJoin:47 ast ==> expected: <
Jan 05 06:56:38 LogicalProject(a1=[$0], b1=[$1], c1=[$2], d1=[$3], a2=[$4],
b2=[$5], c2=[$6], d2=[$7])
Jan 05 06:56:38 +- LogicalFilter(condition=[=($0, $4)])
Jan 05 06:56:38 +- LogicalJoin(condition=[true], joinType=[inner])
Jan 05 06:56:38 :- LogicalTableScan(table=[[default_catalog,
default_database, T1, source: [TestTableSource(a1, b1, c1, d1)]]])
Jan 05 06:56:38 +- LogicalTableScan(table=[[default_catalog,
default_database, T2, source: [TestTableSource(a2, b2, c2, d2)]]])
Jan 05 06:56:38 > but was: <
Jan 05 06:56:38 LogicalProject(a1=[$0], b1=[$1], c1=[$2], d1=[$3], a2=[$4],
b2=[$5], c2=[$6], d2=[$7])
Jan 05 06:56:38 +- LogicalFilter(condition=[=($0, $4)])
Jan 05 06:56:38 +- LogicalJoin(condition=[true], joinType=[inner])
Jan 05 06:56:38 :- LogicalTableScan(table=[[default_catalog,
default_database, T1]])
Jan 05 06:56:38 +- LogicalTableScan(table=[[default_catalog,
default_database, T2]])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
