Re: [PR] [FLINK-36150] tables.exclude is still valid if scan.binlog.newly-added-table.enabled is true. [flink-cdc]

2024-08-25 Thread via GitHub
loserwang1024 commented on code in PR #3573: URL: https://github.com/apache/flink-cdc/pull/3573#discussion_r1730777101 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/schema/Selectors.java: ## @@ -0,0

Re: [PR] [FLINK-36150] tables.exclude is still valid if scan.binlog.newly-added-table.enabled is true. [flink-cdc]

2024-08-25 Thread via GitHub
loserwang1024 commented on code in PR #3573: URL: https://github.com/apache/flink-cdc/pull/3573#discussion_r1730770909 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/schema/Selectors.java: ## @@ -0,0

Re: [PR] [FLINK-34467] bump flink version to 1.20.0 [flink-connector-kafka]

2024-08-25 Thread via GitHub
AHeise commented on PR #111: URL: https://github.com/apache/flink-connector-kafka/pull/111#issuecomment-2309462158 > @AHeise Thanks for the reply. I totally understand the pain points of maintain multiple flink version compatibility for a connector. In each Flink release, there are always

Re: [PR] [FLINK-36150] tables.exclude is still valid if scan.binlog.newly-added-table.enabled is true. [flink-cdc]

2024-08-25 Thread via GitHub
ruanhang1993 commented on code in PR #3573: URL: https://github.com/apache/flink-cdc/pull/3573#discussion_r1730759323 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-mysql-cdc/src/main/java/org/apache/flink/cdc/connectors/mysql/schema/Selectors.java: ## @@ -0,0

[jira] [Closed] (FLINK-35809) Deploying Flink History Server and Flink SQL Gateway via Flink Operator.

2024-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 钟洋洋 closed FLINK-35809. --- Resolution: Fixed > Deploying Flink History Server and Flink SQL Gateway via Flink Operator. > -

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-25 Thread via GitHub
mayuehappy commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2309420675 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-36148][pipeline-connector][mysql] Add custom parser for CreateTableEvent [flink-cdc]

2024-08-25 Thread via GitHub
lvyanquan commented on code in PR #3570: URL: https://github.com/apache/flink-cdc/pull/3570#discussion_r1730722065 ## flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlPipelineITCase.java: #

[jira] [Updated] (FLINK-36146) NoSuchElement exception from SingleThreadFetcherManager

2024-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-36146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kim Gräsman updated FLINK-36146: Environment: AWS EMR/Yarn (was: N/A) > NoSuchElement exception from SingleThreadFetcherManager >

Re: [PR] [FLINK-35177] Fix DataGen Connector documentation [flink]

2024-08-25 Thread via GitHub
snuyanzin commented on PR #24692: URL: https://github.com/apache/flink/pull/24692#issuecomment-2309389579 the idea is to have same example both in doc and example module where compilation is checked during ci process -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [FLINK-35964][table] Add the built-in function STARTSWITH & ENDSWITH [flink]

2024-08-25 Thread via GitHub
lincoln-lil commented on code in PR #25156: URL: https://github.com/apache/flink/pull/25156#discussion_r1730692658 ## flink-python/pyflink/table/expression.py: ## @@ -1028,6 +1028,16 @@ def truncate(self, n: Union[int, 'Expression[int]'] = 0) -> 'Expression[T]': # --

[jira] [Comment Edited] (FLINK-35859) [flink-cdc] Fix: The assigner is not ready to offer finished split information, this should not be called

2024-08-25 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876584#comment-17876584 ] Hongshun Wang edited comment on FLINK-35859 at 8/26/24 5:45 AM: --

[jira] [Comment Edited] (FLINK-35859) [flink-cdc] Fix: The assigner is not ready to offer finished split information, this should not be called

2024-08-25 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876584#comment-17876584 ] Hongshun Wang edited comment on FLINK-35859 at 8/26/24 5:45 AM: --

[jira] [Commented] (FLINK-35859) [flink-cdc] Fix: The assigner is not ready to offer finished split information, this should not be called

2024-08-25 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876584#comment-17876584 ] Hongshun Wang commented on FLINK-35859: --- [~pacinogong] the docs of AssignerStatus

Re: [PR] [FLINK-35850][table] Add the built-in function DATEDIFF [flink]

2024-08-25 Thread via GitHub
flinkbot commented on PR #25254: URL: https://github.com/apache/flink/pull/25254#issuecomment-2309366807 ## CI report: * 833d174116d4cf9cff4caa763214abfffa109ee5 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35850) Add DATEDIFF function

2024-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35850: --- Labels: pull-request-available (was: ) > Add DATEDIFF function > - > >

[PR] [FLINK-35850][table] Add the built-in function DATEDIFF [flink]

2024-08-25 Thread via GitHub
dylanhz opened a new pull request, #25254: URL: https://github.com/apache/flink/pull/25254 ## What is the purpose of the change Add the built-in function DATEDIFF. Examples: ```SQL > SELECT DATEDIFF('2009-07-31', '2009-07-30'); 1 > SELECT DATEDIFF('2009-07-30', '200

Re: [PR] [FLINK-36117] Implement AsyncKeyedStateBackend for RocksDBKeyedStateBackend and HeapKeyedStateBackend [flink]

2024-08-25 Thread via GitHub
Zakelly commented on code in PR #25233: URL: https://github.com/apache/flink/pull/25233#discussion_r1730658801 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/v2/ValueStateWrapper.java: ## @@ -0,0 +1,87 @@ +// +// Source code recreated from a .class file by Intelli

Re: [PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-25 Thread via GitHub
flinkbot commented on PR #25253: URL: https://github.com/apache/flink/pull/25253#issuecomment-2309236263 ## CI report: * df3cd8e4998d6289622c426e94c52023e15b75a8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Resolved] (FLINK-36039) Support clean historical event handler records in JDBC event handler

2024-08-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-36039. - Fix Version/s: kubernetes-operator-1.10.0 Resolution: Fixed Merged to main(1.10.0) via: 6a426b2ff

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-25 Thread via GitHub
1996fanrui merged PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

Re: [PR] [FLINK-26944][table] Add the built-in function ADD_MONTHS [flink]

2024-08-25 Thread via GitHub
flinkbot commented on PR #25252: URL: https://github.com/apache/flink/pull/25252#issuecomment-2309230928 ## CI report: * 47ce8c16deeb3c373c47d6c99edb8dce50723759 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35579) Update the FrocksDB version in FLINK

2024-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35579: --- Labels: pull-request-available (was: ) > Update the FrocksDB version in FLINK > ---

[PR] [FLINK-35579] update frocksdb version to v8.10.0 [flink]

2024-08-25 Thread via GitHub
mayuehappy opened a new pull request, #25253: URL: https://github.com/apache/flink/pull/25253 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

[PR] [FLINK-26944][table] Add the built-in function ADD_MONTHS [flink]

2024-08-25 Thread via GitHub
dylanhz opened a new pull request, #25252: URL: https://github.com/apache/flink/pull/25252 ## What is the purpose of the change Add the built-in function ADD_MONTHS. Examples: ```SQL > SELECT ADD_MONTHS('2016-08-31', 1); 2016-09-30 > SELECT ADD_MONTHS('2016-08-31',

Re: [PR] [FLINK-26943][table] Add the built-in function DATE_ADD [flink]

2024-08-25 Thread via GitHub
dylanhz commented on code in PR #24988: URL: https://github.com/apache/flink/pull/24988#discussion_r1730611766 ## docs/data/sql_functions.yml: ## @@ -653,6 +653,16 @@ temporal: CURRENT_WATERMARK(ts) IS NULL OR ts > CURRENT_WATERMARK(ts) ``` + - sql: DAT

Re: [PR] [FLINK-36100][table] Support ESCAPE in built-in function LIKE [flink]

2024-08-25 Thread via GitHub
lincoln-lil commented on PR #25225: URL: https://github.com/apache/flink/pull/25225#issuecomment-2309221648 Also verified the result with escaping characters, all results with supported patterns are consistent with mysql: ![image](https://github.com/user-attachments/assets/51919cb7-fb44-

Re: [PR] [FLINK-36100][table] Support ESCAPE in built-in function LIKE [flink]

2024-08-25 Thread via GitHub
lincoln-lil commented on code in PR #25225: URL: https://github.com/apache/flink/pull/25225#discussion_r1730585595 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala: ## @@ -387,55 +387,91 @@ class ScalarFunctio

[jira] [Commented] (FLINK-36005) Specify to get part of the potgresql field

2024-08-25 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-36005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876569#comment-17876569 ] 宇宙先生 commented on FLINK-36005: -- who  focus on the issu? thanks,I think it is a valueable iu

[jira] [Assigned] (FLINK-36153) MySQL fails to handle schema change events In Timestamp or Earliest Offset startup mode

2024-08-25 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36153: -- Assignee: yux > MySQL fails to handle schema change events In Timestamp or Earliest Offset >

[jira] [Comment Edited] (FLINK-36141) [mysql]Set the scanNewlyAddedTableEnabled is true, but does not support automatic capture new added table

2024-08-25 Thread zhongyuandong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876218#comment-17876218 ] zhongyuandong edited comment on FLINK-36141 at 8/26/24 2:28 AM: --

[jira] [Assigned] (FLINK-36100) Support ESCAPE in built-in function LIKE formally

2024-08-25 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-36100: --- Assignee: Dylan He > Support ESCAPE in built-in function LIKE formally > --

[jira] [Commented] (FLINK-36131) FlinkSQL upgraded from 1.13.1 to 1.18.1 metrics does not display data

2024-08-25 Thread mumu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876564#comment-17876564 ] mumu commented on FLINK-36131: -- [~hackergin]  I am using Flink-sql-connector-kafka-3.0.2. j

Re: [PR] [FLINK-35177] Fix DataGen Connector documentation [flink]

2024-08-25 Thread via GitHub
morozov commented on PR #24692: URL: https://github.com/apache/flink/pull/24692#issuecomment-2309145899 > how about having the same approach both in docs and in this example? @snuyanzin what exactly do you propose? -- This is an automated message from the Apache Git Service. To resp

Re: [PR] [FLINK-36142][table] Remove TestTableSourceWithTime and its subclasses to prepare removing TableEnvironmentInternal#registerTableSourceInternal [flink]

2024-08-25 Thread via GitHub
xuyangzhong commented on PR #25243: URL: https://github.com/apache/flink/pull/25243#issuecomment-2309129941 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[jira] [Updated] (FLINK-36153) MySQL fails to handle schema change events In Timestamp or Earliest Offset startup mode

2024-08-25 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yux updated FLINK-36153: Issue Type: Bug (was: Improvement) > MySQL fails to handle schema change events In Timestamp or Earliest Offset

[jira] [Created] (FLINK-36153) MySQL fails to handle schema change events In Timestamp or Earliest Offset startup mode

2024-08-25 Thread yux (Jira)
yux created FLINK-36153: --- Summary: MySQL fails to handle schema change events In Timestamp or Earliest Offset startup mode Key: FLINK-36153 URL: https://issues.apache.org/jira/browse/FLINK-36153 Project: Flink

[jira] [Commented] (FLINK-36153) MySQL fails to handle schema change events In Timestamp or Earliest Offset startup mode

2024-08-25 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876559#comment-17876559 ] yux commented on FLINK-36153: - [~Leonard] Please assign this to me. > MySQL fails to handle

[jira] [Updated] (FLINK-36151) Add documentations for Schema Evolution related options

2024-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36151: --- Labels: pull-request-available (was: ) > Add documentations for Schema Evolution related op

[PR] [FLINK-36151] Add schema evolution related docs [flink-cdc]

2024-08-25 Thread via GitHub
yuxiqian opened a new pull request, #3575: URL: https://github.com/apache/flink-cdc/pull/3575 This closes FLINK-36151 by adding missing schema evolution related concepts into Flink CDC docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [FLINK-34467] bump flink version to 1.20.0 [flink-connector-kafka]

2024-08-25 Thread via GitHub
HuangZhenQiu commented on PR #111: URL: https://github.com/apache/flink-connector-kafka/pull/111#issuecomment-2309083950 I think we can drop support for flink 1.17 and flink 1.18 first in this PR https://github.com/apache/flink-connector-kafka/pull/102. -- This is an automated message fr

[jira] [Updated] (FLINK-35589) Support MemorySize type in FlinkCDC ConfigOptions

2024-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35589: --- Labels: pull-request-available (was: ) > Support MemorySize type in FlinkCDC ConfigOptions

Re: [PR] [FLINK-35589][cdc-common] Support MemorySize type in FlinkCDC ConfigOptions. [flink-cdc]

2024-08-25 Thread via GitHub
github-actions[bot] commented on PR #3437: URL: https://github.com/apache/flink-cdc/pull/3437#issuecomment-2309056140 This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. --

Re: [PR] [FLINK-36152] Fix incorrect type extraction in case of cascaded inheritance when DataTypeHint is not configured [flink]

2024-08-25 Thread via GitHub
flinkbot commented on PR #25251: URL: https://github.com/apache/flink/pull/25251#issuecomment-2309047657 ## CI report: * 3f1b92e8d262a3a601624ade2b17bf126f553117 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36152) Traverse through the superclass hierarchy to extract generic type.

2024-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36152: --- Labels: pull-request-available (was: ) > Traverse through the superclass hierarchy to extra

[PR] [FLINK-36152] Fix incorrect type extraction in case of cascaded inheritance when DataTypeHint is not configured [flink]

2024-08-25 Thread via GitHub
littleeleventhwolf opened a new pull request, #25251: URL: https://github.com/apache/flink/pull/25251 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transfer

[jira] [Created] (FLINK-36152) Traverse through the superclass hierarchy to extract generic type.

2024-08-25 Thread Xinglong Wang (Jira)
Xinglong Wang created FLINK-36152: - Summary: Traverse through the superclass hierarchy to extract generic type. Key: FLINK-36152 URL: https://issues.apache.org/jira/browse/FLINK-36152 Project: Flink

Re: [PR] [FLINK-34467] bump flink version to 1.20.0 [flink-connector-kafka]

2024-08-25 Thread via GitHub
HuangZhenQiu commented on PR #111: URL: https://github.com/apache/flink-connector-kafka/pull/111#issuecomment-2309026627 @AHeise Thanks for the reply. I totally understand the pain points of maintain multiple flink version compatibility for a connector. In each Flink release, there are

Re: [PR] [FLINK-35177] Fix DataGen Connector documentation [flink]

2024-08-25 Thread via GitHub
snuyanzin commented on PR #24692: URL: https://github.com/apache/flink/pull/24692#issuecomment-2308984427 if we are talking about examples there is already existing one in examples module which is quite close to the one from description https://github.com/apache/flink/blob/4faf0966766

Re: [PR] [FLINK-34505][table] Migrate WindowGroupReorderRule to java. [flink]

2024-08-25 Thread via GitHub
snuyanzin commented on PR #24375: URL: https://github.com/apache/flink/pull/24375#issuecomment-2308961960 still failing on ci -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-34555][table] Migrate JoinConditionTypeCoerceRule to java. [flink]

2024-08-25 Thread via GitHub
snuyanzin commented on code in PR #24420: URL: https://github.com/apache/flink/pull/24420#discussion_r1730414834 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinConditionTypeCoerceRule.java: ## @@ -0,0 +1,178 @@ +/* + * Lice

[jira] [Commented] (FLINK-36145) Change JobSpec.flinkStateSnapshotReference to snapshotReference

2024-08-25 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876534#comment-17876534 ] Thomas Weise commented on FLINK-36145: -- `snapshotReference` sounds a bit misleading

[jira] [Commented] (FLINK-36145) Change JobSpec.flinkStateSnapshotReference to snapshotReference

2024-08-25 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876532#comment-17876532 ] Gyula Fora commented on FLINK-36145: [~mateczagany] let's hold off on this for a lit

Re: [PR] [FLINK-35177] Fix DataGen Connector documentation [flink]

2024-08-25 Thread via GitHub
morozov commented on PR #24692: URL: https://github.com/apache/flink/pull/24692#issuecomment-2308895535 @GOODBOY008 done. FWIW, you can reference code blocks right on GitHub. This way, then are better readable and could be navigated to: https://github.com/apache/flink/blob/4faf096676

[jira] [Updated] (FLINK-36145) Change JobSpec.flinkStateSnapshotReference to snapshotReference

2024-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36145: --- Labels: pull-request-available (was: ) > Change JobSpec.flinkStateSnapshotReference to snap

[PR] [FLINK-36145][snapshot] Rename flinkStateSnapshotReference to snapshotReference [flink-kubernetes-operator]

2024-08-25 Thread via GitHub
mateczagany opened a new pull request, #870: URL: https://github.com/apache/flink-kubernetes-operator/pull/870 ## What is the purpose of the change Rename JobSpec.flinkStateSnapshotReference to JobSpec.snapshotReference. This should make less verbose and easier to memorize for users.

[jira] [Commented] (FLINK-36145) Change JobSpec.flinkStateSnapshotReference to snapshotReference

2024-08-25 Thread Mate Czagany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876505#comment-17876505 ] Mate Czagany commented on FLINK-36145: -- I think snapshotReference would work well.

[jira] [Created] (FLINK-36151) Add documentations for Schema Evolution related options

2024-08-25 Thread yux (Jira)
yux created FLINK-36151: --- Summary: Add documentations for Schema Evolution related options Key: FLINK-36151 URL: https://issues.apache.org/jira/browse/FLINK-36151 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-36128] Promote LENIENT as the default schema change behavior [flink-cdc]

2024-08-25 Thread via GitHub
yuxiqian commented on code in PR #3574: URL: https://github.com/apache/flink-cdc/pull/3574#discussion_r1730302627 ## flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/parser/YamlPipelineDefinitionParser.java: ## @@ -172,6 +183,23 @@ private SinkDef toSinkDef(JsonNode sinkNode

Re: [PR] [FLINK-36128] Promote LENIENT as the default schema change behavior [flink-cdc]

2024-08-25 Thread via GitHub
leonardBang commented on code in PR #3574: URL: https://github.com/apache/flink-cdc/pull/3574#discussion_r1730301097 ## flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/parser/YamlPipelineDefinitionParser.java: ## @@ -172,6 +183,23 @@ private SinkDef toSinkDef(JsonNode sinkN

[jira] [Updated] (FLINK-36128) Promote LENIENT mode as the default schema evolution behavior

2024-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36128: --- Labels: pull-request-available (was: ) > Promote LENIENT mode as the default schema evoluti

[PR] [FLINK-36128] Promote LENIENT as the default schema change behavior [flink-cdc]

2024-08-25 Thread via GitHub
yuxiqian opened a new pull request, #3574: URL: https://github.com/apache/flink-cdc/pull/3574 This closes FLINK-36128. Currently, default schema evolution mode "EVOLVE" could not handle exceptions, and might not be able to restore from existing state correctly after failover. Before

[jira] [Updated] (FLINK-36150) tables.exclude is not valid if scan.binlog.newly-added-table.enabled is true.

2024-08-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36150: --- Labels: pull-request-available (was: ) > tables.exclude is not valid if scan.binlog.newly-a

[jira] [Commented] (FLINK-36150) tables.exclude is not valid if scan.binlog.newly-added-table.enabled is true.

2024-08-25 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876487#comment-17876487 ] Hongshun Wang commented on FLINK-36150: --- I'd like to do it. > tables.exclude is n

[jira] [Created] (FLINK-36150) tables.exclude is not valid if scan.binlog.newly-added-table.enabled is true.

2024-08-25 Thread Hongshun Wang (Jira)
Hongshun Wang created FLINK-36150: - Summary: tables.exclude is not valid if scan.binlog.newly-added-table.enabled is true. Key: FLINK-36150 URL: https://issues.apache.org/jira/browse/FLINK-36150 Proje

Re: [PR] [FLINK-35444][pipeline-connector][paimon] Paimon Pipeline Connector support changing column names to lowercase for Hive metastore [flink-cdc]

2024-08-25 Thread via GitHub
kyzheng196 commented on code in PR #3569: URL: https://github.com/apache/flink-cdc/pull/3569#discussion_r1730277217 ## flink-cdc-common/src/main/java/org/apache/flink/cdc/common/schema/Schema.java: ## @@ -396,6 +397,9 @@ private void checkColumn(String columnName, DataType type)