leonardBang commented on code in PR #3574:
URL: https://github.com/apache/flink-cdc/pull/3574#discussion_r1730301097
##########
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/parser/YamlPipelineDefinitionParser.java:
##########
@@ -172,6 +183,23 @@ private SinkDef toSinkDef(JsonNode sinkNode) {
Optional.ofNullable(sinkNode.get(EXCLUDE_SCHEMA_EVOLUTION_TYPES))
.ifPresent(e -> e.forEach(tag ->
excludedSETypes.add(tag.asText())));
+ if (includedSETypes.isEmpty()) {
+ // If no schema evolution types are specified, include all schema
evolution types by
+ // default.
+ Arrays.stream(SchemaChangeEventTypeFamily.ALL)
+ .map(SchemaChangeEventType::getTag)
+ .forEach(includedSETypes::add);
+ }
+
+ if (excludedSETypes.isEmpty()
+ && SchemaChangeBehavior.LENIENT.equals(schemaChangeBehavior)) {
+ // In lenient mode, we exclude DROP_TABLE and TRUNCATE_TABLE by
default. This could be
+ // overridden by manually specifying excluded types.
Review Comment:
minor: we should add schema behavior document ASAP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
