[jira] [Updated] (FLINK-36055) Change flink.connector.elasticsearch.version to a release version

2024-08-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36055: --- Labels: pull-request-available (was: ) > Change flink.connector.elasticsearch.version to a

[PR] [FLINK-36055] change flink.connector.elasticsearch.version to a release version [flink-cdc]

2024-08-13 Thread via GitHub
proletarians opened a new pull request, #3542: URL: https://github.com/apache/flink-cdc/pull/3542 change flink.connector.elasticsearch.version to a release version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FLINK-36054][cdc][build] Fix Flink CDC parent pom and release scripts [flink-cdc]

2024-08-13 Thread via GitHub
PatrickRen merged PR #3540: URL: https://github.com/apache/flink-cdc/pull/3540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[jira] [Created] (FLINK-36055) Change flink.connector.elasticsearch.version to a release version

2024-08-13 Thread wuzexian (Jira)
wuzexian created FLINK-36055: Summary: Change flink.connector.elasticsearch.version to a release version Key: FLINK-36055 URL: https://issues.apache.org/jira/browse/FLINK-36055 Project: Flink Is

Re: [PR] [WIP]Local shuffle [flink]

2024-08-13 Thread via GitHub
codenohup closed pull request #23008: [WIP]Local shuffle URL: https://github.com/apache/flink/pull/23008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-13 Thread via GitHub
RocMarshal commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1716379053 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -121,4 +121,11 @@

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-13 Thread via GitHub
RocMarshal commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1716377459 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/StandaloneAutoscalerExecutor.java: ## @@ -113,6 +113,8 @@ public

Re: [PR] [FLINK-34510][Runtime/State]Rename RestoreMode to RecoveryClaimMode [flink]

2024-08-13 Thread via GitHub
spoon-lz commented on PR #25192: URL: https://github.com/apache/flink/pull/25192#issuecomment-2287950544 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (FLINK-36052) add elasticsearch.md for elasticsearch pipeline connector

2024-08-13 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-36052: -- Assignee: wuzexian > add elasticsearch.md for elasticsearch pipeline connector >

Re: [PR] [FLINK-35935][table] Fix RTAS not supporting LIMIT [flink]

2024-08-13 Thread via GitHub
xuyangzhong commented on PR #25185: URL: https://github.com/apache/flink/pull/25185#issuecomment-2287900055 Hi, @lincoln-lil . The reason is: The plan will be optimized to `source -> exchange (single) -> limit`. Theoretically, if the source outputs data with multi parallelism, it could resu

[jira] [Closed] (FLINK-36003) Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate

2024-08-13 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-36003. Resolution: Fixed Fixed in master: 268144c30fab7704e713ccfcda0c3e6be3857660 > Add CompiledPlan an

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
twalthr merged PR #25197: URL: https://github.com/apache/flink/pull/25197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
twalthr commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1716332741 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/BatchRestoreTestBase.java: ## @@ -228,10 +228,9 @@ void loadAn

Re: [PR] [FLINK-36004] Deep copy the BinaryArrayData in ArrayDataSerializer#copy while using custom ArrayData [flink]

2024-08-13 Thread via GitHub
xccui commented on PR #25196: URL: https://github.com/apache/flink/pull/25196#issuecomment-2287858287 Btw, Jingsong mentioned that the bug has been fixed in Paimon a few months ago and they forgot to port it back to Flink :sweat_smile: https://github.com/apache/paimon/blob/master/paimon-

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-13 Thread via GitHub
1996fanrui commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1716301360 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/event/JdbcEventInteractor.java: ## @@ -152,4 +154,49 @@ protected Lis

Re: [PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-13 Thread via GitHub
1996fanrui commented on code in PR #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1716291506 ## flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java: ## @@ -121,4 +121,11 @@

Re: [PR] [FLINK-36004] Deep copy the BinaryArrayData in ArrayDataSerializer#copy while using custom ArrayData [flink]

2024-08-13 Thread via GitHub
xuyangzhong commented on PR #25196: URL: https://github.com/apache/flink/pull/25196#issuecomment-2287819872 Hi, @xccui . I have check all subtasks of TypeSerializer. There’s a class `MapDataSerializer` that seems to exhibit the same issue pattern but operates correctly. I have also added th

[jira] [Updated] (FLINK-36054) Cleanup Flink CDC pom and release scripts

2024-08-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36054: --- Labels: pull-request-available (was: ) > Cleanup Flink CDC pom and release scripts > --

[jira] [Created] (FLINK-36054) Cleanup Flink CDC pom and release scripts

2024-08-13 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-36054: - Summary: Cleanup Flink CDC pom and release scripts Key: FLINK-36054 URL: https://issues.apache.org/jira/browse/FLINK-36054 Project: Flink Issue Type: Impro

[jira] [Created] (FLINK-36053) Support multi-version integration test in mongodb connector

2024-08-13 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-36053: -- Summary: Support multi-version integration test in mongodb connector Key: FLINK-36053 URL: https://issues.apache.org/jira/browse/FLINK-36053 Project: Flink Issu

Re: [PR] [docs][minor] Correct Typos in Documentation/Code [flink-cdc]

2024-08-13 Thread via GitHub
yuxiqian commented on code in PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#discussion_r1716246562 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/schema/MetadataColumnSerializer.java: ## Review Comment: Serializer is a part of rele

Re: [PR] [docs][minor] Correct Typos in Documentation/Code [flink-cdc]

2024-08-13 Thread via GitHub
yuxiqian commented on code in PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#discussion_r1716246562 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/serializer/schema/MetadataColumnSerializer.java: ## Review Comment: Serializer is a part of dist

[jira] [Updated] (FLINK-36052) add elasticsearch.md for elasticsearch pipeline connector

2024-08-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36052: --- Labels: pull-request-available (was: ) > add elasticsearch.md for elasticsearch pipeline co

[jira] [Created] (FLINK-36052) add elasticsearch.md for elasticsearch pipeline connector

2024-08-13 Thread wuzexian (Jira)
wuzexian created FLINK-36052: Summary: add elasticsearch.md for elasticsearch pipeline connector Key: FLINK-36052 URL: https://issues.apache.org/jira/browse/FLINK-36052 Project: Flink Issue Type:

Re: [PR] [docs][minor] Correct Typos in Documentation/Code [flink-cdc]

2024-08-13 Thread via GitHub
Karl-WangSK commented on PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#issuecomment-2287716509 ready to merge @leonardBang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Updated] (FLINK-36039) Support clean historical event handler records in JDBC event handler

2024-08-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36039: --- Labels: pull-request-available (was: ) > Support clean historical event handler records in

[PR] [FLINK-36039][autoscaler] Support clean historical event handler records in JDBC event handler [flink-kubernetes-operator]

2024-08-13 Thread via GitHub
RocMarshal opened a new pull request, #865: URL: https://github.com/apache/flink-kubernetes-operator/pull/865 ## What is the purpose of the change Support clean historical event handler records in JDBC event handler ## Brief change log https://github.com/u

[jira] [Updated] (FLINK-36039) Support clean historical event handler records in JDBC event handler

2024-08-13 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-36039: --- Description: Currently, the autoscaler generates a large amount of historical data for event handle

Re: [PR] Optimize log level [flink-cdc]

2024-08-13 Thread via GitHub
yuxiqian commented on code in PR #3538: URL: https://github.com/apache/flink-cdc/pull/3538#discussion_r1716222841 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaManager.java: ## @@ -224,7 +224,7 @@ private void handleCreateTabl

Re: [PR] [FLINK-36046] Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction to use the new interfaces [f

2024-08-13 Thread via GitHub
zhaomin1423 commented on PR #25199: URL: https://github.com/apache/flink/pull/25199#issuecomment-2287697630 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Optimize log level [flink-cdc]

2024-08-13 Thread via GitHub
yuxiqian commented on PR #3538: URL: https://github.com/apache/flink-cdc/pull/3538#issuecomment-2287697538 Hi @melin, seems the error log message you want to emit is `Handling schema request` in `SchemaRegistry`, which will be printed when an **schema lookup request** occurs. Changing it to

[jira] [Updated] (FLINK-36039) Support clean historical event handler records in JDBC event handler

2024-08-13 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] RocMarshal updated FLINK-36039: --- Description: Currently, the autoscaler generates a large amount of historical data for event handle

[jira] [Commented] (FLINK-18476) PythonEnvUtilsTest#testStartPythonProcess fails

2024-08-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873379#comment-17873379 ] Weijie Guo commented on FLINK-18476: https://dev.azure.com/apache-flink/apache-flink

[jira] [Commented] (FLINK-35810) AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteUnorderedWithRetry fails

2024-08-13 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873378#comment-17873378 ] Weijie Guo commented on FLINK-35810: https://dev.azure.com/apache-flink/apache-flink

[jira] [Updated] (FLINK-36051) JDBC sink doesn't re-prepare invalidated prepared statements

2024-08-13 Thread Sergei Morozov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergei Morozov updated FLINK-36051: --- Description: An SQL Server sink connector may fail with the following exception: {code} jav

[jira] [Updated] (FLINK-36044) In flink-connector-mysql-cdc-2.4.0 version, scan.snapshot.fetch.size does not take effect

2024-08-13 Thread zhanghuaibei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhanghuaibei updated FLINK-36044: - Description: In version 2.4 of the code, scan.snapshot.fetch.size was not read and loaded. In t

Re: [PR] [FLINK-36051] Re-prepare invalid statement even if connection is valid [flink-connector-jdbc]

2024-08-13 Thread via GitHub
boring-cyborg[bot] commented on PR #138: URL: https://github.com/apache/flink-connector-jdbc/pull/138#issuecomment-2287534411 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[jira] [Updated] (FLINK-36051) JDBC sink doesn't re-prepare invalidated prepared statements

2024-08-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36051: --- Labels: pull-request-available (was: ) > JDBC sink doesn't re-prepare invalidated prepared

[PR] [FLINK-36051] Re-prepare invalid statement even if connection is valid [flink-connector-jdbc]

2024-08-13 Thread via GitHub
morozov opened a new pull request, #138: URL: https://github.com/apache/flink-connector-jdbc/pull/138 An SQL Server sink connector may fail with the following exception: ``` java.io.IOException: Writing records to JDBC failed. at org.apache.flink.connector.jdbc.internal.Jdb

[jira] [Created] (FLINK-36051) JDBC sink doesn't re-prepare invalidated prepared statements

2024-08-13 Thread Sergei Morozov (Jira)
Sergei Morozov created FLINK-36051: -- Summary: JDBC sink doesn't re-prepare invalidated prepared statements Key: FLINK-36051 URL: https://issues.apache.org/jira/browse/FLINK-36051 Project: Flink

Re: [PR] [FLINK-35716] Adds a rule which splits out async calls from join cond… [flink]

2024-08-13 Thread via GitHub
AlanConfluent commented on code in PR #24992: URL: https://github.com/apache/flink/pull/24992#discussion_r1716097851 ## flink-table/flink-table-planner/src/test/resources/org/apache/flink/table/planner/plan/rules/logical/AsyncCalcSplitRuleTest.xml: ## @@ -550,6 +550,33 @@ AsyncC

[jira] [Updated] (FLINK-36044) In flink-connector-mysql-cdc-2.4.0 version, scan.snapshot.fetch.size does not take effect

2024-08-13 Thread zhanghuaibei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhanghuaibei updated FLINK-36044: - Summary: In flink-connector-mysql-cdc-2.4.0 version, scan.snapshot.fetch.size does not take effe

Re: [PR] [FLINK-35716] Adds a rule which splits out async calls from join cond… [flink]

2024-08-13 Thread via GitHub
AlanConfluent commented on PR #24992: URL: https://github.com/apache/flink/pull/24992#issuecomment-2287466371 > I have't spend too much thought on this but some pointers to verify that the rewrite is actually correct: https://stackoverflow.com/questions/55893354/predicate-pushdown-vs-on-cla

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
jnh5y commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715953469 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/BatchRestoreTestBase.java: ## @@ -228,10 +228,9 @@ void loadAndR

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
jnh5y commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715952407 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/BatchRestoreTestBase.java: ## @@ -228,10 +228,9 @@ void loadAndR

Re: [PR] [FLINK-35500][Connectors/DynamoDB] DynamoDb Table API Sink fails to delete elements due to key not found [flink-connector-aws]

2024-08-13 Thread via GitHub
robg-eb commented on PR #152: URL: https://github.com/apache/flink-connector-aws/pull/152#issuecomment-2287168263 I addressed all the open comments from @z3d1k now. Thank you all for the suggestions! Sounds like @hlteoh37 is the next who should take a look? -- This is an automated m

Re: [PR] [FLINK-35500][Connectors/DynamoDB] DynamoDb Table API Sink fails to delete elements due to key not found [flink-connector-aws]

2024-08-13 Thread via GitHub
robg-eb commented on code in PR #152: URL: https://github.com/apache/flink-connector-aws/pull/152#discussion_r1715947510 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/table/RowDataToAttributeValueConverterTest.java: ## @@ -547

Re: [PR] [FLINK-35500][Connectors/DynamoDB] DynamoDb Table API Sink fails to delete elements due to key not found [flink-connector-aws]

2024-08-13 Thread via GitHub
robg-eb commented on code in PR #152: URL: https://github.com/apache/flink-connector-aws/pull/152#discussion_r1715947230 ## flink-connector-aws/flink-connector-dynamodb/src/test/java/org/apache/flink/connector/dynamodb/table/RowDataElementConverterTest.java: ## @@ -45,10 +48,17

[jira] [Updated] (FLINK-36050) Support enhanced `show views` statement

2024-08-13 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36050: Description: The issue is similar to table related one FLINK-25631 Enhanced {{SHOW VIEWS}

[jira] [Updated] (FLINK-36050) Support enhanced `show views` statement

2024-08-13 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36050: Description: The issue is similar to table related one FLINK-25631 Enhanced {{SHOW VIEWS}

[jira] [Updated] (FLINK-36050) Support enhanced `show views` statement

2024-08-13 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36050: Description: The issue is similar to table related one FLINK-25631 Enhanced `show views`

[jira] [Updated] (FLINK-36050) Support enhanced `show views` statement

2024-08-13 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-36050: Description: The issue is similar to table related one FLINK-25631 Enhanced `show views`

Re: [PR] [FLINK-35822] Introduce DESCRIBE FUNCTION [flink]

2024-08-13 Thread via GitHub
AlanConfluent commented on code in PR #25115: URL: https://github.com/apache/flink/pull/25115#discussion_r1715867591 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/DescribeFunctionOperation.java: ## @@ -0,0 +1,129 @@ +/* + * Licensed to the A

Re: [PR] [FLINK-33607][build]: Add checksum verification for Maven wrapper [flink]

2024-08-13 Thread via GitHub
XComp commented on PR #24852: URL: https://github.com/apache/flink/pull/24852#issuecomment-2287038369 Sorry for the delay. Let's get this PR merged. Can you fix the PRs commit history: * There shouldn't be any merge commit but only a single commit containing the actual change (just rebas

[jira] [Created] (FLINK-36049) Add CompiledPlan annotations to BatchExecSortLimit

2024-08-13 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-36049: -- Summary: Add CompiledPlan annotations to BatchExecSortLimit Key: FLINK-36049 URL: https://issues.apache.org/jira/browse/FLINK-36049 Project: Flink Issue Type: Su

[jira] [Created] (FLINK-36048) Add CompiledPlan annotations to BatchExecRank

2024-08-13 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-36048: -- Summary: Add CompiledPlan annotations to BatchExecRank Key: FLINK-36048 URL: https://issues.apache.org/jira/browse/FLINK-36048 Project: Flink Issue Type: Sub-tas

[jira] [Created] (FLINK-36047) Add CompiledPlan annotations to BatchExecOverAggregate

2024-08-13 Thread Jim Hughes (Jira)
Jim Hughes created FLINK-36047: -- Summary: Add CompiledPlan annotations to BatchExecOverAggregate Key: FLINK-36047 URL: https://issues.apache.org/jira/browse/FLINK-36047 Project: Flink Issue Type

Re: [PR] [FLINK-36046] Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction to use the new interfaces [f

2024-08-13 Thread via GitHub
flinkbot commented on PR #25199: URL: https://github.com/apache/flink/pull/25199#issuecomment-2286687330 ## CI report: * 4911715bfa60f96cf0c3fa766510f38ce271f519 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36046) Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction to use the new inter

2024-08-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36046: --- Labels: pull-request-available (was: ) > Change the existing > org.apache.flink.streaming.

[PR] [FLINK-36046] Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction to use the new interfaces [flink

2024-08-13 Thread via GitHub
zhaomin1423 opened a new pull request, #25199: URL: https://github.com/apache/flink/pull/25199 ## What is the purpose of the change Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction

[jira] [Created] (FLINK-36046) Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction to use the new inter

2024-08-13 Thread Min Zhao (Jira)
Min Zhao created FLINK-36046: Summary: Change the existing org.apache.flink.streaming.api.functions.sink#DiscardingSink and org.apache.flink.streaming.api.functions.sink#PrintSinkFunction to use the new interfaces Key: FLINK-36046

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
jnh5y commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715558999 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -63,6 +69,8 @@ public final class SinkTestStep extends Tabl

Re: [PR] [FLINK-36038][table] Output for `SHOW CREATE VIEW` should follow the `CREATE VIEW` syntax [flink]

2024-08-13 Thread via GitHub
snuyanzin merged PR #25195: URL: https://github.com/apache/flink/pull/25195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[jira] [Resolved] (FLINK-36038) SHOW CREATE VIEW returns invalid query

2024-08-13 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-36038. - Fix Version/s: 2.0.0 Resolution: Fixed Merged as [2cde5613129b1343bf473c55511b56

Re: [PR] [FLINK-35886][task] Fix watermark idleness timeout accounting when subtask is backpressured/blocked [flink]

2024-08-13 Thread via GitHub
rkhachatryan commented on code in PR #25167: URL: https://github.com/apache/flink/pull/25167#discussion_r1715522711 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/source/ProgressiveTimestampsAndWatermarks.java: ## @@ -273,6 +322,16 @@ void emitPer

[jira] [Commented] (FLINK-32643) Introduce off-heap shared state cache across stateful operators in TM

2024-08-13 Thread Xinglong Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873236#comment-17873236 ] Xinglong Wang commented on FLINK-32643: --- It seems that setting the block cache has

[jira] [Updated] (FLINK-36044) In Flinkcdc-connect-mysql2.4 version, scan.snapshot.fetch.size does not take effect

2024-08-13 Thread zhanghuaibei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhanghuaibei updated FLINK-36044: - Description: In version 2.4 of the code, scan.snapshot.fetch.size was not read and loaded. In t

[jira] [Updated] (FLINK-36044) In Flinkcdc-connect-mysql2.4 version, scan.snapshot.fetch.size does not take effect

2024-08-13 Thread zhanghuaibei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhanghuaibei updated FLINK-36044: - Component/s: Flink CDC Labels: CDC (was: ) > In Flinkcdc-connect-mysql2.4 version, sca

[jira] [Updated] (FLINK-36044) In Flinkcdc-connect-mysql2.4 version, scan.snapshot.fetch.size does not take effect

2024-08-13 Thread zhanghuaibei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhanghuaibei updated FLINK-36044: - Fix Version/s: cdc-3.1.0 Affects Version/s: (was: cdc-3.1.0) > In Flinkcdc-connect-m

[jira] [Commented] (FLINK-36043) [SQL] Unexpected SinkMaterializer operator generated when use coalesce function on upsert key fields

2024-08-13 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873230#comment-17873230 ] lincoln lee commented on FLINK-36043: - [~catyee] [~yunta] Intuitively this is a poss

Re: [PR] [FLINK-25907][runtime][security] Add pluggable delegation token manager [flink]

2024-08-13 Thread via GitHub
dpengpeng commented on PR #18664: URL: https://github.com/apache/flink/pull/18664#issuecomment-2286470231 > The token framework stores everything in-memory and it's not compatible with `HADOOP_TOKEN_FILE_LOCATION`. Such case the new container will load the file content with old tokens (YARN

Re: [PR] [FLINK-36045][flink connector formats]Add support for SharePlex JSON format [flink]

2024-08-13 Thread via GitHub
flinkbot commented on PR #25198: URL: https://github.com/apache/flink/pull/25198#issuecomment-2286467685 ## CI report: * 86780ccbdc484367593d50e06c7ef6cc6197b269 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-36045) Add support for SharePlex JSON format to Flink Formats.

2024-08-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36045: --- Labels: pull-request-available (was: ) > Add support for SharePlex JSON format to Flink For

[PR] [FLINK-36045][flink connector formats]Add support for SharePlex JSON format [flink]

2024-08-13 Thread via GitHub
cfbber opened a new pull request, #25198: URL: https://github.com/apache/flink/pull/25198 ## What is the purpose of the change Add support for SharePlex JSON format to Flink Formats. ## Brief change log Add support for SharePlex JSON format to Flink Formats.

Re: [PR] [FLINK-35638] Refactor OceanBase test cases and remove dependency on host network [flink-cdc]

2024-08-13 Thread via GitHub
GOODBOY008 commented on code in PR #3439: URL: https://github.com/apache/flink-cdc/pull/3439#discussion_r1715438022 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-oceanbase-cdc/src/test/java/org/apache/flink/cdc/connectors/oceanbase/testutils/UniqueDatabase.java: #

Re: [PR] [FLINK-35939] Do not set empty config values via ConfigUtils#encodeCollectionToConfig [flink]

2024-08-13 Thread via GitHub
gaborgsomogyi commented on PR #25139: URL: https://github.com/apache/flink/pull/25139#issuecomment-2286439406 I've double checked the usage and makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
jnh5y commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715418603 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/ExpandTestPrograms.java: ## @@ -29,7 +29,7 @@ /** {@link TableTest

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
twalthr commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715418437 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -63,6 +69,8 @@ public final class SinkTestStep extends Ta

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
twalthr commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715417453 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/ExpandTestPrograms.java: ## @@ -29,7 +29,7 @@ /** {@link TableTe

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
twalthr commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715398912 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -110,11 +117,11 @@ public List getExpectedAsStrings() {

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
jnh5y commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715397098 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -63,6 +69,8 @@ public final class SinkTestStep extends Tabl

[jira] [Created] (FLINK-36045) Add support for SharePlex JSON format to Flink Formats.

2024-08-13 Thread Will-Hyde (Jira)
Will-Hyde created FLINK-36045: - Summary: Add support for SharePlex JSON format to Flink Formats. Key: FLINK-36045 URL: https://issues.apache.org/jira/browse/FLINK-36045 Project: Flink Issue Type:

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
jnh5y commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715369447 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/ExpandTestPrograms.java: ## @@ -29,7 +29,7 @@ /** {@link TableTest

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
twalthr commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715356887 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -63,6 +69,8 @@ public final class SinkTestStep extends Ta

Re: [PR] [FLINK-35935][table] Fix RTAS not supporting LIMIT [flink]

2024-08-13 Thread via GitHub
lincoln-lil commented on code in PR #25185: URL: https://github.com/apache/flink/pull/25185#discussion_r1715348075 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlReplaceTableAsConverter.java: ## @@ -49,10 +49,10 @@ public

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
twalthr commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715353817 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/SinkTestStep.java: ## @@ -37,6 +37,10 @@ public final class SinkTestStep extends T

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
jnh5y commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715356077 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/BatchRestoreTestBase.java: ## @@ -228,10 +228,10 @@ void loadAnd

[jira] [Commented] (FLINK-36043) [SQL] Unexpected SinkMaterializer operator generated when use coalesce function on upsert key fields

2024-08-13 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873210#comment-17873210 ] Yun Tang commented on FLINK-36043: -- [~catyee] I think the root cause is the difference

[jira] [Comment Edited] (FLINK-36043) [SQL] Unexpected SinkMaterializer operator generated when use coalesce function on upsert key fields

2024-08-13 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873210#comment-17873210 ] Yun Tang edited comment on FLINK-36043 at 8/13/24 1:58 PM: --- [~

Re: [PR] [FLINK-36038][table] Output for `SHOW CREATE VIEW` should follow the `CREATE VIEW` syntax [flink]

2024-08-13 Thread via GitHub
twalthr commented on code in PR #25195: URL: https://github.com/apache/flink/pull/25195#discussion_r1715346829 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java: ## @@ -246,13 +230,19 @@ static Optional extractFormattedOpt

[jira] [Commented] (FLINK-35987) Add ELT function

2024-08-13 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17873206#comment-17873206 ] lincoln lee commented on FLINK-35987: - The final implementation includes the compile

[jira] [Closed] (FLINK-35987) Add ELT function

2024-08-13 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-35987. --- Resolution: Fixed Fixed in master: e33028db6a79fad8c7fa3b4d93760112fd91ca7a > Add ELT function > --

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
flinkbot commented on PR #25197: URL: https://github.com/apache/flink/pull/25197#issuecomment-2286320604 ## CI report: * 7c88b2239963e7a1fd7c0fd938fdfac75f0b1992 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35987][table] Add the built-in function ELT [flink]

2024-08-13 Thread via GitHub
lincoln-lil commented on PR #25163: URL: https://github.com/apache/flink/pull/25163#issuecomment-2286317653 Fixed in master: e33028db6a79fad8c7fa3b4d93760112fd91ca7a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [FLINK-36038][table] Output for `SHOW CREATE VIEW` should follow the `CREATE VIEW` syntax [flink]

2024-08-13 Thread via GitHub
twalthr commented on code in PR #25195: URL: https://github.com/apache/flink/pull/25195#discussion_r1715335600 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java: ## @@ -176,10 +161,7 @@ static String getColumnString(Column

Re: [PR] [FLINK-35987][table] Add the built-in function ELT [flink]

2024-08-13 Thread via GitHub
lincoln-lil closed pull request #25163: [FLINK-35987][table] Add the built-in function ELT URL: https://github.com/apache/flink/pull/25163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
snuyanzin commented on code in PR #25197: URL: https://github.com/apache/flink/pull/25197#discussion_r1715335632 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/testutils/BatchRestoreTestBase.java: ## @@ -228,10 +228,10 @@ void loa

Re: [PR] [FLINK-35987][table] Add the built-in function ELT [flink]

2024-08-13 Thread via GitHub
lincoln-lil commented on PR #25163: URL: https://github.com/apache/flink/pull/25163#issuecomment-2286308221 Reorg the commits before merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [FLINK-36003] Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate [flink]

2024-08-13 Thread via GitHub
jnh5y opened a new pull request, #25197: URL: https://github.com/apache/flink/pull/25197 ## What is the purpose of the change * Adds override for batch expected rows/sinks in SinkTestStep. * Adds annotations for BatchExecExpand and BatchExecSortAggregate. ## Verifying this ch

[jira] [Updated] (FLINK-36003) Add CompiledPlan annotations to BatchExecExpand and BatchExecSortAggregate

2024-08-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-36003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-36003: --- Labels: pull-request-available (was: ) > Add CompiledPlan annotations to BatchExecExpand an

  1   2   >