RocMarshal commented on code in PR #865:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/865#discussion_r1716379053
##########
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java:
##########
@@ -121,4 +121,11 @@ private static ConfigOptions.OptionBuilder
autoscalerStandaloneConfig(String key
code(EVENT_HANDLER_TYPE.key()),
code("JDBC"))
.build());
+
+ public static final ConfigOption<Duration> JDBC_EVENT_HANDLER_TTL =
+ autoscalerStandaloneConfig("jdbc-event-handler.ttl")
Review Comment:
thanks for the comments.
> jdbc.event-handler.ttl
Let's do it this way.
Consistent naming conventions are better!
##########
flink-autoscaler-standalone/src/main/java/org/apache/flink/autoscaler/standalone/config/AutoscalerStandaloneOptions.java:
##########
@@ -121,4 +121,11 @@ private static ConfigOptions.OptionBuilder
autoscalerStandaloneConfig(String key
code(EVENT_HANDLER_TYPE.key()),
code("JDBC"))
.build());
+
+ public static final ConfigOption<Duration> JDBC_EVENT_HANDLER_TTL =
+ autoscalerStandaloneConfig("jdbc-event-handler.ttl")
Review Comment:
thanks for the comments.
> jdbc.event-handler.ttl
Let's do it this way.
Consistent naming conventions are better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
