Re: [PR] [cdc-runtime]The processedTableIds add is executed twice [flink-cdc]

2024-07-19 Thread via GitHub
yuxiqian commented on code in PR #3483: URL: https://github.com/apache/flink-cdc/pull/3483#discussion_r1685267350 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/sink/DataSinkWriterOperator.java: ## @@ -172,7 +172,6 @@ public void processElement(StreamR

Re: [PR] [cdc-runtime]The processedTableIds add is executed twice [flink-cdc]

2024-07-19 Thread via GitHub
yuxiqian commented on code in PR #3483: URL: https://github.com/apache/flink-cdc/pull/3483#discussion_r1685267350 ## flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/sink/DataSinkWriterOperator.java: ## @@ -172,7 +172,6 @@ public void processElement(StreamR

[jira] [Commented] (FLINK-35857) Operator restart failed job without latest checkpoint

2024-07-19 Thread chenyuzhi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867471#comment-17867471 ] chenyuzhi commented on FLINK-35857: --- I have test the latest operator version, met with

[jira] [Updated] (FLINK-35857) Operator restart failed job without latest checkpoint

2024-07-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35857: --- Labels: pull-request-available (was: ) > Operator restart failed job without latest checkpo

[PR] [FLINK-FLINK-35857] fix restart failed deployment without latest checkpoint [flink-kubernetes-operator]

2024-07-19 Thread via GitHub
chenyuzhi459 opened a new pull request, #855: URL: https://github.com/apache/flink-kubernetes-operator/pull/855 ## What is the purpose of the change Fix operator won't use latest checkpoint as `execution.savepoint.path` for restarted deployment. ## Brief cha

Re: [PR] [FLINK-35847][release] Add release note for version 1.20 [flink]

2024-07-19 Thread via GitHub
JingGe commented on code in PR #25091: URL: https://github.com/apache/flink/pull/25091#discussion_r1684970706 ## docs/content.zh/release-notes/flink-1.20.md: ## @@ -0,0 +1,434 @@ +--- +title: "Release Notes - Flink 1.20" +--- + + +# Release notes - Flink 1.20 + +These release no

Re: [PR] Add protoc service and dynamic deserializer skeleton [flink]

2024-07-19 Thread via GitHub
dmariassy closed pull request #25107: Add protoc service and dynamic deserializer skeleton URL: https://github.com/apache/flink/pull/25107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Add protoc service and dynamic deserializer skeleton [flink]

2024-07-19 Thread via GitHub
flinkbot commented on PR #25107: URL: https://github.com/apache/flink/pull/25107#issuecomment-2240092185 ## CI report: * e08aa9e72c30871890eab7d7700de1fafe007f32 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Add protoc service and dynamic deserializer skeleton [flink]

2024-07-19 Thread via GitHub
dmariassy opened a new pull request, #25107: URL: https://github.com/apache/flink/pull/25107 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them

Re: [PR] [WIP] [FLINK-XXXX] Generalized watermark wip [flink]

2024-07-19 Thread via GitHub
jeyhunkarimov commented on PR #24997: URL: https://github.com/apache/flink/pull/24997#issuecomment-2240014953 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [DRAFT][FLINK-34440][formats][protobuf-confluent] add support for protobuf-confluent [flink]

2024-07-19 Thread via GitHub
dmariassy commented on PR #24482: URL: https://github.com/apache/flink/pull/24482#issuecomment-2239843309 I started working on an alternative implementation over here: https://github.com/Shopify/flink/tree/protobuf-confluent-dynamic-deser -- This is an automated message from the Apache Gi

[jira] [Commented] (FLINK-12450) [Bitwise Functions] Add BIT_LSHIFT, BIT_RSHIFT functions supported in Table API and SQL

2024-07-19 Thread Kartikey Pant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867370#comment-17867370 ] Kartikey Pant commented on FLINK-12450: --- Hey [~lincoln.86xy], created a PR for the

[jira] [Updated] (FLINK-35851) autoscaler standlone mode use `GlobalConfiguration.loadConfiguration` load config

2024-07-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35851: --- Labels: pull-request-available (was: ) > autoscaler standlone mode use `GlobalConfiguration

Re: [PR] [FLINK-35851][autoscaler] Introduce GlobalConfiguration.loadConfiguration load config [flink-kubernetes-operator]

2024-07-19 Thread via GitHub
huyuanfeng2018 commented on PR #853: URL: https://github.com/apache/flink-kubernetes-operator/pull/853#issuecomment-2239462207 > Hi, > > The title of the PR references a Jira that is for a KDS connector bug: > > * https://issues.apache.org/jira/browse/FLINK-35815 > > Wou

[jira] [Updated] (FLINK-35869) Right side columns of temporal left join are always null when right side is filtered

2024-07-19 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grzegorz Kołakowski updated FLINK-35869: Description: Background: I have a stream of user information updates in Kafka top

[jira] [Updated] (FLINK-35869) Right side columns of temporal left join are always null when right side is filtered

2024-07-19 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grzegorz Kołakowski updated FLINK-35869: Description: Background: I have a stream of user information updates in Kafka top

[jira] [Updated] (FLINK-35869) Right side columns of temporal left join are always null when right side is filtered

2024-07-19 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grzegorz Kołakowski updated FLINK-35869: Description: Background: I have a stream of user information updates in Kafka top

[jira] [Updated] (FLINK-35869) Right side columns of temporal left join are always null when right side is filtered

2024-07-19 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grzegorz Kołakowski updated FLINK-35869: Description: Background: I have a stream of user information updates in Kafka top

[jira] [Updated] (FLINK-35869) Right side columns of temporal left join are always null when right side is filtered

2024-07-19 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grzegorz Kołakowski updated FLINK-35869: Description: Background: I have a stream of user information updates, but those u

[jira] [Updated] (FLINK-35869) Right side columns of temporal left join are always null when right side is filtered

2024-07-19 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Grzegorz Kołakowski updated FLINK-35869: Description: Background: I have a stream of user information updates, but those u

[jira] [Created] (FLINK-35869) Right side columns of temporal left join are always null when right side is filtered

2024-07-19 Thread Jira
Grzegorz Kołakowski created FLINK-35869: --- Summary: Right side columns of temporal left join are always null when right side is filtered Key: FLINK-35869 URL: https://issues.apache.org/jira/browse/FLINK-35869

Re: [PR] [FLINK-28893][table] Add built-in conv function. [flink]

2024-07-19 Thread via GitHub
dylanhz commented on code in PR #20746: URL: https://github.com/apache/flink/pull/20746#discussion_r1684351449 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/BaseConversionUtils.java: ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35815][autoscaler] Introduce GlobalConfiguration.loadConfiguration load config [flink-kubernetes-operator]

2024-07-19 Thread via GitHub
nuno-c-afonso commented on PR #853: URL: https://github.com/apache/flink-kubernetes-operator/pull/853#issuecomment-2239030064 Hi, The title of the PR references a Jira that is for a KDS connector bug: - https://issues.apache.org/jira/browse/FLINK-35815 Would it be possible t

[jira] [Comment Edited] (FLINK-35832) IFNULL returns incorrect result in Flink SQL

2024-07-19 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866984#comment-17866984 ] dalongliu edited comment on FLINK-35832 at 7/19/24 12:17 PM: -

[jira] [Resolved] (FLINK-35832) IFNULL returns incorrect result in Flink SQL

2024-07-19 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu resolved FLINK-35832. --- Resolution: Fixed > IFNULL returns incorrect result in Flink SQL > -

[jira] [Comment Edited] (FLINK-35832) IFNULL returns incorrect result in Flink SQL

2024-07-19 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866984#comment-17866984 ] dalongliu edited comment on FLINK-35832 at 7/19/24 12:17 PM: -

Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-19 Thread via GitHub
lsyldliu merged PR #25105: URL: https://github.com/apache/flink/pull/25105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-19 Thread via GitHub
lsyldliu merged PR #25106: URL: https://github.com/apache/flink/pull/25106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Jira account created: placeholder-flink

2024-07-19 Thread ASF Self-serve Portal
Hi, there. As requested by the flink project, we have created a Jira user account, placeholder-flink, for you to use when reporting issues related to The Apache Software Foundation's projects or products. Go to https://issues.apache.org/jira/secure/ForgotLoginDetails.jspa and select to have y

Please verify your email address

2024-07-19 Thread ASF Self-serve Portal
This email has been sent to you in order to verify the authenticity of a request to create a Jira account with The Apache Software Foundation. If you requested an account, please visit https://selfserve.apache.org/jira-account-verify.html?4c952a84-23a3-4728-854d-abe4d787c9cd to verify your ema

[jira] [Commented] (FLINK-35860) S5CmdOnMinioITCase failed due to IllegalAccessError in JDK17/21

2024-07-19 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867284#comment-17867284 ] Piotr Nowojski commented on FLINK-35860: Thanks for closing the ticket [~Weijie

Re: [PR] [FLINK-34865][pipeline-connector]support sync table and column comments [flink-cdc]

2024-07-19 Thread via GitHub
qg-lin commented on PR #3482: URL: https://github.com/apache/flink-cdc/pull/3482#issuecomment-2238865439 resolve some problems from PR https://github.com/apache/flink-cdc/pull/3039, thanks for @lvyanquan and @dufeng1010 and @yuxiqian -- This is an automated message from the Apache Git Se

[PR] [FLINK-34865][pipeline-connector]support sync table and column comments [flink-cdc]

2024-07-19 Thread via GitHub
qg-lin opened a new pull request, #3482: URL: https://github.com/apache/flink-cdc/pull/3482 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[jira] [Updated] (FLINK-34865) [enhancement] [StarRocks] When synchronizing tables using Flink CDC 3.x, is it possible to include the comments of the source table's fields when creating the target tab

2024-07-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34865: --- Labels: github-import pull-request-available (was: github-import) > [enhancement] [StarRock

[jira] [Created] (FLINK-35868) Bump Mongo driver version to support Mongo 7.0+

2024-07-19 Thread yux (Jira)
yux created FLINK-35868: --- Summary: Bump Mongo driver version to support Mongo 7.0+ Key: FLINK-35868 URL: https://issues.apache.org/jira/browse/FLINK-35868 Project: Flink Issue Type: Improvement

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-07-19 Thread via GitHub
dingxin-tech commented on PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#issuecomment-2238818725 > > hi, @leonardBang, can you help to review again and merge this? > > I append one commit to polish the interface and package, Could you also take a look ? sure and l

Re: [PR] [FLINK-35237] Allow Sink to Choose HashFunction in PrePartitionOperator [flink-cdc]

2024-07-19 Thread via GitHub
leonardBang commented on PR #3414: URL: https://github.com/apache/flink-cdc/pull/3414#issuecomment-2238808223 > hi, @leonardBang, can you help to review again and merge this? I append one commit to polish the interface and package, Could you also take a look ? -- This is an automat

[jira] [Closed] (FLINK-31261) Make AdaptiveScheduler aware of the (local) state size

2024-07-19 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan closed FLINK-31261. - Resolution: Fixed Implemented in caf9b23b3208c8b30cdb6c56ff6f334e2342ce5c..999b7a2f2e3a

Re: [PR] [FLINK-31261][runtime] Make AdaptiveScheduler aware of local state size [flink]

2024-07-19 Thread via GitHub
rkhachatryan merged PR #22046: URL: https://github.com/apache/flink/pull/22046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-31261][runtime] Make AdaptiveScheduler aware of local state size [flink]

2024-07-19 Thread via GitHub
rkhachatryan commented on PR #22046: URL: https://github.com/apache/flink/pull/22046#issuecomment-2238758264 Thanks for the review! Given https://github.com/apache/flink/pull/22046#discussion_r1681407852, I think the improvement should be significant but not in all cases. -- This is an

Re: [PR] [FLINK-35847] Add 1.20 release announcement [flink-web]

2024-07-19 Thread via GitHub
xintongsong commented on code in PR #751: URL: https://github.com/apache/flink-web/pull/751#discussion_r1684056042 ## docs/data/flink.yml: ## @@ -15,6 +15,16 @@ # specific language governing permissions and limitations # under the License +1.20: Review Comment: I'd sugge

[jira] [Commented] (FLINK-35576) FRocksDB cherry pick IngestDB related commits

2024-07-19 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867252#comment-17867252 ] Yue Ma commented on FLINK-35576: [~roman] [~zakelly] I have read the descriptions of the

[jira] [Commented] (FLINK-35634) Add a CDC quickstart utility

2024-07-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867223#comment-17867223 ] Leonard Xu commented on FLINK-35634: Cool [~xiqian_yu] !, could we consider mysql to

Re: [PR] [hotfix][docs] fix doc for maven version and DataStream operators link URL [flink]

2024-07-19 Thread via GitHub
reswqa commented on code in PR #24952: URL: https://github.com/apache/flink/pull/24952#discussion_r1683974850 ## docs/content/docs/try-flink/local_installation.md: ## @@ -141,7 +141,7 @@ You can view the data flow plan for the execution: Here for the job execution, Flink has

[jira] [Commented] (FLINK-35634) Add a CDC quickstart utility

2024-07-19 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867204#comment-17867204 ] yux commented on FLINK-35634: - Just implemented a primitive demo for `cdcup` in https://git

[jira] [Commented] (FLINK-35634) Add a CDC quickstart utility

2024-07-19 Thread yux (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867228#comment-17867228 ] yux commented on FLINK-35634: - Seems Paimon / Kafka sink are missing. Will add them soon. >

[PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL function returns incorrect result [flink]

2024-07-19 Thread via GitHub
dylanhz opened a new pull request, #25105: URL: https://github.com/apache/flink/pull/25105 ## What is the purpose of the change Fix the incorrect output datatype of `IFNULL`. ## Brief change log The `IfNullTypeStrategy` previously takes the datatype of nullReplace

Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL function returns incorrect result [flink]

2024-07-19 Thread via GitHub
flinkbot commented on PR #25105: URL: https://github.com/apache/flink/pull/25105#issuecomment-2238335317 ## CI report: * 78a12db4db89951145fefa4570a624097291b25e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][docs] Add missing "Submitting a Flink job" section in Chinese version doc and other fixes [flink]

2024-07-19 Thread via GitHub
showuon commented on code in PR #24952: URL: https://github.com/apache/flink/pull/24952#discussion_r1684051651 ## docs/content/docs/try-flink/local_installation.md: ## @@ -141,7 +141,7 @@ You can view the data flow plan for the execution: Here for the job execution, Flink has

Re: [PR] add note **Please note that the lib here refers to the lib of flink-c… [flink-cdc]

2024-07-19 Thread via GitHub
Lordeath commented on PR #3476: URL: https://github.com/apache/flink-cdc/pull/3476#issuecomment-2238622216 重复修改,取消这次PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] add note **Please note that the lib here refers to the lib of flink-c… [flink-cdc]

2024-07-19 Thread via GitHub
Lordeath closed pull request #3476: add note **Please note that the lib here refers to the lib of flink-c… URL: https://github.com/apache/flink-cdc/pull/3476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [hotfix][docs] fix doc for maven version and DataStream operators link URL [flink]

2024-07-19 Thread via GitHub
showuon commented on code in PR #24952: URL: https://github.com/apache/flink/pull/24952#discussion_r1683998141 ## docs/content/docs/try-flink/local_installation.md: ## @@ -141,7 +141,7 @@ You can view the data flow plan for the execution: Here for the job execution, Flink has

Re: [PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-19 Thread via GitHub
flinkbot commented on PR #25106: URL: https://github.com/apache/flink/pull/25106#issuecomment-2238612503 ## CI report: * f826267f58ff5dcaed2837e1989110290d47ada4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35832][Table SQL / Planner] Fix IFNULL outputTypeStrategy [flink]

2024-07-19 Thread via GitHub
dylanhz opened a new pull request, #25106: URL: https://github.com/apache/flink/pull/25106 ## What is the purpose of the change Fix the incorrect output datatype of `IFNULL`. ## Brief change log The `IfNullTypeStrategy` previously takes the datatype of nullReplacement

[jira] [Commented] (FLINK-35634) Add a CDC quickstart utility

2024-07-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867226#comment-17867226 ] Leonard Xu commented on FLINK-35634: Ignore my above comment, I saw you've did it, p

[jira] [Assigned] (FLINK-35634) Add a CDC quickstart utility

2024-07-19 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-35634: -- Assignee: yux > Add a CDC quickstart utility > > >

[jira] [Commented] (FLINK-35576) FRocksDB cherry pick IngestDB related commits

2024-07-19 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867206#comment-17867206 ] Zakelly Lan commented on FLINK-35576: - [~roman] I read the description of those two,