chenyuzhi459 opened a new pull request, #855:
URL: https://github.com/apache/flink-kubernetes-operator/pull/855
<!--
*Thank you very much for contributing to the Apache Flink Kubernetes
Operator - we are happy that you want to help us improve the project. To help
the community review your contribution in the best possible way, please go
through the checklist below, which will get the contribution into a shape in
which it can be best reviewed.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the
pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix][docs] Fix typo in event time introduction` or
`[hotfix][javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can read more on how we use GitHub Actions for CI
[here](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/development/guide/#cicd).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Fix operator won't use latest checkpoint as `execution.savepoint.path` for
restarted deployment.
## Brief change log
- *Restart failed deployment with latest checkpoint if
upgradeMode=`SAVEPOINT/LAST_STATE`*
## Verifying this change
Unit tests + manual verification
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
(no)
- Core observer or reconciler logic that is regularly executed: (no)
## Other implementation details
As the [FLINK-35857](https://issues.apache.org/jira/browse/FLINK-35857)
described, if a deployment first started without
setting `execution.savepoint.path` but enable periodic checkpointing and
external checkpoint storage run troble into failed status, operator won't use
latest checkpoint to redeploy.
The root cause is when deployment started without setting
`execution.savepoint.path` , operator will set `spec.job.upgradeMode =
STATELESS` and serialize as `status.reconciliationStatus.lastReconciledSpec` in
the method
[AbstractFlinkResourceReconciler.updateStatusBeforeFirstDeployment](https://github.com/apache/flink-kubernetes-operator/blob/29076c80eaac5547e3d12f703c43780cd4a52dad/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java#L224).
However, when redploying failed deployment, the method
[AbstractJobReconciler.resubmitJob](https://github.com/apache/flink-kubernetes-operator/blob/29076c80eaac5547e3d12f703c43780cd4a52dad/flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java#L315)
will read the upgradeMode of lastReconciledSpec and decide whether to redeploy
from latestSavepoint based on whether it is STATELESS.
Thus, it should update `status.reconciliationStatus.lastReconciledSpec`
using the right upgradeMode before redeploy failed deployment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
