Re: [PR] [BP-1.19][FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25057: URL: https://github.com/apache/flink/pull/25057#issuecomment-2216726410 ## CI report: * 98f6bcbe0e3adfc2d849fb67e6a471d994442aae UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.19][FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan opened a new pull request, #25057: URL: https://github.com/apache/flink/pull/25057 backport of #25050 to 1.19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 [flink]

2024-07-08 Thread via GitHub
fhueske commented on code in PR #24967: URL: https://github.com/apache/flink/pull/24967#discussion_r1669010333 ## docs/data/sql_functions.yml: ## @@ -377,6 +377,12 @@ string: - sql: SUBSTR(string, integer1[, integer2]) table: STRING.substr(INTEGER1[, INTEGER2]) desc

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan merged PR #25050: URL: https://github.com/apache/flink/pull/25050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

Re: [PR] [FLINK-34657] extract lineage info for stream API [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25056: URL: https://github.com/apache/flink/pull/25056#issuecomment-2216704983 ## CI report: * 75d6e981e0387369db13c4a3646b5af764c84e9c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-34657] add lineage info for stream API [flink]

2024-07-08 Thread via GitHub
HuangZhenQiu opened a new pull request, #25056: URL: https://github.com/apache/flink/pull/25056 ## What is the purpose of the change Support Lineage info extraction for Stream API use cases. ## Brief change log - Add LineageVertexInfo into transformation when user use D

[jira] [Updated] (FLINK-35749) Kafka sink component will lose data when kafka cluster is unavailable for a while

2024-07-08 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-35749: --- Affects Version/s: kafka-3.2.0 > Kafka sink component will lose data when kafka cluster is u

[jira] [Commented] (FLINK-35749) Kafka sink component will lose data when kafka cluster is unavailable for a while

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864016#comment-17864016 ] Weijie Guo commented on FLINK-35749: I don't think this should be a blocker of 1.20,

[jira] [Updated] (FLINK-35749) Kafka sink component will lose data when kafka cluster is unavailable for a while

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35749: --- Affects Version/s: (was: 1.20.0) > Kafka sink component will lose data when kafka cluster is una

Re: [PR] [FLINK-35354] Support host mapping in Flink tikv cdc [flink-cdc]

2024-07-08 Thread via GitHub
GOODBOY008 commented on PR #3336: URL: https://github.com/apache/flink-cdc/pull/3336#issuecomment-2216531933 @Mrart Can you rebase the branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Closed] (FLINK-35783) Flink CDC Could not start the yaml Job

2024-07-08 Thread layhuts (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] layhuts closed FLINK-35783. --- Resolution: Done > Flink CDC Could not start the yaml Job > -- > >

Re: [PR] [FLINK-35299] Respect initial position for new streams [flink-connector-aws]

2024-07-08 Thread via GitHub
code-hard-play-harder commented on code in PR #140: URL: https://github.com/apache/flink-connector-aws/pull/140#discussion_r1669689616 ## docs/content/docs/connectors/datastream/kinesis.md: ## @@ -217,6 +217,38 @@ properties by providing a value for `ConsumerConfigConstants.ST

[jira] [Updated] (FLINK-35792) Sorting by proctime does not work in rank

2024-07-08 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-35792: Affects Version/s: 1.19.1 (was: 1.19.0) > Sorting by proctime does not

[jira] [Created] (FLINK-35792) Sorting by proctime does not work in rank

2024-07-08 Thread xuyang (Jira)
xuyang created FLINK-35792: -- Summary: Sorting by proctime does not work in rank Key: FLINK-35792 URL: https://issues.apache.org/jira/browse/FLINK-35792 Project: Flink Issue Type: Bug Compo

Re: [PR] [FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]

2024-07-08 Thread via GitHub
Zakelly commented on PR #25051: URL: https://github.com/apache/flink/pull/25051#issuecomment-2216370232 Thanks. I change some names of vars and functions, will merge after CI green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] FLIP-466: Introduce ProcessFunction Attribute in DataStream API V2 [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25055: URL: https://github.com/apache/flink/pull/25055#issuecomment-2216364944 ## CI report: * 1f14a6435260beb038deae2b136249d66e36599c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35740][mysql] Allow column as chunk key even if not in Primary Keys [flink-cdc]

2024-07-08 Thread via GitHub
SML0127 commented on PR #3448: URL: https://github.com/apache/flink-cdc/pull/3448#issuecomment-2216351412 @leonardBang PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [docs][minor] Correct Typos in Documentation/Code [flink-cdc]

2024-07-08 Thread via GitHub
yuxiqian commented on PR #3451: URL: https://github.com/apache/flink-cdc/pull/3451#issuecomment-2216340738 Seems `OracleE2eITCase.testOracleCDC` missed a change inside: ``` arrays first differed at element [7]; expected:<...,jacket,water resist[a]nt black wind breake...> but was:

[PR] FLIP-466: Introduce ProcessFunction Attribute in DataStream API V2 [flink]

2024-07-08 Thread via GitHub
WencongLiu opened a new pull request, #25055: URL: https://github.com/apache/flink/pull/25055 ## What is the purpose of the change *Introduce ProcessFunction Attribute in DataStream API V2.* ## Brief change log - *Introduce the framework of ProcessFunction Attribute.*

[jira] [Created] (FLINK-35791) Add database and table infos to Kafka json output.

2024-07-08 Thread LvYanquan (Jira)
LvYanquan created FLINK-35791: - Summary: Add database and table infos to Kafka json output. Key: FLINK-35791 URL: https://issues.apache.org/jira/browse/FLINK-35791 Project: Flink Issue Type: Impr

Re: [PR] [FLINK-34572] Support OceanBase Jdbc Catalog [flink-connector-jdbc]

2024-07-08 Thread via GitHub
RocMarshal commented on PR #109: URL: https://github.com/apache/flink-connector-jdbc/pull/109#issuecomment-2216074991 @whhe nice work! Could you help squish the commits into a single commit ? thx -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (FLINK-35783) Flink CDC Could not start the yaml Job

2024-07-08 Thread layhuts (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863976#comment-17863976 ] layhuts commented on FLINK-35783: - [~xiqian_yu] 谢谢 (y) > Flink CDC Could not start the

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-07-08 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1669440001 ## flink-connector-aws-e2e-tests/flink-connector-aws-sqs-e2e-tests/pom.xml: ## @@ -0,0 +1,111 @@ + + + +http://maven.apache.org/POM/4.0.0"; +

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-07-08 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1669436100 ## flink-connector-aws/flink-connector-sqs/src/main/java/org/apache/flink/connector/sqs/sink/SqsSinkElementConverter.java: ## @@ -0,0 +1,105 @@ +/* +

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-07-08 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1669426704 ## flink-connector-aws/flink-connector-sqs/src/main/java/org/apache/flink/connector/sqs/sink/SqsSinkWriter.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-07-08 Thread via GitHub
19priyadhingra commented on code in PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#discussion_r1669408631 ## flink-connector-aws/flink-connector-sqs/src/main/java/org/apache/flink/connector/sqs/sink/SqsStateSerializer.java: ## @@ -0,0 +1,58 @@ +/* + * Lice

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2024-07-08 Thread Kevin Tseng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863951#comment-17863951 ] Kevin Tseng commented on FLINK-33545: - Hi [~arvid] , [~masc] , [~thomasWeise]  I ag

Re: [PR] [WIP][FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-08 Thread via GitHub
hlteoh37 commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1669358672 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/proxy/KinesisStreamProxyTest.java: ## @@

Re: [PR] [FLINK-35789][table] Allow defining watermarks & PRIMARY KEY in CREATE TABLE AS (CTAS) [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25054: URL: https://github.com/apache/flink/pull/25054#issuecomment-2215396765 ## CI report: * d7c585e34cab930de4c29f068a64e889d8a9bbfb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-35790) Update docs for new schema definition in CTAS and RTAS

2024-07-08 Thread Jira
Sergio Peña created FLINK-35790: --- Summary: Update docs for new schema definition in CTAS and RTAS Key: FLINK-35790 URL: https://issues.apache.org/jira/browse/FLINK-35790 Project: Flink Issue Ty

Re: [PR] [FLINK-35789][table] Allow defining watermarks & PRIMARY KEY in CREATE TABLE AS (CTAS) [flink]

2024-07-08 Thread via GitHub
spena commented on code in PR #25054: URL: https://github.com/apache/flink/pull/25054#discussion_r1669360054 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/MergeTableLikeUtil.java: ## @@ -312,113 +302,36 @@ private void appendDerivedPr

[jira] [Updated] (FLINK-35789) Allow defining watermarks & PRIMARY KEY in CREATE TABLE AS (CTAS)

2024-07-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35789: --- Labels: pull-request-available (was: ) > Allow defining watermarks & PRIMARY KEY in CREATE

[PR] [FLINK-35789][table] Allow defining watermarks & PRIMARY KEY in CREATE TABLE AS (CTAS) [flink]

2024-07-08 Thread via GitHub
spena opened a new pull request, #25054: URL: https://github.com/apache/flink/pull/25054 ## What is the purpose of the change Allows defining the WATERMARK and PRIMARY KEY in the CTAS statement. PRIMARY KEY example: ``` CREATE TABLE table_name (PRIMARY KEY (person) NOT EN

[jira] [Updated] (FLINK-35789) Allow defining watermarks & PRIMARY KEY in CREATE TABLE AS (CTAS)

2024-07-08 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Peña updated FLINK-35789: Summary: Allow defining watermarks & PRIMARY KEY in CREATE TABLE AS (CTAS) (was: Allow WATERMARK

[jira] [Created] (FLINK-35789) Allow WATERMARK & PRIMARY KEY in CREATE TABLE AS (CTAS)

2024-07-08 Thread Jira
Sergio Peña created FLINK-35789: --- Summary: Allow WATERMARK & PRIMARY KEY in CREATE TABLE AS (CTAS) Key: FLINK-35789 URL: https://issues.apache.org/jira/browse/FLINK-35789 Project: Flink Issue T

Re: [PR] [FLINK-34111][table] Add support for json_quote, json_unquote, address PR feedback #24156 [flink]

2024-07-08 Thread via GitHub
snuyanzin commented on code in PR #24967: URL: https://github.com/apache/flink/pull/24967#discussion_r1669276320 ## docs/data/sql_functions.yml: ## @@ -377,6 +377,12 @@ string: - sql: SUBSTR(string, integer1[, integer2]) table: STRING.substr(INTEGER1[, INTEGER2]) de

Re: [PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-08 Thread via GitHub
mas-chen commented on code in PR #107: URL: https://github.com/apache/flink-connector-kafka/pull/107#discussion_r1669266607 ## flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -449,12 +460,17 @@ public void onCompletion(RecordMet

[jira] [Commented] (FLINK-34127) Kafka connector repo runs a duplicate of `IntegrationTests` framework tests

2024-07-08 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863925#comment-17863925 ] Mason Chen commented on FLINK-34127: Hi [~arvid], yes feel free to takeover. I left

[jira] [Commented] (FLINK-33545) KafkaSink implementation can cause dataloss during broker issue when not using EXACTLY_ONCE if there's any batching

2024-07-08 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863924#comment-17863924 ] Mason Chen commented on FLINK-33545: [~arvid] [~thw] I believe this is solved by ht

Re: [PR] [WIP][FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-08 Thread via GitHub
hlteoh37 commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1669243126 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTrackerTest.java: ###

Re: [PR] [WIP][FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-08 Thread via GitHub
hlteoh37 commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1669238262 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/enumerator/tracker/SplitTrackerTest.java: ###

Re: [PR] [FLINK-35749] Kafka sink component will lose data when kafka cluster is unavailable for a while [flink-connector-kafka]

2024-07-08 Thread via GitHub
JimmyZZZ commented on PR #107: URL: https://github.com/apache/flink-connector-kafka/pull/107#issuecomment-2214785529 @AHeise added new test case KafkaWriterFaultToleranceITCase and do some refactor to extract some public things for KafkaWriterFaultToleranceITCase and KafkaWriterITCase, an

Re: [PR] [WIP] [FLINK-12450] Add leftshift, rightshift functions supported in Table API and SQL [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25053: URL: https://github.com/apache/flink/pull/25053#issuecomment-2214758102 ## CI report: * 16ea0a2e327ff94139aa069f65b893514540eb1d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Closed] (FLINK-35785) Executing query in SQL client results in "java.lang.ClassNotFoundException: org.apache.flink.core.execution.RestoreMode"

2024-07-08 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-35785. -- Resolution: Cannot Reproduce [~Weijie Guo] [~ferenc-csaky] I'm not sure why, but after manuall

[jira] [Updated] (FLINK-12450) [Bitwise Functions] Add BIT_LSHIFT, BIT_RSHIFT functions supported in Table API and SQL

2024-07-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12450: --- Labels: auto-unassigned pull-request-available stale-assigned (was: auto-unassigned stale-a

[PR] [FLINK-12450] [WIP] Add leftshift, rightshift functions supported in Table API and SQL [flink]

2024-07-08 Thread via GitHub
kartikeypant opened a new pull request, #25053: URL: https://github.com/apache/flink/pull/25053 ## What is the purpose of the change * The purpose of this change is to enhance the Flink Table API and SQL by introducing new bitwise functions: `shiftleft` and `shiftright`. These will also

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r166929 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -396,7 +399,9 @@ public void close() throws IOException { if (LOG.isInfoE

Re: [PR] [WIP][FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-08 Thread via GitHub
hlteoh37 commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1668997135 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/test/java/org/apache/flink/connector/kinesis/source/enumerator/KinesisStreamsSourceEnumeratorStateSer

Re: [PR] [BP-1.20][FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25052: URL: https://github.com/apache/flink/pull/25052#issuecomment-2214715238 ## CI report: * cadb2364f238bf047e938b742079f7f56a2b10ea UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25051: URL: https://github.com/apache/flink/pull/25051#issuecomment-2214714463 ## CI report: * e555779cb606a2ecb5bcd7f5f6e7c12eddd85a65 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [BP-1.20][FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]

2024-07-08 Thread via GitHub
Zakelly opened a new pull request, #25052: URL: https://github.com/apache/flink/pull/25052 ## What is the purpose of the change The `OperatorSubtaskState` only make keyed state register with `SharedStateRegistry`. However, the file-merging directories's handle are wrapped in `FileMer

[jira] [Updated] (FLINK-35784) The cp file-merging directory not properly registered in SharedStateRegistry

2024-07-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35784: --- Labels: pull-request-available (was: ) > The cp file-merging directory not properly registe

[PR] [FLINK-35784][checkpoint] Fix the missing shared state registration of file-merging directories [flink]

2024-07-08 Thread via GitHub
Zakelly opened a new pull request, #25051: URL: https://github.com/apache/flink/pull/25051 ## What is the purpose of the change The `OperatorSubtaskState` only make keyed state register with `SharedStateRegistry`. However, the file-merging directories's handle are wrapped in `FileMer

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668975142 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -396,7 +399,9 @@ public void close() throws IOException { if (LOG.

[jira] [Updated] (FLINK-35784) The cp file-merging directory not properly registered in SharedStateRegistry

2024-07-08 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan updated FLINK-35784: Description: The {{OperatorSubtaskState}} only make keyed state register with {{SharedStateRegistr

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668927920 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -396,7 +399,9 @@ public void close() throws IOException { if (LOG.isInfoE

[jira] [Updated] (FLINK-35738) Release Testing: Verify FLINK-26050 Too many small sst files in rocksdb state backend when using time window created in ascending order

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35738: --- Labels: release-testing (was: ) > Release Testing: Verify FLINK-26050 Too many small sst files in r

[jira] [Updated] (FLINK-35738) Release Testing: Verify FLINK-26050 Too many small sst files in rocksdb state backend when using time window created in ascending order

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35738: --- Fix Version/s: 1.20.0 > Release Testing: Verify FLINK-26050 Too many small sst files in rocksdb stat

[jira] [Updated] (FLINK-35738) Release Testing: Verify FLINK-26050 Too many small sst files in rocksdb state backend when using time window created in ascending order

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35738: --- Affects Version/s: 1.20.0 > Release Testing: Verify FLINK-26050 Too many small sst files in rocksdb

[jira] [Resolved] (FLINK-35712) [Release-1.20] Prepare RC0 release

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo resolved FLINK-35712. Resolution: Done Already announced in mail list. > [Release-1.20] Prepare RC0 release > -

[jira] [Updated] (FLINK-35712) [Release-1.20] Prepare RC0 release

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35712: --- Description: * The preview source release and binary convenience releases * All artifacts that woul

[jira] [Updated] (FLINK-35602) [Umbrella] Test Flink Release 1.20

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-35602: --- Fix Version/s: 1.20.0 > [Umbrella] Test Flink Release 1.20 > -- > >

[jira] [Commented] (FLINK-35785) Executing query in SQL client results in "java.lang.ClassNotFoundException: org.apache.flink.core.execution.RestoreMode"

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863848#comment-17863848 ] Weijie Guo commented on FLINK-35785: I download flink-1.20.0 binary from [https://d

[jira] [Comment Edited] (FLINK-35785) Executing query in SQL client results in "java.lang.ClassNotFoundException: org.apache.flink.core.execution.RestoreMode"

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863848#comment-17863848 ] Weijie Guo edited comment on FLINK-35785 at 7/8/24 4:04 PM:

[jira] [Comment Edited] (FLINK-35785) Executing query in SQL client results in "java.lang.ClassNotFoundException: org.apache.flink.core.execution.RestoreMode"

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863848#comment-17863848 ] Weijie Guo edited comment on FLINK-35785 at 7/8/24 4:04 PM:

[jira] [Comment Edited] (FLINK-35785) Executing query in SQL client results in "java.lang.ClassNotFoundException: org.apache.flink.core.execution.RestoreMode"

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863848#comment-17863848 ] Weijie Guo edited comment on FLINK-35785 at 7/8/24 4:04 PM:

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668897088 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdo

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668896504 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdo

[jira] [Comment Edited] (FLINK-33494) FLIP-376: Add DISTRIBUTED BY clause

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863839#comment-17863839 ] Weijie Guo edited comment on FLINK-33494 at 7/8/24 3:48 PM:

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668882384 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdownReque

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668880762 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdownReque

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668880762 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdownReque

[jira] [Commented] (FLINK-33494) FLIP-376: Add DISTRIBUTED BY clause

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863839#comment-17863839 ] Weijie Guo commented on FLINK-33494: Hi [~jhughes]  1. click the Edit button on the

[jira] [Updated] (FLINK-33494) FLIP-376: Add DISTRIBUTED BY clause

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33494: --- Attachment: image-2024-07-08-23-46-11-355.png > FLIP-376: Add DISTRIBUTED BY clause > --

[jira] [Updated] (FLINK-33494) FLIP-376: Add DISTRIBUTED BY clause

2024-07-08 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33494: --- Attachment: image-2024-07-08-23-45-43-850.png > FLIP-376: Add DISTRIBUTED BY clause > --

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668850192 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdo

[jira] [Created] (FLINK-35788) Deprecate old InputFormat and SinkFunction

2024-07-08 Thread Jira
João Boto created FLINK-35788: - Summary: Deprecate old InputFormat and SinkFunction Key: FLINK-35788 URL: https://issues.apache.org/jira/browse/FLINK-35788 Project: Flink Issue Type: Sub-task

[jira] [Closed] (FLINK-35707) Allow column definition in CREATE TABLE AS (CTAS)

2024-07-08 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-35707. Fix Version/s: 2.0.0 Resolution: Fixed Fixed in master: 93d7f45595435da10ac1d685feae8f7e8a9

Re: [PR] [FLINK-35707][Table SQL / API] Allow column definition in CREATE TABLE AS (CTAS) [flink]

2024-07-08 Thread via GitHub
twalthr merged PR #24987: URL: https://github.com/apache/flink/pull/24987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apach

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668797608 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdownReque

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25050: URL: https://github.com/apache/flink/pull/25050#discussion_r1668797608 ## flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java: ## @@ -354,10 +354,12 @@ public void close() throws IOException { if (shutdownReque

[jira] [Commented] (FLINK-33494) FLIP-376: Add DISTRIBUTED BY clause

2024-07-08 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863819#comment-17863819 ] Jim Hughes commented on FLINK-33494: Hi [~Weijie Guo] sorry to be slow to respond.

[jira] [Commented] (FLINK-35785) Executing query in SQL client results in "java.lang.ClassNotFoundException: org.apache.flink.core.execution.RestoreMode"

2024-07-08 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863817#comment-17863817 ] Ferenc Csaky commented on FLINK-35785: -- With a fresh local build today from the {{r

[jira] [Comment Edited] (FLINK-35785) Executing query in SQL client results in "java.lang.ClassNotFoundException: org.apache.flink.core.execution.RestoreMode"

2024-07-08 Thread Ferenc Csaky (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17863817#comment-17863817 ] Ferenc Csaky edited comment on FLINK-35785 at 7/8/24 2:41 PM:

[jira] [Updated] (FLINK-35787) DefaultSlotStatusSyncer might bring down JVM (exit code 239 instead of a proper shutdown)

2024-07-08 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-35787: -- Description: In our internal CI, I've encountered the following error: {code:java} * 1

[jira] [Closed] (FLINK-35787) DefaultSlotStatusSyncer might bring down JVM (exit code 239 instead of a proper shutdown)

2024-07-08 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-35787. - Resolution: Duplicate This is a duplicate of FLINK-34427. > DefaultSlotStatusSyncer might bring

[jira] [Updated] (FLINK-35787) DefaultSlotStatusSyncer might bring down JVM (exit code 239 instead of a proper shutdown)

2024-07-08 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-35787: -- Description: In our internal CI, I've encountered the following error: {code:java} * 1

[jira] [Updated] (FLINK-35787) DefaultSlotStatusSyncer might bring down JVM (exit code 239 instead of a proper shutdown)

2024-07-08 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-35787: -- Affects Version/s: 1.19.1 > DefaultSlotStatusSyncer might bring down JVM (exit code 23

[jira] [Updated] (FLINK-35787) DefaultSlotStatusSyncer might bring down JVM (exit code 239 instead of a proper shutdown)

2024-07-08 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-35787: -- Component/s: Runtime / Coordination > DefaultSlotStatusSyncer might bring down JVM (ex

[jira] [Created] (FLINK-35787) DefaultSlotStatusSyncer might bring down JVM (exit code 239 instead of a proper shutdown)

2024-07-08 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-35787: - Summary: DefaultSlotStatusSyncer might bring down JVM (exit code 239 instead of a proper shutdown) Key: FLINK-35787 URL: https://issues.apache.org/jira/browse/FLINK-3578

Re: [PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
flinkbot commented on PR #25050: URL: https://github.com/apache/flink/pull/25050#issuecomment-2214162634 ## CI report: * 2d524cf16224834ef4b8c3fd7f4c63caabdf43ba UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-35786) NPE in BlobServer / shutdownHook

2024-07-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35786: --- Labels: pull-request-available (was: ) > NPE in BlobServer / shutdownHook > ---

[PR] [FLINK-35786] Fix NPE BlobServer / shutdownHook [flink]

2024-07-08 Thread via GitHub
rkhachatryan opened a new pull request, #25050: URL: https://github.com/apache/flink/pull/25050 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring th

Re: [PR] [WIP][FLINK-32218][Connector/Kinesis] Add support for parent-child shard ordering to Kinesis streams source [flink-connector-aws]

2024-07-08 Thread via GitHub
hlteoh37 commented on code in PR #145: URL: https://github.com/apache/flink-connector-aws/pull/145#discussion_r1668649676 ## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/event/SplitsFinishedEvent.java: ## @@ -0,

[jira] [Created] (FLINK-35786) NPE in BlobServer / shutdownHook

2024-07-08 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-35786: - Summary: NPE in BlobServer / shutdownHook Key: FLINK-35786 URL: https://issues.apache.org/jira/browse/FLINK-35786 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1668650443 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManagerRunners() {

Re: [PR] [FLINK-35265] Implement FlinkStateSnapshot custom resource [flink-kubernetes-operator]

2024-07-08 Thread via GitHub
mateczagany commented on code in PR #821: URL: https://github.com/apache/flink-kubernetes-operator/pull/821#discussion_r1668650953 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractJobReconciler.java: ## @@ -266,19 +30

Re: [PR] [FLINK-27355][runtime] Unregister JobManagerRunner after it's closed [flink]

2024-07-08 Thread via GitHub
XComp commented on code in PR #25027: URL: https://github.com/apache/flink/pull/25027#discussion_r1668650443 ## flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DefaultJobManagerRunnerRegistry.java: ## @@ -85,7 +85,16 @@ public Collection getJobManagerRunners() {

Re: [PR] [FLINK-35739][FLIP-444] Native file copy support [flink]

2024-07-08 Thread via GitHub
rkhachatryan commented on code in PR #25028: URL: https://github.com/apache/flink/pull/25028#discussion_r1668622658 ## flink-filesystems/flink-s3-fs-base/src/main/java/org/apache/flink/fs/s3/common/AbstractS3FileSystemFactory.java: ## @@ -41,6 +42,41 @@ /** Base class for file

[jira] [Resolved] (FLINK-35697) Release Testing: Verify FLIP-451 Introduce timeout configuration to AsyncSink

2024-07-08 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy resolved FLINK-35697. - Resolution: Resolved > Release Testing: Verify FLIP-451 Introduce timeout configuration to Async

  1   2   >