XComp commented on code in PR #25050:
URL: https://github.com/apache/flink/pull/25050#discussion_r1669000029
##########
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobServer.java:
##########
@@ -396,7 +399,9 @@ public void close() throws IOException {
if (LOG.isInfoEnabled()) {
LOG.info(
"Stopped BLOB server at {}:{}",
- serverSocket.getInetAddress().getHostAddress(),
+ serverSocket == null
+ ? null
+ :
serverSocket.getInetAddress().getHostAddress(),
getPort());
Review Comment:
but then you might want to add a log message in the else branch as well.
Otherwise, we would miss the log message in certain scenarios.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
