Re: [PR] [FLINK-31664] Implement ARRAY_INTERSECT function [flink]

2024-06-03 Thread via GitHub
snuyanzin commented on code in PR #24526: URL: https://github.com/apache/flink/pull/24526#discussion_r1625447988 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -1723,6 +1724,83 @@ private Stream arr

Re: [PR] [FLINK-31664] Implement ARRAY_INTERSECT function [flink]

2024-06-03 Thread via GitHub
snuyanzin commented on code in PR #24526: URL: https://github.com/apache/flink/pull/24526#discussion_r1625448219 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -1723,6 +1724,83 @@ private Stream arr

Re: [PR] [FLINK-35423][table] ARRAY_EXCEPT should follow set semantics [flink]

2024-06-03 Thread via GitHub
snuyanzin commented on PR #24828: URL: https://github.com/apache/flink/pull/24828#issuecomment-2146732235 hi @reswqa thanks for reaching out seems I missed this test failure, thanks for noticing this I updated the test, it should pass now just need to wait and then need for a rev

[jira] [Assigned] (FLINK-35516) Update the Experimental annotation to PublicEvolving for files connector

2024-06-03 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-35516: --- Assignee: RocMarshal > Update the Experimental annotation to PublicEvolving for files connector >

Re: [PR] [FLINK-35423][table] ARRAY_EXCEPT should follow set semantics [flink]

2024-06-03 Thread via GitHub
reswqa commented on PR #24828: URL: https://github.com/apache/flink/pull/24828#issuecomment-2146650973 Hi @snuyanzin, what is the state of this PR right now? I notice this as it marked as a blocker of 1.20. -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-03 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851899#comment-17851899 ] RocMarshal commented on FLINK-35496: - I carefully read the discussion and found tha

[jira] [Commented] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-03 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851897#comment-17851897 ] RocMarshal commented on FLINK-35496: >> BTW, should we update the Experimental to Pu

[jira] [Commented] (FLINK-35516) Update the Experimental annotation to PublicEvolving for files connector

2024-06-03 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851896#comment-17851896 ] RocMarshal commented on FLINK-35516: I'd like to contribute for the Jira. Could some

[jira] [Created] (FLINK-35516) Update the Experimental annotation to PublicEvolving for files connector

2024-06-03 Thread RocMarshal (Jira)
RocMarshal created FLINK-35516: -- Summary: Update the Experimental annotation to PublicEvolving for files connector Key: FLINK-35516 URL: https://issues.apache.org/jira/browse/FLINK-35516 Project: Flink

[jira] [Commented] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-03 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851881#comment-17851881 ] RocMarshal commented on FLINK-35496: Thanks [~fanrui] for the checking and [~leonard

[PR] [FLINK-35496] Revert "[FLINK-35496] Fix annotations on new JdbcSink and JdbcSource" [flink-connector-jdbc]

2024-06-03 Thread via GitHub
RocMarshal opened a new pull request, #129: URL: https://github.com/apache/flink-connector-jdbc/pull/129 This reverts commit b955e8b5479c65512f94ee7270eb2868a4a14ebe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Resolved] (FLINK-35514) Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-35514. Resolution: Implemented > Add Flink CDC Channel to Apache Flink Slack Workspace >

[jira] [Updated] (FLINK-35514) Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-35514: --- Component/s: Build System > Add Flink CDC Channel to Apache Flink Slack Workspace >

[jira] [Updated] (FLINK-35514) Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-35514: --- Affects Version/s: cdc-3.1.0 > Add Flink CDC Channel to Apache Flink Slack Workspace > -

[jira] [Updated] (FLINK-35514) Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-35514: --- Fix Version/s: cdc-3.2.0 > Add Flink CDC Channel to Apache Flink Slack Workspace > -

[jira] [Commented] (FLINK-35514) Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851879#comment-17851879 ] Leonard Xu commented on FLINK-35514: done > Add Flink CDC Channel to Apache Flink S

[jira] [Commented] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851878#comment-17851878 ] Leonard Xu commented on FLINK-35496: > I commented it at > https://github.com/apach

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-03 Thread via GitHub
1996fanrui commented on code in PR #24757: URL: https://github.com/apache/flink/pull/24757#discussion_r1625296576 ## flink-tests/src/test/java/org/apache/flink/test/streaming/api/datastream/SubTaskFinishedWithWatermarkAlignmentITCase.java: ## @@ -0,0 +1,52 @@ +package org.apache

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-06-03 Thread via GitHub
zoltar9264 commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2146519076 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-33607][build]: Add checksum verification for Maven wrapper [flink]

2024-06-03 Thread via GitHub
showuon commented on PR #24852: URL: https://github.com/apache/flink/pull/24852#issuecomment-2146511397 @snuyanzin @JingGe @XComp , please take a look when available. This PR is doing similar things as https://github.com/apache/flink/pull/23766 , just bump the Maven wrapper version. Thanks.

[jira] [Commented] (FLINK-35473) FLIP-457: Improve Table/SQL Configuration for Flink 2.0

2024-06-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851875#comment-17851875 ] lincoln lee commented on FLINK-35473: - Hi [~qingyue], any updates on this? As the F

[jira] [Created] (FLINK-35515) Upgrade hive version to 4.0.0

2024-06-03 Thread vikasap (Jira)
vikasap created FLINK-35515: --- Summary: Upgrade hive version to 4.0.0 Key: FLINK-35515 URL: https://issues.apache.org/jira/browse/FLINK-35515 Project: Flink Issue Type: Improvement Compone

[jira] [Updated] (FLINK-35473) FLIP-457: Improve Table/SQL Configuration for Flink 2.0

2024-06-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-35473: Fix Version/s: 1.20.0 > FLIP-457: Improve Table/SQL Configuration for Flink 2.0 >

[jira] [Commented] (FLINK-35514) Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851868#comment-17851868 ] Leonard Xu commented on FLINK-35514: Let me have a try > Add Flink CDC Channel to A

[jira] [Assigned] (FLINK-35514) Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-35514: -- Assignee: Leonard Xu > Add Flink CDC Channel to Apache Flink Slack Workspace > --

[jira] [Commented] (FLINK-35514) Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851867#comment-17851867 ] Zhongqiang Gong commented on FLINK-35514: - Hi [~martijnvisser] , Can you help c

[jira] [Updated] (FLINK-35514) Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhongqiang Gong updated FLINK-35514: Issue Type: Improvement (was: Bug) > Add Flink CDC Channel to Apache Flink Slack Workspac

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-06-03 Thread via GitHub
zoltar9264 commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2146442592 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-06-03 Thread via GitHub
19priyadhingra commented on PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#issuecomment-2146436785 > > Would you recommend keeping it normal, String? > > Yes! And if someone needs base64 encoding they can encode it in the `SerializationSchema`. > > > I ha

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-06-03 Thread via GitHub
19priyadhingra commented on PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#issuecomment-2146436055 > Thanks for the efforts. Could we remove the ticket link from the PR title, it should be automatically linked using "Autolink" > > We need to add documentation fo

[jira] [Commented] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-03 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851865#comment-17851865 ] Rui Fan commented on FLINK-35496: - Thanks [~leonard] for the clarification, I misunderst

[jira] [Created] (FLINK-35514) Add Flink CDC Channel to Apache Flink Slack Workspace

2024-06-03 Thread Zhongqiang Gong (Jira)
Zhongqiang Gong created FLINK-35514: --- Summary: Add Flink CDC Channel to Apache Flink Slack Workspace Key: FLINK-35514 URL: https://issues.apache.org/jira/browse/FLINK-35514 Project: Flink I

Re: [PR] [FLINK-35475][runtime] Introduce isInternalSorterSupport to OperatorAttributes [flink]

2024-06-03 Thread via GitHub
Sxnan commented on PR #24874: URL: https://github.com/apache/flink/pull/24874#issuecomment-2146407007 @jeyhunkarimov Thanks for the review! I updated the PR. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-35502) compress the checkpoint metadata generated by ZK/ETCD HA Services

2024-06-03 Thread Ying Z (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851859#comment-17851859 ] Ying Z commented on FLINK-35502: Yes, I understand that using cron + savepoint can parti

Re: [PR] [FLINK-35305]Amazon SQS Sink Connector [flink-connector-aws]

2024-06-03 Thread via GitHub
19priyadhingra commented on PR #141: URL: https://github.com/apache/flink-connector-aws/pull/141#issuecomment-2146248914 > Thanks @19priyadhingra for addressing the comments, could we fix the spotless violations as mentioned above? I was able to finally make "spotless

Re: [PR] [FLINK-35501] Use common IO thread pool for RocksDB data transfer [flink]

2024-06-03 Thread via GitHub
rkhachatryan commented on PR #24882: URL: https://github.com/apache/flink/pull/24882#issuecomment-2146241374 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-35475][runtime] Introduce isInternalSorterSupport to OperatorAttributes [flink]

2024-06-03 Thread via GitHub
jeyhunkarimov commented on code in PR #24874: URL: https://github.com/apache/flink/pull/24874#discussion_r1624875893 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/OperatorAttributes.java: ## @@ -49,4 +51,12 @@ public class OperatorAttributes impl

Re: [PR] [FLINK-26050] Manually compact small SST files [flink]

2024-06-03 Thread via GitHub
rkhachatryan commented on PR #24880: URL: https://github.com/apache/flink/pull/24880#issuecomment-2145845406 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Updated] (FLINK-34064) FLIP-471: Expose JobManagerOperatorMetrics via REST API

2024-06-03 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-34064: --- Summary: FLIP-471: Expose JobManagerOperatorMetrics via REST API (was: Expose JobManagerOperatorMet

[jira] [Commented] (FLINK-34445) Integrate new endpoint with Flink UI metrics section

2024-06-03 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851748#comment-17851748 ] Mason Chen commented on FLINK-34445: [~ruanhang1993] do you still have time to work

[jira] [Commented] (FLINK-35502) compress the checkpoint metadata generated by ZK/ETCD HA Services

2024-06-03 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851744#comment-17851744 ] Mingliang Liu commented on FLINK-35502: --- When would you need to restore from check

Re: [PR] FLINK-35402 [flink-operator][Deployment] add labels to metadata [flink-kubernetes-operator]

2024-06-03 Thread via GitHub
luismacosta commented on code in PR #829: URL: https://github.com/apache/flink-kubernetes-operator/pull/829#discussion_r1624820266 ## docs/content.zh/docs/operations/helm.md: ## @@ -76,7 +76,7 @@ The configurable parameters of the Helm chart and which default values as detail

Re: [PR] FLINK-35402 [flink-operator][Deployment] add labels to metadata [flink-kubernetes-operator]

2024-06-03 Thread via GitHub
gyfora commented on code in PR #829: URL: https://github.com/apache/flink-kubernetes-operator/pull/829#discussion_r1624805845 ## docs/content.zh/docs/operations/helm.md: ## @@ -76,7 +76,7 @@ The configurable parameters of the Helm chart and which default values as detail | rb

[jira] [Commented] (FLINK-35503) OracleE2eITCase fails with error ORA-12528 on Mac M2

2024-06-03 Thread Saketh Kurnool (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851734#comment-17851734 ] Saketh Kurnool commented on FLINK-35503: Thank you [~gongzhongqiang], [~xiqian_y

Re: [PR] [FLINK-35282] Upgrade pyarrow and beam [flink]

2024-06-03 Thread via GitHub
antovespoli closed pull request #24876: [FLINK-35282] Upgrade pyarrow and beam URL: https://github.com/apache/flink/pull/24876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [FLINK-35282] Upgrade pyarrow and beam [flink]

2024-06-03 Thread via GitHub
antovespoli commented on PR #24876: URL: https://github.com/apache/flink/pull/24876#issuecomment-2145706228 Dropping 1.19 branch PR as beam upgrade is not backwards compatible and could result in breaking python apps. Will still pursue merge on master: https://github.com/apache/flink/pull/2

Re: [PR] [hotfix] A couple of hotfixes [flink]

2024-06-03 Thread via GitHub
flinkbot commented on PR #24883: URL: https://github.com/apache/flink/pull/24883#issuecomment-2145695417 ## CI report: * 81ea19f5b19f1ec3ed0cd1094e2cce9b2c12d9b3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix] A couple of hotfixes [flink]

2024-06-03 Thread via GitHub
pnowojski opened a new pull request, #24883: URL: https://github.com/apache/flink/pull/24883 New PR replacing https://github.com/apache/flink/pull/24868 trying to force new azure run. ## What is the purpose of the change A couple of hotfixes ## Brief change log Pl

Re: [PR] [hotfix] A couple of hotfixes [flink]

2024-06-03 Thread via GitHub
pnowojski closed pull request #24868: [hotfix] A couple of hotfixes URL: https://github.com/apache/flink/pull/24868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] [hotfix] A couple of hotfixes [flink]

2024-06-03 Thread via GitHub
pnowojski commented on PR #24868: URL: https://github.com/apache/flink/pull/24868#issuecomment-2145669119 I can not get the azure to work for this PR, something has got stuck. Going to create a new one -- This is an automated message from the Apache Git Service. To respond to the message,

[PR] [FLINK-33803] Remove deprecated `lastReconciledSpec` meta generation in favour of `observedGeneration` [flink-kubernetes-operator]

2024-06-03 Thread via GitHub
angelachenn opened a new pull request, #834: URL: https://github.com/apache/flink-kubernetes-operator/pull/834 ## What is the purpose of the change Followup to https://issues.apache.org/jira/browse/FLINK-33803 (https://github.com/apache/flink-kubernetes-operator/pull/755) > The `ob

[jira] [Commented] (FLINK-35512) ArtifactFetchManagerTest unit tests fail

2024-06-03 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851722#comment-17851722 ] Hong Liang Teoh commented on FLINK-35512: - However, it seems that the tests pass

[jira] [Reopened] (FLINK-35512) ArtifactFetchManagerTest unit tests fail

2024-06-03 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh reopened FLINK-35512: - > ArtifactFetchManagerTest unit tests fail > > >

Re: [PR] [FLINK-34883] Fix postgres uuid column as PK [flink-cdc]

2024-06-03 Thread via GitHub
eskabetxe commented on code in PR #3282: URL: https://github.com/apache/flink-cdc/pull/3282#discussion_r1624721302 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/fetch/PostgresScanFetchTask.java

[jira] [Resolved] (FLINK-35512) ArtifactFetchManagerTest unit tests fail

2024-06-03 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh resolved FLINK-35512. - Resolution: Not A Problem > ArtifactFetchManagerTest unit tests fail > -

[jira] [Commented] (FLINK-35512) ArtifactFetchManagerTest unit tests fail

2024-06-03 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851716#comment-17851716 ] Hong Liang Teoh commented on FLINK-35512: - Turns out we do run the build test an

Re: [PR] [FLINK-34883] Fix postgres uuid column as PK [flink-cdc]

2024-06-03 Thread via GitHub
eskabetxe commented on code in PR #3282: URL: https://github.com/apache/flink-cdc/pull/3282#discussion_r1624721302 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/fetch/PostgresScanFetchTask.java

Re: [PR] [FLINK-34883] Fix postgres uuid column as PK [flink-cdc]

2024-06-03 Thread via GitHub
eskabetxe commented on code in PR #3282: URL: https://github.com/apache/flink-cdc/pull/3282#discussion_r1624721302 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/fetch/PostgresScanFetchTask.java

Re: [PR] [FLINK-34883] Fix postgres uuid column as PK [flink-cdc]

2024-06-03 Thread via GitHub
eskabetxe commented on code in PR #3282: URL: https://github.com/apache/flink-cdc/pull/3282#discussion_r1624723194 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/splitter/JdbcSourceChunkSplitter.java: ##

Re: [PR] [FLINK-34883] Fix postgres uuid column as PK [flink-cdc]

2024-06-03 Thread via GitHub
eskabetxe commented on code in PR #3282: URL: https://github.com/apache/flink-cdc/pull/3282#discussion_r1624721302 ## flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/fetch/PostgresScanFetchTask.java

[jira] [Updated] (FLINK-35506) disable kafka auto-commit and rely on flink’s checkpointing if both are enabled

2024-06-03 Thread elon_X (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] elon_X updated FLINK-35506: --- Description: When I use KafkaSource for consuming topics and set the Kafka parameter {{{}enable.auto.commit

[jira] [Updated] (FLINK-35506) disable kafka auto-commit and rely on flink’s checkpointing if both are enabled

2024-06-03 Thread elon_X (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] elon_X updated FLINK-35506: --- Description: When I use KafkaSource for consuming topics and set the Kafka parameter {{{}enable.auto.commit

[jira] [Updated] (FLINK-35506) disable kafka auto-commit and rely on flink’s checkpointing if both are enabled

2024-06-03 Thread elon_X (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] elon_X updated FLINK-35506: --- Attachment: image-2024-06-03-23-39-28-270.png > disable kafka auto-commit and rely on flink’s checkpointing

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-06-03 Thread via GitHub
zoltar9264 commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2145529943 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Closed] (FLINK-35513) ArtifactFetchManager unit tests are failing

2024-06-03 Thread Elphas Toringepi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elphas Toringepi closed FLINK-35513. Resolution: Duplicate > ArtifactFetchManager unit tests are failing >

Re: [PR] [FLINK-35157][runtime] Sources with watermark alignment get stuck once some subtasks finish [flink]

2024-06-03 Thread via GitHub
elon-X commented on code in PR #24757: URL: https://github.com/apache/flink/pull/24757#discussion_r1624644653 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -201,8 +201,11 @@ void announceCombinedWatermark() { //

[jira] [Updated] (FLINK-35513) ArtifactFetchManager unit tests are failing

2024-06-03 Thread Elphas Toringepi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elphas Toringepi updated FLINK-35513: - Description: The following unit tests in [ArtifactFetchManagerTest.java|https://github.

[jira] [Created] (FLINK-35513) ArtifactFetchManager unit tests are failing

2024-06-03 Thread Elphas Toringepi (Jira)
Elphas Toringepi created FLINK-35513: Summary: ArtifactFetchManager unit tests are failing Key: FLINK-35513 URL: https://issues.apache.org/jira/browse/FLINK-35513 Project: Flink Issue Typ

Re: [PR] [FLINK-26050] Manually compact small SST files [flink]

2024-06-03 Thread via GitHub
rkhachatryan commented on PR #24880: URL: https://github.com/apache/flink/pull/24880#issuecomment-2145433373 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] [FLINK-35200][table] Support the execution of suspend, resume materialized table in full refresh mode [flink]

2024-06-03 Thread via GitHub
hackergin commented on code in PR #24877: URL: https://github.com/apache/flink/pull/24877#discussion_r1624617251 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/service/MaterializedTableStatementITCase.java: ## @@ -652,6 +654,158 @@ void testAlterM

Re: [PR] [FLINK-34883] Fix postgres uuid column as PK [flink-cdc]

2024-06-03 Thread via GitHub
GOODBOY008 commented on code in PR #3282: URL: https://github.com/apache/flink-cdc/pull/3282#discussion_r1624561604 ## flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/assigner/splitter/JdbcSourceChunkSplitter.java: #

[jira] [Created] (FLINK-35512) ArtifactFetchManagerTest unit tests fail

2024-06-03 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-35512: --- Summary: ArtifactFetchManagerTest unit tests fail Key: FLINK-35512 URL: https://issues.apache.org/jira/browse/FLINK-35512 Project: Flink Issue Type: Te

[jira] [Comment Edited] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851671#comment-17851671 ] Leonard Xu edited comment on FLINK-35496 at 6/3/24 2:43 PM:

[jira] [Commented] (FLINK-35496) The annotations of the new JDBC connector should be changed to non-Public/non-PublicEvolving

2024-06-03 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851671#comment-17851671 ] Leonard Xu commented on FLINK-35496: I lust want to clarify two points here: (1)We

Re: [PR] [FLINK-25421] Port JDBC Sink to new Unified Sink API (FLIP-143) [flink-connector-jdbc]

2024-06-03 Thread via GitHub
leonardBang commented on code in PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#discussion_r1624585888 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/sink/JdbcSink.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [FLINK-35501] Use common IO thread pool for RocksDB data transfer [flink]

2024-06-03 Thread via GitHub
flinkbot commented on PR #24882: URL: https://github.com/apache/flink/pull/24882#issuecomment-2145384476 ## CI report: * c71cdf93d7350212afe826ff76f49f9f318ec57c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-35509] Updates the slack invitation link [flink-web]

2024-06-03 Thread via GitHub
rmetzger merged PR #744: URL: https://github.com/apache/flink-web/pull/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Updated] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-06-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35489: --- Labels: pull-request-available (was: ) > Metaspace size can be too little after autotuning

[PR] [FLINK-35489][Autoscaler] Ensure METASPACE size is computed before the heap [flink-kubernetes-operator]

2024-06-03 Thread via GitHub
ashangit opened a new pull request, #833: URL: https://github.com/apache/flink-kubernetes-operator/pull/833 ## What is the purpose of the change If the heap usage with overhead leads to remaining memory to be assigned to the HEAP no memory will be assigned to the METASPACE lea

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-06-03 Thread via GitHub
flinkbot commented on PR #24881: URL: https://github.com/apache/flink/pull/24881#issuecomment-2145361395 ## CI report: * c1b3b0623e1d0fd68ca0d10924cea9bfa693b368 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-35501] Use common IO thread pool for RocksDB data transfer [flink]

2024-06-03 Thread via GitHub
rkhachatryan opened a new pull request, #24882: URL: https://github.com/apache/flink/pull/24882 ## What is the purpose of the change Allow to control the total number of data transfers per TM. ## Brief change log *(for example:)* - *The TaskInfo is stored in the

[jira] [Updated] (FLINK-35501) Use common thread pools when transferring RocksDB state files

2024-06-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35501: --- Labels: pull-request-available (was: ) > Use common thread pools when transferring RocksDB

Re: [PR] [FLINK-26050] Manually compact small SST files [flink]

2024-06-03 Thread via GitHub
flinkbot commented on PR #24880: URL: https://github.com/apache/flink/pull/24880#issuecomment-2145341247 ## CI report: * a63261046d57fb91897e9fb2e56a93081489c017 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-06-03 Thread via GitHub
GOODBOY008 opened a new pull request, #24881: URL: https://github.com/apache/flink/pull/24881 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-06-03 Thread via GitHub
GOODBOY008 closed pull request #24685: [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core URL: https://github.com/apache/flink/pull/24685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-06-03 Thread via GitHub
JingGe commented on code in PR #24471: URL: https://github.com/apache/flink/pull/24471#discussion_r1624540081 ## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Found

[jira] [Updated] (FLINK-26050) Too many small sst files in rocksdb state backend when using time window created in ascending order

2024-06-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-26050: --- Labels: pull-request-available (was: ) > Too many small sst files in rocksdb state backend

[PR] [FLINK-26050] Manually compact small SST files [flink]

2024-06-03 Thread via GitHub
rkhachatryan opened a new pull request, #24880: URL: https://github.com/apache/flink/pull/24880 In some cases, the number of files produced by RocksDB state backend grows indefinitely. This might cause task state info (TDD and checkpoint ACK) to exceed RPC message size and fail recovery/

[jira] [Created] (FLINK-35511) Enhance metrics. The incremental and full phases count the number of records separately

2024-06-03 Thread melin (Jira)
melin created FLINK-35511: - Summary: Enhance metrics. The incremental and full phases count the number of records separately Key: FLINK-35511 URL: https://issues.apache.org/jira/browse/FLINK-35511 Project: Fl

Re: [PR] [FLINK-35200][table] Support the execution of suspend, resume materialized table in full refresh mode [flink]

2024-06-03 Thread via GitHub
hackergin commented on PR #24877: URL: https://github.com/apache/flink/pull/24877#issuecomment-2145284586 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [hotfix] A couple of hotfixes [flink]

2024-06-03 Thread via GitHub
pnowojski commented on PR #24868: URL: https://github.com/apache/flink/pull/24868#issuecomment-2145281883 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-06-03 Thread via GitHub
flinkbot commented on PR #24879: URL: https://github.com/apache/flink/pull/24879#issuecomment-2145225059 ## CI report: * 6e2f34a849971292c1377ffc68b12c0ea10c4b61 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-25538) [JUnit5 Migration] Module: flink-connector-kafka

2024-06-03 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-25538: -- Assignee: Muhammet Orazov (was: xiang1 yu) > [JUnit5 Migration] Module: flink-connec

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-06-03 Thread via GitHub
affo commented on code in PR #24471: URL: https://github.com/apache/flink/pull/24471#discussion_r1624446134 ## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundat

[jira] [Updated] (FLINK-35510) Implement basic incremental checkpoint for ForStStateBackend

2024-06-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-35510: --- Labels: pull-request-available (was: ) > Implement basic incremental checkpoint for ForStSt

[PR] [FLINK-35510][statebackend] Implement basic incremental checkpoint fo… [flink]

2024-06-03 Thread via GitHub
zoltar9264 opened a new pull request, #24879: URL: https://github.com/apache/flink/pull/24879 …r ForStStateBackend ## What is the purpose of the change Use low DB api implement a basic incremental checkpoint for ForStStatebackend, follow steps: 1. db.disableFileDeletions

Re: [PR] [FLINK-20398][e2e] Migrate test_batch_sql.sh to Java e2e tests framework [flink]

2024-06-03 Thread via GitHub
affo commented on code in PR #24471: URL: https://github.com/apache/flink/pull/24471#discussion_r1624443303 ## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundat

[jira] [Updated] (FLINK-35510) Implement basic incremental checkpoint for ForStStateBackend

2024-06-03 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Feifan Wang updated FLINK-35510: Parent: FLINK-34982 Issue Type: Sub-task (was: New Feature) > Implement basic incremental

[jira] [Created] (FLINK-35510) Implement basic incremental checkpoint for ForStStateBackend

2024-06-03 Thread Feifan Wang (Jira)
Feifan Wang created FLINK-35510: --- Summary: Implement basic incremental checkpoint for ForStStateBackend Key: FLINK-35510 URL: https://issues.apache.org/jira/browse/FLINK-35510 Project: Flink I

[jira] [Updated] (FLINK-35282) PyFlink Support for Apache Beam > 2.49

2024-06-03 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-35282: Fix Version/s: 1.20.0 1.19.1 > PyFlink Support for Apache Beam > 2.49 >

  1   2   >