JingGe commented on code in PR #24471: URL: https://github.com/apache/flink/pull/24471#discussion_r1624540081
########## flink-end-to-end-tests/flink-batch-sql-test/src/test/java/org/apache/flink/sql/tests/Generator.java: ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.tests; + +import org.apache.flink.connector.testframe.source.FromElementsSource; +import org.apache.flink.table.data.GenericRowData; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.data.StringData; +import org.apache.flink.table.data.TimestampData; +import org.apache.flink.types.Row; + +import java.time.Instant; +import java.time.LocalDateTime; +import java.time.ZoneOffset; +import java.util.ArrayList; +import java.util.List; + +class Generator implements FromElementsSource.ElementsSupplier<RowData> { + private static final long serialVersionUID = -8455653458083514261L; + private final List<Row> elements; + + static Generator create( + int numKeys, float rowsPerKeyAndSecond, int durationSeconds, int offsetSeconds) { + final int stepMs = (int) (1000 / rowsPerKeyAndSecond); + final long durationMs = durationSeconds * 1000L; + final long offsetMs = offsetSeconds * 2000L; + final List<Row> elements = new ArrayList<>(); + int keyIndex = 0; + long ms = 0; + while (ms < durationMs) { + elements.add(createRow(keyIndex++, ms, offsetMs)); Review Comment: The original implementation was only for batch in `BatchSQLTestProgram`. This PR is for the migration that should not implicitly bring big change for the data generation that might cause performance issue later. In addition, the new implementation is still in the `flink-batch-sql-test` module which should be used only for batch. No sure if there are already similar generators in the stream-sql-test. If not, a new jira task could created and add the new implementation to the stream sql test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
