[PR] [docs] Delete redundant note [flink-cdc]

2024-05-30 Thread via GitHub
Gianzie opened a new pull request, #3384: URL: https://github.com/apache/flink-cdc/pull/3384 Delete redundant note -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [FLINK-34545][cdc-pipeline-connector]Add OceanBase pipeline connector to Flink CDC [flink-cdc]

2024-05-30 Thread via GitHub
yuanoOo commented on PR #3360: URL: https://github.com/apache/flink-cdc/pull/3360#issuecomment-2141342325 Hello everyone, Is there anyone currently following this PR and willing to do a code review? I will continue to follow up on it. -- This is an automated message from the Apache Git Se

Re: [PR] FLINK-35402 [flink-operator][Deployment] add labels to metadata [flink-kubernetes-operator]

2024-05-30 Thread via GitHub
gyfora commented on code in PR #829: URL: https://github.com/apache/flink-kubernetes-operator/pull/829#discussion_r1621803625 ## helm/flink-kubernetes-operator/templates/flink-operator.yaml: ## @@ -23,6 +23,11 @@ metadata: namespace: {{ .Release.Namespace }} labels:

Re: [PR] [doc]Flink sql gettingstarted Expression 'dept_id' is not being grouped and sql-queries-overview TableDescriptor Missing required options are: path [flink]

2024-05-30 Thread via GitHub
ZmmBigdata commented on PR #24841: URL: https://github.com/apache/flink/pull/24841#issuecomment-2141266594 @reswqa please help take a look at the doc update PR. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] [FLINK-33461][Connector/JDBC] Support streaming related semantics for the new JDBC source [flink-connector-jdbc]

2024-05-30 Thread via GitHub
RocMarshal commented on code in PR #119: URL: https://github.com/apache/flink-connector-jdbc/pull/119#discussion_r1621712488 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/ContinuousUnBoundingSettings.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to th

Re: [PR] [FLINK-35406] Use inner serializer when casting RAW type to BINARY or… [flink]

2024-05-30 Thread via GitHub
docete commented on code in PR #24818: URL: https://github.com/apache/flink/pull/24818#discussion_r1621681290 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RawToBinaryCastRule.java: ## @@ -62,7 +62,7 @@ public boolean canFail(L

Re: [PR] [FLINK-35406] Use inner serializer when casting RAW type to BINARY or… [flink]

2024-05-30 Thread via GitHub
docete commented on code in PR #24818: URL: https://github.com/apache/flink/pull/24818#discussion_r1621677150 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RawToBinaryCastRule.java: ## @@ -62,7 +62,7 @@ public boolean canFail(L

Re: [PR] [FLINK-35406] Use inner serializer when casting RAW type to BINARY or… [flink]

2024-05-30 Thread via GitHub
docete commented on code in PR #24818: URL: https://github.com/apache/flink/pull/24818#discussion_r1621677150 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RawToBinaryCastRule.java: ## @@ -62,7 +62,7 @@ public boolean canFail(L

Re: [PR] [FLINK-35406] Use inner serializer when casting RAW type to BINARY or… [flink]

2024-05-30 Thread via GitHub
docete commented on code in PR #24818: URL: https://github.com/apache/flink/pull/24818#discussion_r1621677150 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RawToBinaryCastRule.java: ## @@ -62,7 +62,7 @@ public boolean canFail(L

Re: [PR] [FLINK-35406] Use inner serializer when casting RAW type to BINARY or… [flink]

2024-05-30 Thread via GitHub
docete commented on code in PR #24818: URL: https://github.com/apache/flink/pull/24818#discussion_r1621677150 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RawToBinaryCastRule.java: ## @@ -62,7 +62,7 @@ public boolean canFail(L

[jira] [Closed] (FLINK-35215) The performance of serializerKryo and serializerKryoWithoutRegistration are regressed

2024-05-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan closed FLINK-35215. --- Resolution: Fixed > The performance of serializerKryo and serializerKryoWithoutRegistration are > regressed

[jira] [Commented] (FLINK-35215) The performance of serializerKryo and serializerKryoWithoutRegistration are regressed

2024-05-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850904#comment-17850904 ] Rui Fan commented on FLINK-35215: - The performance seems already recovered, let me close

[jira] [Updated] (FLINK-35215) The performance of serializerKryo and serializerKryoWithoutRegistration are regressed

2024-05-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35215: Description: The performance of serializerKryo and serializerKryoWithoutRegistration are regressed[1][2],

[jira] [Updated] (FLINK-35215) The performance of serializerKryo and serializerKryoWithoutRegistration are regressed

2024-05-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-35215: Attachment: image-2024-05-31-11-22-49-226.png > The performance of serializerKryo and serializerKryoWithou

[jira] [Commented] (FLINK-35295) Improve jdbc connection pool initialization failure message

2024-05-30 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850903#comment-17850903 ] Jiabao Sun commented on FLINK-35295: release-3.1: e18e7a2523ac1ea59471e5714eb60f544e

[jira] [Updated] (FLINK-35295) Improve jdbc connection pool initialization failure message

2024-05-30 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiabao Sun updated FLINK-35295: --- Fix Version/s: cdc-3.1.1 > Improve jdbc connection pool initialization failure message > ---

Re: [PR] [BP-3.1][FLINK-35295][mysql] Improve jdbc connection pool initialization failure message [flink-cdc]

2024-05-30 Thread via GitHub
Jiabao-Sun merged PR #3374: URL: https://github.com/apache/flink-cdc/pull/3374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[jira] [Created] (FLINK-35495) The native metrics for column family are not reported

2024-05-30 Thread Yanfei Lei (Jira)
Yanfei Lei created FLINK-35495: -- Summary: The native metrics for column family are not reported Key: FLINK-35495 URL: https://issues.apache.org/jira/browse/FLINK-35495 Project: Flink Issue Type:

Re: [PR] [FLINK-35297][mysql] Add validation for option connect.timeout [flink-cdc]

2024-05-30 Thread via GitHub
Shawn-Hx commented on PR #3295: URL: https://github.com/apache/flink-cdc/pull/3295#issuecomment-2141143675 cc @leonardBang @PatrickRen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Commented] (FLINK-35363) FLIP-449: Reorganization of flink-connector-jdbc

2024-05-30 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850901#comment-17850901 ] Leonard Xu commented on FLINK-35363: Hey [~eskabetxe], assigned to you. > FLIP-449:

[jira] [Assigned] (FLINK-35363) FLIP-449: Reorganization of flink-connector-jdbc

2024-05-30 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-35363: -- Assignee: João Boto > FLIP-449: Reorganization of flink-connector-jdbc >

[jira] [Commented] (FLINK-35484) Flink document file had removed but website can access

2024-05-30 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850900#comment-17850900 ] Leonard Xu commented on FLINK-35484: thanks [~gongzhongqiang] for the confirm, cool!

Re: [PR] [docs] Improve the readme and issue template [flink-cdc]

2024-05-30 Thread via GitHub
leonardBang commented on code in PR #3383: URL: https://github.com/apache/flink-cdc/pull/3383#discussion_r1621585404 ## .github/ISSUE_TEMPLATE/issue-notice.yml: ## @@ -47,6 +50,8 @@ body: 感谢您选择 Flink CDC! 由于 Apache Flink 的要求,请在 [Apache Jira](https://issues.a

Re: [PR] [docs] Improve the readme and issue template [flink-cdc]

2024-05-30 Thread via GitHub
leonardBang commented on code in PR #3383: URL: https://github.com/apache/flink-cdc/pull/3383#discussion_r1621584793 ## .github/ISSUE_TEMPLATE/issue-notice.yml: ## @@ -47,6 +50,8 @@ body: 感谢您选择 Flink CDC! 由于 Apache Flink 的要求,请在 [Apache Jira](https://issues.a

[jira] [Commented] (FLINK-35483) BatchJobRecoveryTest related to JM failover produced no output for 900 second

2024-05-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850894#comment-17850894 ] Weijie Guo commented on FLINK-35483: https://dev.azure.com/apache-flink/apache-flink

[jira] [Commented] (FLINK-33463) Support the implementation of dynamic source tables based on the new source

2024-05-30 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850892#comment-17850892 ] Rui Fan commented on FLINK-33463: - After discuss with [~RocMarshal] , it's better to sup

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-30 Thread via GitHub
1996fanrui commented on PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2141086375 > Maybe we should revert this commit and re-commit it in the next second or third version Sounds make sense to me. The JdbcSource is introduced in the current versio

[jira] [Comment Edited] (FLINK-35484) Flink document file had removed but website can access

2024-05-30 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850890#comment-17850890 ] Zhongqiang Gong edited comment on FLINK-35484 at 5/31/24 1:31 AM:

[jira] [Comment Edited] (FLINK-35484) Flink document file had removed but website can access

2024-05-30 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850890#comment-17850890 ] Zhongqiang Gong edited comment on FLINK-35484 at 5/31/24 1:31 AM:

[jira] [Commented] (FLINK-35484) Flink document file had removed but website can access

2024-05-30 Thread Zhongqiang Gong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850890#comment-17850890 ] Zhongqiang Gong commented on FLINK-35484: - After build document ci scheduled,I c

Re: [PR] [FLINK-34613][cdc] Support recover from a specific savepoint file [flink-cdc]

2024-05-30 Thread via GitHub
monologuist commented on PR #2959: URL: https://github.com/apache/flink-cdc/pull/2959#issuecomment-2141075378 > @lvyanquan hi,请问您这个PR,所预期的从savepoint重启Flink CDC Pipeline作业的规范命令是这样吗? > > ``` > 在${FLINK_CDC_HOME}目录下执行: > $ ./bin/flink-cdc.sh mysql-to-doris.yaml -s /tmp/flink-savepo

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-05-30 Thread via GitHub
GOODBOY008 commented on PR #24685: URL: https://github.com/apache/flink/pull/24685#issuecomment-2141075315 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [FLINK-25537] [JUnit5 Migration] Module: flink-core with,Package: core [flink]

2024-05-30 Thread via GitHub
GOODBOY008 commented on PR #24685: URL: https://github.com/apache/flink/pull/24685#issuecomment-2140991378 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Comment Edited] (FLINK-34023) Expose Kinesis client retry config in sink

2024-05-30 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850841#comment-17850841 ] Brad Atcheson edited comment on FLINK-34023 at 5/30/24 7:28 PM: --

[jira] [Comment Edited] (FLINK-34023) Expose Kinesis client retry config in sink

2024-05-30 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850841#comment-17850841 ] Brad Atcheson edited comment on FLINK-34023 at 5/30/24 7:28 PM: --

[jira] [Comment Edited] (FLINK-34023) Expose Kinesis client retry config in sink

2024-05-30 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850841#comment-17850841 ] Brad Atcheson edited comment on FLINK-34023 at 5/30/24 7:26 PM: --

[jira] [Commented] (FLINK-34023) Expose Kinesis client retry config in sink

2024-05-30 Thread Brad Atcheson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850841#comment-17850841 ] Brad Atcheson commented on FLINK-34023: --- [Here's](https://github.com/brada/flink-c

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-30 Thread via GitHub
reta commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1621068383 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,144 @

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-30 Thread via GitHub
liuml07 commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1621057382 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,14

[jira] [Created] (FLINK-35494) Reorganize sources

2024-05-30 Thread Jira
João Boto created FLINK-35494: - Summary: Reorganize sources Key: FLINK-35494 URL: https://issues.apache.org/jira/browse/FLINK-35494 Project: Flink Issue Type: Sub-task Reporter: João

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-30 Thread via GitHub
reta commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1621010106 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,144 @

Re: [PR] [FLINK-35472] Improve tests for Elasticsearch 8 connector [flink-connector-elasticsearch]

2024-05-30 Thread via GitHub
reta commented on code in PR #105: URL: https://github.com/apache/flink-connector-elasticsearch/pull/105#discussion_r1621010106 ## flink-connector-elasticsearch8/src/test/java/org/apache/flink/connector/elasticsearch/sink/ElasticsearchSinkBaseITCase.java: ## @@ -21,86 +21,144 @

Re: [PR] [FLINK-35483][runtime] Fix unstable BatchJobRecoveryTest. [flink]

2024-05-30 Thread via GitHub
zhuzhurk commented on code in PR #24871: URL: https://github.com/apache/flink/pull/24871#discussion_r1620899559 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptivebatch/BatchJobRecoveryTest.java: ## @@ -257,6 +260,11 @@ void testRecoverFromJMFailover() thr

Re: [PR] [hotfix][docs] Fix typo in alter.md [flink]

2024-05-30 Thread via GitHub
potterxu commented on PR #24858: URL: https://github.com/apache/flink/pull/24858#issuecomment-2139841619 Hi @swuferhong @luoyuxia , would you mind take a look at the above changes in doc? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Commented] (FLINK-35399) Add documents for batch job master failure recovery

2024-05-30 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850739#comment-17850739 ] Zhu Zhu commented on FLINK-35399: - 56cd9607713d0da874dcc54c4cf6d5b3b52b1050 refined the

Re: [PR] [FLINK-35399][doc] Update the batch job recovery documentation. [flink]

2024-05-30 Thread via GitHub
zhuzhurk merged PR #24872: URL: https://github.com/apache/flink/pull/24872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Commented] (FLINK-32384) Remove deprecated configuration keys which violate YAML spec

2024-05-30 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850734#comment-17850734 ] Zhu Zhu commented on FLINK-32384: - Thanks for volunteering to contribute to Flink. [~kar

[jira] [Commented] (FLINK-34746) Switching to the Apache CDN for Dockerfile

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850732#comment-17850732 ] Hong Liang Teoh commented on FLINK-34746: -  merged commit [{{7f63237}}|https://

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 merged PR #193: URL: https://github.com/apache/flink-docker/pull/193 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 merged PR #192: URL: https://github.com/apache/flink-docker/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 merged PR #191: URL: https://github.com/apache/flink-docker/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 commented on PR #191: URL: https://github.com/apache/flink-docker/pull/191#issuecomment-2139676975 Thanks @MartijnVisser. Merging the PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (FLINK-34379) table.optimizer.dynamic-filtering.enabled lead to OutOfMemoryError

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850730#comment-17850730 ] Hong Liang Teoh commented on FLINK-34379: - Closing Jira as patch has been comple

[jira] [Resolved] (FLINK-35358) Breaking change when loading artifacts

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh resolved FLINK-35358. - Resolution: Fixed > Breaking change when loading artifacts > ---

[jira] [Closed] (FLINK-34379) table.optimizer.dynamic-filtering.enabled lead to OutOfMemoryError

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh closed FLINK-34379. --- Resolution: Fixed > table.optimizer.dynamic-filtering.enabled lead to OutOfMemoryError > ---

[jira] [Updated] (FLINK-35367) Reorganize sinks

2024-05-30 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-35367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] João Boto updated FLINK-35367: -- Summary: Reorganize sinks (was: Reorganize datastream sink and source) > Reorganize sinks > -

[jira] [Updated] (FLINK-35358) Breaking change when loading artifacts

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-35358: Fix Version/s: 1.20.0 > Breaking change when loading artifacts > -

[jira] [Commented] (FLINK-35358) Breaking change when loading artifacts

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850729#comment-17850729 ] Hong Liang Teoh commented on FLINK-35358: - merged commit [{{90a71a1}}|https://g

[jira] [Commented] (FLINK-35358) Breaking change when loading artifacts

2024-05-30 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850727#comment-17850727 ] Hong Liang Teoh commented on FLINK-35358: -  merged commit [{{853989b}}|https://

Re: [PR] [FLINK-35358][clients] Reintroduce recursive JAR listing in classpath load from "usrlib" [flink]

2024-05-30 Thread via GitHub
hlteoh37 merged PR #24791: URL: https://github.com/apache/flink/pull/24791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [BP-1.19][FLINK-35358][clients] Reintroduce recursive JAR listing in classpath load from "usrlib" [flink]

2024-05-30 Thread via GitHub
hlteoh37 merged PR #24792: URL: https://github.com/apache/flink/pull/24792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 commented on PR #190: URL: https://github.com/apache/flink-docker/pull/190#issuecomment-2139650422 Appreciate if I could get your review please! @MartijnVisser or @lincoln-lil :) -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [FLINK-34746] Switching to the Apache CDN for Dockerfile [flink-docker]

2024-05-30 Thread via GitHub
hlteoh37 commented on PR #190: URL: https://github.com/apache/flink-docker/pull/190#issuecomment-2139649509 Backport for Flink 1.19: https://github.com/apache/flink-docker/pull/191 Backport for Flink 1.18: https://github.com/apache/flink-docker/pull/192 Backport for Flink 1.17: https://

Re: [PR] [FLINK-26808][1.19] Limit FileUploadHandler to multipart routes [flink]

2024-05-30 Thread via GitHub
uce merged PR #24859: URL: https://github.com/apache/flink/pull/24859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.or

Re: [PR] [FLINK-35448] Translate pod templates documentation into Chinese [flink-kubernetes-operator]

2024-05-30 Thread via GitHub
RocMarshal commented on code in PR #830: URL: https://github.com/apache/flink-kubernetes-operator/pull/830#discussion_r1620723423 ## docs/content/docs/custom-resource/pod-template.md: ## @@ -113,10 +112,10 @@ arr1: [{name: a, p2: v2}, {name: c, p2: v2}] merged: [{name: a, p1:

Re: [PR] [FLINK-33463][Connector/JDBC] Support the implementation of dynamic source tables based on the new source [flink-connector-jdbc]

2024-05-30 Thread via GitHub
RocMarshal commented on PR #117: URL: https://github.com/apache/flink-connector-jdbc/pull/117#issuecomment-2139538600 Hi, @1996fanrui . Kafka introduced KafkaSource API in the Flink 1.12 branch https://issues.apache.org/jira/browse/FLINK-18323 Afterwards, in Flink version 1.14, Kafk

[jira] [Comment Edited] (FLINK-33001) KafkaSource in batch mode failing with exception if topic partition is empty

2024-05-30 Thread Naci Simsek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850678#comment-17850678 ] Naci Simsek edited comment on FLINK-33001 at 5/30/24 1:07 PM:

Re: [PR] Enable async profiler [flink-benchmarks]

2024-05-30 Thread via GitHub
Zakelly commented on PR #90: URL: https://github.com/apache/flink-benchmarks/pull/90#issuecomment-2139458543 > @Zakelly I've pushed [decdc8e](https://github.com/apache/flink-benchmarks/commit/decdc8e2d161584a798461b4f381adba7cee731f) which restores the JMH defaults from 1.19. Hopefully that

Re: [PR] [FLINK-35199][table] Support the execution of create materialized table in full refresh mode [flink]

2024-05-30 Thread via GitHub
lsyldliu commented on code in PR #24866: URL: https://github.com/apache/flink/pull/24866#discussion_r1620385497 ## flink-table/flink-sql-gateway/src/main/java/org/apache/flink/table/gateway/service/materializedtable/MaterializedTableManager.java: ## @@ -640,10 +750,15 @@ private

[jira] [Created] (FLINK-35493) Make max history age and count configurable for FlinkStateSnapshot resources

2024-05-30 Thread Mate Czagany (Jira)
Mate Czagany created FLINK-35493: Summary: Make max history age and count configurable for FlinkStateSnapshot resources Key: FLINK-35493 URL: https://issues.apache.org/jira/browse/FLINK-35493 Project:

[jira] [Created] (FLINK-35492) Add metrics for FlinkStateSnapshot resources

2024-05-30 Thread Mate Czagany (Jira)
Mate Czagany created FLINK-35492: Summary: Add metrics for FlinkStateSnapshot resources Key: FLINK-35492 URL: https://issues.apache.org/jira/browse/FLINK-35492 Project: Flink Issue Type: Sub-

[jira] [Commented] (FLINK-30719) flink-runtime-web failed due to a corrupted nodejs dependency

2024-05-30 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850700#comment-17850700 ] Weijie Guo commented on FLINK-30719: {code:java} The archive file /__w/1/.m2/reposi

[jira] [Comment Edited] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-05-30 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850694#comment-17850694 ] Nicolas Fraison edited comment on FLINK-35489 at 5/30/24 12:07 PM: ---

[jira] [Updated] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-05-30 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Fraison updated FLINK-35489: Description: We have enable the autotuning feature on one of our flink job with below conf

[jira] [Updated] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-05-30 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Fraison updated FLINK-35489: Description: We have enable the autotuning feature on one of our flink job with below conf

[jira] [Updated] (FLINK-35489) Metaspace size can be too little after autotuning change memory setting

2024-05-30 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Fraison updated FLINK-35489: Summary: Metaspace size can be too little after autotuning change memory setting (was: Ad

Re: [PR] [FLINK-35406] Use inner serializer when casting RAW type to BINARY or… [flink]

2024-05-30 Thread via GitHub
twalthr commented on code in PR #24818: URL: https://github.com/apache/flink/pull/24818#discussion_r1620578309 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RawToBinaryCastRule.java: ## @@ -62,7 +62,7 @@ public boolean canFail(

[jira] [Commented] (FLINK-35489) Add capability to set min taskmanager.memory.managed.size when enabling autotuning

2024-05-30 Thread Nicolas Fraison (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850694#comment-17850694 ] Nicolas Fraison commented on FLINK-35489: - Thks [~fanrui] for the feedback it he

Re: [PR] [docs] Improve the readme and issue template [flink-cdc]

2024-05-30 Thread via GitHub
caicancai commented on code in PR #3383: URL: https://github.com/apache/flink-cdc/pull/3383#discussion_r1620475491 ## .github/ISSUE_TEMPLATE/issue-notice.yml: ## @@ -47,6 +50,8 @@ body: 感谢您选择 Flink CDC! 由于 Apache Flink 的要求,请在 [Apache Jira](https://issues.apa

[jira] [Commented] (FLINK-33001) KafkaSource in batch mode failing with exception if topic partition is empty

2024-05-30 Thread Naci Simsek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850678#comment-17850678 ] Naci Simsek commented on FLINK-33001: - Just be able to try with the *flink-connector

[jira] [Comment Edited] (FLINK-33001) KafkaSource in batch mode failing with exception if topic partition is empty

2024-05-30 Thread Naci Simsek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850678#comment-17850678 ] Naci Simsek edited comment on FLINK-33001 at 5/30/24 10:41 AM: ---

[jira] [Comment Edited] (FLINK-33001) KafkaSource in batch mode failing with exception if topic partition is empty

2024-05-30 Thread Naci Simsek (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850678#comment-17850678 ] Naci Simsek edited comment on FLINK-33001 at 5/30/24 10:40 AM: ---

Re: [PR] [FLINK-34239][core] Add copy() method for SerializerConfig [flink]

2024-05-30 Thread via GitHub
kumar-mallikarjuna commented on PR #24544: URL: https://github.com/apache/flink/pull/24544#issuecomment-2139268835 Done, @reswqa . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Resolved] (FLINK-35484) Flink document file had removed but website can access

2024-05-30 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-35484. Resolution: Fixed Fixed via master: b1841c0ff34b6e8d118139f6f87b7fdf06afacd3 > Flink document fil

Re: [PR] [FLINK-35484][doc-ci] Flink document file had removed but website can access [flink]

2024-05-30 Thread via GitHub
leonardBang merged PR #24870: URL: https://github.com/apache/flink/pull/24870 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

Re: [PR] [FLINK-35363] FLIP-449: Reorganization of flink-connector-jdbc [flink-connector-jdbc]

2024-05-30 Thread via GitHub
eskabetxe commented on code in PR #123: URL: https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1620403861 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/JdbcFactory.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35463]Fixed issue for route rule changed when restored from checkpoint. [flink-cdc]

2024-05-30 Thread via GitHub
hk-lrzy commented on PR #3364: URL: https://github.com/apache/flink-cdc/pull/3364#issuecomment-2139205095 > exception got it, let me do the double check and give you reply asap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [FLINK-33461][Connector/JDBC] Support streaming related semantics for the new JDBC source [flink-connector-jdbc]

2024-05-30 Thread via GitHub
1996fanrui commented on code in PR #119: URL: https://github.com/apache/flink-connector-jdbc/pull/119#discussion_r1620372109 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/utils/ContinuousUnBoundingSettings.java: ## @@ -0,0 +1,86 @@ +/* + * Licensed to th

[jira] [Created] (FLINK-35491) [JUnit5 Migration] Module: Flink CDC modules

2024-05-30 Thread Muhammet Orazov (Jira)
Muhammet Orazov created FLINK-35491: --- Summary: [JUnit5 Migration] Module: Flink CDC modules Key: FLINK-35491 URL: https://issues.apache.org/jira/browse/FLINK-35491 Project: Flink Issue Type

[jira] [Commented] (FLINK-32384) Remove deprecated configuration keys which violate YAML spec

2024-05-30 Thread Kartikey Pant (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850664#comment-17850664 ] Kartikey Pant commented on FLINK-32384: --- Hello [~zhuzh], I am eager to start contr

[jira] [Commented] (FLINK-35490) [JUnit5 Migration] Module: Flink CDC flink-cdc-connect/flink-cdc-source-connectors

2024-05-30 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-35490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850663#comment-17850663 ] Muhammet Orazov commented on FLINK-35490: - I would be happy to work on this, ple

[jira] [Created] (FLINK-35490) [JUnit5 Migration] Module: Flink CDC flink-cdc-connect/flink-cdc-source-connectors

2024-05-30 Thread Muhammet Orazov (Jira)
Muhammet Orazov created FLINK-35490: --- Summary: [JUnit5 Migration] Module: Flink CDC flink-cdc-connect/flink-cdc-source-connectors Key: FLINK-35490 URL: https://issues.apache.org/jira/browse/FLINK-35490

[jira] [Commented] (FLINK-34585) [JUnit5 Migration] Module: Flink CDC

2024-05-30 Thread Muhammet Orazov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850662#comment-17850662 ] Muhammet Orazov commented on FLINK-34585: - Hey all, Since this is lots of effor

Re: [PR] [FLINK-35484][doc-ci] Flink document file had removed but website can access [flink]

2024-05-30 Thread via GitHub
leonardBang commented on PR #24870: URL: https://github.com/apache/flink/pull/24870#issuecomment-2139125612 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [FLINK-35463]Fixed issue for route rule changed when restored from checkpoint. [flink-cdc]

2024-05-30 Thread via GitHub
yuxiqian commented on PR #3364: URL: https://github.com/apache/flink-cdc/pull/3364#issuecomment-2139108465 Hi @hk-lrzy, I've compiled Flink CDC on your branch and tried to verify this patch by doing the following steps: 1. Create a MySQL source with tables (`alice`, `bob`, and `chris`

Re: [PR] [FLINK-35363] FLIP-449: Reorganization of flink-connector-jdbc [flink-connector-jdbc]

2024-05-30 Thread via GitHub
eskabetxe commented on code in PR #123: URL: https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1620277111 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/JdbcFactory.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35068][core][type] Introduce built-in serialization support for java.util.Set [flink]

2024-05-30 Thread via GitHub
jeyhunkarimov commented on code in PR #24845: URL: https://github.com/apache/flink/pull/24845#discussion_r1620282539 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/SetSerializer.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-35363] FLIP-449: Reorganization of flink-connector-jdbc [flink-connector-jdbc]

2024-05-30 Thread via GitHub
eskabetxe commented on code in PR #123: URL: https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1620277111 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/JdbcFactory.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-35363] FLIP-449: Reorganization of flink-connector-jdbc [flink-connector-jdbc]

2024-05-30 Thread via GitHub
eskabetxe commented on code in PR #123: URL: https://github.com/apache/flink-connector-jdbc/pull/123#discussion_r1620277111 ## flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/table/JdbcFactory.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache

[jira] [Comment Edited] (FLINK-33937) Translate "Stateful Stream Processing" page into Chinese

2024-05-30 Thread Pinrui Dong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850604#comment-17850604 ] Pinrui Dong edited comment on FLINK-33937 at 5/30/24 8:40 AM:

  1   2   >