Re: [PR] [FLINK-20772][State] Make TtlValueState#update follow the description of interface about null values [flink]

2023-12-13 Thread via GitHub
flinkbot commented on PR #23928: URL: https://github.com/apache/flink/pull/23928#issuecomment-1855354424 ## CI report: * 8b7dc770d95714c15529007ee011cd1ca2768fa3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-20772][State] Make TtlValueState#update follow the description of interface about null values [flink]

2023-12-13 Thread via GitHub
Zakelly opened a new pull request, #23928: URL: https://github.com/apache/flink/pull/23928 ## What is the purpose of the change Currently, the TtlValueState#update will wrap the user value with timestamp and proxy request to the original value state. It does not check the null value,

[jira] [Updated] (FLINK-20772) RocksDBValueState with TTL occurs NullPointerException when calling update(null) method

2023-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-20772: --- Labels: auto-deprioritized-major auto-deprioritized-minor beginner pull-request-available (

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-13 Thread via GitHub
schulzp commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1855334073 @reswqa, thanks `TestingSinkWriterMetricGroup` works on all tested versions. I only faced the arch rules issue locally, so far. -- This is an automated message from

Re: [PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-13 Thread via GitHub
flinkbot commented on PR #23927: URL: https://github.com/apache/flink/pull/23927#issuecomment-1855302232 ## CI report: * 85ba4659f937d58dd510aa63009c3939bc085300 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33743) Support consuming multiple subpartitions on a single channel

2023-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33743: --- Labels: pull-request-available (was: ) > Support consuming multiple subpartitions on a sing

[PR] [FLINK-33743][runtime] Support consuming multiple subpartitions on a single channel [flink]

2023-12-13 Thread via GitHub
yunfengzhou-hub opened a new pull request, #23927: URL: https://github.com/apache/flink/pull/23927 ## What is the purpose of the change This pull request adds support for consuming multiple subpartitions in a single input channel. ## Brief change log - Separate the n

[jira] [Commented] (FLINK-30535) Introduce TTL state based benchmarks

2023-12-13 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796585#comment-17796585 ] Zakelly Lan commented on FLINK-30535: - [~yunta] Sure, I would like to do this. > In

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-13 Thread via GitHub
KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1413318476 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolService.java: ## @@ -110,7 +110,7 @@ public Optional castInto(Class claz

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-12-13 Thread via GitHub
KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1426214331 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java: ## @@ -200,10 +226,45 @@ protected void onReleaseTaskManager

Re: [PR] [FLINK-33810][Runtime] Propagate RecordAttributes that contains isProcessingBacklog status [flink]

2023-12-13 Thread via GitHub
xintongsong commented on code in PR #23919: URL: https://github.com/apache/flink/pull/23919#discussion_r1426213522 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/RecordAttributesCombiner.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Softwa

[jira] [Closed] (FLINK-33781) Cleanup usage of deprecated org.apache.flink.table.api.TableConfig#ctor()

2023-12-13 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacky Lau closed FLINK-33781. - Resolution: Fixed > Cleanup usage of deprecated org.apache.flink.table.api.TableConfig#ctor() >

[jira] [Commented] (FLINK-30535) Introduce TTL state based benchmarks

2023-12-13 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796562#comment-17796562 ] Yun Tang commented on FLINK-30535: -- [~Zakelly] would you like to take this ticket? > I

Re: [PR] [FLINK-32756][ha] Implement reusable ClientHAServices and reuse it when creating RestClusterClient [flink]

2023-12-13 Thread via GitHub
flinkbot commented on PR #23926: URL: https://github.com/apache/flink/pull/23926#issuecomment-1855111482 ## CI report: * da9d3da97bf03d2c1bb33880c5f56b1b96fce493 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32756) Reuse ClientHighAvailabilityServices when creating RestClusterClient

2023-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32756: --- Labels: pull-request-available (was: ) > Reuse ClientHighAvailabilityServices when creating

[PR] [FLINK-32756][ha] Implement reusable ClientHAServices and reuse it when creating RestClusterClient [flink]

2023-12-13 Thread via GitHub
xiangyuf opened a new pull request, #23926: URL: https://github.com/apache/flink/pull/23926 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on ea

[jira] [Commented] (FLINK-30535) Introduce TTL state based benchmarks

2023-12-13 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796535#comment-17796535 ] Zakelly Lan commented on FLINK-30535: - big +1 for this > Introduce TTL state based

[jira] [Commented] (FLINK-33756) Missing record with CUMULATE/HOP windows using an optimization

2023-12-13 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796533#comment-17796533 ] Jim Hughes commented on FLINK-33756: Hi [~jeyhunkarimov], nice analysis!  I did see

Re: [PR] [FLINK-32028][connectors/elasticsearch] Allow customising bulk failure handling [flink-connector-elasticsearch]

2023-12-13 Thread via GitHub
reswqa commented on PR #83: URL: https://github.com/apache/flink-connector-elasticsearch/pull/83#issuecomment-1855090968 @schulzp, thank you for the investigation. 1. I think `TestingSinkWriterMetricGroup` might help. 2. Yes, this is a violations indeed. But I'm not sure if this wi

Re: [PR] [FLINK-33449][table]Support array_contains_seq function [flink]

2023-12-13 Thread via GitHub
xuyangzhong commented on PR #23656: URL: https://github.com/apache/flink/pull/23656#issuecomment-1855089363 Hi, @leoyy0316 and @MartijnVisser . Let's talk in the jira instead of this pr. I shared my view there. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (FLINK-33449) Support array_contains_seq function

2023-12-13 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796532#comment-17796532 ] xuyang commented on FLINK-33449: Hi, [~leoyy] thanks for driving this. IMO, this type of

[jira] [Updated] (FLINK-33819) Support setting CompressType in RocksDBStateBackend

2023-12-13 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-33819: --- Summary: Support setting CompressType in RocksDBStateBackend (was: Suppor setting CompressType in RocksDBSt

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-12-13 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796527#comment-17796527 ] Yue Ma commented on FLINK-27681: [~pnowojski] Thanks for your suggestion, I think this i

[jira] [Updated] (FLINK-33819) Suppor setting CompressType in RocksDBStateBackend

2023-12-13 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-33819: --- Description: Currently, RocksDBStateBackend does not support setting the compression level, and Snappy is u

[jira] [Updated] (FLINK-33819) Suppor setting CompressType in RocksDBStateBackend

2023-12-13 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yue Ma updated FLINK-33819: --- Attachment: image-2023-12-14-11-35-22-306.png > Suppor setting CompressType in RocksDBStateBackend > ---

[jira] [Created] (FLINK-33819) Suppor setting CompressType in RocksDBStateBackend

2023-12-13 Thread Yue Ma (Jira)
Yue Ma created FLINK-33819: -- Summary: Suppor setting CompressType in RocksDBStateBackend Key: FLINK-33819 URL: https://issues.apache.org/jira/browse/FLINK-33819 Project: Flink Issue Type: Improvemen

[jira] [Assigned] (FLINK-20772) RocksDBValueState with TTL occurs NullPointerException when calling update(null) method

2023-12-13 Thread Zakelly Lan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zakelly Lan reassigned FLINK-20772: --- Assignee: Zakelly Lan > RocksDBValueState with TTL occurs NullPointerException when calling

Re: [PR] [FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. [flink]

2023-12-13 Thread via GitHub
liming30 commented on PR #23922: URL: https://github.com/apache/flink/pull/23922#issuecomment-1855059115 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33588][Flink-Runtime] Fix NullArgumentException of getQuantile method in DescriptiveStatisticsHistogramStatistics [flink]

2023-12-13 Thread via GitHub
zhutong6688 commented on PR #23915: URL: https://github.com/apache/flink/pull/23915#issuecomment-1855054142 @JingGe Okay, I will resubmit it this evening and compress the submission -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-13 Thread via GitHub
masteryhx commented on PR #21635: URL: https://github.com/apache/flink/pull/21635#issuecomment-1855044542 > Hi @masteryhx , thanks for the contribution and update! > > I have reviewed this PR and left some comments. Please take a look in your free time, thanks~ > > Also, `The S

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-13 Thread via GitHub
masteryhx commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1426111500 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java: ## @@ -1244,8 +1244,8 @@ void testStateMigrationAfterChangingTTLFro

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-13 Thread via GitHub
masteryhx commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1426110489 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java: ## @@ -124,11 +124,40 @@ void readSnapshot(int readVersion, DataInputVi

[jira] [Commented] (FLINK-33754) Serialize QueryOperations into SQL

2023-12-13 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796517#comment-17796517 ] Benchao Li commented on FLINK-33754: [~dwysakowicz] Sorry to comment on a closed tic

Re: [PR] [FLINK-33686][client] Reuse ClusterDescriptor in AbstractSessionClusterExecutor [flink]

2023-12-13 Thread via GitHub
flinkbot commented on PR #23925: URL: https://github.com/apache/flink/pull/23925#issuecomment-1855022932 ## CI report: * af8119eece05028b05a3e079a69c5359dee3f1e1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-12-13 Thread via GitHub
masteryhx commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1426108037 ## flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeSerializerSnapshot.java: ## @@ -124,11 +124,40 @@ void readSnapshot(int readVersion, DataInputVi

[jira] [Updated] (FLINK-33686) Reuse ClusterDescriptor in AbstractSessionClusterExecutor when executing jobs on the same cluster

2023-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33686: --- Labels: pull-request-available (was: ) > Reuse ClusterDescriptor in AbstractSessionClusterE

[PR] [FLINK-33686][client] Reuse ClusterDescriptor in AbstractSessionClusterExecutor [flink]

2023-12-13 Thread via GitHub
xiangyuf opened a new pull request, #23925: URL: https://github.com/apache/flink/pull/23925 ## What is the purpose of the change Reuse ClusterDescriptor in AbstractSessionClusterExecutor ## Brief change log - Add `cachedClusterDescriptors` in `AbstractSessionCluster

Re: [PR] [FLINK-33809] HiveCatalog load hivemetastore-site.xml [flink]

2023-12-13 Thread via GitHub
flinkbot commented on PR #23924: URL: https://github.com/apache/flink/pull/23924#issuecomment-1855007709 ## CI report: * a6d6662bc551b60b528c863217219379fa415b0d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-13 Thread via GitHub
masteryhx commented on code in PR #23253: URL: https://github.com/apache/flink/pull/23253#discussion_r1426092346 ## flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java: ## @@ -164,6 +164,14 @@ public class CliFrontendParser { false

[jira] [Updated] (FLINK-33809) HiveCatalog load hivemetastore.xml

2023-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33809: --- Labels: pull-request-available (was: ) > HiveCatalog load hivemetastore.xml > -

[PR] [FLINK-33809] HiveCatalog load hivemetastore-site.xml [flink]

2023-12-13 Thread via GitHub
cuibo01 opened a new pull request, #23924: URL: https://github.com/apache/flink/pull/23924 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-13 Thread via GitHub
masteryhx commented on PR #23253: URL: https://github.com/apache/flink/pull/23253#issuecomment-1854996169 > @masteryhx @Zakelly Following your constructive comments, I have rearranged the commits and rebased to the master branch, please have a look, many thanks~ Thanks for the update

Re: [PR] [FLINK-32881][checkpoint] Support triggering savepoint in detach mode for CLI and dumping all pending savepoint ids by rest api [flink]

2023-12-13 Thread via GitHub
masteryhx commented on code in PR #23253: URL: https://github.com/apache/flink/pull/23253#discussion_r1426080866 ## flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java: ## @@ -188,6 +207,21 @@ CompletableFuture triggerSavepoint( */ Completab

[jira] [Resolved] (FLINK-33723) Disallow triggering incremental checkpoint explicitly from REST API

2023-12-13 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-33723. -- Resolution: Fixed merged 07d159bf into master > Disallow triggering incremental checkpoint ex

Re: [PR] [FLINK-33723] Disallow triggering incremental checkpoint explicitly from REST API [flink]

2023-12-13 Thread via GitHub
masteryhx closed pull request #23853: [FLINK-33723] Disallow triggering incremental checkpoint explicitly from REST API URL: https://github.com/apache/flink/pull/23853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [FLINK-33779][table] Cleanup usage of deprecated BaseExpressions#cast [flink]

2023-12-13 Thread via GitHub
liuyongvs commented on PR #23895: URL: https://github.com/apache/flink/pull/23895#issuecomment-1854975748 hi @lsyldliu @xuyangzhong will you also help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [FLINK-33778][table] Cleanup usage of deprecated TableConfig#setIdleS… [flink]

2023-12-13 Thread via GitHub
liuyongvs commented on PR #23894: URL: https://github.com/apache/flink/pull/23894#issuecomment-1854976683 hi @lsyldliu @xuyangzhong will you also help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [FLINK-33500][Runtime] Run storing the JobGraph an asynchronous operation [flink]

2023-12-13 Thread via GitHub
zhengzhili333 commented on code in PR #23880: URL: https://github.com/apache/flink/pull/23880#discussion_r1426063623 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobGraphWriter.java: ## @@ -37,6 +38,18 @@ public interface JobGraphWriter extends LocallyClea

[jira] [Commented] (FLINK-33781) Cleanup usage of deprecated org.apache.flink.table.api.TableConfig#ctor()

2023-12-13 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796507#comment-17796507 ] dalongliu commented on FLINK-33781: --- Merged to master: bb02698dee078446500d94246acf6b1

Re: [PR] [FLINK-33781][table] Cleanup usage of deprecated TableConfig#ctor [flink]

2023-12-13 Thread via GitHub
lsyldliu merged PR #23897: URL: https://github.com/apache/flink/pull/23897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

Re: [PR] [FLINK-33818] Implement restore tests for WindowDeduplicate node [flink]

2023-12-13 Thread via GitHub
flinkbot commented on PR #23923: URL: https://github.com/apache/flink/pull/23923#issuecomment-1854828911 ## CI report: * e7fdab8bf875d961bf1e29830864d9ee5a0f455f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33818) Implement restore tests for WindowDeduplicate node

2023-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33818: --- Labels: pull-request-available (was: ) > Implement restore tests for WindowDeduplicate node

[PR] [FLINK-33818] Implement restore tests for WindowDeduplicate node [flink]

2023-12-13 Thread via GitHub
bvarghese1 opened a new pull request, #23923: URL: https://github.com/apache/flink/pull/23923 ## What is the purpose of the change *Add restore tests for WindowDeduplicate node* ## Verifying this change This change added tests and can be verified as follows:

[jira] [Created] (FLINK-33818) Implement restore tests for WindowDeduplicate node

2023-12-13 Thread Bonnie Varghese (Jira)
Bonnie Varghese created FLINK-33818: --- Summary: Implement restore tests for WindowDeduplicate node Key: FLINK-33818 URL: https://issues.apache.org/jira/browse/FLINK-33818 Project: Flink Issu

[jira] [Updated] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2023-12-13 Thread Sai Sharath Dandi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sai Sharath Dandi updated FLINK-33817: -- Description: *Background*   The current Protobuf format [implementation|https://git

[jira] [Created] (FLINK-33817) Allow ReadDefaultValues = False for non primitive types on Proto3

2023-12-13 Thread Sai Sharath Dandi (Jira)
Sai Sharath Dandi created FLINK-33817: - Summary: Allow ReadDefaultValues = False for non primitive types on Proto3 Key: FLINK-33817 URL: https://issues.apache.org/jira/browse/FLINK-33817 Project:

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-13 Thread via GitHub
snuyanzin commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1425934480 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +98,70 @@ public JdbcDynamicTableSourc

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub
snuyanzin commented on PR #23914: URL: https://github.com/apache/flink/pull/23914#issuecomment-1854769170 @Jiabao-Sun >I tend to avoid too much CI failure through this PR until we find the root cause. >WDYT 🤔️ I put commit with WA I've described above at https://github.com/apa

[jira] [Commented] (FLINK-33804) Add Option to disable showing metrics in JobMananger UI

2023-12-13 Thread Lu Niu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796474#comment-17796474 ] Lu Niu commented on FLINK-33804: the whitelist will be a subset of metrics listed here

Re: [PR] [ FLINK-33603][FileSystems] shade guava in gs-fs filesystem [flink]

2023-12-13 Thread via GitHub
JingGe commented on PR #23489: URL: https://github.com/apache/flink/pull/23489#issuecomment-1854677694 Hi folks, thanks for driving it. @MartijnVisser my understanding is that your version won't work, since there still a `guava 27.0-jre` in the classpath. @singhravidutt: https:

[jira] [Commented] (FLINK-33804) Add Option to disable showing metrics in JobMananger UI

2023-12-13 Thread Lu Niu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796455#comment-17796455 ] Lu Niu commented on FLINK-33804: The problem we want to address: In default setting, th

[jira] [Comment Edited] (FLINK-33804) Add Option to disable showing metrics in JobMananger UI

2023-12-13 Thread Lu Niu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796455#comment-17796455 ] Lu Niu edited comment on FLINK-33804 at 12/13/23 8:36 PM: -- [~ma

Re: [PR] [ FLINK-33603][FileSystems] shade guava in gs-fs filesystem [flink]

2023-12-13 Thread via GitHub
JingGe commented on code in PR #23489: URL: https://github.com/apache/flink/pull/23489#discussion_r1425851930 ## flink-filesystems/flink-gs-fs-hadoop/pom.xml: ## @@ -188,6 +212,29 @@ under the License. shade

[jira] [Commented] (FLINK-33734) Merge unaligned checkpoint state handle

2023-12-13 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796391#comment-17796391 ] Piotr Nowojski commented on FLINK-33734: {quote} Yes, since multiple subtasks w

Re: [PR] [FLINK-33632] Adding custom flink mutator [flink-kubernetes-operator]

2023-12-13 Thread via GitHub
AncyRominus closed pull request #732: [FLINK-33632] Adding custom flink mutator URL: https://github.com/apache/flink-kubernetes-operator/pull/732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-13 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1425570925 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +98,70 @@ public JdbcDynamicTableSourc

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-13 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1425570925 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +98,70 @@ public JdbcDynamicTableSourc

[jira] [Commented] (FLINK-33756) Missing record with CUMULATE/HOP windows using an optimization

2023-12-13 Thread Jeyhun Karimov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796372#comment-17796372 ] Jeyhun Karimov commented on FLINK-33756: Hi [~jhughes] I had a chance to look at

Re: [PR] [FLINK-33770] Migrate legacy autoscaler config keys [flink-kubernetes-operator]

2023-12-13 Thread via GitHub
gyfora commented on code in PR #729: URL: https://github.com/apache/flink-kubernetes-operator/pull/729#discussion_r1425609941 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -247,21 +222,41 @@ private static ConfigOptions.Optio

[jira] [Updated] (FLINK-33632) Add custom mutator plugin

2023-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33632: --- Labels: pull-request-available (was: ) > Add custom mutator plugin > --

[PR] [FLINK-33632] Adding custom flink mutator [flink-kubernetes-operator]

2023-12-13 Thread via GitHub
AncyRominus opened a new pull request, #733: URL: https://github.com/apache/flink-kubernetes-operator/pull/733 ## What is the purpose of the change Adding Custom Flink Mutator ## Brief change log No change in logs ## Verifying this change *(Please pi

[jira] [Updated] (FLINK-33686) Reuse ClusterDescriptor in AbstractSessionClusterExecutor when executing jobs on the same cluster

2023-12-13 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-33686: - Summary: Reuse ClusterDescriptor in AbstractSessionClusterExecutor when executing jobs on the sa

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-13 Thread via GitHub
snuyanzin commented on PR #23917: URL: https://github.com/apache/flink/pull/23917#issuecomment-1854237160 interesting, retry of successful build does not work... will sumbit same commit with different comment -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-13 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1425570925 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +98,70 @@ public JdbcDynamicTableSourc

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-13 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1425382471 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +98,70 @@ public JdbcDynamicTableSourc

Re: [PR] [FLINK-33807] Update JUnit to 5.10.1 [flink]

2023-12-13 Thread via GitHub
snuyanzin commented on PR #23917: URL: https://github.com/apache/flink/pull/23917#issuecomment-1854127737 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (FLINK-33611) Add the ability to reuse variable names across different split method scopes

2023-12-13 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-33611: -- Assignee: Sai Sharath Dandi > Add the ability to reuse variable names across differen

Re: [PR] [FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. [flink]

2023-12-13 Thread via GitHub
flinkbot commented on PR #23922: URL: https://github.com/apache/flink/pull/23922#issuecomment-1854091789 ## CI report: * 7c02b054dfcf713a87e92344bbc95d0d8bd12393 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. [flink]

2023-12-13 Thread via GitHub
liming30 opened a new pull request, #23922: URL: https://github.com/apache/flink/pull/23922 ## What is the purpose of the change [FLINK-33798][statebackend/rocksdb] automatically clean up rocksdb logs when the task exited. ## Brief change log When the ta

[jira] [Updated] (FLINK-33798) Automatically clean up rocksdb logs when the task failover.

2023-12-13 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33798: --- Labels: pull-request-available (was: ) > Automatically clean up rocksdb logs when the task

Re: [PR] [FLINK-33057] Add options to disable creating job-id subdirectories under the checkpoint directory [flink]

2023-12-13 Thread via GitHub
Zakelly commented on PR #23509: URL: https://github.com/apache/flink/pull/23509#issuecomment-1854062776 @masteryhx @Myasuka Thanks for your review! I have addressed your comments, would you please take another look? Thanks! -- This is an automated message from the Apache Git Service. To

Re: [PR] [FLINK-33057] Add options to disable creating job-id subdirectories under the checkpoint directory [flink]

2023-12-13 Thread via GitHub
Zakelly commented on code in PR #23509: URL: https://github.com/apache/flink/pull/23509#discussion_r1425468192 ## flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java: ## @@ -228,6 +228,32 @@ public class CheckpointingOptions {

Re: [PR] [FLINK-33057] Add options to disable creating job-id subdirectories under the checkpoint directory [flink]

2023-12-13 Thread via GitHub
Zakelly commented on code in PR #23509: URL: https://github.com/apache/flink/pull/23509#discussion_r1425459440 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/memory/MemoryBackendCheckpointStorageAccess.java: ## @@ -72,6 +73,7 @@ public MemoryBackendCheckpointStora

Re: [PR] [FLINK-33057] Add options to disable creating job-id subdirectories under the checkpoint directory [flink]

2023-12-13 Thread via GitHub
Zakelly commented on code in PR #23509: URL: https://github.com/apache/flink/pull/23509#discussion_r1425456803 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsStateBackend.java: ## @@ -141,6 +141,12 @@ public class FsStateBackend extends AbstractFileS

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-13 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1425444399 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +98,70 @@ public JdbcDynamicTableSourc

[PR] Adding custom flink mutator [flink-kubernetes-operator]

2023-12-13 Thread via GitHub
AncyRominus opened a new pull request, #732: URL: https://github.com/apache/flink-kubernetes-operator/pull/732 ## What is the purpose of the change *(For example: This pull request adds a new feature to periodically create and maintain savepoints through the `FlinkDeployment`

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-13 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1425382471 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +98,70 @@ public JdbcDynamicTableSourc

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-13 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1425382471 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +98,70 @@ public JdbcDynamicTableSourc

Re: [PR] [FLINK-33795] Add new config to forbid autoscaling in certain periods of a day [flink-kubernetes-operator]

2023-12-13 Thread via GitHub
flashJd commented on code in PR #728: URL: https://github.com/apache/flink-kubernetes-operator/pull/728#discussion_r1425382922 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/config/AutoScalerOptions.java: ## @@ -72,6 +72,15 @@ private static ConfigOptions.OptionB

Re: [PR] [FLINK-33365] include filters with Lookup joins [flink-connector-jdbc]

2023-12-13 Thread via GitHub
davidradl commented on code in PR #79: URL: https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1425382471 ## flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSource.java: ## @@ -96,28 +98,70 @@ public JdbcDynamicTableSourc

Re: [PR] [FLINK-33767] Implement restore tests for TemporalJoin node [flink]

2023-12-13 Thread via GitHub
dawidwys commented on code in PR #23916: URL: https://github.com/apache/flink/pull/23916#discussion_r1425373388 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/test/program/TemporalFunctionTestStep.java: ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache

[jira] [Commented] (FLINK-26644) python StreamExecutionEnvironmentTests.test_generate_stream_graph_with_dependencies failed on azure

2023-12-13 Thread Jim Hughes (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796276#comment-17796276 ] Jim Hughes commented on FLINK-26644: [https://dev.azure.com/apache-flink/apache-flin

[jira] [Updated] (FLINK-33815) Add tests against jdk17 for pulsar connector

2023-12-13 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-33815: --- Fix Version/s: pulsar-4.2.0 > Add tests against jdk17 for pulsar connector > ---

[jira] [Updated] (FLINK-33815) Add tests against jdk17 for pulsar connector

2023-12-13 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-33815: --- Affects Version/s: pulsar-4.0.1 > Add tests against jdk17 for pulsar connector > ---

[jira] [Resolved] (FLINK-33815) Add tests against jdk17 for pulsar connector

2023-12-13 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-33815. Resolution: Fixed Implemented in main(4.2): 8bfbe33f86a45b4757a9cd1f19f2ede5da771487 > Add tests

Re: [PR] [FLINK-33815][Connector / Pulsar] Add tests against jdk17 for pulsar connector [flink-connector-pulsar]

2023-12-13 Thread via GitHub
leonardBang merged PR #71: URL: https://github.com/apache/flink-connector-pulsar/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

Re: [PR] [FLINK-33815][Connector / Pulsar] Add tests against jdk17 for pulsar connector [flink-connector-pulsar]

2023-12-13 Thread via GitHub
snuyanzin commented on PR #71: URL: https://github.com/apache/flink-connector-pulsar/pull/71#issuecomment-1853797497 @leonardBang @tisonkun could you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (FLINK-33454) Adding tls configuration to IngressSpec

2023-12-13 Thread dongwoo.kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17796210#comment-17796210 ] dongwoo.kim commented on FLINK-33454: - [~ryanvanhuuksloot] sorry for the late reply,

Re: [PR] [FLINK-33641][test] Suppress the DirectoryNotEmptyException in StreamingWithStateTestBase to prevent test failures [flink]

2023-12-13 Thread via GitHub
snuyanzin commented on PR #23914: URL: https://github.com/apache/flink/pull/23914#issuecomment-1853781175 I tested with junit5.10.1 and I think it also introduced some changes if you look at PR https://github.com/apache/flink/pull/23917 where there is only junit bump 5.9.1 -> 5.10.1 ci

Re: [PR] [FLINK-33764] Track Heap usage and GC pressure to avoid unnecessary scaling [flink-kubernetes-operator]

2023-12-13 Thread via GitHub
gyfora commented on code in PR #726: URL: https://github.com/apache/flink-kubernetes-operator/pull/726#discussion_r1425246326 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/RestApiMetricsCollector.java: ## @@ -78,19 +99,89 @@ protected Map queryAggregatedVertexM

  1   2   >