masteryhx commented on code in PR #23253:
URL: https://github.com/apache/flink/pull/23253#discussion_r1426092346


##########
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java:
##########
@@ -164,6 +164,14 @@ public class CliFrontendParser {
                     false,
                     "Defines whether to trigger this checkpoint as a full 
one.");
 
+    static final Option SAVEPOINT_DETACH_OPTION =

Review Comment:
   1. How about just using 'detached' here aligned with DETACHED_OPTION ? It 
should not be conflict with other one because it will only be checked in 
savepoint and stop-with-savepoint command, right ? It will help us migrating in 
the future.
   2. I saw this could also be used for manual checkpoint. Of course, we could 
support this in other ticket/pr.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to