Re: [PR] [hotfix][docs] Remove the OverrideDefault annotation for option slotmanager.number-of-slots.min [flink]

2023-10-14 Thread via GitHub
xiangyuf commented on PR #23525: URL: https://github.com/apache/flink/pull/23525#issuecomment-1763200478 Hi @KarmaGYZ , can you help review this when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [FLINK-33235][doc] Update OLAP QuickStart doc and translate to Chinese [flink]

2023-10-14 Thread via GitHub
xiangyuf commented on PR #23523: URL: https://github.com/apache/flink/pull/23523#issuecomment-1763200364 @KarmaGYZ @FangYongs Hi, can you help review this when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [hotfix][docs] Remove the OverrideDefault annotation for option slotmanager.number-of-slots.min [flink]

2023-10-14 Thread via GitHub
flinkbot commented on PR #23525: URL: https://github.com/apache/flink/pull/23525#issuecomment-1763111289 ## CI report: * 92dd674424246c8fef41f98792df0a97aa8df664 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][docs] Remove the OverrideDefault annotation for option slotmanager.number-of-slots.min [flink]

2023-10-14 Thread via GitHub
xiangyuf opened a new pull request, #23525: URL: https://github.com/apache/flink/pull/23525 ## What is the purpose of the change Remove the OverrideDefault annotation for option `slotmanager.number-of-slots.min`. ## Brief change log Remove the OverrideDefault annotat

Re: [PR] [FLINK-33235][doc] Update OLAP QuickStart doc and translate to Chinese [flink]

2023-10-14 Thread via GitHub
xiangyuf commented on PR #23523: URL: https://github.com/apache/flink/pull/23523#issuecomment-1763086952 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33235][doc] Update OLAP QuickStart doc and translate to Chinese [flink]

2023-10-14 Thread via GitHub
xiangyuf commented on PR #23523: URL: https://github.com/apache/flink/pull/23523#issuecomment-1763083586 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33235][doc] Update OLAP QuickStart doc and translate to Chinese [flink]

2023-10-14 Thread via GitHub
xiangyuf commented on PR #23523: URL: https://github.com/apache/flink/pull/23523#issuecomment-1763063085 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33235][doc] Update OLAP QuickStart doc and translate to Chinese [flink]

2023-10-14 Thread via GitHub
xiangyuf commented on PR #23523: URL: https://github.com/apache/flink/pull/23523#issuecomment-1763060499 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33030][python]Add python 3.11 support [flink]

2023-10-14 Thread via GitHub
gaborgsomogyi commented on PR #23417: URL: https://github.com/apache/flink/pull/23417#issuecomment-1763037841 We're good to go :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] [FLINK-33171][table planner] Table SQL support Not Equal for TimePoint type and TimeString [flink]

2023-10-14 Thread via GitHub
fengjiajie commented on code in PR #23478: URL: https://github.com/apache/flink/pull/23478#discussion_r1359458406 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala: ## @@ -488,6 +488,18 @@ object ScalarOperato

Re: [PR] [FLINK-33171][table planner] Table SQL support Not Equal for TimePoint type and TimeString [flink]

2023-10-14 Thread via GitHub
fengjiajie commented on PR #23478: URL: https://github.com/apache/flink/pull/23478#issuecomment-1762985221 @lincoln-lil Based on the approach you provided, I attempted to write some test cases. However, there are two types that are not covered: 1. non comparable types: I don't know h

[jira] [Commented] (FLINK-33238) Upgrade org.apache.avro:avro to 1.11.3 to mitigate CVE-2023-39410

2023-10-14 Thread Andrei Leib (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775250#comment-17775250 ] Andrei Leib commented on FLINK-33238: - Hi [~martijnvisser] I noticed this Jira after

Re: [PR] [AVRO-3536] [flink-avro] Union type not inheriting type conversions [flink]

2023-10-14 Thread via GitHub
flinkbot commented on PR #23524: URL: https://github.com/apache/flink/pull/23524#issuecomment-1762937761 ## CI report: * b2a8c2ea90d27269f42b66848d63f37c622fc3dd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] Bump avro [flink]

2023-10-14 Thread via GitHub
m8719-github opened a new pull request, #23524: URL: https://github.com/apache/flink/pull/23524 ## What is the purpose of the change Apache Avro 1.11.2 contains an important fix: [AVRO-3536](https://issues.apache.org/jira/browse/AVRO-3536) Just want to make sure it makes it

[jira] [Updated] (FLINK-33235) Improve the Quickstart guide for Flink OLAP and translate to Chinese

2023-10-14 Thread xiangyu feng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xiangyu feng updated FLINK-33235: - Description: 1, Follow the [https://flink.apache.org/how-to-contribute/documentation-style-guid

Re: [PR] [FLINK-33235][doc] Update OLAP QuickStart doc and translate to Chinese [flink]

2023-10-14 Thread via GitHub
flinkbot commented on PR #23523: URL: https://github.com/apache/flink/pull/23523#issuecomment-1762920258 ## CI report: * 8a105d5f559f282991b45916892ac38e7b36cd45 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33235) Improve the Quickstart guide for Flink OLAP and translate to Chinese

2023-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33235: --- Labels: pull-request-available (was: ) > Improve the Quickstart guide for Flink OLAP and tr

[PR] [FLINK-33235][doc] Update OLAP QuickStart doc and translate to Chinese [flink]

2023-10-14 Thread via GitHub
xiangyuf opened a new pull request, #23523: URL: https://github.com/apache/flink/pull/23523 ## What is the purpose of the change Update Flink OLAP quickstart and translate to Chinese ## Brief change log - Follow the [documentation style guide](https://flink.apache.org/ho

Re: [PR] [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods [flink]

2023-10-14 Thread via GitHub
afedulov commented on PR #22850: URL: https://github.com/apache/flink/pull/22850#issuecomment-1762903558 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33097][autoscaler] Initialize the generic autoscaler module and interfaces [flink-kubernetes-operator]

2023-10-14 Thread via GitHub
mateczagany commented on code in PR #677: URL: https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1359305741 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesJobAutoScalerContext.java: ## @@ -0,0 +1,67 @@

Re: [PR] [FLINK-33030][python]Add python 3.11 support [flink]

2023-10-14 Thread via GitHub
gaborgsomogyi commented on PR #23417: URL: https://github.com/apache/flink/pull/23417#issuecomment-1762818432 Finally there is a green result including wheel builds: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=53722&view=results Reverting the azure hack agains a

Re: [PR] [FLINK-33255] [table] Validate argument count during type inference [flink]

2023-10-14 Thread via GitHub
snuyanzin commented on code in PR #23520: URL: https://github.com/apache/flink/pull/23520#discussion_r1359230362 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java: ## @@ -1948,9 +1951,23 @@ public CalciteException handleUnreso

[jira] [Assigned] (FLINK-33275) CLONE - Vote on the release candidate

2023-10-14 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-33275: - Assignee: Chris > CLONE - Vote on the release candidate > -

[jira] [Assigned] (FLINK-33275) CLONE - Vote on the release candidate

2023-10-14 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dalongliu reassigned FLINK-33275: - Assignee: (was: Chris) > CLONE - Vote on the release candidate > --