mateczagany commented on code in PR #677: URL: https://github.com/apache/flink-kubernetes-operator/pull/677#discussion_r1359305741
########## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/KubernetesJobAutoScalerContext.java: ########## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.kubernetes.operator.autoscaler; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.api.common.JobStatus; +import org.apache.flink.autoscaler.JobAutoScalerContext; +import org.apache.flink.client.program.rest.RestClusterClient; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.kubernetes.operator.api.AbstractFlinkResource; +import org.apache.flink.metrics.MetricGroup; +import org.apache.flink.util.function.SupplierWithException; + +import io.fabric8.kubernetes.client.KubernetesClient; +import io.javaoperatorsdk.operator.processing.event.ResourceID; + +import javax.annotation.Nullable; + +/** An implementation of JobAutoscalerContext for Kubernetes. */ +public class KubernetesJobAutoScalerContext extends JobAutoScalerContext<ResourceID> { + + private final AbstractFlinkResource<?, ?> resource; + + private final KubernetesClient kubernetesClient; + + public KubernetesJobAutoScalerContext( + JobID jobID, Review Comment: jobID should also be `@Nullable` ########## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingMetricCollector.java: ########## @@ -441,15 +442,21 @@ protected Collection<AggregatedMetric> queryAggregatedMetricNames( protected abstract Map<JobVertexID, Map<FlinkMetric, AggregatedMetric>> queryAllAggregatedMetrics( - AbstractFlinkResource<?, ?> cr, - FlinkService flinkService, - Configuration conf, + Context ctx, Map<JobVertexID, Map<String, FlinkMetric>> filteredVertexMetricNames); - public void cleanup(AbstractFlinkResource<?, ?> cr) { - var resourceId = ResourceID.fromResource(cr); - histories.remove(resourceId); - availableVertexMetricNames.remove(resourceId); + public JobDetailsInfo getJobDetailsInfo( + JobAutoScalerContext<KEY> context, Duration clientTimeout) throws Exception { Review Comment: I don't expect it to be fixed in this PR, just want to note that this is an abstract class with `RestApiMetricsCollector` extending it. This makes it seem like it would be possible to extend this class to be able to collect metrics via methods other than REST API. This would already be a challenge as there are several REST API calls already in this class, but with this PR, we will also tie this class to REST API with `JobAutoScalerContext`. Perhaps it makes sense to remove `RestApiMetricsCollector` at this point? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
