Re: [PR] [FLINK-33007] Integrate autoscaler config validation into the general validator flow [flink-kubernetes-operator]

2023-10-02 Thread via GitHub
mateczagany commented on code in PR #682: URL: https://github.com/apache/flink-kubernetes-operator/pull/682#discussion_r1343536043 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/validation/AutoScalerValidator.java: ## @@ -0

[jira] [Updated] (FLINK-32733) Add AlgoOperator for FpGrowth

2023-10-02 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-32733: --- Labels: pull-request-available stale-major (was: pull-request-available) I am the [Flink Ji

Re: [PR] [hotfix][ci] Set AWS end-to-end tests to run on all push [flink-connector-aws]

2023-10-02 Thread via GitHub
hlteoh37 merged PR #100: URL: https://github.com/apache/flink-connector-aws/pull/100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

Re: [PR] [FLINK-33007] Integrate autoscaler config validation into the general validator flow [flink-kubernetes-operator]

2023-10-02 Thread via GitHub
srpraneeth commented on PR #682: URL: https://github.com/apache/flink-kubernetes-operator/pull/682#issuecomment-1743670601 @gyfora Can you please take a look at this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [FLINK-33159] [build] use variables in pom file for Java and Maven versions [flink]

2023-10-02 Thread via GitHub
ferenc-csaky commented on code in PR #23469: URL: https://github.com/apache/flink/pull/23469#discussion_r1341880718 ## pom.xml: ## @@ -1764,8 +1768,7 @@ under the License.

Re: [PR] [FLINK-15462][connectors] Add Trino dialect [flink-connector-jdbc]

2023-10-02 Thread via GitHub
eskabetxe commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1342945228 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/testutils/databases/trino/TrinoDatabasePost.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed t

Re: [PR] [FLINK-15462][connectors] Add Trino dialect [flink-connector-jdbc]

2023-10-02 Thread via GitHub
eskabetxe commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1342944619 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/trino/dialect/TrinoPreparedStatementTest.java: ## @@ -0,0 +1,153 @@ +/* + * Li

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
bvarghese1 commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342912753 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -776,6 +780,14 @@ protected void convertSelectImpl(final Bl

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
JingGe commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342647998 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -776,6 +780,14 @@ protected void convertSelectImpl(final Blackb

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
dawidwys commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342877025 ## docs/layouts/shortcodes/generated/table_config_configuration.html: ## @@ -62,6 +62,12 @@ String The local time zone defines current sessio

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
dawidwys commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342858444 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -776,6 +780,14 @@ protected void convertSelectImpl(final Blac

[jira] [Created] (FLINK-33177) Memory leak in MockStreamingRuntimeContext

2023-10-02 Thread Ryan Skraba (Jira)
Ryan Skraba created FLINK-33177: --- Summary: Memory leak in MockStreamingRuntimeContext Key: FLINK-33177 URL: https://issues.apache.org/jira/browse/FLINK-33177 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-33159] [build] use variables in pom file for Java and Maven versions [flink]

2023-10-02 Thread via GitHub
davidradl commented on PR #23469: URL: https://github.com/apache/flink/pull/23469#issuecomment-1743135401 thanks @MartijnVisser . I am looking forward to your review @zentol :-) . If we are ok with this, please could you assign me the issue and pr. -- This is an automated message from t

Re: [PR] [FLINK-21883][scheduler] Implement cooldown period for adaptive scheduler [flink]

2023-10-02 Thread via GitHub
echauchot commented on PR #22985: URL: https://github.com/apache/flink/pull/22985#issuecomment-1743082203 > > > > ## CI report: > > > > > > > > * [6fa4048](https://github.com/apache/flink/commit/6fa40484d3725b7b4e4b095171a20f57b72ce7d5) Azure: [FAILURE](https://dev.azure.com/apache-

Re: [PR] [FLINK-33046][FLIP-333] Redesign Apache Flink website [flink-web]

2023-10-02 Thread via GitHub
dannycranmer commented on PR #676: URL: https://github.com/apache/flink-web/pull/676#issuecomment-1743022204 > Why is "Powered By" in the footer and not in the "About" menu? This is as per the FLIP design. Would you prefer it in both locations, or just under About? > Is the sec

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
snuyanzin commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342695582 ## docs/layouts/shortcodes/generated/table_config_configuration.html: ## @@ -62,6 +62,12 @@ String The local time zone defines current sessi

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
snuyanzin commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342695582 ## docs/layouts/shortcodes/generated/table_config_configuration.html: ## @@ -62,6 +62,12 @@ String The local time zone defines current sessi

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
snuyanzin commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342695582 ## docs/layouts/shortcodes/generated/table_config_configuration.html: ## @@ -62,6 +62,12 @@ String The local time zone defines current sessi

Re: [PR] [FLINK-33046][FLIP-333] Redesign Apache Flink website [flink-web]

2023-10-02 Thread via GitHub
dannycranmer commented on code in PR #676: URL: https://github.com/apache/flink-web/pull/676#discussion_r1342693215 ## docs/i18n/en.yaml: ## @@ -0,0 +1,163 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
snuyanzin commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342686349 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -776,6 +780,14 @@ protected void convertSelectImpl(final Bla

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
snuyanzin commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342686349 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -776,6 +780,14 @@ protected void convertSelectImpl(final Bla

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
JingGe commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342647998 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -776,6 +780,14 @@ protected void convertSelectImpl(final Blackb

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
JingGe commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342647998 ## flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java: ## @@ -776,6 +780,14 @@ protected void convertSelectImpl(final Blackb

[jira] [Created] (FLINK-33176) Kinesis source throws NullPointerException in Table API on ignored parsing errors

2023-10-02 Thread Aleksandr Pilipenko (Jira)
Aleksandr Pilipenko created FLINK-33176: --- Summary: Kinesis source throws NullPointerException in Table API on ignored parsing errors Key: FLINK-33176 URL: https://issues.apache.org/jira/browse/FLINK-33176

Re: [PR] [FLINK-32873][table] - Add config to allow disabling QUERY hints [flink]

2023-10-02 Thread via GitHub
dawidwys commented on code in PR #23223: URL: https://github.com/apache/flink/pull/23223#discussion_r1342612321 ## docs/layouts/shortcodes/generated/table_config_configuration.html: ## @@ -62,6 +62,12 @@ String The local time zone defines current sessio

Re: [PR] [hotfix][ci] Set AWS end-to-end tests to run for all CI runs against [flink-connector-aws]

2023-10-02 Thread via GitHub
hlteoh37 closed pull request #101: [hotfix][ci] Set AWS end-to-end tests to run for all CI runs against URL: https://github.com/apache/flink-connector-aws/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] [docs] Update Vendor Solutions [flink]

2023-10-02 Thread via GitHub
flinkbot commented on PR #23482: URL: https://github.com/apache/flink/pull/23482#issuecomment-1742763737 ## CI report: * e92682144cdca0d9fb8cb12f076b24baaf16b80a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [docs] Update Vendor Solutions [flink]

2023-10-02 Thread via GitHub
rmoff opened a new pull request, #23482: URL: https://github.com/apache/flink/pull/23482 - Add Decodable and Aiven - Update the name of AWS's offering (it's now called Amazon Managed Service for Apache Flink) ## What is the purpose of the change There are more vendors of

Re: [PR] [hotfix] Temporarily swap nightlies over to the released versions to … [flink-connector-aws]

2023-10-02 Thread via GitHub
hlteoh37 commented on code in PR #100: URL: https://github.com/apache/flink-connector-aws/pull/100#discussion_r1342512170 ## .github/workflows/common.yml: ## @@ -120,7 +115,7 @@ jobs: mvn clean - name: Run AWS e2e tests -if: ${{ inputs.run_aws_end_to

Re: [PR] [FLINK-15462][connectors] Add Trino dialect [flink-connector-jdbc]

2023-10-02 Thread via GitHub
snuyanzin commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1342484168 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/testutils/databases/trino/TrinoDatabasePost.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed t

Re: [PR] [FLINK-15462][connectors] Add Trino dialect [flink-connector-jdbc]

2023-10-02 Thread via GitHub
snuyanzin commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1342485701 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/trino/dialect/TrinoPreparedStatementTest.java: ## @@ -0,0 +1,153 @@ +/* + * Li

Re: [PR] [hotfix] Temporarily swap nightlies over to the released versions to … [flink-connector-aws]

2023-10-02 Thread via GitHub
hlteoh37 commented on code in PR #100: URL: https://github.com/apache/flink-connector-aws/pull/100#discussion_r1342483443 ## .github/workflows/common.yml: ## @@ -120,7 +115,7 @@ jobs: mvn clean - name: Run AWS e2e tests -if: ${{ inputs.run_aws_end_to

Re: [PR] [FLINK-15462][connectors] Add Trino dialect [flink-connector-jdbc]

2023-10-02 Thread via GitHub
snuyanzin commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1342482739 ## pom.xml: ## @@ -280,6 +280,13 @@ under the License. test + + +org.apache.commons +

[PR] [hotfix][ci] Set AWS end-to-end tests to run for all CI runs against [flink-connector-aws]

2023-10-02 Thread via GitHub
hlteoh37 opened a new pull request, #101: URL: https://github.com/apache/flink-connector-aws/pull/101 main branch # DO NOT MERGE. testing behavior of github actions when merge branch is named `main` -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] [FLINK-15462][connectors] Add Trino dialect [flink-connector-jdbc]

2023-10-02 Thread via GitHub
snuyanzin commented on code in PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#discussion_r1342482739 ## pom.xml: ## @@ -280,6 +280,13 @@ under the License. test + + +org.apache.commons +

Re: [PR] [hotfix] Temporarily swap nightlies over to the released versions to … [flink-connector-aws]

2023-10-02 Thread via GitHub
hlteoh37 commented on code in PR #100: URL: https://github.com/apache/flink-connector-aws/pull/100#discussion_r1342482159 ## .github/workflows/common.yml: ## @@ -120,7 +115,7 @@ jobs: mvn clean - name: Run AWS e2e tests -if: ${{ inputs.run_aws_end_to

Re: [PR] [hotfix] Temporarily swap nightlies over to the released versions to … [flink-connector-aws]

2023-10-02 Thread via GitHub
dannycranmer commented on code in PR #100: URL: https://github.com/apache/flink-connector-aws/pull/100#discussion_r1342480652 ## .github/workflows/common.yml: ## @@ -120,7 +115,7 @@ jobs: mvn clean - name: Run AWS e2e tests -if: ${{ inputs.run_aws_en

Re: [PR] [FLINK-15462][connectors] Add Trino dialect [flink-connector-jdbc]

2023-10-02 Thread via GitHub
eskabetxe commented on PR #3: URL: https://github.com/apache/flink-connector-jdbc/pull/3#issuecomment-1742659851 @snuyanzin @MartijnVisser could you check please.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[PR] [hotfix] Temporarily swap nightlies over to the released versions to … [flink-connector-aws]

2023-10-02 Thread via GitHub
hlteoh37 opened a new pull request, #100: URL: https://github.com/apache/flink-connector-aws/pull/100 …test AWS credentials for end-to-end test ## Purpose of the change * Flink nightlies are failing because the snapshots are not available to download from S3. We will tempor