JingGe commented on code in PR #23223:
URL: https://github.com/apache/flink/pull/23223#discussion_r1342647998
##########
flink-table/flink-table-planner/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -776,6 +780,14 @@ protected void convertSelectImpl(final Blackboard bb,
SqlSelect select) {
convertOrder(select, bb, collation, orderExprList, select.getOffset(),
select.getFetch());
if (select.hasHints()) {
+ FlinkContext context = ShortcutUtils.unwrapContext(cluster);
+ if
(context.getTableConfig().get(TableConfigOptions.TABLE_QUERY_HINTS_IGNORE)) {
+ throw new ValidationException(
Review Comment:
Thanks for working on this topic. I was wondering why exception will be
thrown. The idea was to ingore hints, not disallow them, i.e. SQLs/hints are
still valid, even if the ignore config is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
