[GitHub] [flink] XComp commented on pull request #22829: [FLINK-30342][test] Migrates ZooKeeperLeaderElectionTest to use the MultipleComponentLeaderElectionDriver interface

2023-06-19 Thread via GitHub
XComp commented on PR #22829: URL: https://github.com/apache/flink/pull/22829#issuecomment-1598216745 I had to change the order of the PRs because I realized that I did assign a few commits to the wrong branch/PR. But I didn't want to touch the already approved PR FLINK-30344. I updated the

[GitHub] [flink] XComp commented on pull request #22830: [FLINK-30343][test] Migrates KubernetesLeaderElectionAndRetrievalITCase to use the MultipleComponentLeaderElectionDriver interface

2023-06-19 Thread via GitHub
XComp commented on PR #22830: URL: https://github.com/apache/flink/pull/22830#issuecomment-1598216870 I had to change the order of the PRs because I realized that I did assign a few commits to the wrong branch/PR. But I didn't want to touch the already approved PR FLINK-30344. I updated the

[jira] [Comment Edited] (FLINK-31923) Connector weekly runs are only testing main branches instead of all supported branches

2023-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733002#comment-17733002 ] Martijn Visser edited comment on FLINK-31923 at 6/20/23 6:54 AM: -

[jira] [Commented] (FLINK-20628) Port RabbitMQ Sources to FLIP-27 API

2023-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735160#comment-17735160 ] Martijn Visser commented on FLINK-20628: [~RocMarshal] I've assigned the ticket

[jira] [Assigned] (FLINK-20628) Port RabbitMQ Sources to FLIP-27 API

2023-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-20628: -- Assignee: RocMarshal > Port RabbitMQ Sources to FLIP-27 API > ---

[GitHub] [flink] XComp commented on pull request #22829: [FLINK-30342][test] Migrates ZooKeeperLeaderElectionTest to use the MultipleComponentLeaderElectionDriver interface

2023-06-19 Thread via GitHub
XComp commented on PR #22829: URL: https://github.com/apache/flink/pull/22829#issuecomment-1598180313 Force-pushed rebase to master (no additional changes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (FLINK-32180) Move error handling into MultipleComponentLeaderElectionDriverFactory

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-32180. --- Fix Version/s: 1.18.0 Resolution: Fixed master: 6a410899e2c57059f9944e8dd35742efa1358

[GitHub] [flink] XComp merged pull request #22656: [FLINK-32180][runtime] Moves error handling from DefaultMultipleComponentLeaderElectionService into the MultipleComponentLeaderElectionDriver impleme

2023-06-19 Thread via GitHub
XComp merged PR #22656: URL: https://github.com/apache/flink/pull/22656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[jira] [Resolved] (FLINK-32371) Bump snappy-java to 1.1.10.1

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-32371. --- Fix Version/s: 1.16.3 1.17.2 Resolution: Fixed > Bump snappy-java

[jira] [Comment Edited] (FLINK-32371) Bump snappy-java to 1.1.10.1

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734063#comment-17734063 ] Matthias Pohl edited comment on FLINK-32371 at 6/20/23 6:03 AM: --

[GitHub] [flink] XComp merged pull request #22823: [BP-1.16][FLINK-32371][build] Bump snappy-java to 1.1.10.1

2023-06-19 Thread via GitHub
XComp merged PR #22823: URL: https://github.com/apache/flink/pull/22823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[GitHub] [flink] XComp merged pull request #22822: [BP-1.17][FLINK-32371][build] Bump snappy-java to 1.1.10.1

2023-06-19 Thread via GitHub
XComp merged PR #22822: URL: https://github.com/apache/flink/pull/22822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[GitHub] [flink] reswqa commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
reswqa commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234767876 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/TieredStorageConsumerClientTest.java: ## @@ -0,0 +1,74 @@ +/* + * Licens

[GitHub] [flink] snuyanzin commented on pull request #17867: [FLINK-24592][Table SQL/Client] FlinkSQL Client multiline parser improvements

2023-06-19 Thread via GitHub
snuyanzin commented on PR #17867: URL: https://github.com/apache/flink/pull/17867#issuecomment-1598142720 Thanks for having a look @reswqa , @fsk119 I've rebased, tests are passed will merge soon -- This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (FLINK-32137) Flame graph is hard to use with many task managers

2023-06-19 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735128#comment-17735128 ] Rui Fan commented on FLINK-32137: - A mistake has just occurred about assignee. Hi [~net

[jira] [Assigned] (FLINK-32137) Flame graph is hard to use with many task managers

2023-06-19 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-32137: --- Assignee: Vladimir Matveev (was: Rui Fan) > Flame graph is hard to use with many task managers > -

[jira] [Assigned] (FLINK-32137) Flame graph is hard to use with many task managers

2023-06-19 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-32137: --- Assignee: Rui Fan (was: Vladimir Matveev) > Flame graph is hard to use with many task managers > -

[GitHub] [flink] curcur commented on pull request #22590: [FLINK-32071] Implement the snapshot manager for merged checkpoint files in TM

2023-06-19 Thread via GitHub
curcur commented on PR #22590: URL: https://github.com/apache/flink/pull/22590#issuecomment-1598107276 @Zakelly Thanks for the efforts! I've gone through another pass, LGTM. A couple of things left: 1. squash the commits (address comments e.t.c) 2. run the bot again (the pip

[GitHub] [flink] FangYongs commented on pull request #22768: [FLINK-32309][sql-gateway] Use independent resource manager for table environment

2023-06-19 Thread via GitHub
FangYongs commented on PR #22768: URL: https://github.com/apache/flink/pull/22768#issuecomment-1598082695 Hi @fsk119 Please help to review this PR when you are free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (FLINK-32310) Support enhanced show functions syntax

2023-06-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17735108#comment-17735108 ] luoyuxia commented on FLINK-32310: -- [~lemonjing] Sorry to bother you. I'm wondering the

[jira] [Created] (FLINK-32387) InputGateDeploymentDescriptor uses cache to avoid deserializing shuffle descriptors multiple times

2023-06-19 Thread Weihua Hu (Jira)
Weihua Hu created FLINK-32387: - Summary: InputGateDeploymentDescriptor uses cache to avoid deserializing shuffle descriptors multiple times Key: FLINK-32387 URL: https://issues.apache.org/jira/browse/FLINK-32387

[jira] [Updated] (FLINK-32383) 2.0 Breaking configuration changes

2023-06-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-32383: Priority: Blocker (was: Major) > 2.0 Breaking configuration changes > --

[jira] [Created] (FLINK-32386) Add ShuffleDescriptorsCache in TaskExecutor to cache ShuffleDescriptors

2023-06-19 Thread Weihua Hu (Jira)
Weihua Hu created FLINK-32386: - Summary: Add ShuffleDescriptorsCache in TaskExecutor to cache ShuffleDescriptors Key: FLINK-32386 URL: https://issues.apache.org/jira/browse/FLINK-32386 Project: Flink

[GitHub] [flink] luoyuxia commented on a diff in pull request #22721: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table

2023-06-19 Thread via GitHub
luoyuxia commented on code in PR #22721: URL: https://github.com/apache/flink/pull/22721#discussion_r1234691322 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ShowPartitionsOperation.java: ## @@ -66,10 +66,6 @@ public CatalogPartitionSpec get

[GitHub] [flink] WencongLiu commented on pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on PR #22733: URL: https://github.com/apache/flink/pull/22733#issuecomment-1598052498 Thanks for the review from @TanYuxin-tyx and @reswqa ! I've made a round of changes. 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] WencongLiu commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234687955 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java: ## @@ -813,6 +813,11 @@ private void checkPartitionReq

[GitHub] [flink] WencongLiu commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234687042 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java: ## @@ -217,6 +222,12 @@ public class SingleInputGate exte

[GitHub] [flink] WencongLiu commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234687515 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java: ## @@ -280,7 +281,8 @@ private IndexedI

[GitHub] [flink] WencongLiu commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234687374 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateFactory.java: ## @@ -158,9 +166,34 @@ public SingleInputGate cre

[jira] [Updated] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-19 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li updated FLINK-32370: --- Component/s: Tests > JDBC SQl gateway e2e test is unstable > - >

[jira] [Created] (FLINK-32385) Introduce a struct SerializedShuffleDescriptorAndIndices to identify a group of ShuffleDescriptorAndIndex

2023-06-19 Thread Weihua Hu (Jira)
Weihua Hu created FLINK-32385: - Summary: Introduce a struct SerializedShuffleDescriptorAndIndices to identify a group of ShuffleDescriptorAndIndex Key: FLINK-32385 URL: https://issues.apache.org/jira/browse/FLINK-3238

[jira] [Closed] (FLINK-32370) JDBC SQl gateway e2e test is unstable

2023-06-19 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benchao Li closed FLINK-32370. -- Assignee: Fang Yong Resolution: Fixed Fixed via https://github.com/apache/flink/commit/8119411a

[jira] [Closed] (FLINK-32288) Improve the scheduling performance of AdaptiveBatchScheduler

2023-06-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-32288. --- Resolution: Done done via b462d0ec4d1d421a369e45f8dca33284b5be6bc2 > Improve the scheduling performance of

[GitHub] [flink] libenchao closed pull request #22819: [FLINK-32370][client] Fix warn log in result fetcher when job is finished

2023-06-19 Thread via GitHub
libenchao closed pull request #22819: [FLINK-32370][client] Fix warn log in result fetcher when job is finished URL: https://github.com/apache/flink/pull/22819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] zhuzhurk closed pull request #22798: [FLINK-32288][runtime] Improve the scheduling performance of AdaptiveBatchScheduler

2023-06-19 Thread via GitHub
zhuzhurk closed pull request #22798: [FLINK-32288][runtime] Improve the scheduling performance of AdaptiveBatchScheduler URL: https://github.com/apache/flink/pull/22798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-connector-aws] Samrat002 commented on pull request #83: [FLINK-32372] Push PR support build and test with recently release fl…

2023-06-19 Thread via GitHub
Samrat002 commented on PR #83: URL: https://github.com/apache/flink-connector-aws/pull/83#issuecomment-1598036360 Hi @dannycranmer , @hlteoh37 ! Please validate if we want to add newly released minor version of flink (1.16.2 and 1.17.1) in the PR build pipeline. Thank you

[GitHub] [flink] LoveHeat commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-19 Thread via GitHub
LoveHeat commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1234672707 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[GitHub] [flink] LoveHeat commented on a diff in pull request #22806: [FLINK-32362] [SourceAlignment] increase the robustness of announceCombinedWatermark to cover the case task failover

2023-06-19 Thread via GitHub
LoveHeat commented on code in PR #22806: URL: https://github.com/apache/flink/pull/22806#discussion_r1234672707 ## flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinator.java: ## @@ -195,9 +195,19 @@ void announceCombinedWatermark() {

[jira] [Created] (FLINK-32384) Remove deprecated configuration keys which violate YAML spec

2023-06-19 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-32384: --- Summary: Remove deprecated configuration keys which violate YAML spec Key: FLINK-32384 URL: https://issues.apache.org/jira/browse/FLINK-32384 Project: Flink Issue Typ

[GitHub] [flink] LoveHeat commented on pull request #22808: [FLINK-32316] [SourceAlignment] Scheduling announceCombinedWatermark period task during SourceCoordinator::start not in construct function t

2023-06-19 Thread via GitHub
LoveHeat commented on PR #22808: URL: https://github.com/apache/flink/pull/22808#issuecomment-1598030633 The first path is(just simple call stack not full): [create JobMaster for each recovered job, and will init a scheduler object in jobmaster construct function](https://github.com/apac

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234664689 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TestingTierFactory.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed t

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234664689 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TestingTierFactory.java: ## @@ -0,0 +1,128 @@ +/* + * Licensed t

[jira] [Created] (FLINK-32383) 2.0 Breaking configuration changes

2023-06-19 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-32383: --- Summary: 2.0 Breaking configuration changes Key: FLINK-32383 URL: https://issues.apache.org/jira/browse/FLINK-32383 Project: Flink Issue Type: Technical Debt

[jira] [Commented] (FLINK-20628) Port RabbitMQ Sources to FLIP-27 API

2023-06-19 Thread RocMarshal (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734964#comment-17734964 ] RocMarshal commented on FLINK-20628: [~martijnvisser] Thank you for your reply. Yes,

[jira] [Comment Edited] (FLINK-32374) ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734087#comment-17734087 ] luoyuxia edited comment on FLINK-32374 at 6/20/23 1:49 AM: --- ma

[jira] [Closed] (FLINK-32374) ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-32374. Resolution: Fixed > ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for > overwrit

[GitHub] [flink] luoyuxia merged pull request #22825: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-19 Thread via GitHub
luoyuxia merged PR #22825: URL: https://github.com/apache/flink/pull/22825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] luoyuxia merged pull request #22826: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

2023-06-19 Thread via GitHub
luoyuxia merged PR #22826: URL: https://github.com/apache/flink/pull/22826 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Commented] (FLINK-27240) Support ADD PARTITION statement for partitioned table

2023-06-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734637#comment-17734637 ] luoyuxia commented on FLINK-27240: -- master: 4586bcbe6627ad91001838507b9e1e68ddfc7cdf >

[jira] [Closed] (FLINK-27240) Support ADD PARTITION statement for partitioned table

2023-06-19 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-27240. Resolution: Fixed > Support ADD PARTITION statement for partitioned table > --

[GitHub] [flink] luoyuxia merged pull request #22711: [FLINK-27240][table] Support ADD PARTITION statement for partitioned table

2023-06-19 Thread via GitHub
luoyuxia merged PR #22711: URL: https://github.com/apache/flink/pull/22711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[GitHub] [flink] luoyuxia commented on pull request #22711: [FLINK-27240][table] Support ADD PARTITION statement for partitioned table

2023-06-19 Thread via GitHub
luoyuxia commented on PR #22711: URL: https://github.com/apache/flink/pull/22711#issuecomment-1597923994 @ruanhang1993 Thanks for review. Merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-19 Thread via GitHub
rkhachatryan commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1234528219 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -122,37 +121,20 @@ public StreamStateHandle registerReference(

[GitHub] [flink] rkhachatryan commented on pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-19 Thread via GitHub
rkhachatryan commented on PR #22669: URL: https://github.com/apache/flink/pull/22669#issuecomment-1597828851 Good find @zoltar9264! > Don't trigger a new materialization until the previous one has either confirmed or failed That makes perfect sense to me. Would you be able

[GitHub] [flink] XComp commented on a diff in pull request #22828: [FLINK-30344][test] Migrates KubernetesHighAvailabilityTestBase-related tests to use the MultipleComponentLeaderElectionDriver interf

2023-06-19 Thread via GitHub
XComp commented on code in PR #22828: URL: https://github.com/apache/flink/pull/22828#discussion_r1234298207 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderRetrievalDriverTest.java: ## @@ -62,14 +62,13 @@ void testKubernetesLeaderR

[GitHub] [flink] zentol commented on a diff in pull request #22828: [FLINK-30344][test] Migrates KubernetesHighAvailabilityTestBase-related tests to use the MultipleComponentLeaderElectionDriver inter

2023-06-19 Thread via GitHub
zentol commented on code in PR #22828: URL: https://github.com/apache/flink/pull/22828#discussion_r1234288121 ## flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderRetrievalDriverTest.java: ## @@ -62,14 +62,13 @@ void testKubernetesLeader

[GitHub] [flink] flinkbot commented on pull request #22830: [FLINK-30343][test] Migrates KubernetesLeaderElectionAndRetrievalITCase to use the MultipleComponentLeaderElectionDriver interface

2023-06-19 Thread via GitHub
flinkbot commented on PR #22830: URL: https://github.com/apache/flink/pull/22830#issuecomment-1597491143 ## CI report: * 2ebfc9a83f4fc6a438e280d5463da8ca702dc1e8 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30343) Migrate KubernetesLeaderElectionAndRetrievalITCase

2023-06-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30343: --- Labels: pull-request-available (was: ) > Migrate KubernetesLeaderElectionAndRetrievalITCase

[GitHub] [flink] flinkbot commented on pull request #22829: [FLINK-30342][test] Migrates ZooKeeperLeaderElectionTest to use the MultipleComponentLeaderElectionDriver interface

2023-06-19 Thread via GitHub
flinkbot commented on PR #22829: URL: https://github.com/apache/flink/pull/22829#issuecomment-1597485705 ## CI report: * cf666395bd0ca5e4f1b3114313b118a346fcb485 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22828: [FLINK-30344][test] Migrates KubernetesHighAvailabilityTestBase-related tests to use the MultipleComponentLeaderElectionDriver interface

2023-06-19 Thread via GitHub
flinkbot commented on PR #22828: URL: https://github.com/apache/flink/pull/22828#issuecomment-1597485614 ## CI report: * f981327bb48ba92b93d68e1a95964960d7dbd9f9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp opened a new pull request, #22830: [FLINK-30343][test] Migrates KubernetesLeaderElectionAndRetrievalITCase to use the MultipleComponentLeaderElectionDriver interface

2023-06-19 Thread via GitHub
XComp opened a new pull request, #22830: URL: https://github.com/apache/flink/pull/22830 * https://github.com/apache/flink/pull/21742 * https://github.com/apache/flink/pull/22379 * https://github.com/apache/flink/pull/22422 * https://github.com/apache/flink/pull/22380 * https://gi

[jira] [Updated] (FLINK-30342) Migrate ZooKeeperLeaderElectionTest

2023-06-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30342: --- Labels: pull-request-available (was: ) > Migrate ZooKeeperLeaderElectionTest >

[GitHub] [flink] XComp opened a new pull request, #22829: [FLINK-30342][test] Migrates ZooKeeperLeaderElectionTest to use the MultipleComponentLeaderElectionDriver interface

2023-06-19 Thread via GitHub
XComp opened a new pull request, #22829: URL: https://github.com/apache/flink/pull/22829 * https://github.com/apache/flink/pull/21742 * https://github.com/apache/flink/pull/22379 * https://github.com/apache/flink/pull/22422 * https://github.com/apache/flink/pull/22380 * https://gi

[jira] [Updated] (FLINK-30344) Migrate KubernetesHighAvailabilityTestBase and implementing test classes

2023-06-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30344: --- Labels: pull-request-available (was: ) > Migrate KubernetesHighAvailabilityTestBase and imp

[GitHub] [flink] XComp opened a new pull request, #22828: [FLINK-30344][test] Migrates KubernetesHighAvailabilityTestBase-related tests to use the MultipleComponentLeaderElectionDriver interface

2023-06-19 Thread via GitHub
XComp opened a new pull request, #22828: URL: https://github.com/apache/flink/pull/22828 * https://github.com/apache/flink/pull/21742 * https://github.com/apache/flink/pull/22379 * https://github.com/apache/flink/pull/22422 * https://github.com/apache/flink/pull/22380 * https://gi

[GitHub] [flink] afedulov commented on pull request #22816: [FLINK-32373][sql-client] Support passing headers with SQL Client gateway requests

2023-06-19 Thread via GitHub
afedulov commented on PR #22816: URL: https://github.com/apache/flink/pull/22816#issuecomment-1597458830 Flaky test failure. Passed in a private pipeline https://dev.azure.com/alexanderfedulov/Flink/_build/results?buildId=484&view=results -- This is an automated message from the Apache Gi

[GitHub] [flink] afedulov commented on pull request #22816: [FLINK-32373][sql-client] Support passing headers with SQL Client gateway requests

2023-06-19 Thread via GitHub
afedulov commented on PR #22816: URL: https://github.com/apache/flink/pull/22816#issuecomment-1597457675 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Resolved] (FLINK-32382) SQL JDBC e2e test failed with FlinkJobNotFoundException

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-32382. --- Resolution: Duplicate > SQL JDBC e2e test failed with FlinkJobNotFoundException > --

[GitHub] [flink] XComp commented on pull request #22656: [FLINK-32180][runtime] Moves error handling from DefaultMultipleComponentLeaderElectionService into the MultipleComponentLeaderElectionDriver i

2023-06-19 Thread via GitHub
XComp commented on PR #22656: URL: https://github.com/apache/flink/pull/22656#issuecomment-1597399978 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] XComp commented on pull request #22656: [FLINK-32180][runtime] Moves error handling from DefaultMultipleComponentLeaderElectionService into the MultipleComponentLeaderElectionDriver i

2023-06-19 Thread via GitHub
XComp commented on PR #22656: URL: https://github.com/apache/flink/pull/22656#issuecomment-1597399847 I created FLINK-32382 to cover the test instability. It doesn't look like it's related to the refactoring -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Updated] (FLINK-32382) SQL JDBC e2e test failed with FlinkJobNotFoundException

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32382: -- Description: I ran into a test instability in [this CI build|https://dev.azure.com/apache-fli

[jira] [Updated] (FLINK-32382) SQL JDBC e2e test failed with FlinkJobNotFoundException

2023-06-19 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-32382: -- Attachment: logs-ci-e2e_2_ci-1687181689.zip > SQL JDBC e2e test failed with FlinkJobNotFoundEx

[jira] [Created] (FLINK-32382) SQL JDBC e2e test failed with FlinkJobNotFoundException

2023-06-19 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-32382: - Summary: SQL JDBC e2e test failed with FlinkJobNotFoundException Key: FLINK-32382 URL: https://issues.apache.org/jira/browse/FLINK-32382 Project: Flink Iss

[GitHub] [flink] flinkbot commented on pull request #22827: [FLINK-20887][table-planner] Disable project merge & join condition pushdown during sql2rel phase by default to avoid incorrectly project me

2023-06-19 Thread via GitHub
flinkbot commented on PR #22827: URL: https://github.com/apache/flink/pull/22827#issuecomment-1597364046 ## CI report: * 0f1b59cb40de5f2e4763578c56e763e8f4e9cb2f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-20887) Non-deterministic functions return different values even if it is referred with the same column name

2023-06-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-20887: --- Labels: auto-deprioritized-major auto-unassigned pull-request-available (was: auto-depriori

[jira] [Commented] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734207#comment-17734207 ] Chesnay Schepler commented on FLINK-32379: -- There seem to be some differences i

[GitHub] [flink-connector-hbase] ferenc-csaky commented on pull request #5: [FLINK-30349] Sync missing HBase e2e tests to external repo

2023-06-19 Thread via GitHub
ferenc-csaky commented on PR #5: URL: https://github.com/apache/flink-connector-hbase/pull/5#issuecomment-1597249499 @MartijnVisser @zentol opened #12 with the dockerized E2E tests. The workflow runs currently seems to fail, I'm not sure why. -- This is an automated message from the Apac

[jira] [Commented] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734203#comment-17734203 ] Chesnay Schepler commented on FLINK-32379: -- {code} maven clean install -DskipTe

[jira] [Updated] (FLINK-20887) Non-deterministic functions return different values even if it is referred with the same column name

2023-06-19 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-20887: Fix Version/s: 1.18.0 > Non-deterministic functions return different values even if it is referred

[jira] [Commented] (FLINK-31238) Use IngestDB to speed up Rocksdb rescaling recovery

2023-06-19 Thread Stefan Richter (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734183#comment-17734183 ] Stefan Richter commented on FLINK-31238: [~mayuehappy] Thanks for working on thi

[jira] [Commented] (FLINK-32379) Skip archunit tests in java1X-target profiles

2023-06-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734179#comment-17734179 ] Chesnay Schepler commented on FLINK-32379: -- Nope, I also couldn't reproduce it.

[GitHub] [flink] WencongLiu commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
WencongLiu commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1234040994 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/memory/MemoryTierConsumerAgent.java: ## @@ -0,0 +1,82 @@ +/* + * Lice

[GitHub] [flink] reswqa commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
reswqa commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1233995628 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java: ## @@ -217,6 +222,12 @@ public class SingleInputGate extends

[jira] [Updated] (FLINK-32097) Implement support for Kinesis deaggregation

2023-06-19 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh updated FLINK-32097: Summary: Implement support for Kinesis deaggregation (was: Implement support for Kinesis

[jira] [Closed] (FLINK-31990) Use Flink Configuration to specify KDS Source configuration object

2023-06-19 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Cranmer closed FLINK-31990. - Resolution: Done > Use Flink Configuration to specify KDS Source configuration object >

[jira] [Commented] (FLINK-31990) Use Flink Configuration to specify KDS Source configuration object

2023-06-19 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734168#comment-17734168 ] Danny Cranmer commented on FLINK-31990: --- ok thanks [~liangtl]    > Use Flink Con

[GitHub] [flink] carp84 commented on a diff in pull request #22788: [FLINK-32345][state] Improve parallel download of RocksDB incremental state.

2023-06-19 Thread via GitHub
carp84 commented on code in PR #22788: URL: https://github.com/apache/flink/pull/22788#discussion_r1231969461 ## flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksDBStateDownloaderTest.java: ## @@ -165,4 +192,48 @@ public

[jira] [Commented] (FLINK-31956) Extend the CompiledPlan to read from/write to Flink's FileSystem

2023-06-19 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734166#comment-17734166 ] Jane Chan commented on FLINK-31956: --- Hi, [~xu_shuai_] Thanks for your contribution! We

[jira] [Commented] (FLINK-20628) Port RabbitMQ Sources to FLIP-27 API

2023-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17734163#comment-17734163 ] Martijn Visser commented on FLINK-20628: [~RocMarshal] Do you want to continue o

[jira] [Updated] (FLINK-20628) Port RabbitMQ Sources to FLIP-27 API

2023-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-20628: --- Fix Version/s: (was: 1.12.0) > Port RabbitMQ Sources to FLIP-27 API > --

[GitHub] [flink] LadyForest commented on a diff in pull request #22539: [FLINK-31956][table] Extend the CompiledPlan to read from/write to Fl…

2023-06-19 Thread via GitHub
LadyForest commented on code in PR #22539: URL: https://github.com/apache/flink/pull/22539#discussion_r1230722665 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/ExecNodeGraphInternalPlan.java: ## @@ -75,6 +75,9 @@ public void writeToFile(Fil

[GitHub] [flink] XComp commented on pull request #22656: [FLINK-32180][runtime] Moves error handling from DefaultMultipleComponentLeaderElectionService into the MultipleComponentLeaderElectionDriver i

2023-06-19 Thread via GitHub
XComp commented on PR #22656: URL: https://github.com/apache/flink/pull/22656#issuecomment-1597107794 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Closed] (FLINK-26656) Change/remove mentions of "mode" in Source and Sink documentation

2023-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26656?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-26656. -- Resolution: Later > Change/remove mentions of "mode" in Source and Sink documentation > --

[jira] [Closed] (FLINK-28119) Update the document for Contribute Documentation

2023-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-28119. -- Resolution: Fixed > Update the document for Contribute Documentation > ---

[jira] [Closed] (FLINK-31801) Missing elasticsearch connector on maven central repository

2023-06-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-31801. -- Resolution: Fixed > Missing elasticsearch connector on maven central repository > ---

[jira] [Updated] (FLINK-32198) Enforce single maxExceptions query parameter

2023-06-19 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-32198: - Parent: FLINK-32377 Issue Type: Sub-task (was: Bug) > Enforce single maxExcepti

[GitHub] [flink] zentol commented on a diff in pull request #22718: [FLINK-32265][runtime] Use system classloader in jm for job without jars and classpaths

2023-06-19 Thread via GitHub
zentol commented on code in PR #22718: URL: https://github.com/apache/flink/pull/22718#discussion_r1233971542 ## flink-runtime/src/main/java/org/apache/flink/runtime/execution/librarycache/BlobLibraryCacheManager.java: ## @@ -391,6 +407,7 @@ private ResolvedClassLoader(

[GitHub] [flink] TanYuxin-tyx commented on a diff in pull request #22733: [FLINK-31642][network] Introduce the MemoryTierConsumerAgent

2023-06-19 Thread via GitHub
TanYuxin-tyx commented on code in PR #22733: URL: https://github.com/apache/flink/pull/22733#discussion_r1233875486 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/memory/MemoryTierFactory.java: ## @@ -28,7 +30,9 @@ import org.ap

[GitHub] [flink] FangYongs commented on a diff in pull request #22718: [FLINK-32265][runtime] Use system classloader in jm for job without jars and classpaths

2023-06-19 Thread via GitHub
FangYongs commented on code in PR #22718: URL: https://github.com/apache/flink/pull/22718#discussion_r1233966178 ## flink-runtime/src/main/java/org/apache/flink/runtime/execution/librarycache/LibraryCacheManager.java: ## @@ -43,9 +43,11 @@ public interface LibraryCacheManager {

[jira] [Resolved] (FLINK-32357) Elasticsearch v3.0 won't compile when testing against Flink 1.17.1

2023-06-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-32357. - Fix Version/s: elasticsearch-3.0.2 Resolution: Fixed > Elasticsearch v3.0 won't c

  1   2   >