XComp commented on code in PR #22828:
URL: https://github.com/apache/flink/pull/22828#discussion_r1234298207
##########
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderRetrievalDriverTest.java:
##########
@@ -62,14 +62,13 @@ void testKubernetesLeaderRetrievalOnModified() throws
Exception {
() -> {
leaderCallbackGrantLeadership();
+ // Leader changed
+ final String newLeader = LEADER_ADDRESS + "_" + 2;
+
putLeaderInformationIntoConfigMap(UUID.randomUUID(), newLeader);
+
final
FlinkKubeClient.WatchCallbackHandler<KubernetesConfigMap>
callbackHandler =
getLeaderRetrievalConfigMapCallback();
- // Leader changed
- final String newLeader = LEADER_ADDRESS + "_" + 2;
- getLeaderConfigMap()
- .getData()
- .put(Constants.LEADER_ADDRESS_KEY,
newLeader);
Review Comment:
No, I fixed this to reduce the diff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
