[GitHub] [flink] MartijnVisser commented on pull request #22724: [BP-1.17][FLINK-28853][Docs] Sync watermark split alignment documentation with…

2023-06-06 Thread via GitHub
MartijnVisser commented on PR #22724: URL: https://github.com/apache/flink/pull/22724#issuecomment-1580012515 > @MartijnVisser last one! Thanks for the catch and help on this btw Thank you and you're welcome! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] MartijnVisser merged pull request #22724: [BP-1.17][FLINK-28853][Docs] Sync watermark split alignment documentation with…

2023-06-06 Thread via GitHub
MartijnVisser merged PR #22724: URL: https://github.com/apache/flink/pull/22724 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink

[GitHub] [flink] luoyuxia commented on a diff in pull request #22398: [FLINK-31774][doc] Add document for delete and update statement

2023-06-06 Thread via GitHub
luoyuxia commented on code in PR #22398: URL: https://github.com/apache/flink/pull/22398#discussion_r1220823839 ## docs/content.zh/docs/dev/table/sql/delete.md: ## @@ -0,0 +1,201 @@ +--- +title: "DELETE 语句" +weight: 18 +type: docs +aliases: + - /zh/dev/table/sql/delete.html +--

[GitHub] [flink-web] leonardBang commented on a diff in pull request #655: Add Pulsar v3.0.1 for Flink 1.16.x

2023-06-06 Thread via GitHub
leonardBang commented on code in PR #655: URL: https://github.com/apache/flink-web/pull/655#discussion_r1220945105 ## docs/data/release_archive.yml: ## @@ -490,6 +490,11 @@ release_archive: version: 3.0.1 release_date: 2023-05-09 filename: "gcp-pubsub" +

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-06 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1220936492 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java: ## @@ -395,18 +3

[GitHub] [flink] zoltar9264 commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-06 Thread via GitHub
zoltar9264 commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1220936492 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java: ## @@ -395,18 +3

[GitHub] [flink] KarmaGYZ commented on a diff in pull request #17873: [FLINK-25009][CLI] Output slotSharingGroup as part of JsonGraph

2023-06-06 Thread via GitHub
KarmaGYZ commented on code in PR #17873: URL: https://github.com/apache/flink/pull/17873#discussion_r1220931306 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/JSONGenerator.java: ## @@ -184,6 +185,8 @@ private void decorateNode(Integer vertexID, Objec

[GitHub] [flink] jiaoqingbo commented on pull request #22694: [FLINK-32223][runtime][security] Add Hive delegation token support

2023-06-06 Thread via GitHub
jiaoqingbo commented on PR #22694: URL: https://github.com/apache/flink/pull/22694#issuecomment-1579957279 @gaborgsomogyi could you help take a look when you have time? Thanks. I added [Test Gist](https://gist.github.com/jiaoqingbo/99564342ab6576869cfe1961a9e76ed4) -- This is an automate

[GitHub] [flink] masteryhx commented on pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-06-06 Thread via GitHub
masteryhx commented on PR #21635: URL: https://github.com/apache/flink/pull/21635#issuecomment-1579956303 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] YasuoStudyJava commented on pull request #22719: [FLINK-32188][Table SQL / Planner] Support to "where" query and simplify condition for an array-type filed of temporary table.

2023-06-06 Thread via GitHub
YasuoStudyJava commented on PR #22719: URL: https://github.com/apache/flink/pull/22719#issuecomment-1579942317 > There are some format violations, I'll fix it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] reswqa commented on a diff in pull request #22552: [FLINK-30585][flamegraph] Collect the flame graph of a single subtask instead of all subtasks when viewing the flame graph of a sing

2023-06-06 Thread via GitHub
reswqa commented on code in PR #22552: URL: https://github.com/apache/flink/pull/22552#discussion_r1220799554 ## flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/threadinfo/VertexThreadInfoTracker.java: ## @@ -0,0 +1,569 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] xintongsong commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-06-06 Thread via GitHub
xintongsong commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1220671319 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/netty/NettyProducerService.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot commented on pull request #22727: [BP-1.16][FLINK-32254][runtime] FineGrainedSlotManager may not allocate enough taskmanagers if maxSlotNum is configured

2023-06-06 Thread via GitHub
flinkbot commented on PR #22727: URL: https://github.com/apache/flink/pull/22727#issuecomment-1579800116 ## CI report: * 852ee12b1947057181ef80178b1f1abfd7d785ff UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22726: [BP-1.17][FLINK-32254][runtime] FineGrainedSlotManager may not allocate enough taskmanagers if maxSlotNum is configured

2023-06-06 Thread via GitHub
flinkbot commented on PR #22726: URL: https://github.com/apache/flink/pull/22726#issuecomment-1579799771 ## CI report: * 8176bdb61a237d58de3018cfb0707c20031baf0d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-31812) SavePoint from /jars/:jarid:/run api on body is not anymore set to null if empty

2023-06-06 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729745#comment-17729745 ] Weijie Guo edited comment on FLINK-31812 at 6/7/23 3:02 AM:

[jira] [Closed] (FLINK-31812) SavePoint from /jars/:jarid:/run api on body is not anymore set to null if empty

2023-06-06 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-31812. -- Fix Version/s: 1.18.0 1.17.2 Resolution: Fixed > SavePoint from /jars/:jarid

[GitHub] [flink] reswqa opened a new pull request, #22727: [BP-1.16][FLINK-32254][runtime] FineGrainedSlotManager may not allocate enough taskmanagers if maxSlotNum is configured

2023-06-06 Thread via GitHub
reswqa opened a new pull request, #22727: URL: https://github.com/apache/flink/pull/22727 Backport FLINK-32254 to `release-1.16` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [flink] reswqa opened a new pull request, #22726: [BP-1.17][FLINK-32254][runtime] FineGrainedSlotManager may not allocate enough taskmanagers if maxSlotNum is configured

2023-06-06 Thread via GitHub
reswqa opened a new pull request, #22726: URL: https://github.com/apache/flink/pull/22726 Backport FLINK-32254 to `release-1.17` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [flink] reswqa closed pull request #22714: [FLINK-32254][runtime] FineGrainedSlotManager may not allocate enough taskmangers if maxSlotNum is configured

2023-06-06 Thread via GitHub
reswqa closed pull request #22714: [FLINK-32254][runtime] FineGrainedSlotManager may not allocate enough taskmangers if maxSlotNum is configured URL: https://github.com/apache/flink/pull/22714 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] flinkbot commented on pull request #22725: [FLINK-32219][sql-client] Fix SqlClient hangs when executing EXECUTE PLAN statement

2023-06-06 Thread via GitHub
flinkbot commented on PR #22725: URL: https://github.com/apache/flink/pull/22725#issuecomment-1579790642 ## CI report: * 34a4d769f8f5511f75153373bd3b39e16e6be762 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] LadyForest opened a new pull request, #22725: [FLINK-32219][sql-client] Fix SqlClient hangs when executing EXECUTE PLAN statement

2023-06-06 Thread via GitHub
LadyForest opened a new pull request, #22725: URL: https://github.com/apache/flink/pull/22725 ## What is the purpose of the change This PR is cherry-picked from commit 83ba6b5348cbffb26e8d1d5ce6e8d6bb1994e3bc. ## Brief change log See #22703 ## Verifying th

[GitHub] [flink] reswqa commented on pull request #22714: [FLINK-32254][runtime] FineGrainedSlotManager may not allocate enough taskmangers if maxSlotNum is configured

2023-06-06 Thread via GitHub
reswqa commented on PR #22714: URL: https://github.com/apache/flink/pull/22714#issuecomment-1579785582 Thanks @huwh for the review, merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] masteryhx commented on pull request #21635: [FLINK-30613] Improve resolving schema compatibility -- Milestone one

2023-06-06 Thread via GitHub
masteryhx commented on PR #21635: URL: https://github.com/apache/flink/pull/21635#issuecomment-1579768878 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-32219) SQL client hangs when executing EXECUTE PLAN

2023-06-06 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729879#comment-17729879 ] Shengkai Fang commented on FLINK-32219: --- Merged into master: 83ba6b5348cbffb26e8d1

[jira] [Commented] (FLINK-32269) CreateTableAsITCase.testCreateTableAsInStatementSet fails on AZP

2023-06-06 Thread dalongliu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729877#comment-17729877 ] dalongliu commented on FLINK-32269: --- Yes. According to the exception, I think the root

[jira] [Updated] (FLINK-32273) What is org.apache.flink.avro.generated.record_json?

2023-06-06 Thread Tan Kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tan Kim updated FLINK-32273: Description: I'm trying to relay a topic from kafka to another kafka. This is the original record in sour

[jira] [Updated] (FLINK-32273) What is org.apache.flink.avro.generated.record_json?

2023-06-06 Thread Tan Kim (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tan Kim updated FLINK-32273: Description: I'm trying to relay a topic from kafka to another kafka. This is the original record in sour

[jira] [Created] (FLINK-32273) What is org.apache.flink.avro.generated.record_json?

2023-06-06 Thread Tan Kim (Jira)
Tan Kim created FLINK-32273: --- Summary: What is org.apache.flink.avro.generated.record_json? Key: FLINK-32273 URL: https://issues.apache.org/jira/browse/FLINK-32273 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-32253) Blocklist unblockResources does not update the pending resource request

2023-06-06 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729874#comment-17729874 ] Lijie Wang commented on FLINK-32253: Thanks [~prabhujoseph] , assigned to you. > Bl

[jira] [Assigned] (FLINK-32253) Blocklist unblockResources does not update the pending resource request

2023-06-06 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang reassigned FLINK-32253: -- Assignee: Prabhu Joseph > Blocklist unblockResources does not update the pending resource req

[jira] [Updated] (FLINK-32271) Report RECOMMENDED_PARALLELISM as an autoscaler metric

2023-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32271: --- Labels: pull-request-available (was: ) > Report RECOMMENDED_PARALLELISM as an autoscaler me

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #613: [FLINK-32271] Report RECOMMENDED_PARALLELISM as an autoscaler metric

2023-06-06 Thread via GitHub
morhidi opened a new pull request, #613: URL: https://github.com/apache/flink-kubernetes-operator/pull/613 ## What is the purpose of the change It is beneficial to report the recommended parallelism and overlay it with the current parallelism on the same chart when auto scaler is runn

[jira] [Updated] (FLINK-32272) Expose LOAD_MAX as autoscaler metric

2023-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32272: --- Labels: pull-request-available (was: ) > Expose LOAD_MAX as autoscaler metric > ---

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #612: [FLINK-32272] Expose LOAD_MAX as autoscaler metric

2023-06-06 Thread via GitHub
morhidi opened a new pull request, #612: URL: https://github.com/apache/flink-kubernetes-operator/pull/612 ## What is the purpose of the change LOAD_MAX can be used to identify the busiest vertices in a job graph, hence it's useful to have it as a metric. ## Brief change log

[GitHub] [flink-connector-elasticsearch] mtfelisb commented on pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-06-06 Thread via GitHub
mtfelisb commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1579604638 > I try to compile your code, but throwing follow errors: > > ``` > [INFO] There are 69 errors reported by Checkstyle 8.14 with /tools/maven/checkstyle.xml ru

[GitHub] [flink-connector-elasticsearch] mtfelisb commented on pull request #53: [FLINK-26088][Connectors/ElasticSearch] Add Elasticsearch 8.0 support

2023-06-06 Thread via GitHub
mtfelisb commented on PR #53: URL: https://github.com/apache/flink-connector-elasticsearch/pull/53#issuecomment-1579602598 > > Even though I'm concerned about the implementation using Kryo, I'll mark it as ready to review and get your feedback. > > @reta Could you help with a review?

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22669: [FLINK-29913] fix shared state be discarded by mistake when maxConcurrentCheckpoint>1

2023-06-06 Thread via GitHub
rkhachatryan commented on code in PR #22669: URL: https://github.com/apache/flink/pull/22669#discussion_r1220434655 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksDBSnapshotStrategyBase.java: ## @@ -395,18

[jira] [Assigned] (FLINK-32272) Expose LOAD_MAX as autoscaler metric

2023-06-06 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi reassigned FLINK-32272: - Assignee: Matyas Orhidi > Expose LOAD_MAX as autoscaler metric > --

[jira] [Created] (FLINK-32272) Expose LOAD_MAX as autoscaler metric

2023-06-06 Thread Matyas Orhidi (Jira)
Matyas Orhidi created FLINK-32272: - Summary: Expose LOAD_MAX as autoscaler metric Key: FLINK-32272 URL: https://issues.apache.org/jira/browse/FLINK-32272 Project: Flink Issue Type: New Featur

[GitHub] [flink] snuyanzin commented on a diff in pull request #22722: [FLINK-32267] Upgrade tesctcontainers from 1.17.6 to 1.18.3

2023-06-06 Thread via GitHub
snuyanzin commented on code in PR #22722: URL: https://github.com/apache/flink/pull/22722#discussion_r1220223645 ## pom.xml: ## @@ -158,8 +158,7 @@ under the License. 2.43.0 3.21.7 3.14.9 - Review Comment: no mor

[jira] [Updated] (FLINK-32256) Add ARRAY_MAX support in SQL & Table API

2023-06-06 Thread Hanyu Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hanyu Zheng updated FLINK-32256: Description: This is an implementation of ARRAY_MAX The array_max() function concatenates get the

[GitHub] [flink] flinkbot commented on pull request #22724: [BP-1.17][FLINK-28853][Docs] Sync watermark split alignment documentation with…

2023-06-06 Thread via GitHub
flinkbot commented on PR #22724: URL: https://github.com/apache/flink/pull/22724#issuecomment-1579273086 ## CI report: * fc82ccfec46ae525f9b014da7563a7a066df6906 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] mas-chen commented on pull request #22724: [BP-1.17][FLINK-28853][Docs] Sync watermark split alignment documentation with…

2023-06-06 Thread via GitHub
mas-chen commented on PR #22724: URL: https://github.com/apache/flink/pull/22724#issuecomment-1579272196 @MartijnVisser last one! Thanks for the catch and help on this btw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [flink] mas-chen opened a new pull request, #22724: [BP-1.17][FLINK-28853][Docs] Sync watermark split alignment documentation with…

2023-06-06 Thread via GitHub
mas-chen opened a new pull request, #22724: URL: https://github.com/apache/flink/pull/22724 … the Chinese version. This closes #22716 Backporting this commit to 1.17 for the split level watermark alignment feature. -- This is an automated message from the Apache Git Service. To res

[jira] [Assigned] (FLINK-32271) Report RECOMMENDED_PARALLELISM as an autoscaler metric

2023-06-06 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi reassigned FLINK-32271: - Assignee: Matyas Orhidi > Report RECOMMENDED_PARALLELISM as an autoscaler metric >

[jira] [Created] (FLINK-32271) Report RECOMMENDED_PARALLELISM as an autoscaler metric

2023-06-06 Thread Matyas Orhidi (Jira)
Matyas Orhidi created FLINK-32271: - Summary: Report RECOMMENDED_PARALLELISM as an autoscaler metric Key: FLINK-32271 URL: https://issues.apache.org/jira/browse/FLINK-32271 Project: Flink Issu

[jira] [Commented] (FLINK-32270) Heartbeat timeout in AggregateReduceGroupingITCase.testAggOnLeftJoin on AZP

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729809#comment-17729809 ] Sergey Nuyanzin commented on FLINK-32270: - looks similar to FLINK-25903 > Heart

[GitHub] [flink] MartijnVisser commented on pull request #17873: [FLINK-25009][CLI] Output slotSharingGroup as part of JsonGraph

2023-06-06 Thread via GitHub
MartijnVisser commented on PR #17873: URL: https://github.com/apache/flink/pull/17873#issuecomment-1579093655 @KarmaGYZ Are you still planning to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] bvarghese1 commented on a diff in pull request #22717: [FLINK-31665] [table] Add ARRAY_CONCAT function

2023-06-06 Thread via GitHub
bvarghese1 commented on code in PR #22717: URL: https://github.com/apache/flink/pull/22717#discussion_r1219960448 ## docs/data/sql_functions.yml: ## @@ -646,6 +646,9 @@ collection: - sql: ARRAY_UNION(array1, array2) table: haystack.arrayUnion(array) description: Ret

[jira] [Commented] (FLINK-32253) Blocklist unblockResources does not update the pending resource request

2023-06-06 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729802#comment-17729802 ] Prabhu Joseph commented on FLINK-32253: --- Yes, sure. Could you assign this ticket t

[jira] [Commented] (FLINK-27284) KafkaSinkITCase$IntegrationTests.testScaleUp failed on azures due to failed to create topic

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729787#comment-17729787 ] Sergey Nuyanzin commented on FLINK-27284: - https://dev.azure.com/apache-flink/ap

[jira] [Updated] (FLINK-27284) KafkaSinkITCase$IntegrationTests.testScaleUp failed on azures due to failed to create topic

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-27284: Affects Version/s: 1.17.2 > KafkaSinkITCase$IntegrationTests.testScaleUp failed on azures

[jira] [Commented] (FLINK-32253) Blocklist unblockResources does not update the pending resource request

2023-06-06 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729786#comment-17729786 ] Lijie Wang commented on FLINK-32253: [~prabhujoseph] I think it can work. Would you

[jira] [Updated] (FLINK-30153) YARNSessionCapacitySchedulerITCase fails with NoClassDefFoundError org/jboss/netty/channel/ExceptionEvent

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-30153: Affects Version/s: 1.16.3 (was: 1.18.0) > YARNSessionCapacitySc

[jira] [Updated] (FLINK-30153) YARNSessionCapacitySchedulerITCase fails with NoClassDefFoundError org/jboss/netty/channel/ExceptionEvent

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin updated FLINK-30153: Affects Version/s: 1.18.0 > YARNSessionCapacitySchedulerITCase fails with NoClassDefFoundE

[jira] [Commented] (FLINK-30153) YARNSessionCapacitySchedulerITCase fails with NoClassDefFoundError org/jboss/netty/channel/ExceptionEvent

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729784#comment-17729784 ] Sergey Nuyanzin commented on FLINK-30153: - https://dev.azure.com/apache-flink/ap

[GitHub] [flink] fsk119 merged pull request #22703: [FLINK-32219][sql-client] Fix SqlClient hangs when executing EXECUTE PLAN statement

2023-06-06 Thread via GitHub
fsk119 merged PR #22703: URL: https://github.com/apache/flink/pull/22703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[GitHub] [flink] flinkbot commented on pull request #22723: [BP-1.17][FLINK-31812][api] Transform savepoint path to null if empty in body

2023-06-06 Thread via GitHub
flinkbot commented on PR #22723: URL: https://github.com/apache/flink/pull/22723#issuecomment-1578941524 ## CI report: * bdc0985815b9ef5eea4e235343bdac9e5458ec53 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-32270) Heartbeat timeout in AggregateReduceGroupingITCase.testAggOnLeftJoin on AZP

2023-06-06 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32270: --- Summary: Heartbeat timeout in AggregateReduceGroupingITCase.testAggOnLeftJoin on AZP Key: FLINK-32270 URL: https://issues.apache.org/jira/browse/FLINK-32270 Pro

[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-06 Thread via GitHub
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1578935469 > how do you recognize that `rebase` has successfully completed? I tried to do it with your branch (`git rebase upstream/main`) and got a number of conflicts The proble

[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-06-06 Thread via GitHub
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1578933279 I have identified the problem and during the final step, I executed a push instead of a force push, which caused the git rebase to fall into a loop. Thank you for your guidanc

[jira] [Commented] (FLINK-27284) KafkaSinkITCase$IntegrationTests.testScaleUp failed on azures due to failed to create topic

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729776#comment-17729776 ] Sergey Nuyanzin commented on FLINK-27284: - https://dev.azure.com/apache-flink/ap

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #17: [FLINK-32222] avoid using non-public DataInputDeserializer and DataOutputSerializer

2023-06-06 Thread via GitHub
echauchot commented on PR #17: URL: https://github.com/apache/flink-connector-cassandra/pull/17#issuecomment-1578915246 > This doesn't seem like such a bad replacement for the data*serializers. +1 > > This would also work, and _may_ look nicer? shrug > > ``` > final

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #17: [FLINK-32222] avoid using non-public DataInputDeserializer and DataOutputSerializer

2023-06-06 Thread via GitHub
echauchot commented on PR #17: URL: https://github.com/apache/flink-connector-cassandra/pull/17#issuecomment-1578914220 > new ByteArrayOutputStream(); But that is the same code I pushed except you've put the ByteArrayOutputStream creation outside of the try-with-resources and the

[jira] [Commented] (FLINK-32204) ZooKeeperLeaderElectionTest.testZooKeeperReelectionWithReplacement fails with The ExecutorService is shut down already. No Callables can be executed on AZP

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729774#comment-17729774 ] Sergey Nuyanzin commented on FLINK-32204: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729772#comment-17729772 ] Sergey Nuyanzin commented on FLINK-30629: - [~Jiangang] thanks for your update c

[jira] [Commented] (FLINK-30629) ClientHeartbeatTest.testJobRunningIfClientReportHeartbeat is unstable

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729770#comment-17729770 ] Sergey Nuyanzin commented on FLINK-30629: - https://dev.azure.com/apache-flink/ap

[jira] [Commented] (FLINK-32269) CreateTableAsITCase.testCreateTableAsInStatementSet fails on AZP

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729767#comment-17729767 ] Sergey Nuyanzin commented on FLINK-32269: - Hi [~lsy] it seems it is very similar

[jira] [Created] (FLINK-32269) CreateTableAsITCase.testCreateTableAsInStatementSet fails on AZP

2023-06-06 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32269: --- Summary: CreateTableAsITCase.testCreateTableAsInStatementSet fails on AZP Key: FLINK-32269 URL: https://issues.apache.org/jira/browse/FLINK-32269 Project: Flink

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #31: [FLINK-31747] Remove Confluent Avro formats from externalized Kafka connector repo

2023-06-06 Thread via GitHub
tzulitai commented on PR #31: URL: https://github.com/apache/flink-connector-kafka/pull/31#issuecomment-157866 Good point @mas-chen. Following along the same logic for how other tests in `apache/flink` that depend on the Kafka connector handle this (i.e. pinning to a specific Kafka con

[GitHub] [flink] echauchot commented on a diff in pull request #22667: [FLINK-31806] Fix public API rule for connectors

2023-06-06 Thread via GitHub
echauchot commented on code in PR #22667: URL: https://github.com/apache/flink/pull/22667#discussion_r1219746448 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java: ## @@ -41,16 +39,14 @@ public c

[GitHub] [flink] FangYongs commented on pull request #22718: [FLINK-32265][runtime] Use system classloader in jm for job without jars and classpaths

2023-06-06 Thread via GitHub
FangYongs commented on PR #22718: URL: https://github.com/apache/flink/pull/22718#issuecomment-1578869662 @zentol I got some help from our JVM team and the detailed structure is in JVM native codes. For Java 10 and later, each classloader has a `ClassLoaderData` and there is a `Dictionary`

[GitHub] [flink] echauchot commented on a diff in pull request #22667: [FLINK-31806] Fix public API rule for connectors

2023-06-06 Thread via GitHub
echauchot commented on code in PR #22667: URL: https://github.com/apache/flink/pull/22667#discussion_r1219746448 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java: ## @@ -41,16 +39,14 @@ public c

[GitHub] [flink] reswqa commented on a diff in pull request #22714: [FLINK-32254][runtime] FineGrainedSlotManager may not allocate enough taskmangers if maxSlotNum is configured

2023-06-06 Thread via GitHub
reswqa commented on code in PR #22714: URL: https://github.com/apache/flink/pull/22714#discussion_r1219713507 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerConfiguration.java: ## @@ -244,7 +244,12 @@ private static MemorySize getM

[jira] [Comment Edited] (FLINK-31812) SavePoint from /jars/:jarid:/run api on body is not anymore set to null if empty

2023-06-06 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729745#comment-17729745 ] Weijie Guo edited comment on FLINK-31812 at 6/6/23 1:59 PM:

[jira] [Commented] (FLINK-31812) SavePoint from /jars/:jarid:/run api on body is not anymore set to null if empty

2023-06-06 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729745#comment-17729745 ] Weijie Guo commented on FLINK-31812: master(1.18) via bc2fee44a87591d08ab0df6cba06bb

[GitHub] [flink] patricklucas commented on pull request #20936: [FLINK-13703][flink-formats/flink-avro] AvroTypeInfo requires objects to be strict POJOs (mutable, with setters)

2023-06-06 Thread via GitHub
patricklucas commented on PR #20936: URL: https://github.com/apache/flink/pull/20936#issuecomment-1578821997 @rmetzger friendly ping since you offered to review ;) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[jira] [Updated] (FLINK-31649) [Connectors/Jdbc] Fix archunit violations

2023-06-06 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31649: --- Fix Version/s: jdbc-3.1.1 > [Connectors/Jdbc] Fix archunit violations >

[jira] [Commented] (FLINK-31649) [Connectors/Jdbc] Fix archunit violations

2023-06-06 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729737#comment-17729737 ] Martijn Visser commented on FLINK-31649: Also fixed in branch v3.1: 8492962db3cc

[GitHub] [flink-connector-jdbc] MartijnVisser merged pull request #53: [FLINK-31649][BP 3.1] Fix archunit violations

2023-06-06 Thread via GitHub
MartijnVisser merged PR #53: URL: https://github.com/apache/flink-connector-jdbc/pull/53 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[jira] [Commented] (FLINK-28440) EventTimeWindowCheckpointingITCase failed with restore

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729731#comment-17729731 ] Sergey Nuyanzin commented on FLINK-28440: - Redirected to here from FLINK-30107 h

[GitHub] [flink] flinkbot commented on pull request #22722: [FLINK-32267] Upgrade tesctcontainers from 1.17.6 to 1.18.3

2023-06-06 Thread via GitHub
flinkbot commented on PR #22722: URL: https://github.com/apache/flink/pull/22722#issuecomment-1578748030 ## CI report: * 5cb28d9fc85a6a2cf5dd18199ca0981cb6190da4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Created] (FLINK-32268) KafkaTableITCase.testKafkaSourceSinkWithBoundedTimestamp failed to create topic

2023-06-06 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32268: --- Summary: KafkaTableITCase.testKafkaSourceSinkWithBoundedTimestamp failed to create topic Key: FLINK-32268 URL: https://issues.apache.org/jira/browse/FLINK-32268

[GitHub] [flink] WencongLiu commented on pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-06-06 Thread via GitHub
WencongLiu commented on PR #22342: URL: https://github.com/apache/flink/pull/22342#issuecomment-1578747105 @xintongsong I have made a round of changes. Please take a look at it when you have time. 😄 -- This is an automated message from the Apache Git Service. To respond to the message, p

[jira] [Updated] (FLINK-32267) Update testcontainers dependency to v1.18.3

2023-06-06 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32267: --- Labels: pull-request-available (was: ) > Update testcontainers dependency to v1.18.3 >

[GitHub] [flink] snuyanzin opened a new pull request, #22722: [FLINK-32267] Upgrade tesctcontainers from 1.17.6 to 1.18.3

2023-06-06 Thread via GitHub
snuyanzin opened a new pull request, #22722: URL: https://github.com/apache/flink/pull/22722 ## What is the purpose of the change Bump `testcontainers` from 1.17.6 to 1.18.3 ## Brief change log `pom.xml` ## Verifying this change This change is a trivial rework /

[jira] [Created] (FLINK-32267) Update testcontainers dependency to v1.18.3

2023-06-06 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-32267: --- Summary: Update testcontainers dependency to v1.18.3 Key: FLINK-32267 URL: https://issues.apache.org/jira/browse/FLINK-32267 Project: Flink Issue Type:

[GitHub] [flink] zentol commented on a diff in pull request #22667: [FLINK-31806] Fix public API rule for connectors

2023-06-06 Thread via GitHub
zentol commented on code in PR #22667: URL: https://github.com/apache/flink/pull/22667#discussion_r1219609586 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java: ## @@ -41,16 +39,14 @@ public clas

[GitHub] [flink] echauchot commented on a diff in pull request #22667: [FLINK-31806] Fix public API rule for connectors

2023-06-06 Thread via GitHub
echauchot commented on code in PR #22667: URL: https://github.com/apache/flink/pull/22667#discussion_r1219601949 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java: ## @@ -41,16 +39,14 @@ public c

[jira] [Commented] (FLINK-31856) Add support for Opensearch Connector REST client customization

2023-06-06 Thread Andriy Redko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729724#comment-17729724 ] Andriy Redko commented on FLINK-31856: -- Thanks [~mhjtrifork] , probably building lo

[jira] [Comment Edited] (FLINK-31551) Support CrateDB in JDBC Connector

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729722#comment-17729722 ] Sergey Nuyanzin edited comment on FLINK-31551 at 6/6/23 12:47 PM:

[jira] [Comment Edited] (FLINK-31551) Support CrateDB in JDBC Connector

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729722#comment-17729722 ] Sergey Nuyanzin edited comment on FLINK-31551 at 6/6/23 12:47 PM:

[jira] [Resolved] (FLINK-31551) Support CrateDB in JDBC Connector

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-31551. - Fix Version/s: jdbc-3.2.0 Resolution: Fixed > Support CrateDB in JDBC Connector >

[jira] [Commented] (FLINK-31551) Support CrateDB in JDBC Connector

2023-06-06 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729722#comment-17729722 ] Sergey Nuyanzin commented on FLINK-31551: - great, thanks for the update [~libenc

[jira] [Commented] (FLINK-32255) Pre-deployed idle Task Managers

2023-06-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729721#comment-17729721 ] Gyula Fora commented on FLINK-32255: This feature is mostly relevant for the native

[jira] [Closed] (FLINK-32240) Update Flink client to 1.17.1

2023-06-06 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-32240. -- Fix Version/s: kubernetes-operator-1.6.0 Resolution: Fixed merged to main 20b86883ca07e886cefd6

[GitHub] [flink] flinkbot commented on pull request #22721: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table

2023-06-06 Thread via GitHub
flinkbot commented on PR #22721: URL: https://github.com/apache/flink/pull/22721#issuecomment-1578646099 ## CI report: * 50ab37737ea4d5807b11f693324eaee79efc46a9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia opened a new pull request, #22721: [FLINK-27243][table] Support SHOW PARTITIONS statement for partitioned table

2023-06-06 Thread via GitHub
luoyuxia opened a new pull request, #22721: URL: https://github.com/apache/flink/pull/22721 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[GitHub] [flink] zentol commented on a diff in pull request #22667: [FLINK-31806] Fix public API rule for connectors

2023-06-06 Thread via GitHub
zentol commented on code in PR #22667: URL: https://github.com/apache/flink/pull/22667#discussion_r1219512175 ## flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/ConnectorRules.java: ## @@ -41,16 +39,14 @@ public clas

[jira] [Commented] (FLINK-32255) Pre-deployed idle Task Managers

2023-06-06 Thread Christophe Bornet (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729705#comment-17729705 ] Christophe Bornet commented on FLINK-32255: --- [~gyfora] it's almost what is nee

  1   2   >