KarmaGYZ commented on code in PR #17873:
URL: https://github.com/apache/flink/pull/17873#discussion_r1220931306
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/JSONGenerator.java:
##########
@@ -184,6 +185,8 @@ private void decorateNode(Integer vertexID, ObjectNode
node) {
node.put(CONTENTS, vertex.getOperatorDescription());
+ node.put(SLOT_SHARING_GROUP, vertex.getSlotSharingGroup());
Review Comment:
I'm still lean to option 1. The `slotSharingGroup` are by designed to be
non-null for a compiled streamGraph. We should proactively through an exception
if we get a partially completed streamGraph here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
