[GitHub] [flink] PatrickRen merged pull request #22244: [FLINK-31149][docs] Update compatibility matrix for release 1.17

2023-03-22 Thread via GitHub
PatrickRen merged PR #22244: URL: https://github.com/apache/flink/pull/22244 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[GitHub] [flink] flinkbot commented on pull request #22246: [FLINK-31498][runtime] Only request redundant task manager when all pending slots registered.

2023-03-22 Thread via GitHub
flinkbot commented on PR #22246: URL: https://github.com/apache/flink/pull/22246#issuecomment-1480687125 ## CI report: * 3abbc91b037c13cf9d97590099aedb74d77f3a0a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31498) DeclartiveSlotManager always request redundant task manager when resource is not enough

2023-03-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31498: --- Labels: pull-request-available (was: ) > DeclartiveSlotManager always request redundant tas

[GitHub] [flink] huwh opened a new pull request, #22246: [FLINK-31498][runtime] Only request redundant task manager when all pending slots registered.

2023-03-22 Thread via GitHub
huwh opened a new pull request, #22246: URL: https://github.com/apache/flink/pull/22246 ## What is the purpose of the change We will request redundant task managers when there are no enough free slots. But if task manager start too slow or yarn/Kubernetes no resource to create new task m

[jira] [Commented] (FLINK-31375) the values of map are truncated by the CASE WHEN function.

2023-03-22 Thread jeff-zou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703921#comment-17703921 ] jeff-zou commented on FLINK-31375: -- Great,it's ok to use this method, thank u. > the v

[GitHub] [flink] chucheng92 commented on pull request #22240: [FLINK-31574][table-planner] Cleanup unused private methods in OperationConverterUtils

2023-03-22 Thread via GitHub
chucheng92 commented on PR #22240: URL: https://github.com/apache/flink/pull/22240#issuecomment-1480673376 @wuchong hi, jark. sorry to bother you, ci has passed, could u help to merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] chucheng92 commented on pull request #22242: [FLINK-31452][table] Let show databases return sorted results

2023-03-22 Thread via GitHub
chucheng92 commented on PR #22242: URL: https://github.com/apache/flink/pull/22242#issuecomment-1480671763 @wuchong sorry to bother you, ci has passed, could u help to merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [flink] flinkbot commented on pull request #22245: [BP-1.17][FLINK-31157][release] Add release note for version 1.17

2023-03-22 Thread via GitHub
flinkbot commented on PR #22245: URL: https://github.com/apache/flink/pull/22245#issuecomment-1480670377 ## CI report: * b93d7596e54b3c7d6c1ccc0ac82ac2a2c35ca23b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] PatrickRen opened a new pull request, #22245: [BP-1.17][FLINK-31157][release] Add release note for version 1.17

2023-03-22 Thread via GitHub
PatrickRen opened a new pull request, #22245: URL: https://github.com/apache/flink/pull/22245 Unchanged backport of #22146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink] PatrickRen merged pull request #22146: [FLINK-31157][release] Add release note for version 1.17

2023-03-22 Thread via GitHub
PatrickRen merged PR #22146: URL: https://github.com/apache/flink/pull/22146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Comment Edited] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-03-22 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703907#comment-17703907 ] Mason Chen edited comment on FLINK-30859 at 3/23/23 6:14 AM: -

[jira] [Commented] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-03-22 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703907#comment-17703907 ] Mason Chen commented on FLINK-30859: [~martijnvisser] [~tzulitai] [~t...@apache.org]

[jira] [Assigned] (FLINK-31152) Select executing Release Manager

2023-03-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-31152: - Assignee: Qingsheng Ren > Select executing Release Manager > --

[jira] [Resolved] (FLINK-31152) Select executing Release Manager

2023-03-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-31152. --- Resolution: Fixed > Select executing Release Manager > > >

[jira] [Commented] (FLINK-31152) Select executing Release Manager

2023-03-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703905#comment-17703905 ] Qingsheng Ren commented on FLINK-31152: --- * Release Manager’s GPG key is published

[jira] [Resolved] (FLINK-31151) Review Release Notes in JIRA

2023-03-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-31151. --- Resolution: Fixed > Review Release Notes in JIRA > > >

[jira] [Assigned] (FLINK-31151) Review Release Notes in JIRA

2023-03-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-31151: - Assignee: Qingsheng Ren > Review Release Notes in JIRA > >

[jira] [Commented] (FLINK-31151) Review Release Notes in JIRA

2023-03-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703903#comment-17703903 ] Qingsheng Ren commented on FLINK-31151: --- * Followed the guide to create [this pag

[GitHub] [flink] flinkbot commented on pull request #22244: [FLINK-31149][docs] Update compatibility matrix for release 1.17

2023-03-22 Thread via GitHub
flinkbot commented on PR #22244: URL: https://github.com/apache/flink/pull/22244#issuecomment-1480651154 ## CI report: * 33754b5d8ac93843632e4696246fbd422a1209fd UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Resolved] (FLINK-31148) Triage release-blocking issues in JIRA

2023-03-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-31148. --- Assignee: Qingsheng Ren Resolution: Fixed > Triage release-blocking issues in JIRA > -

[jira] [Commented] (FLINK-31148) Triage release-blocking issues in JIRA

2023-03-22 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703901#comment-17703901 ] Qingsheng Ren commented on FLINK-31148: --- All blockers of 1.17.0 has been swiped ou

[GitHub] [flink] xintongsong commented on a diff in pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-22 Thread via GitHub
xintongsong commented on code in PR #22176: URL: https://github.com/apache/flink/pull/22176#discussion_r1145655305 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotMatchingStrategy.java: ## @@ -41,4 +42,18 @@ Optional findMatchingSlot(

[jira] [Updated] (FLINK-31149) Review and update documentation

2023-03-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31149: --- Labels: pull-request-available (was: ) > Review and update documentation >

[GitHub] [flink] PatrickRen opened a new pull request, #22244: [FLINK-31149][docs] Update compatibility matrix for release 1.17

2023-03-22 Thread via GitHub
PatrickRen opened a new pull request, #22244: URL: https://github.com/apache/flink/pull/22244 ## What is the purpose of the change This pull requests updates the snapshot compatibility matrix for release 1.17. Please note that 1.17 drops snapshot compatibility before 1.8, whic

[jira] [Updated] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-03-22 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-30859: --- Description: Remove flink-connector-kafka from master branch since the repo has now been externalize

[jira] [Updated] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-03-22 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-30859: --- Affects Version/s: 1.18.0 (was: 1.17.0) > Remove flink-connector-kafka fr

[jira] [Updated] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-03-22 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mason Chen updated FLINK-30859: --- Summary: Remove flink-connector-kafka from master branch (was: Remove flink-connector-kafka rom mas

[GitHub] [flink] PatrickRen commented on pull request #22146: [FLINK-31157][release] Add release note for version 1.17

2023-03-22 Thread via GitHub
PatrickRen commented on PR #22146: URL: https://github.com/apache/flink/pull/22146#issuecomment-1480642481 Big thanks for the review @echauchot! Fixed in the latest commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Updated] (FLINK-31560) Savepoint failing to complete with incremental RocksDB statebackend

2023-03-22 Thread Brian Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Zhou updated FLINK-31560: --- Summary: Savepoint failing to complete with incremental RocksDB statebackend (was: Savepoint failin

[jira] [Updated] (FLINK-31560) Savepoint failing to complete with incremental checkpointing

2023-03-22 Thread Brian Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Zhou updated FLINK-31560: --- Summary: Savepoint failing to complete with incremental checkpointing (was: Issue deleting Flink cl

[GitHub] [flink] tzulitai commented on pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-22 Thread via GitHub
tzulitai commented on PR #22150: URL: https://github.com/apache/flink/pull/22150#issuecomment-1480618973 @tweise on the matter of merge process for this change: I believe there wasn't any prior announcement for this, but technically now that `release-1.17` branch is cut, and the fact

[GitHub] [flink] flinkbot commented on pull request #22243: [FLINK-31541][UI] encode request params to support special characters metrics name.

2023-03-22 Thread via GitHub
flinkbot commented on PR #22243: URL: https://github.com/apache/flink/pull/22243#issuecomment-1480615120 ## CI report: * 60258059b8fdfbaca92635789f685a32b745c990 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] (FLINK-30935) Add KafkaSerializer deserialize check when using SimpleVersionedSerializer

2023-03-22 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30935 ] Ran Tao deleted comment on FLINK-30935: - was (Author: lemonjing): @[~mapohl]  [~Leonard] Can u help me to review this PR ? thanks. > Add KafkaSerializer deserialize check when using SimpleVersio

[GitHub] [flink-connector-kafka] chucheng92 commented on pull request #10: [FLINK-30935][connector/kafka] Add kafka serializers version check when using SimpleVersionedSerializer

2023-03-22 Thread via GitHub
chucheng92 commented on PR #10: URL: https://github.com/apache/flink-connector-kafka/pull/10#issuecomment-1480614191 @leonardBang @PatrickRen sorry to bother you, can someone of you have a look please? -- This is an automated message from the Apache Git Service. To respond to the messa

[jira] (FLINK-30935) Add KafkaSerializer deserialize check when using SimpleVersionedSerializer

2023-03-22 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30935 ] Ran Tao deleted comment on FLINK-30935: - was (Author: lemonjing): Hi [~chesnay] [~becket_qin] what do u think? > Add KafkaSerializer deserialize check when using SimpleVersionedSerializer >

[jira] [Updated] (FLINK-30935) Add KafkaSerializer deserialize check when using SimpleVersionedSerializer

2023-03-22 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-30935: Description: Current kafka many implemented serializers do not deal with version check while other implem

[jira] [Updated] (FLINK-31541) Get metrics in Flink WEB UI error

2023-03-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31541: --- Labels: pull-request-available (was: ) > Get metrics in Flink WEB UI error > --

[GitHub] [flink] huwh opened a new pull request, #22243: [FLINK-31541] encode request params to support special characters metrics name.

2023-03-22 Thread via GitHub
huwh opened a new pull request, #22243: URL: https://github.com/apache/flink/pull/22243 ## What is the purpose of the change User could set operator name with some special characters, such as '%' and '['. This cause request failed when try to get metrics of this operator in WEB UI.

[jira] [Commented] (FLINK-31518) HighAvailabilityServiceUtils resolves wrong webMonitorAddress in Standalone mode

2023-03-22 Thread Yao Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703867#comment-17703867 ] Yao Zhang commented on FLINK-31518: --- Hi [~prabhujoseph] , It seems that we can retrie

[jira] [Commented] (FLINK-31305) KafkaWriter doesn't wait for errors for in-flight records before completing flush

2023-03-22 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703866#comment-17703866 ] Tzu-Li (Gordon) Tai commented on FLINK-31305: - thanks [~mason6345] for the p

[jira] [Comment Edited] (FLINK-31424) NullPointer when using StatementSet for multiple sinks

2023-03-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703543#comment-17703543 ] lincoln lee edited comment on FLINK-31424 at 3/23/23 4:05 AM:

[jira] [Resolved] (FLINK-31424) NullPointer when using StatementSet for multiple sinks

2023-03-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee resolved FLINK-31424. - Resolution: Resolved > NullPointer when using StatementSet for multiple sinks >

[GitHub] [flink] lincoln-lil merged pull request #22238: [FLINK-31424][table-planner] Fix NPE produced by multiple sink with local-global window aggregate

2023-03-22 Thread via GitHub
lincoln-lil merged PR #22238: URL: https://github.com/apache/flink/pull/22238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.a

[GitHub] [flink] reswqa commented on pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

2023-03-22 Thread via GitHub
reswqa commented on PR #22207: URL: https://github.com/apache/flink/pull/22207#issuecomment-1480571001 Thanks @slfan1989 for creating this. Would you mind resolving conflict in `YarnClusterDescriptor `? -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Commented] (FLINK-31233) no error should be logged when retrieving the task manager's stdout if it does not exist

2023-03-22 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703857#comment-17703857 ] Weihua Hu commented on FLINK-31233: --- [~Weijie Guo] Thanks for your attention. Yes, th

[jira] [Commented] (FLINK-31305) KafkaWriter doesn't wait for errors for in-flight records before completing flush

2023-03-22 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703855#comment-17703855 ] Mason Chen commented on FLINK-31305: [~martijnvisser] [~tzulitai] Have time to revie

[jira] [Commented] (FLINK-31233) no error should be logged when retrieving the task manager's stdout if it does not exist

2023-03-22 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703852#comment-17703852 ] Weijie Guo commented on FLINK-31233: Thanks [~huwh] for reporting this. > This API

[jira] [Commented] (FLINK-31498) DeclartiveSlotManager always request redundant task manager when resource is not enough

2023-03-22 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703850#comment-17703850 ] Weijie Guo commented on FLINK-31498: Thanks [~huwh] for reporting this, you are assi

[jira] [Assigned] (FLINK-31498) DeclartiveSlotManager always request redundant task manager when resource is not enough

2023-03-22 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31498: -- Assignee: Weihua Hu > DeclartiveSlotManager always request redundant task manager when resour

[GitHub] [flink] chucheng92 commented on pull request #22242: [FLINK-31452][table] Let show databases return sorted results

2023-03-22 Thread via GitHub
chucheng92 commented on PR #22242: URL: https://github.com/apache/flink/pull/22242#issuecomment-1480548557 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Assigned] (FLINK-31541) Get metrics in Flink WEB UI error

2023-03-22 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo reassigned FLINK-31541: -- Assignee: Weihua Hu > Get metrics in Flink WEB UI error > - >

[jira] [Commented] (FLINK-31165) Over Agg: The window rank function without order by error in top N query

2023-03-22 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703843#comment-17703843 ] lincoln lee commented on FLINK-31165: - [~qingyue] If there is a large cost on implem

[jira] [Commented] (FLINK-18996) Avoid disorder for time interval join

2023-03-22 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703835#comment-17703835 ] Lyn Zhang commented on FLINK-18996: --- If need, I can modify [this PR|https://github.com

[jira] [Commented] (FLINK-18996) Avoid disorder for time interval join

2023-03-22 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703834#comment-17703834 ] Lyn Zhang commented on FLINK-18996: --- [~lincoln.86xy] good solution. In our inner branc

[GitHub] [flink] zoltar9264 commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-22 Thread via GitHub
zoltar9264 commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1145600275 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -281,6 +302,11 @@ private void handleUploadSuccess(List

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-22 Thread via GitHub
1996fanrui commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1145599539 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] zoltar9264 commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-22 Thread via GitHub
zoltar9264 commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1145598181 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -281,6 +302,10 @@ private void handleUploadSuccess(List

[jira] [Closed] (FLINK-31230) Improve YarnClusterDescriptor memory unit display

2023-03-22 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan closed FLINK-31230. --- Resolution: Done > Improve YarnClusterDescriptor memory unit display > -

[jira] [Updated] (FLINK-31230) Improve YarnClusterDescriptor memory unit display

2023-03-22 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-31230: Fix Version/s: 1.18.0 > Improve YarnClusterDescriptor memory unit display > --

[jira] [Commented] (FLINK-31230) Improve YarnClusterDescriptor memory unit display

2023-03-22 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703832#comment-17703832 ] Rui Fan commented on FLINK-31230: - master commit: 753da61bb366df35df4bc2c2ebbbe7f75e8237

[GitHub] [flink] 1996fanrui merged pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-03-22 Thread via GitHub
1996fanrui merged PR #22028: URL: https://github.com/apache/flink/pull/22028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

[jira] [Commented] (FLINK-31424) NullPointer when using StatementSet for multiple sinks

2023-03-22 Thread jirawech.s (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703828#comment-17703828 ] jirawech.s commented on FLINK-31424: [~qingyue] Thank you so much (y) > NullPointer

[jira] [Updated] (FLINK-31560) Issue deleting Flink cluster due to savepoint failing to complete

2023-03-22 Thread Brian Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Zhou updated FLINK-31560: --- Description: Flink version: 1.16.0   We are using Flink to run some streaming applications with Pr

[GitHub] [flink-web] JingGe commented on pull request #624: remove Jekyll toc

2023-03-22 Thread via GitHub
JingGe commented on PR #624: URL: https://github.com/apache/flink-web/pull/624#issuecomment-148043 Thanks @zentol for the hint. I have addressed it. Please check again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [flink] snuyanzin commented on a diff in pull request #19637: [FLINK-25567][table] Add support casting of multisets to multisets

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #19637: URL: https://github.com/apache/flink/pull/19637#discussion_r1145523634 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala: ## @@ -1433,7 +1435,10 @@ object ScalarOperat

[GitHub] [flink] snuyanzin commented on a diff in pull request #19637: [FLINK-25567][table] Add support casting of multisets to multisets

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #19637: URL: https://github.com/apache/flink/pull/19637#discussion_r1145512436 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/utils/ValuesOperationFactory.java: ## @@ -197,10 +199,18 @@ private Optional conv

[jira] [Closed] (FLINK-31466) Backport "FilterJoinRule misses opportunity to push filter to semijoin input" to FlinkFilterJoinRule

2023-03-22 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-31466. --- Fix Version/s: 1.18.0 Resolution: Fixed Merged to master at [e91eb5ec2fea9a2f28f3f55

[jira] [Assigned] (FLINK-31466) Backport "FilterJoinRule misses opportunity to push filter to semijoin input" to FlinkFilterJoinRule

2023-03-22 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-31466: --- Assignee: Sergey Nuyanzin > Backport "FilterJoinRule misses opportunity to push fil

[GitHub] [flink] snuyanzin merged pull request #22185: [FLINK-31466][table] Apply FilterJoinRule misses opportunity to push filter to semijoin input to FlinkFilterJoinRule

2023-03-22 Thread via GitHub
snuyanzin merged PR #22185: URL: https://github.com/apache/flink/pull/22185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apa

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

2023-03-22 Thread via GitHub
mbalassi merged PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubs

[jira] [Commented] (FLINK-31139) not upload empty state changelog file

2023-03-22 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703787#comment-17703787 ] Roman Khachatryan commented on FLINK-31139: --- Yes [~Feifan Wang] , I think so.

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-22 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1145373085 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -216,11 +218,16 @@ private final DeploymentStateTimeM

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-22 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1145370369 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/scalingpolicy/EnforceMinimalIncreaseRescalingController.java: ## @@ -25,16 +25,17 @@ *

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1145355604 ## flink-table/flink-sql-client/src/main/resources/keywords.properties: ## @@ -0,0 +1,20 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1145335947 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/parser/SqlClientSyntaxHighlighter.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the A

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1145334655 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/parser/SqlClientSyntaxHighlighter.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the A

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

2023-03-22 Thread via GitHub
mbalassi commented on PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548#issuecomment-1479966458 @gaborgsomogyi offered to help me out with finishing this, so we are spitting up the work into 2 portions. One that can be verified and merged quickly and the `createOrR

[jira] [Closed] (FLINK-31527) ChangelogRescalingITCase.test failed due to FileNotFoundException

2023-03-22 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan closed FLINK-31527. - Assignee: Roman Khachatryan Resolution: Fixed Fix merged into master as 9ba3b1a586

[GitHub] [flink] rkhachatryan merged pull request #22234: [FLINK-31527][tests] Stabilize ChangelogRescalingITCase

2023-03-22 Thread via GitHub
rkhachatryan merged PR #22234: URL: https://github.com/apache/flink/pull/22234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.

[GitHub] [flink] rkhachatryan commented on pull request #22234: [FLINK-31527][tests] Stabilize ChangelogRescalingITCase

2023-03-22 Thread via GitHub
rkhachatryan commented on PR #22234: URL: https://github.com/apache/flink/pull/22234#issuecomment-1479933102 Thanks for the review @fredia CI failure is unrelated (private build [passed](https://dev.azure.com/khachatryanroman/flink/_build/results?buildId=1684&view=logs&jobId=0a15d512-44a

[jira] [Commented] (FLINK-18996) Avoid disorder for time interval join

2023-03-22 Thread Chalres Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703718#comment-17703718 ] Chalres Tan commented on FLINK-18996: - [~lincoln.86xy] yes, sounds good > Avoid dis

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1144959118 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java: ## @@ -307,6 +314,26 @@ private LineReader createLineReader(Terminal t

[jira] [Assigned] (FLINK-31528) Move SqlXXXCatalog conversion logic to SqlNodeConverter

2023-03-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-31528: --- Assignee: xuzhiwen > Move SqlXXXCatalog conversion logic to SqlNodeConverter >

[jira] [Commented] (FLINK-31464) Move SqlNode conversion logic out from SqlToOperationConverter

2023-03-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703706#comment-17703706 ] Jark Wu commented on FLINK-31464: - [~twalthr] Sure, I created an issue for the JavaDoc.

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1144962410 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java: ## @@ -307,6 +314,26 @@ private LineReader createLineReader(Terminal t

[jira] [Updated] (FLINK-31576) Add JavaDoc that SqlNodeConverter.getCatalogManager is discouraged to use

2023-03-22 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-31576: Description: See the comment: https://issues.apache.org/jira/browse/FLINK-31464?focusedCommentId=17703555

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1144959118 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java: ## @@ -307,6 +314,26 @@ private LineReader createLineReader(Terminal t

[jira] [Created] (FLINK-31576) Add JavaDoc that SqlNodeConverter.getCatalogManager is discouraged to use

2023-03-22 Thread Jark Wu (Jira)
Jark Wu created FLINK-31576: --- Summary: Add JavaDoc that SqlNodeConverter.getCatalogManager is discouraged to use Key: FLINK-31576 URL: https://issues.apache.org/jira/browse/FLINK-31576 Project: Flink

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1144929172 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/parser/SqlClientSyntaxHighlighter.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the A

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1144862356 ## flink-table/flink-sql-client/src/main/resources/keywords.properties: ## @@ -0,0 +1,20 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1144929172 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/parser/SqlClientSyntaxHighlighter.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the A

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1144929172 ## flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/parser/SqlClientSyntaxHighlighter.java: ## @@ -0,0 +1,246 @@ +/* + * Licensed to the A

[jira] [Updated] (FLINK-31492) AWS Firehose Connector misclassifies IAM permission exceptions as retryable

2023-03-22 Thread Samuel Siebenmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samuel Siebenmann updated FLINK-31492: -- Labels: pull-request-available (was: ) > AWS Firehose Connector misclassifies IAM per

[GitHub] [flink-connector-aws] boring-cyborg[bot] commented on pull request #59: [Flink 31492][Connectors/AWS] Add support for exception classification based on AWS error codes

2023-03-22 Thread via GitHub
boring-cyborg[bot] commented on PR #59: URL: https://github.com/apache/flink-connector-aws/pull/59#issuecomment-1479674540 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is an

[GitHub] [flink-connector-aws] samuelsiebenmann opened a new pull request, #59: [Flink 31492][Connectors/AWS] Add support for exception classification based on AWS error codes

2023-03-22 Thread via GitHub
samuelsiebenmann opened a new pull request, #59: URL: https://github.com/apache/flink-connector-aws/pull/59 ## Purpose of the change Add support for exception classification based on AWS error codes: - Add AWSExceptionClassifierUtil to create FatalExceptionClassifiers to cl

[jira] [Commented] (FLINK-31575) Don't swap table-planner-loader and table-planner to use hive dialect

2023-03-22 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703681#comment-17703681 ] Timo Walther commented on FLINK-31575: -- [~luoyuxia] my gut feeling is that the modu

[jira] [Comment Edited] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

2023-03-22 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703680#comment-17703680 ] Timo Walther edited comment on FLINK-26945 at 3/22/23 2:03 PM: ---

[jira] [Commented] (FLINK-26945) Add DATE_SUB supported in SQL & Table API

2023-03-22 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703680#comment-17703680 ] Timo Walther commented on FLINK-26945: -- I see the problem is that this is rather an

[GitHub] [flink] snuyanzin commented on a diff in pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-03-22 Thread via GitHub
snuyanzin commented on code in PR #22063: URL: https://github.com/apache/flink/pull/22063#discussion_r1144862356 ## flink-table/flink-sql-client/src/main/resources/keywords.properties: ## @@ -0,0 +1,20 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# c

[jira] [Commented] (FLINK-31542) FatalExceptionClassifier#isFatal returns false if the exception is fatal

2023-03-22 Thread DavidLiu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703678#comment-17703678 ] DavidLiu commented on FLINK-31542: -- [~danny.cranmer]  Would you please help review this

  1   2   3   >