[jira] [Assigned] (FLINK-31531) Test HiveCatalogHiveMetadataTest.testCreateTableWithConstraint failed on azure

2023-03-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-31531: -- Assignee: Yuxia Luo > Test HiveCatalogHiveMetadataTest.testCreateTableWithConstraint failed o

[jira] [Assigned] (FLINK-31531) Test HiveCatalogHiveMetadataTest.testCreateTableWithConstraint failed on azure

2023-03-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-31531: -- Assignee: luoyuxia (was: Yuxia Luo) > Test HiveCatalogHiveMetadataTest.testCreateTableWithCo

[jira] [Updated] (FLINK-31375) the values of map are truncated by the CASE WHEN function.

2023-03-20 Thread jeff-zou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jeff-zou updated FLINK-31375: - Component/s: Table SQL / Runtime > the values of map are truncated by the CASE WHEN function. >

[GitHub] [flink] luoyuxia commented on pull request #22166: [FLINK-31409][hive] Hive dialect should use public interfaces

2023-03-20 Thread via GitHub
luoyuxia commented on PR #22166: URL: https://github.com/apache/flink/pull/22166#issuecomment-1477347904 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] liuyongvs commented on pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-20 Thread via GitHub
liuyongvs commented on PR #22144: URL: https://github.com/apache/flink/pull/22144#issuecomment-1477347441 hi @snuyanzin fix your reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [flink] zoltar9264 commented on pull request #21975: [FLINK-31139][state/changelog] not upload empty state changelog file

2023-03-20 Thread via GitHub
zoltar9264 commented on PR #21975: URL: https://github.com/apache/flink/pull/21975#issuecomment-1477346700 Hi @pnowojski , can you help me merge this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] zoltar9264 commented on pull request #21330: [FLINK-30023][changelog] increase timeout in ChangelogStorageMetricsT…

2023-03-20 Thread via GitHub
zoltar9264 commented on PR #21330: URL: https://github.com/apache/flink/pull/21330#issuecomment-1477346284 Hi @pnowojski , can you help me review this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] zoltar9264 commented on pull request #21208: [FLINK-29822] fix wrong description in comments of StreamExecutionEnv…

2023-03-20 Thread via GitHub
zoltar9264 commented on PR #21208: URL: https://github.com/apache/flink/pull/21208#issuecomment-1477345851 Hi @pnowojski , can you help me merge this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink] fsk119 commented on a diff in pull request #21979: [FLINK-30810] Rework CliClientITCase extends AbstractStatementTestBase

2023-03-20 Thread via GitHub
fsk119 commented on code in PR #21979: URL: https://github.com/apache/flink/pull/21979#discussion_r1142869047 ## flink-table/flink-sql-gateway/src/test/java/org/apache/flink/table/gateway/AbstractSqlGatewayStatementTestBase.java: ## @@ -16,19 +16,23 @@ * limitations under the

[GitHub] [flink] zoltar9264 commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-20 Thread via GitHub
zoltar9264 commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1142935980 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -199,15 +200,21 @@ public SequenceNumber nextSequenceNumb

[jira] (FLINK-31531) Test HiveCatalogHiveMetadataTest.testCreateTableWithConstraint failed on azure

2023-03-20 Thread xuzhiwen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31531 ] xuzhiwen deleted comment on FLINK-31531: -- was (Author: xzw0223): It seems that the version obtained is not correct. I checked and found that the current hive version is 2.3, and the assertion i

[jira] [Commented] (FLINK-31531) Test HiveCatalogHiveMetadataTest.testCreateTableWithConstraint failed on azure

2023-03-20 Thread xuzhiwen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703053#comment-17703053 ] xuzhiwen commented on FLINK-31531: -- It seems that the version obtained is not correct.

[GitHub] [flink] zoltar9264 commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-20 Thread via GitHub
zoltar9264 commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1142854696 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -216,17 +223,31 @@ private void preEmptiveFlushIfNeeded(b

[GitHub] [flink] flinkbot commented on pull request #22230: [FLINK-31531][hive] Fix HiveCatalogHiveMetadataTest failure in Hive3

2023-03-20 Thread via GitHub
flinkbot commented on PR #22230: URL: https://github.com/apache/flink/pull/22230#issuecomment-1477335664 ## CI report: * d95aced48b7ebb2bf8d1a172ea05dcd528b4126f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] luoyuxia commented on a diff in pull request #22230: [FLINK-31531][hive] Fix HiveCatalogHiveMetadataTest failure in Hive3

2023-03-20 Thread via GitHub
luoyuxia commented on code in PR #22230: URL: https://github.com/apache/flink/pull/22230#discussion_r1142930500 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogHiveMetadataTest.java: ## @@ -266,7 +266,7 @@ void testCreateTabl

[jira] [Updated] (FLINK-31531) Test HiveCatalogHiveMetadataTest.testCreateTableWithConstraint failed on azure

2023-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31531: --- Labels: pull-request-available (was: ) > Test HiveCatalogHiveMetadataTest.testCreateTableWi

[GitHub] [flink] luoyuxia opened a new pull request, #22230: [FLINK-31531][hive] Fix HiveCatalogHiveMetadataTest failure in Hive3

2023-03-20 Thread via GitHub
luoyuxia opened a new pull request, #22230: URL: https://github.com/apache/flink/pull/22230 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[GitHub] [flink] liyubin117 commented on a diff in pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

2023-03-20 Thread via GitHub
liyubin117 commented on code in PR #21521: URL: https://github.com/apache/flink/pull/21521#discussion_r1142920457 ## docs/content/docs/dev/table/sql/describe.md: ## @@ -112,11 +112,11 @@ table_env = TableEnvironment.create(...) # register a table named "Orders" table_env.execu

[GitHub] [flink] liyubin117 commented on a diff in pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

2023-03-20 Thread via GitHub
liyubin117 commented on code in PR #21521: URL: https://github.com/apache/flink/pull/21521#discussion_r1142919830 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala: ## @@ -2528,7 +2528,14 @@ class TableEnvironmentTest {

[GitHub] [flink] liyubin117 commented on a diff in pull request #21521: [FLINK-30435][table] `SHOW CREATE TABLE` statement shows column comment

2023-03-20 Thread via GitHub
liyubin117 commented on code in PR #21521: URL: https://github.com/apache/flink/pull/21521#discussion_r1142919231 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/catalog/CatalogTableITCase.scala: ## @@ -1060,6 +1060,61 @@ class CatalogTableITCase

[GitHub] [flink] reswqa commented on a diff in pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

2023-03-20 Thread via GitHub
reswqa commented on code in PR #22196: URL: https://github.com/apache/flink/pull/22196#discussion_r1142918984 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRuntimeServices.java: ## @@ -83,7 +83,13 @@ private static SlotManager createSlotM

[GitHub] [flink] FangYongs commented on pull request #22227: [FLINK-31523][sql-client] Merge sql script reader in client and gateway

2023-03-20 Thread via GitHub
FangYongs commented on PR #7: URL: https://github.com/apache/flink/pull/7#issuecomment-1477305621 @fsk119 Please help to review this PR when you are free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] FangYongs commented on pull request #22221: [FLINK-31521][jdbc-driver] Initialize jdbc driver module in flink-table

2023-03-20 Thread via GitHub
FangYongs commented on PR #1: URL: https://github.com/apache/flink/pull/1#issuecomment-1477305048 Thanks @libenchao Updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[jira] [Commented] (FLINK-31495) Improve metrics tab on flink ui

2023-03-20 Thread zhang haoyan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703036#comment-17703036 ] zhang haoyan commented on FLINK-31495: -- I see,  but it is still very hard to look t

[jira] [Updated] (FLINK-24045) KafkaTableITCase.testPerPartitionWatermarkKafka fails on azure

2023-03-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu updated FLINK-24045: --- Fix Version/s: 1.15.5 (was: 1.16.0) > KafkaTableITCase.testPerPartitionWaterm

[jira] [Commented] (FLINK-24045) KafkaTableITCase.testPerPartitionWatermarkKafka fails on azure

2023-03-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703031#comment-17703031 ] Leonard Xu commented on FLINK-24045: The same test failed in release-1.15 again, alt

[GitHub] [flink] huwh commented on pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

2023-03-20 Thread via GitHub
huwh commented on PR #22196: URL: https://github.com/apache/flink/pull/22196#issuecomment-1477286542 Thanks @reswqa , squash some commits, and address the first comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Reopened] (FLINK-24045) KafkaTableITCase.testPerPartitionWatermarkKafka fails on azure

2023-03-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reopened FLINK-24045: > KafkaTableITCase.testPerPartitionWatermarkKafka fails on azure > ---

[GitHub] [flink] huwh commented on a diff in pull request #22196: [FLINK-31445][runtime]Split resource allocate/release related logic from FineGrainedSlotManager to TaskManagerTracker

2023-03-20 Thread via GitHub
huwh commented on code in PR #22196: URL: https://github.com/apache/flink/pull/22196#discussion_r1142891394 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRuntimeServices.java: ## @@ -83,7 +83,13 @@ private static SlotManager createSlotMan

[jira] [Commented] (FLINK-24095) Elasticsearch7DynamicSinkITCase.testWritingDocuments fails due to socket timeout

2023-03-20 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703027#comment-17703027 ] Leonard Xu commented on FLINK-24095: {noformat} Mar 14 01:50:08 [ERROR] Elasticse

[jira] [Created] (FLINK-31531) Test HiveCatalogHiveMetadataTest.testCreateTableWithConstraint failed on azure

2023-03-20 Thread Leonard Xu (Jira)
Leonard Xu created FLINK-31531: -- Summary: Test HiveCatalogHiveMetadataTest.testCreateTableWithConstraint failed on azure Key: FLINK-31531 URL: https://issues.apache.org/jira/browse/FLINK-31531 Project: F

[GitHub] [flink] luoyuxia commented on a diff in pull request #21645: [FLINK-30556] Introduce the StaticPartitionFileSplitEnumerator

2023-03-20 Thread via GitHub
luoyuxia commented on code in PR #21645: URL: https://github.com/apache/flink/pull/21645#discussion_r1142880392 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/src/impl/StaticPartitionFileSplitEnumerator.java: ## @@ -0,0 +1,154 @@ +/* + *

[GitHub] [flink] FangYongs commented on a diff in pull request #22221: [FLINK-31521][jdbc-driver] Initialize jdbc driver module in flink-table

2023-03-20 Thread via GitHub
FangYongs commented on code in PR #1: URL: https://github.com/apache/flink/pull/1#discussion_r1142874300 ## flink-table/flink-sql-jdbc-driver/pom.xml: ## @@ -0,0 +1,77 @@ + + + +http://maven.apache.org/POM/4.0.0"; +xmlns:xsi="http://www.w3.org/2001/XMLSch

[GitHub] [flink] FangYongs commented on a diff in pull request #22221: [FLINK-31521][jdbc-driver] Initialize jdbc driver module in flink-table

2023-03-20 Thread via GitHub
FangYongs commented on code in PR #1: URL: https://github.com/apache/flink/pull/1#discussion_r1142873836 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkDriver.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundatio

[jira] [Created] (FLINK-31530) For currently commonly used databases, MySQL and Postgres have implemented catalogs. Currently, catalogs are implemented based on Oracle

2023-03-20 Thread xingyuan cheng (Jira)
xingyuan cheng created FLINK-31530: -- Summary: For currently commonly used databases, MySQL and Postgres have implemented catalogs. Currently, catalogs are implemented based on Oracle Key: FLINK-31530 URL: https:/

[GitHub] [flink] flinkbot commented on pull request #22229: support oraclecatalog

2023-03-20 Thread via GitHub
flinkbot commented on PR #9: URL: https://github.com/apache/flink/pull/9#issuecomment-1477257633 ## CI report: * fc38434942b13ac692b5145d1e4fa1b6aeb79624 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] complone opened a new pull request, #22229: support oraclecatalog

2023-03-20 Thread via GitHub
complone opened a new pull request, #9: URL: https://github.com/apache/flink/pull/9 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[GitHub] [flink] lincoln-lil commented on pull request #22166: [FLINK-31409][hive] Hive dialect should use public interfaces

2023-03-20 Thread via GitHub
lincoln-lil commented on PR #22166: URL: https://github.com/apache/flink/pull/22166#issuecomment-1477251531 @luoyuxia seems the latest change failed to pass the style check, PTAL otherwise +1 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] lincoln-lil commented on a diff in pull request #22166: [FLINK-31409][hive] Hive dialect should use public interfaces

2023-03-20 Thread via GitHub
lincoln-lil commented on code in PR #22166: URL: https://github.com/apache/flink/pull/22166#discussion_r1142868437 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala: ## @@ -169,17 +171,46 @@ abstract class PlannerBase(

[jira] [Updated] (FLINK-31479) Close blocking iterators in tests

2023-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31479: --- Labels: pull-request-available (was: ) > Close blocking iterators in tests > --

[jira] [Commented] (FLINK-30719) flink-runtime-web failed due to a corrupted

2023-03-20 Thread Junhan Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703016#comment-17703016 ] Junhan Yang commented on FLINK-30719: - Hi, I spent a while investigating on this, an

[GitHub] [flink] lindong28 commented on a diff in pull request #21589: [FLINK-25509][connector-base] Add RecordEvaluator to dynamically stop source based on de-serialized records

2023-03-20 Thread via GitHub
lindong28 commented on code in PR #21589: URL: https://github.com/apache/flink/pull/21589#discussion_r1142856743 ## flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManager.java: ## @@ -153,6 +153,8 @@ public v

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #220: [FLINK-31325] Improve performance of Swing

2023-03-20 Thread via GitHub
Fanoid commented on code in PR #220: URL: https://github.com/apache/flink-ml/pull/220#discussion_r1142859028 ## flink-ml-lib/src/main/java/org/apache/flink/ml/recommendation/swing/Swing.java: ## @@ -289,36 +303,40 @@ public void endInput() throws Exception { Map use

[jira] [Commented] (FLINK-31259) Gateway supports initialization of catalog at startup

2023-03-20 Thread Feng Jin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703014#comment-17703014 ] Feng Jin commented on FLINK-31259: -- [~zjureel] [~fsk119]  Sorry, the description in the

[jira] [Resolved] (FLINK-31486) Using KeySelector in IterationBody causes ClassCastException

2023-03-20 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin resolved FLINK-31486. -- Resolution: Fixed > Using KeySelector in IterationBody causes ClassCastException > ---

[jira] [Commented] (FLINK-31486) Using KeySelector in IterationBody causes ClassCastException

2023-03-20 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703005#comment-17703005 ] Dong Lin commented on FLINK-31486: -- Merged to apache/flink-ml master branch fa5f47ea2a0

[jira] [Assigned] (FLINK-31486) Using KeySelector in IterationBody causes ClassCastException

2023-03-20 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-31486: Assignee: Jiang Xin > Using KeySelector in IterationBody causes ClassCastException >

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #222: [FLINK-31029] Fix bug when using quantile in KbinsDiscretizer

2023-03-20 Thread via GitHub
Fanoid commented on code in PR #222: URL: https://github.com/apache/flink-ml/pull/222#discussion_r1142849665 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/kbinsdiscretizer/KBinsDiscretizer.java: ## @@ -220,22 +220,46 @@ private static double[][] findBinEdgesWithQuan

[GitHub] [flink] liuyongvs commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-20 Thread via GitHub
liuyongvs commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142850269 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream getTestSetSp

[GitHub] [flink-ml] lindong28 merged pull request #226: [FLINK-31486] Get the KeySelector with UserClassLoader

2023-03-20 Thread via GitHub
lindong28 merged PR #226: URL: https://github.com/apache/flink-ml/pull/226 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apac

[jira] [Commented] (FLINK-31259) Gateway supports initialization of catalog at startup

2023-03-20 Thread Darcy Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703004#comment-17703004 ] Darcy Lin commented on FLINK-31259: --- [~fsk119] I generally agree with your conclusions

[jira] [Comment Edited] (FLINK-31259) Gateway supports initialization of catalog at startup

2023-03-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703002#comment-17703002 ] Shengkai Fang edited comment on FLINK-31259 at 3/21/23 3:03 AM: --

[GitHub] [flink-ml] lindong28 commented on pull request #226: [FLINK-31486] Get the KeySelector with UserClassLoader

2023-03-20 Thread via GitHub
lindong28 commented on PR #226: URL: https://github.com/apache/flink-ml/pull/226#issuecomment-1477218565 Thanks for the PR! LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (FLINK-31259) Gateway supports initialization of catalog at startup

2023-03-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17703002#comment-17703002 ] Shengkai Fang commented on FLINK-31259: --- [~zjureel]  Thanks for pointing out the c

[jira] [Updated] (FLINK-31433) Make SchemaChange serializable

2023-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31433: --- Labels: pull-request-available (was: ) > Make SchemaChange serializable > -

[jira] [Closed] (FLINK-31432) Introduce a special StoreWriteOperator to deal with schema changes

2023-03-20 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-31432. --- Resolution: Fixed master: 556443f098252a98610a03450ed8ad2a661f27dd > Introduce a special StoreWrite

[GitHub] [flink] chucheng92 commented on pull request #22220: [FLINK-31500][table-planner] Move SqlAlterTableSchema conversion logic to SqlAlterTableSchemaConverter

2023-03-20 Thread via GitHub
chucheng92 commented on PR #0: URL: https://github.com/apache/flink/pull/0#issuecomment-1477207123 @wuchong PTAL. how about reuse previous AlterSchemaConverter? or we extract the convert utils from AlterSchemaConverter and shrink in SqlAlterTableConverter. -- This is an automated

[jira] [Commented] (FLINK-31259) Gateway supports initialization of catalog at startup

2023-03-20 Thread Fang Yong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702999#comment-17702999 ] Fang Yong commented on FLINK-31259: --- Thanks [~fsk119] I found some differences between

[jira] [Comment Edited] (FLINK-31259) Gateway supports initialization of catalog at startup

2023-03-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702994#comment-17702994 ] Shengkai Fang edited comment on FLINK-31259 at 3/21/23 2:25 AM: --

[jira] [Commented] (FLINK-31259) Gateway supports initialization of catalog at startup

2023-03-20 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702994#comment-17702994 ] Shengkai Fang commented on FLINK-31259: --- I apologize for the delay in my response.

[jira] [Commented] (FLINK-31495) Improve metrics tab on flink ui

2023-03-20 Thread zlzhang0122 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702988#comment-17702988 ] zlzhang0122 commented on FLINK-31495: - IMHO this is not a problem, if you mouseover

[jira] [Updated] (FLINK-31524) StreamDependencyTests.test_add_python_file failed

2023-03-20 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-31524: - Issue Type: Technical Debt (was: Bug) > StreamDependencyTests.test_add_python_file failed > ---

[jira] [Assigned] (FLINK-31524) StreamDependencyTests.test_add_python_file failed

2023-03-20 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang reassigned FLINK-31524: Assignee: Xingbo Huang > StreamDependencyTests.test_add_python_file failed >

[jira] [Updated] (FLINK-31524) StreamDependencyTests.test_add_python_file failed

2023-03-20 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingbo Huang updated FLINK-31524: - Priority: Major (was: Blocker) > StreamDependencyTests.test_add_python_file failed > --

[jira] [Commented] (FLINK-31524) StreamDependencyTests.test_add_python_file failed

2023-03-20 Thread Xingbo Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702985#comment-17702985 ] Xingbo Huang commented on FLINK-31524: -- [~mapohl] Thanks a lot for reporting this i

[jira] [Commented] (FLINK-31424) NullPointer when using StatementSet for multiple sinks

2023-03-20 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702977#comment-17702977 ] Jane Chan commented on FLINK-31424: --- I opened a PR, and it would be great if you could

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-20 Thread via GitHub
snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142753109 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream getTestSetSp

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-20 Thread via GitHub
snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142751406 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream getTestSetSp

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-20 Thread via GitHub
snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142751304 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream getTestSetSp

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-20 Thread via GitHub
snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142750735 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream getTestSetSp

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-20 Thread via GitHub
snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142750566 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream getTestSetSp

[GitHub] [flink] snuyanzin commented on a diff in pull request #22144: [FLINK-31102][table] Add ARRAY_REMOVE function.

2023-03-20 Thread via GitHub
snuyanzin commented on code in PR #22144: URL: https://github.com/apache/flink/pull/22144#discussion_r1142750315 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/CollectionFunctionsITCase.java: ## @@ -178,6 +181,125 @@ Stream getTestSetSp

[GitHub] [flink-web] JingGe commented on pull request #624: remove Jekyll toc

2023-03-20 Thread via GitHub
JingGe commented on PR #624: URL: https://github.com/apache/flink-web/pull/624#issuecomment-1476876332 @MartijnVisser Would you like to check if I did it right? Thanks! Just saw weird `{% toc %}` while reading Flink blogs, e.g. https://flink.apache.org/2022/02/22/scala-free-in-one-fifteen/

[GitHub] [flink] flinkbot commented on pull request #22228: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-03-20 Thread via GitHub
flinkbot commented on PR #8: URL: https://github.com/apache/flink/pull/8#issuecomment-1476799487 ## CI report: * 1df0da7d5379ee6bcd44869a42688af76f820eac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31049) Add support for Kafka record headers to KafkaSink

2023-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31049: --- Labels: KafkaSink pull-request-available (was: KafkaSink) > Add support for Kafka record he

[GitHub] [flink] AlexAxeman opened a new pull request, #22228: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-03-20 Thread via GitHub
AlexAxeman opened a new pull request, #8: URL: https://github.com/apache/flink/pull/8 ## What is the purpose of the change The default `org.apache.flink.connector.kafka.sink.KafkaSink` does not support adding Kafka record headers when using KafkaRecordSerializationSchemaBuild

[jira] [Commented] (FLINK-31490) ZooKeeperLeaderElectionTest.testLeaderShouldBeCorrectedWhenOverwritten times out

2023-03-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702861#comment-17702861 ] Matthias Pohl commented on FLINK-31490: --- There is something that looks like a hick

[jira] [Commented] (FLINK-31490) ZooKeeperLeaderElectionTest.testLeaderShouldBeCorrectedWhenOverwritten times out

2023-03-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702858#comment-17702858 ] Matthias Pohl commented on FLINK-31490: --- hm, the server logs show that the session

[jira] [Commented] (FLINK-31509) REST Service missing sessionAffinity causes job run failure with HA cluster

2023-03-20 Thread Emmanuel Leroy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702823#comment-17702823 ] Emmanuel Leroy commented on FLINK-31509: [~bgeng777]  I agree ideally the Servic

[GitHub] [flink] flinkbot commented on pull request #22227: [FLINK-31523][sql-client] Merge sql script reader in client and gateway

2023-03-20 Thread via GitHub
flinkbot commented on PR #7: URL: https://github.com/apache/flink/pull/7#issuecomment-1476417025 ## CI report: * 9f45c13538ab75fbbd0d6b9238a92709ef2833bb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] libenchao commented on a diff in pull request #22221: [FLINK-31521][jdbc-driver] Initialize jdbc driver module in flink-table

2023-03-20 Thread via GitHub
libenchao commented on code in PR #1: URL: https://github.com/apache/flink/pull/1#discussion_r1142076440 ## flink-table/flink-sql-jdbc-driver/src/main/java/org/apache/flink/table/jdbc/FlinkDriver.java: ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundatio

[jira] [Updated] (FLINK-31523) Merge query files and processing in sql client and gateway

2023-03-20 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31523: --- Labels: pull-request-available (was: ) > Merge query files and processing in sql client and

[GitHub] [flink] FangYongs opened a new pull request, #22227: [FLINK-31523][sql-client] Merge sql script reader in client and gateway

2023-03-20 Thread via GitHub
FangYongs opened a new pull request, #7: URL: https://github.com/apache/flink/pull/7 ## What is the purpose of the change There're .q files and script readers in client and gateway, which are quite similar. This PR aims to merge the .q files in gateway module and merge the two

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

2023-03-20 Thread via GitHub
mbalassi commented on code in PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548#discussion_r1142261346 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClient.java: ## @@ -57,14 +58,1

[GitHub] [flink-kubernetes-operator] mbalassi commented on a diff in pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

2023-03-20 Thread via GitHub
mbalassi commented on code in PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548#discussion_r1142261062 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClient.java: ## @@ -57,14 +58,1

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

2023-03-20 Thread via GitHub
gyfora commented on PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548#issuecomment-1476388021 > I've just had a deeper look at the test issues and here are my findings: > > * The originally used `createOrReplace` has the following semantics > > * Cr

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

2023-03-20 Thread via GitHub
leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1142251396 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,486 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date: "2023-03-0

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #548: [FLINK-31407] Bump fabric8 version to 6.5.0

2023-03-20 Thread via GitHub
gyfora commented on code in PR #548: URL: https://github.com/apache/flink-kubernetes-operator/pull/548#discussion_r1142249645 ## flink-kubernetes-standalone/src/main/java/org/apache/flink/kubernetes/operator/kubeclient/Fabric8FlinkStandaloneKubeClient.java: ## @@ -57,14 +58,14

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #549: [FLINK-31502] Limit the number of scale operations to reduce cluster churn

2023-03-20 Thread via GitHub
gyfora commented on code in PR #549: URL: https://github.com/apache/flink-kubernetes-operator/pull/549#discussion_r1142244157 ## docs/layouts/shortcodes/generated/dynamic_section.html: ## @@ -86,6 +86,12 @@ Duration Interval at which periodic savepoint

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

2023-03-20 Thread via GitHub
leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1142241969 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,486 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date: "2023-03-0

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

2023-03-20 Thread via GitHub
leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1142239563 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,486 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date: "2023-03-0

[GitHub] [flink-web] leonardBang commented on a diff in pull request #618: Announcement blogpost for the 1.17 release

2023-03-20 Thread via GitHub
leonardBang commented on code in PR #618: URL: https://github.com/apache/flink-web/pull/618#discussion_r1142241182 ## docs/content/posts/2023-03-09-release-1.17.0.md: ## @@ -0,0 +1,486 @@ +--- +authors: +- LeonardXu: + name: "Leonard Xu" + twitter: Leonardxbj +date: "2023-03-0

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-20 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142227595 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed

[jira] [Resolved] (FLINK-31167) Verify that no exclusions were erroneously added to the japicmp plugin

2023-03-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-31167. --- Resolution: Fixed I guess it's reasonable considering that we used the same approach in the

[jira] [Commented] (FLINK-31490) ZooKeeperLeaderElectionTest.testLeaderShouldBeCorrectedWhenOverwritten times out

2023-03-20 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702760#comment-17702760 ] Matthias Pohl commented on FLINK-31490: --- ok, makes sense. FLINK-27848 is kind of s

[GitHub] [flink] LadyForest commented on pull request #22222: [FLINK-31424][table-planner] Fix NPE produced by multiple sink with local-global window aggregate

2023-03-20 Thread via GitHub
LadyForest commented on PR #2: URL: https://github.com/apache/flink/pull/2#issuecomment-1476347631 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-20 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142213149 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-20 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142213149 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #3: [FLINK-26822] Add Cassandra Source

2023-03-20 Thread via GitHub
echauchot commented on code in PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#discussion_r1142211308 ## flink-connector-cassandra/src/main/java/org/apache/flink/connector/cassandra/source/split/SplitsGenerator.java: ## @@ -0,0 +1,259 @@ +/* + * Licensed

[jira] [Commented] (FLINK-26088) Add Elasticsearch 8.0 support

2023-03-20 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17702738#comment-17702738 ] Martijn Visser commented on FLINK-26088: [~mtfelisb] Are you still planning to w

  1   2   3   >