huwh commented on code in PR #22196:
URL: https://github.com/apache/flink/pull/22196#discussion_r1142891394
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerRuntimeServices.java:
##########
@@ -83,7 +83,13 @@ private static SlotManager createSlotManager(
slotManagerConfiguration,
slotManagerMetricGroup,
new DefaultResourceTracker(),
- new FineGrainedTaskManagerTracker(),
+ new FineGrainedTaskManagerTracker(
+ slotManagerConfiguration.getMaxTotalCpu(),
+ slotManagerConfiguration.getMaxTotalMem(),
+
slotManagerConfiguration.isWaitResultConsumedBeforeRelease(),
+ slotManagerConfiguration.getTaskManagerTimeout(),
+
slotManagerConfiguration.getDeclareNeededResourceDelay(),
Review Comment:
Good idea, but these configuration are used both in DeclarativeSlotManager
and FineGrainedSlotManager. How about create a new issue to do this after we
remove DeclarativeSlotManager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
